GNU bug report logs - #29610
[PATCH] gnu: games: Add quakespasm.

Previous Next

Full log

View this message in rfc822 format

From: Kei Kebreau <kkebreau <at> posteo.net>
To: nee <nee <at> cock.li>
Cc: 29610 <at> debbugs.gnu.org
Subject: [bug#29610] [PATCH] gnu: games: Add quakespasm.
Date: Tue, 19 Dec 2017 10:32:34 -0500

[Message part 1 (text/plain, inline)]

nee <nee <at> cock.li> writes:

> Am 18.12.2017 um 17:52 schrieb Kei Kebreau:
>> A few things:
>> * Please end the "fix-makefile-paths" phase with a #t.
>> * It turns out that the license is actually gpl2+.
>> * The description's indentation seems a bit early and weird. That is, we
>>   can have up to 80 characters per line in our description, and some of
>>   the description can be adjusted accordingly.
>> 
>
> GJ spotting all of this. Here is the updated patch.

One more nitpick: our commit messages tend not to include the name of
the file being added to, so they look like

gnu: Add quakespasm.

as opposed to

gnu: games: Add quakespasm.

I've fixed that bit, though, and this patch is otherwise great! I've
pushed this to master.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.