From unknown Tue Jun 17 01:37:10 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29599: 26.0; `dframe.el' binds keys unconditionally when loaded Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 07 Dec 2017 06:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 29599 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 29599@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.151262706910919 (code B ref -1); Thu, 07 Dec 2017 06:12:02 +0000 Received: (at submit) by debbugs.gnu.org; 7 Dec 2017 06:11:09 +0000 Received: from localhost ([127.0.0.1]:49765 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eMpOm-0002q3-Sb for submit@debbugs.gnu.org; Thu, 07 Dec 2017 01:11:09 -0500 Received: from eggs.gnu.org ([208.118.235.92]:38605) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eMpOl-0002pg-4j for submit@debbugs.gnu.org; Thu, 07 Dec 2017 01:11:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eMpOe-0007ml-Uy for submit@debbugs.gnu.org; Thu, 07 Dec 2017 01:11:01 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:47475) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eMpOe-0007ma-R0 for submit@debbugs.gnu.org; Thu, 07 Dec 2017 01:11:00 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57801) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eMpOd-0005ti-Nq for bug-gnu-emacs@gnu.org; Thu, 07 Dec 2017 01:11:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eMpOa-0007ib-GT for bug-gnu-emacs@gnu.org; Thu, 07 Dec 2017 01:10:59 -0500 Received: from aserp2130.oracle.com ([141.146.126.79]:39078) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eMpOa-0007gw-6s for bug-gnu-emacs@gnu.org; Thu, 07 Dec 2017 01:10:56 -0500 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.21/8.16.0.21) with SMTP id vB767U8f099033 for ; Thu, 7 Dec 2017 06:10:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : subject : content-type : content-transfer-encoding; s=corp-2017-10-26; bh=GDecq8MklC18xkNbNH7fvq5+4H7is3t6YWZc4t3g66g=; b=lE9EkPmCRpSXa/63WufmKDxH3346b0iAtEKz2+LUMz9//KEcyaSxjQflwU35Oudf0fNS MvoPI0nMqlvsnaKylFWMywHXYH2f5dgWj4R8RfSkAPD0qK+m/F1v1isB91CUmgv/pthg LRtPgzSBJvSrdEnvvtJE1JKg18smE0h/gW20Lc1BNI5rS+GVTmgRoT6hdmEAhCgA0vfQ Mf9/sf6DV0doAQkK1Zx4kY5FTGRhv83OXDcZ7f1TvcuXJu1spUz8z9IaAqyycBWrrGeE w4OovfiJRxah5ksRXUCMOXiPPd2y3KJcC4efI36Bl/HJ7bLx4SMONEKecGfUgz805inO RA== Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by aserp2130.oracle.com with ESMTP id 2epct9dr9g-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 07 Dec 2017 06:10:54 +0000 Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id vB76Asmh027075 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 7 Dec 2017 06:10:54 GMT Received: from abhmp0001.oracle.com (abhmp0001.oracle.com [141.146.116.7]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id vB76Ar8t012469 for ; Thu, 7 Dec 2017 06:10:54 GMT MIME-Version: 1.0 Message-ID: Date: Wed, 6 Dec 2017 22:10:52 -0800 (PST) From: Drew Adams X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4615.0 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8737 signatures=668643 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=1 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1712070095 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Well, not completely unconditionally. But I see this: (if (boundp 'special-event-map) (progn (define-key special-event-map [make-frame-visible] =09'dframe-handle-make-frame-visible) (define-key special-event-map [iconify-frame] =09'dframe-handle-iconify-frame) (define-key special-event-map [delete-frame] =09'dframe-handle-delete-frame)) ) That condition that the map exists isn't, I think, sufficient to give it license to bind keys in the map. I must have done something after my init file was loaded that required `dframe.elc' to be loaded, and that load overwrote bindings I made in my init file. I don't know what I did that caused dframe to be loaded, but that shouldn't matter. I don't think it should overwrite key bindings just by being loaded. In my init file I do this (after loading library `thumb-frm.el', which defines `thumfr-thumbify-frame-upon-event'): (when (and (eq system-type 'windows-nt) (fboundp 'thumfr-thumbify-frame-upon-event)) (define-key special-event-map [iconify-frame] 'thumfr-thumbify-frame-upon-event)) But dframe.el overwrites that binding when it gets loaded. Shouldn't dframe.el bind its own commands to `special-event-map' keys only if those keys are not already bound? I don't know what it's doing or why, but this doesn't seem very polite of it. Why should it think that just by being loaded it should (re-)bind keys? In GNU Emacs 26.0.90 (build 3, x86_64-w64-mingw32) of 2017-10-13 Repository revision: 906224eba147bdfc0514090064e8e8f53160f1d4 Windowing system distributor `Microsoft Corp.', version 6.1.7601 Configured using: `configure --without-dbus --host=3Dx86_64-w64-mingw32 --without-compress-install 'CFLAGS=3D-O2 -static -g3'' From unknown Tue Jun 17 01:37:10 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29599: 26.0; `dframe.el' binds keys unconditionally when loaded Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 Dec 2017 01:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29599 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Drew Adams Cc: 29599@debbugs.gnu.org Received: via spool by 29599-submit@debbugs.gnu.org id=B29599.151364761712296 (code B ref 29599); Tue, 19 Dec 2017 01:41:01 +0000 Received: (at 29599) by debbugs.gnu.org; 19 Dec 2017 01:40:17 +0000 Received: from localhost ([127.0.0.1]:40968 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eR6tE-0003CF-Ol for submit@debbugs.gnu.org; Mon, 18 Dec 2017 20:40:16 -0500 Received: from mail-it0-f43.google.com ([209.85.214.43]:45388) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eR6tB-0003Bz-QH for 29599@debbugs.gnu.org; Mon, 18 Dec 2017 20:40:14 -0500 Received: by mail-it0-f43.google.com with SMTP id z6so924659iti.4 for <29599@debbugs.gnu.org>; Mon, 18 Dec 2017 17:40:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=XSAYCpR7YE1iAIiFkdhtkF4wg/dF4dZstorY6biFwzI=; b=KCnpz6Ikj8XXmWVpcQ0YtaOSlGJpkAAz8BhC5jdntG0T0p7xzYIqK1yf1EAWQnCTpE NqTzWMRulO7u4wrNycLPSIX95qH1Nr4ZcwR1RISUUwW8SqsbRqlrDQ8MherC0fm8L5si U3cgms4itgLYJcC3y/HzM3yidFPJdG9lkEHZnvuaMQwxhcAUZcmm5xw9Q/N7Qr/1X5aE mV5RrlNy8tNX34fW+9/I/6K65cn0iLoBuQ6v4pZimmppj5TqgsyV5WKXKbTz8BtyZU+F coCXV82DPpkabDe3KZj+gIStCm1ujn2peTQyvSfwcnw9nnJqbseBb24FIyKE2qNo3Z6j ccGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=XSAYCpR7YE1iAIiFkdhtkF4wg/dF4dZstorY6biFwzI=; b=W9oNBoFe28hB5MKvlcgg+YCZenidq5U08GgSZ8cEmpPOWuMve7KjLniyfrXQBFvuYu uAAmWHOeceuWaS6qo2SgslnhQZhoqOWPGHmKHqDKOsjK/vVesKB+uFNUs7FBJJxNPrl8 PjCQPlq2GkxUSSjFjt4c28Zu2rwbFnqKV+bKTwZM7WrshXrPlCI4Qj6yRL3og0Zt9bRV 4NDb7I23PX3HnrGgnhUuN0vkCPOkAFpzM3qz2g9gj2CO8OIMuXaakUn4x/2yg0FA5OBT wMbBX7BMZLxDOxVYmggDbZkqUKsRTE6ojiihuMC/JvLJd8a4GUJr0UUPIdBw6lm8LaXa G5Bg== X-Gm-Message-State: AKGB3mKSeowTeNp9PcyXgDlfa4bMcqkbU9Zt8BIgVXiCOglAlwYdr2+L vVPWmWk2H+CY/HuG1iHVqwM9dQ== X-Google-Smtp-Source: ACJfBouvNadAbcUJIMFdq1WuDN52ezVzzAPc5/UBEJthmQJ6ni1SgaRNx8KKLHoGwfkZzG8hLQ4v3A== X-Received: by 10.36.1.4 with SMTP id 4mr1316473itk.59.1513647607714; Mon, 18 Dec 2017 17:40:07 -0800 (PST) Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id 202sm7061642iou.72.2017.12.18.17.40.06 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 18 Dec 2017 17:40:06 -0800 (PST) From: Noam Postavsky References: Date: Mon, 18 Dec 2017 20:40:05 -0500 In-Reply-To: (Drew Adams's message of "Wed, 6 Dec 2017 22:10:52 -0800 (PST)") Message-ID: <878tdzbimi.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.5 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) --=-=-= Content-Type: text/plain Drew Adams writes: > I must have done something after my init file was loaded that required > `dframe.elc' to be loaded, and that load overwrote bindings I made in my > init file. > > I don't know what I did that caused dframe to be loaded, but that > shouldn't matter. I don't think it should overwrite key bindings > just by being loaded. Yeah (it's probably the loading-on-completion thing again). > Shouldn't dframe.el bind its own commands to `special-event-map' keys > only if those keys are not already bound? > I don't know what it's doing or why, but this doesn't seem very polite > of it. Why should it think that just by being loaded it should > (re-)bind keys? The root problem is that there is no easy way to share the bindings. I think those keys should be bound to a function which calls runs a hook, like focus-in and focus-out events are. Actually, it sort of looks like dframe is trying to install such a hook; the functions it puts don't do anything except call `dframe-make-frame-{visible,iconify,delete}-function'. Anyway, at a minimum, we can't have keybindings being modified by just a load. Here's a patch which moves the keybinding to dframe-frame-mode activation instead. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Don-t-bind-dframe-events-on-load-Bug-29599.patch Content-Description: patch >From e7965c6f4f9dcce7f38ab9a51cd2638d5feb5c66 Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Mon, 18 Dec 2017 20:30:10 -0500 Subject: [PATCH] Don't bind dframe events on load (Bug#29599) * lisp/dframe.el (dframe-set-special-events): New function, containing previous top-level key binding code. (dframe-frame-mode): Use it. --- lisp/dframe.el | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/lisp/dframe.el b/lisp/dframe.el index 7f77d8991f..0766bd068d 100644 --- a/lisp/dframe.el +++ b/lisp/dframe.el @@ -288,6 +288,7 @@ dframe-frame-mode (set frame-var nil)) ;; Set this as our currently attached frame (setq dframe-attached-frame (selected-frame)) + (dframe-set-special-events) (run-hooks popup-hook) ;; Updated the buffer passed in to contain all the hacks needed ;; to make it work well in a dedicated window. @@ -543,16 +544,14 @@ dframe-detach ))) ;;; Special frame event proxies -;; -(if (boundp 'special-event-map) - (progn - (define-key special-event-map [make-frame-visible] - 'dframe-handle-make-frame-visible) - (define-key special-event-map [iconify-frame] - 'dframe-handle-iconify-frame) - (define-key special-event-map [delete-frame] - 'dframe-handle-delete-frame)) - ) +(defun dframe-set-special-events () + (when (boundp 'special-event-map) + (define-key special-event-map [make-frame-visible] + 'dframe-handle-make-frame-visible) + (define-key special-event-map [iconify-frame] + 'dframe-handle-iconify-frame) + (define-key special-event-map [delete-frame] + 'dframe-handle-delete-frame))) (defvar dframe-make-frame-visible-function nil "Function used when a dframe controlled frame is de-iconified. -- 2.11.0 --=-=-=-- From unknown Tue Jun 17 01:37:10 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29599: 26.0; `dframe.el' binds keys unconditionally when loaded Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 Dec 2017 02:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29599 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Noam Postavsky Cc: 29599@debbugs.gnu.org Received: via spool by 29599-submit@debbugs.gnu.org id=B29599.151364972415487 (code B ref 29599); Tue, 19 Dec 2017 02:16:02 +0000 Received: (at 29599) by debbugs.gnu.org; 19 Dec 2017 02:15:24 +0000 Received: from localhost ([127.0.0.1]:40976 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eR7RE-00041i-K1 for submit@debbugs.gnu.org; Mon, 18 Dec 2017 21:15:24 -0500 Received: from aserp2120.oracle.com ([141.146.126.78]:50796) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eR7RD-00041W-3A for 29599@debbugs.gnu.org; Mon, 18 Dec 2017 21:15:23 -0500 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.21/8.16.0.21) with SMTP id vBJ2BTee071222; Tue, 19 Dec 2017 02:15:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2017-10-26; bh=+jZjUA0P+i4NpjzoScAE08qpIxcO/HuWGGUsCktYaKQ=; b=FUz0BxyqroH2DIn1uBAs5ldo/bCmmlAFnfn87OP0pCAvSWiSk9e0ze/qi0Li36D6ST76 DdPsuu7Q4uI/b8witG60QAF0uGF2eOcXebbXbrr++w8CRNpldaSAwhrmmZQ+inwEySZV Q7JPe/JAvKkDyKfVdgt1Ng6QZmr0ku8KBNLPsrYKtxA/B4phoVvQXNyK7Ub+pMcxTQXR s8y3QgwMdb8WEwJ5ryC/vkmq6FYQebfomvTTX/JQtlkgCl8EPSvfTQc2QF1Fh4UW23tn IoxpaJxhE332XLrVtoV0bIYj0DJpeNIHzu5X15pxnUn25yUHtfb2dnRiYwcsbMEv5PnZ qw== Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by aserp2120.oracle.com with ESMTP id 2exsnvr434-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 19 Dec 2017 02:15:17 +0000 Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id vBJ2FG6U028914 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 19 Dec 2017 02:15:16 GMT Received: from abhmp0004.oracle.com (abhmp0004.oracle.com [141.146.116.10]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id vBJ2FFJc011941; Tue, 19 Dec 2017 02:15:16 GMT MIME-Version: 1.0 Message-ID: <161e969d-1b2b-4bcc-9e24-a932fe6a2655@default> Date: Mon, 18 Dec 2017 18:15:10 -0800 (PST) From: Drew Adams References: <878tdzbimi.fsf@users.sourceforge.net> In-Reply-To: <878tdzbimi.fsf@users.sourceforge.net> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4627.0 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8749 signatures=668649 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=953 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1712190027 X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) > > I must have done something after my init file was loaded that required > > `dframe.elc' to be loaded, and that load overwrote bindings I made in > > my init file. > > > > I don't know what I did that caused dframe to be loaded, but that > > shouldn't matter. I don't think it should overwrite key bindings > > just by being loaded. >=20 > Yeah (it's probably the loading-on-completion thing again). I don't think I know (or didn't know or at least don't recall) anything about such a thing. Is it something new? > > Shouldn't dframe.el bind its own commands to `special-event-map' keys > > only if those keys are not already bound? >=20 > > I don't know what it's doing or why, but this doesn't seem very polite > > of it. Why should it think that just by being loaded it should > > (re-)bind keys? >=20 > The root problem is that there is no easy way to share the bindings. Dunno what you mean by that ("share the bindings"). But maybe if I knew what "loading-on-completion" is then I would understand "share the bindings" (?). > I think those keys should be bound to a function which calls runs a hook, > like focus-in and focus-out events are. Maybe so, but then the question would be whether and why dframe.el (or anything else) would initialize the hook to have one or more functions on it. In my case, I'm pretty sure I don't want anything other than my replacement for iconification to be on the hook. So I would probably empty the hook before using `add-hook' for my function. Maybe that's only out of ignorance of what the deframe functions are for or do. > Actually, it sort of looks like > dframe is trying to install such a hook; the functions it puts don't do > anything except call `dframe-make-frame-{visible,iconify,delete}- > function'. But (without looking at them), those sound like specific replacements for the standard iconify etc. If so, it's great to provide such functions, but they shouldn't be bound to special events by default (i.e., upon loading). > Anyway, at a minimum, we can't have keybindings being modified by just a > load. Yes, thank you. > Here's a patch which moves the keybinding to dframe-frame-mode > activation instead. I can't speak to the value of the patch (I know nothing about this), but thanks for working on this. From unknown Tue Jun 17 01:37:10 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29599: 26.0; `dframe.el' binds keys unconditionally when loaded Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 Dec 2017 03:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29599 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Drew Adams Cc: 29599@debbugs.gnu.org Received: via spool by 29599-submit@debbugs.gnu.org id=B29599.151365547724105 (code B ref 29599); Tue, 19 Dec 2017 03:52:02 +0000 Received: (at 29599) by debbugs.gnu.org; 19 Dec 2017 03:51:17 +0000 Received: from localhost ([127.0.0.1]:41004 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eR8w1-0006Gd-Eo for submit@debbugs.gnu.org; Mon, 18 Dec 2017 22:51:17 -0500 Received: from mail-it0-f54.google.com ([209.85.214.54]:38606) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eR8vz-0006GM-GW; Mon, 18 Dec 2017 22:51:15 -0500 Received: by mail-it0-f54.google.com with SMTP id r6so1182716itr.3; Mon, 18 Dec 2017 19:51:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=yAbrrBlSAzN8f9OTEtB0EG0vW/UScghyPU0rQ7T3/S8=; b=CqpkEBZquaexrJKUYbWy/M4E4FeMR8xAv1keiIFwN/SJJeuMMbEMN/2TbsVRG/ODYL oi1iA763OUEaR6D7UYHRJajMvk8n+v87UfFwhgmT/L+pGNUqvvjza7QdBGmC3ug/FHZe gm+08ydXKVEGjUNe0DSxto/u/UW0v30KV7yTssYnEaOFOGyd4lekhqXjXifRYpO+m+d1 iFUFEBF+kd4r9ExKXRf7T/EReYU46E5q292LTQCe48wgkkZprirFne3vhwyH54z3nczR Rh4sVsIT4O3SC+Isr/DBsgpzVIwhLamA2jBEgtphBSM159X4PV6DT9DVnkRDe520b4xk 07gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=yAbrrBlSAzN8f9OTEtB0EG0vW/UScghyPU0rQ7T3/S8=; b=TseD6Uoziiy63fWC3I/vQJsH2E5bN62cbL7hYigsmG13w5sU6jgptgXoX2NvS3Yoqa CMsMlkX7uFzYqA/LSOHOO7NEvlVAN0yJzFx6V7Sbg6bHlUfVSJeYGoShSsSvf2aga5gT TXeGxz0pZY8FSgfbRm6tlRFBFZB0QrEQzS1/45roi+xbbQtCHtp1XbQMsqqDiKx9g+MZ FIapmGHxgVfdeITXs+nttCbWMp5ri1uH3EKdqZeF8XuuPJpLqLyQHMSZCVQmrs9m0iSJ erF6jYwhdp99NKQkRBZSSwESEjoyI4FD/jY2XTTsRqDzOhLEo21kJO7q96DfPhZFZNmC U6Ew== X-Gm-Message-State: AKGB3mLELVv/DKO8UxwfXoRTaiO7Yk85/4PMoAYX8loTMwk4/LKbfUnD wekRV9PUapVapfQbBEBZHHUuWw== X-Google-Smtp-Source: ACJfBos5zzyQd0Y9WSGPWk76e1VH4O11AD6v/Dgd7mIK7ROsN+J8bcKYZQGDw8rt6Uo4qlJH2icJsQ== X-Received: by 10.36.150.67 with SMTP id z64mr1696170itd.72.1513655469450; Mon, 18 Dec 2017 19:51:09 -0800 (PST) Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id i133sm3104204itf.1.2017.12.18.19.51.07 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 18 Dec 2017 19:51:07 -0800 (PST) From: Noam Postavsky References: <878tdzbimi.fsf@users.sourceforge.net> <161e969d-1b2b-4bcc-9e24-a932fe6a2655@default> Date: Mon, 18 Dec 2017 22:51:06 -0500 In-Reply-To: <161e969d-1b2b-4bcc-9e24-a932fe6a2655@default> (Drew Adams's message of "Mon, 18 Dec 2017 18:15:10 -0800 (PST)") Message-ID: <876093bck5.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.2 (/) tags 29599 + patch quit Drew Adams writes: >> Yeah (it's probably the loading-on-completion thing again). > > I don't think I know (or didn't know or at least don't > recall) anything about such a thing. Is it something new? Yes, see Bug#28607. >> Actually, it sort of looks like >> dframe is trying to install such a hook; the functions it puts don't do >> anything except call `dframe-make-frame-{visible,iconify,delete}- >> function'. > > But (without looking at them), those sound like specific > replacements for the standard iconify etc. If so, it's > great to provide such functions, but they shouldn't be > bound to special events by default (i.e., upon loading). As far as I can tell, there is no code in Emacs which sets those functions to anything. So presumably the idea is to allow the user to run some code when a "dframe" is made visible/iconified/deleted. >> Here's a patch which moves the keybinding to dframe-frame-mode >> activation instead. > > I can't speak to the value of the patch (I know nothing > about this), but thanks for working on this. Okay, it should take care of this bug, and it should be perfectly safe, since the functions do nothing before dframe-frame-mode is activated anyway. I'll push to emacs-26 in a few days if there are no objections. From unknown Tue Jun 17 01:37:10 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29599: 26.0; `dframe.el' binds keys unconditionally when loaded Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 Dec 2017 05:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29599 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Noam Postavsky Cc: 29599@debbugs.gnu.org Received: via spool by 29599-submit@debbugs.gnu.org id=B29599.151366089614488 (code B ref 29599); Tue, 19 Dec 2017 05:22:02 +0000 Received: (at 29599) by debbugs.gnu.org; 19 Dec 2017 05:21:36 +0000 Received: from localhost ([127.0.0.1]:41058 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eRALQ-0003lc-Dh for submit@debbugs.gnu.org; Tue, 19 Dec 2017 00:21:36 -0500 Received: from aserp2120.oracle.com ([141.146.126.78]:47186) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eRALO-0003lO-Dw for 29599@debbugs.gnu.org; Tue, 19 Dec 2017 00:21:35 -0500 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.21/8.16.0.21) with SMTP id vBJ5J482182499; Tue, 19 Dec 2017 05:21:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2017-10-26; bh=KAvW1ddujGO00DhwZjvKxr/vJ8f10thQeS/0q+/jXFI=; b=a+NEFkpnmbnc/IzhsD+808lvo4JCXhhiM1G29tg6tE67m8vdiuokemlrr1qL6IexSMsV dE7/QTSNW3SQWLLyfYK7IYFKZk8lXl1m6INQWrrNkoqkWAORIuZWbmv0XSPoRL+hJh/3 MtY4WXBifDUDnRochygSekG4cH0Tc5ipxuA4cMWRTKARA/4MmOYQ5MMN4T8SUGrdRWlw FK4Lry4cXPxuC4Q2vTrEFgBHbVOF2oPaJMKfbxhhMfwplK05CeVG/Ks3xF2d0sk5HDxc IwdQmmoVU2U9v0YkDqrUVWGAbVNCwx3gyTNF5Tf5ZeStsbyrbvASGfGP3jQ1f3CvnbWh Sg== Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by aserp2120.oracle.com with ESMTP id 2exvh1808h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 19 Dec 2017 05:21:28 +0000 Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id vBJ5LRnD025940 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 19 Dec 2017 05:21:27 GMT Received: from abhmp0008.oracle.com (abhmp0008.oracle.com [141.146.116.14]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id vBJ5LQ8l015182; Tue, 19 Dec 2017 05:21:27 GMT MIME-Version: 1.0 Message-ID: Date: Mon, 18 Dec 2017 21:21:25 -0800 (PST) From: Drew Adams References: <878tdzbimi.fsf@users.sourceforge.net> <161e969d-1b2b-4bcc-9e24-a932fe6a2655@default> <876093bck5.fsf@users.sourceforge.net> In-Reply-To: <876093bck5.fsf@users.sourceforge.net> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4627.0 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8749 signatures=668649 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=873 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1712190077 X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) > tags 29599 + patch > quit >=20 > Drew Adams writes: >=20 > >> Yeah (it's probably the loading-on-completion thing again). > > > > I don't think I know (or didn't know or at least don't > > recall) anything about such a thing. Is it something new? >=20 > Yes, see Bug#28607. That's quite a bug report - no report at all (?). Perhaps it was because all of the actual report was in another bug report that was closed, and that now redirects to this (vacuous) report? The only thing in #28607 is a link to an emacs-devel thread. No description of the problem (?). Anyway, it's not clear to me how that bug relates to this one. This one is about explicitly binding keys when the source code loads. I don't get the impression that that one is about this at all. (What am I missing?) > > But (without looking at them), those sound like specific > > replacements for the standard iconify etc. If so, it's > > great to provide such functions, but they shouldn't be > > bound to special events by default (i.e., upon loading). >=20 > As far as I can tell, there is no code in Emacs which sets those > functions to anything. So presumably the idea is to allow the user to > run some code when a "dframe" is made visible/iconified/deleted. No doubt. But (I think we agree?) that possibility should be offered to users, to choose, and not imposed just by loading the file. > >> Here's a patch which moves the keybinding to dframe-frame-mode > >> activation instead. > > > > I can't speak to the value of the patch (I know nothing > > about this), but thanks for working on this. >=20 > Okay, it should take care of this bug, and it should be perfectly safe, > since the functions do nothing before dframe-frame-mode is activated > anyway. I'll push to emacs-26 in a few days if there are no objections. Thanks. From unknown Tue Jun 17 01:37:10 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29599: 26.0; `dframe.el' binds keys unconditionally when loaded Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 Dec 2017 13:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29599 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Drew Adams Cc: 29599@debbugs.gnu.org Received: via spool by 29599-submit@debbugs.gnu.org id=B29599.15136893211196 (code B ref 29599); Tue, 19 Dec 2017 13:16:01 +0000 Received: (at 29599) by debbugs.gnu.org; 19 Dec 2017 13:15:21 +0000 Received: from localhost ([127.0.0.1]:41358 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eRHjs-0000JE-Tr for submit@debbugs.gnu.org; Tue, 19 Dec 2017 08:15:21 -0500 Received: from mail-io0-f182.google.com ([209.85.223.182]:44235) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eRHjq-0000J1-RM for 29599@debbugs.gnu.org; Tue, 19 Dec 2017 08:15:19 -0500 Received: by mail-io0-f182.google.com with SMTP id w127so13534488iow.11 for <29599@debbugs.gnu.org>; Tue, 19 Dec 2017 05:15:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=DwMMxWuW1LceBUjAShCg1GaYhLxZqG51wUK4qUzTaaU=; b=pbflyYmY5SHIPZrpNgr3+hD6HHkWOSold4rA8iFYByVHY22oIDkwAparCr3D2V7sP9 HPQi3QGNQiNUFXW0HrYAwjXyk/YV1s0DNQJu5MBNAbthMa2yIlxlL7dT6oDbqUM8iFzP kugRVdwp5xPZzsBEu7fgjyXPF+AHAzfHylqa1Gn/foLDWvDUoxEvujQ9GqMqjdCHShxj xBuO6u3XRQ1HD7VCY8oBrJuYfLWkXCoOr/XbvmNH2eOeaQbdCaOg909oUafec8BEHwE2 +GESIjr4Yfrd4c1wmPunSLnvY2lxC8Xug/Qj7wKCHO1V618BaZEvrxdmvpzk5M/YYYkW Rd4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=DwMMxWuW1LceBUjAShCg1GaYhLxZqG51wUK4qUzTaaU=; b=lYUgktR44zVp5Pfp3L5bkdh/6/B6FRV4PIQ8OIZ1mFYyKqSN/iGp/EJdjKaAWaQFrh 0VQEgkW2u7yHycyKJTneuraFqGuuVltgbTg2STdbQ1qLUcqMs1NkjEAEuR0p9IHwqzoR xK7KNEmGlI4dgpzDUpHNgB7YOimfcnJ299GimCtnsYMIeH3Lcec0oMqnhORDjVnhC+Og MRcr6yROMqcny1qo8gQ5eCA7DbmI6yeezF8621wr3ecDBbPXfKIH91UjEnlVnsy0NDDF AuVttgCZWDAszR1yJu8z9r+GpICd0afjtbcKsb7/JUgWNuhqHoAs4alGOvHBTY2NXxqD bA+Q== X-Gm-Message-State: AKGB3mIiOKnW0eTjutUXsHxYaPUtZpqqN/Ht3vY5FOS8jq0APy4JCk9o TY2BoM8VBBFRP3qDLmGqSzh12Q== X-Google-Smtp-Source: ACJfBotSN1IM285GtHSpkGspE9iYMzJTl/BjOT/0MxCJbaG96a1eOU4dl1FF0C7o63+Qkvx8rI5yXQ== X-Received: by 10.107.174.201 with SMTP id n70mr4081008ioo.45.1513689313115; Tue, 19 Dec 2017 05:15:13 -0800 (PST) Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id i76sm1221956itf.3.2017.12.19.05.15.11 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 19 Dec 2017 05:15:12 -0800 (PST) From: Noam Postavsky References: <878tdzbimi.fsf@users.sourceforge.net> <161e969d-1b2b-4bcc-9e24-a932fe6a2655@default> <876093bck5.fsf@users.sourceforge.net> Date: Tue, 19 Dec 2017 08:15:11 -0500 In-Reply-To: (Drew Adams's message of "Mon, 18 Dec 2017 21:21:25 -0800 (PST)") Message-ID: <873746c10g.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.5 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) Drew Adams writes: > That's quite a bug report - no report at all (?). > > Perhaps it was because all of the actual report was > in another bug report that was closed, and that now > redirects to this (vacuous) report? > > The only thing in #28607 is a link to an emacs-devel > thread. No description of the problem (?). > > Anyway, it's not clear to me how that bug relates to this one. > > This one is about explicitly binding keys when the > source code loads. I don't get the impression that > that one is about this at all. (What am I missing?) Oh, yeah, I probably should have pointed to the linked stuff. Bug#28048 has more info. Anyway, the relation is just that it probably explains how you got dframe loaded (I have got dframe loaded in my session as well, even though I don't use it). From unknown Tue Jun 17 01:37:10 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29599: 26.0; `dframe.el' binds keys unconditionally when loaded Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 Dec 2017 15:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29599 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Noam Postavsky Cc: 29599@debbugs.gnu.org Received: via spool by 29599-submit@debbugs.gnu.org id=B29599.151369696613800 (code B ref 29599); Tue, 19 Dec 2017 15:23:01 +0000 Received: (at 29599) by debbugs.gnu.org; 19 Dec 2017 15:22:46 +0000 Received: from localhost ([127.0.0.1]:42443 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eRJjC-0003aW-4M for submit@debbugs.gnu.org; Tue, 19 Dec 2017 10:22:46 -0500 Received: from userp2130.oracle.com ([156.151.31.86]:51810) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eRJjA-0003aI-KZ for 29599@debbugs.gnu.org; Tue, 19 Dec 2017 10:22:45 -0500 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.21/8.16.0.21) with SMTP id vBJFLWlm186422; Tue, 19 Dec 2017 15:22:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2017-10-26; bh=2nPXF+dGOmKfhII9Wr9FmWYO9mi33Qcy9oTZfcfIijM=; b=Wfsw6RaEu98ZQRjks9JgzDsgieohLcKsNTxqKRtdbB1zWeqB6E5bWp+UDS15WtZvD0J5 g8oEtr06Pd89yj4MU4fkps0+fLhGz+Fr91Y2K9D0Og4r7DaFBXB7PZ4yjmdVN6CDP4xV t3+WbLTnxJiCiYLPchtLdAUCZDtuE5CBOywsrgD5zIJnEyt0ySMmeN0b3Ye6J5uuWayZ FkoeGCLKFNIuccZWJSPE3lRxV8+EHIykYp4BD85hSvxGW9vdS9Wvk2sIpTtVQXZ2jKlA pEdj+ZWKym/TwVhi9jGnibkiSGI1EG1oHj5Qcm/9uU9HXREUqJRoksnaLYBSU1SeEXRC UQ== Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by userp2130.oracle.com with ESMTP id 2ey3x5rh47-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 19 Dec 2017 15:22:37 +0000 Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id vBJFMYB9007215 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 19 Dec 2017 15:22:35 GMT Received: from abhmp0007.oracle.com (abhmp0007.oracle.com [141.146.116.13]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id vBJFMYDc018468; Tue, 19 Dec 2017 15:22:34 GMT MIME-Version: 1.0 Message-ID: Date: Tue, 19 Dec 2017 07:22:32 -0800 (PST) From: Drew Adams References: <878tdzbimi.fsf@users.sourceforge.net> <161e969d-1b2b-4bcc-9e24-a932fe6a2655@default> <876093bck5.fsf@users.sourceforge.net> <873746c10g.fsf@users.sourceforge.net> In-Reply-To: <873746c10g.fsf@users.sourceforge.net> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4627.0 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8750 signatures=668650 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=439 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1712190220 X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) > the relation is just that it probably explains how you got > dframe loaded (I have got dframe loaded in my session as well, even > though I don't use it). Got it. Thanks. From unknown Tue Jun 17 01:37:10 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29599: 26.0; `dframe.el' binds keys unconditionally when loaded Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 03 Jan 2018 02:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29599 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Drew Adams Cc: 29599@debbugs.gnu.org Received: via spool by 29599-submit@debbugs.gnu.org id=B29599.151494478229463 (code B ref 29599); Wed, 03 Jan 2018 02:00:02 +0000 Received: (at 29599) by debbugs.gnu.org; 3 Jan 2018 01:59:42 +0000 Received: from localhost ([127.0.0.1]:33648 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eWYLF-0007f5-Pr for submit@debbugs.gnu.org; Tue, 02 Jan 2018 20:59:41 -0500 Received: from mail-it0-f44.google.com ([209.85.214.44]:42987) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eWYLD-0007ek-Ay; Tue, 02 Jan 2018 20:59:39 -0500 Received: by mail-it0-f44.google.com with SMTP id p139so217863itb.1; Tue, 02 Jan 2018 17:59:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=dBc8fyme8pezW7Nh0YPUQ9qwWr+GB4mcSx/7+HrKVzA=; b=Q/HRo6wltFd0ANBOfM3FnRMe2p509gw/RbkPB2P5FQ7gvSdNtSz0g5N1XkXO/So9hX kcyBLGDWgOH7HraSopVnKOZ2Kg0CkLZoGKbk4ZOlw/5+Nuny38B5EjmTspYB8mODhhAs oaWdm3VcdfKw4niKi5CsKKfDQhB+gI4wSyYuZpMra0kWatuakrh1+2GZsnFwFTI4dR9K 1uusuVW0Wso8Dp7Z6yvuUn2XS3w4rDBUHYgJFUXcNFY6HzMZ/vccC1keI52ikvqCrQqX c0j01yhXe+NiL3wfzlcQV+mPIPZ3Dp77jctLyVmobzHau7sxNPAS4DFG1A72Jj7Dh667 Gq7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=dBc8fyme8pezW7Nh0YPUQ9qwWr+GB4mcSx/7+HrKVzA=; b=uU7q5p6BsBMgKCVrlYDQKuHAt8ymcAImEHGFME5IGtU2yZggt7gqDedzXNJX6kBnpW uCXvxclw7xzlU5K0P99TE98hX0ilAL85hv9iN9P7FuxRFVnkrrucWQ0u+VxetT/eCfhV tV6SBjXSr1fEm/aTH6ocNFo9Ct/ByiC1jYiVsx2e19yUGISOA6FvJyhaWbV9UzfYG8E/ Vul4M/3gwsSAZVhqeYQ52ynihEA44Sr0SCQUvxWddHItFMRYRU4XBcXFiVL18wJ96Au+ c6joZHQmq2KYZ2Ns114iGCuvvWYY2B3P9oWDSSEyjlKwEeya3NtfUHnLegIDibQjyUtt Mwpg== X-Gm-Message-State: AKGB3mIdKzcMxSTSDy11K0grVwKLmceFSt6Opb5nKbhgG4cIEy0HHV/v rGibefxY7df5cMAYwr8R6AdyGg== X-Google-Smtp-Source: ACJfBotHSQLsTklyT7PB3xW9J+fazn/lOghIZyAFj5PmzAYJ6ClFY8YhQUVAE1piSMDJrM88YXAMaA== X-Received: by 10.36.48.82 with SMTP id q79mr206639itq.75.1514944773602; Tue, 02 Jan 2018 17:59:33 -0800 (PST) Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id 140sm6009408itx.3.2018.01.02.17.59.32 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 02 Jan 2018 17:59:32 -0800 (PST) From: Noam Postavsky References: <878tdzbimi.fsf@users.sourceforge.net> <161e969d-1b2b-4bcc-9e24-a932fe6a2655@default> <876093bck5.fsf@users.sourceforge.net> Date: Tue, 02 Jan 2018 20:59:31 -0500 In-Reply-To: <876093bck5.fsf@users.sourceforge.net> (Noam Postavsky's message of "Mon, 18 Dec 2017 22:51:06 -0500") Message-ID: <87lghfsnwc.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.5 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) tags 29599 fixed close 29599 26.1 quit Noam Postavsky writes: > Okay, it should take care of this bug, and it should be perfectly safe, > since the functions do nothing before dframe-frame-mode is activated > anyway. I'll push to emacs-26 in a few days if there are no objections. Pushed to emacs-26, but I modified the patch a bit to avoid binding the keys repeatedly. [1: 43e2aafae3]: 2018-01-02 20:53:42 -0500 Don't bind dframe events on load (Bug#29599) https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=43e2aafae306d9f7a463cba301d0253db846e20d