GNU bug report logs - #29594
Emacs 26 -- xdisp.c:21657 OR xdisp.c:21671?

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Keith David Bershatsky <esq <at> lawlist.com>
Cc: 29594 <at> debbugs.gnu.org
Subject: bug#29594: Emacs 26 -- xdisp.c:21657 OR xdisp.c:21671?
Date: Sat, 09 Dec 2017 14:51:04 +0200

> Date: Wed, 06 Dec 2017 13:49:24 -0800
> From: Keith David Bershatsky <esq <at> lawlist.com>
> 
> In the Emacs 26 branch downloaded this morning, I see:
> 
> xdisp.c:21657
> it->continuation_lines_width += wrap_x;
> 
> and, I see:
> 
> xdisp.c:21671
> it->continuation_lines_width += x;
> 
> If only one of these is needed, then it may be appropriate to remove whichever one is not needed.  I understand that the second occurrence supersedes the first occurrence in this section of code, but it would be cleaner if there were only one setting.  If both occurrences are needed, then perhaps a comment in the code at that particular location would be helpful.

This is a bug, and a very old one: the second increment should not be
done.  This bug was introduced when the word-wrap feature was added to
Emacs, 9 years ago.  It could only remain undetected for such a long
time because the numerical value of continuation_lines_width is almost
never used, most of the code only cares whether the value is zero or
positive.

Thanks for pointing this out, I've now fixed this on the release
branch.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.