Subject: bug#29582: closed (Re: [bug#29582] [PATCH] gnu: git-modes: Rename to 'emacs-git-modes'.)

From: [email-masked] (GNU bug Tracking System)
Date: Sun, 10 Dec 2017 19:42:03 +0000

Your bug report

#29582: [PATCH] gnu: git-modes: Rename to 'emacs-git-modes'.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
29582: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=29582
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#29582] [PATCH] gnu: git-modes: Rename to 'emacs-git-modes'.
From: Alex Kost <[email-masked]>
To: [email-masked] (Ludovic Courtès)
Cc: Leo Famulari <[email-masked]>, [email-masked]
Date: Sun, 10 Dec 2017 22:41:35 +0300
List-Id: <debbugs-submit.debbugs.gnu.org>

Ludovic Courtès (2017-12-08 10:44 +0100) wrote:

> Hi,
>
> Alex Kost <[email-masked]> skribis:
>
>> Then I'm lost here: it is absolutely not clear for me where the border
>> between libraries and end-user applications lies in the Emacs world.
>> Such things as "emacs-dash" or "emacs-s" are definitely libraries but
>> most of the other Emacs packages are intended for users but we still
>> prefix them ("emacs-auctex", "emacs-pdf-tools", etc.)
>
> “emacs-git-modes” looks appropriate to me here and consistent with the
> choices we’ve made so far.

Committed as 6d21272b2, thanks all for the comments!

-- 
Alex

Subject: [PATCH] gnu: git-modes: Rename to 'emacs-git-modes'.
From: Alex Kost <[email-masked]>
To: [email-masked]
Date: Tue, 05 Dec 2017 23:31:30 +0300
List-Id: <debbugs-submit.debbugs.gnu.org>

Hello, what about renaming 'git-modes' to 'emacs-git-modes' (similarly
to 'emacs-paredit')?

>From 6b36950703b1fa589ac0ee9e2343c7970a7859f6 Mon Sep 17 00:00:00 2001
From: Alex Kost <[email-masked]>
Date: Tue, 5 Dec 2017 23:27:23 +0300
Subject: [PATCH] gnu: git-modes: Rename to 'emacs-git-modes'.

* gnu/packages/emacs.scm (git-modes)[name]: Change to "emacs-git-modes".
(git-modes/old-name): New variable.
---
 gnu/packages/emacs.scm | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index e5e6cf097..0ca8add53 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -377,7 +377,7 @@ when typing parentheses directly or commenting out code line by line.")
 
 (define-public git-modes
   (package
-    (name "git-modes")
+    (name "emacs-git-modes")
     (version "1.2.6")
     (source (origin
               (method url-fetch)
@@ -396,6 +396,9 @@ when typing parentheses directly or commenting out code line by line.")
 configuration files, such as .gitattributes, .gitignore, and .git/config.")
     (license license:gpl3+)))
 
+(define-public git-modes/old-name
+  (deprecated-package "git-modes" git-modes))
+
 (define-public emacs-with-editor
   (package
     (name "emacs-with-editor")
-- 
2.14.2