From unknown Mon Jun 23 07:53:06 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29575: 25.3; Secret Service API treats labels as unique Resent-From: Allen Li Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 05 Dec 2017 05:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 29575 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 29575@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.151245255929968 (code B ref -1); Tue, 05 Dec 2017 05:43:02 +0000 Received: (at submit) by debbugs.gnu.org; 5 Dec 2017 05:42:39 +0000 Received: from localhost ([127.0.0.1]:46267 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eM606-0007nI-PP for submit@debbugs.gnu.org; Tue, 05 Dec 2017 00:42:39 -0500 Received: from eggs.gnu.org ([208.118.235.92]:39719) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eM605-0007n4-1x for submit@debbugs.gnu.org; Tue, 05 Dec 2017 00:42:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eM5zy-0004qX-Pi for submit@debbugs.gnu.org; Tue, 05 Dec 2017 00:42:31 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:40609) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eM5zy-0004qT-Ls for submit@debbugs.gnu.org; Tue, 05 Dec 2017 00:42:30 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58923) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eM5zx-0007Ls-EK for bug-gnu-emacs@gnu.org; Tue, 05 Dec 2017 00:42:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eM5zw-0004os-IR for bug-gnu-emacs@gnu.org; Tue, 05 Dec 2017 00:42:29 -0500 Received: from mail-qt0-x22c.google.com ([2607:f8b0:400d:c0d::22c]:41474) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eM5zw-0004oi-Ck for bug-gnu-emacs@gnu.org; Tue, 05 Dec 2017 00:42:28 -0500 Received: by mail-qt0-x22c.google.com with SMTP id i40so26581194qti.8 for ; Mon, 04 Dec 2017 21:42:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=rmqDLKrtrr2Sy1M2TlEAV8cAB1751+eqGSUNHPYgWJI=; b=Ql4VMVHd26vcaPe8qxTvHCpLvVqhlhyUC7va9wulG4vyDPLt6Jk0145H8zdsCHAcdv oxmKkiqBLDO3qJR9Vfj0otw8T75LhCd8KcQ5PrUWu0wFJkrAxzfLWA7RGBnm34XoRndT nWRClgfbKx0VQknQtAAy8jD2cg1zC9zsGboIXYICeZKE01jdaiX/4IJIyRFluJP0mRD6 y6k0Ov7nX7h5nNsM50V6XJklu3kzOdHv0EdgwRqhTwTrmQW4OAJ0EZiPsqTAJ9IXHmL2 /stOXAO8Xj9XuKVKS97RpyrQrsWOc3PL760rjkiuxT/AioE0bn88ATan3orUuZAjVQ24 Hbpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=rmqDLKrtrr2Sy1M2TlEAV8cAB1751+eqGSUNHPYgWJI=; b=KNyeQnujXjOzoSeS95P4Jwl+u6ABZIOlaNNpBJFjXChVI14tfDROBDAY4sAoef4IdU s8GGZRTb91jIhWT/Yz6ED2HQgcsZs9tVzxvjheZ1q8Y90zyl5MdTuAGxXStiLo1csmx+ 5kd8E94/HapciaJiCxb3iRp/Xm5ZEh04S0syc9jR9wVYcNKMI0x37vsnHGabEb4SGAzn m5z2ms2soLsOudwe40pqmCsve6seiFzoeeT4QjyHRoWOoEMiUWK1oHihgkv4nYMnt+qN veuqME6mKkHg2kdJ3xeLJgkY6gPhmI2mFxJeCm5ue52QP7kng47GvLkxo2ELIEzSBy26 BFlg== X-Gm-Message-State: AKGB3mKOlCkd+vr0osJY7zyqP01hgbaTx7kpDPCs3DPobNHhVgFIuRXF VU81yr9mZwri+YJySbKIqrqSHiiAjGC0HsYBn4ehn2Db X-Google-Smtp-Source: AGs4zMZAkPACYnzW97As5qrjm1kyA6HRN2F89nUdlXUcw1jWGJ7GXx+hNKVV+ssDmEdnp1iHGIbf9o1Fi+d3A5+DhEA= X-Received: by 10.55.18.134 with SMTP id 6mr22183642qks.136.1512452547269; Mon, 04 Dec 2017 21:42:27 -0800 (PST) MIME-Version: 1.0 Received: by 10.237.55.36 with HTTP; Mon, 4 Dec 2017 21:42:26 -0800 (PST) From: Allen Li Date: Mon, 4 Dec 2017 21:42:26 -0800 Message-ID: Content-Type: text/plain; charset="UTF-8" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) The Secret Service API [1] treats labels as unique keys for each secret item in a collection. However, labels are not required to be unique in a collection [2], the attribute key/value pairs are. It is perfectly valid to have multiple secrets with the same label, in which case Emacs's Secret Service API is not able to retrieve all but the most recently created (?) secret. This can be demonstrated by creating two such secrets using the secret-tool utility: secret-tool store --label=Test1 id foo secret-tool store --label=Test1 id bar You can see how the attributes uniquely identify secrets: secret-tool store --label=Test2 id foo # This overwrites the first secret. Implementation idea: Use attribute plists instead of label strings to uniquely identify secret items. This would require creating a new copy of the API to preserve backward compatibility. [1]: https://www.gnu.org/software/emacs/manual/html_node/auth/Secret-Service-API.html [2]: https://specifications.freedesktop.org/secret-service/re02.html In GNU Emacs 25.3.1 (x86_64-pc-linux-gnu, GTK+ Version 3.22.19) of 2017-09-16 built on juergen Windowing system distributor 'The X.Org Foundation', version 11.0.11905000 Configured using: 'configure --prefix=/usr --sysconfdir=/etc --libexecdir=/usr/lib --localstatedir=/var --with-x-toolkit=gtk3 --with-xft --with-modules 'CFLAGS=-march=x86-64 -mtune=generic -O2 -pipe -fstack-protector-strong -fno-plt' CPPFLAGS=-D_FORTIFY_SOURCE=2 LDFLAGS=-Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now' Configured features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GCONF GSETTINGS NOTIFY ACL GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 MODULES From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 05 02:42:35 2017 Received: (at control) by debbugs.gnu.org; 5 Dec 2017 07:42:35 +0000 Received: from localhost ([127.0.0.1]:46353 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eM7sB-0002Nu-8p for submit@debbugs.gnu.org; Tue, 05 Dec 2017 02:42:35 -0500 Received: from mout.gmx.net ([212.227.15.15]:60064) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eM7s7-0002Ng-Mg for control@debbugs.gnu.org; Tue, 05 Dec 2017 02:42:34 -0500 Received: from detlef.gmx.de ([79.140.122.24]) by mail.gmx.com (mrgmx003 [212.227.17.190]) with ESMTPSA (Nemesis) id 0LlV71-1eu5B81MgB-00bK9A for ; Tue, 05 Dec 2017 08:42:25 +0100 Date: Tue, 05 Dec 2017 08:42:24 +0100 Message-Id: <878tehlixr.fsf@gmx.de> To: control@debbugs.gnu.org From: Michael Albinus Subject: control message for bug #29575 X-Provags-ID: V03:K0:2OhgNTjitBrLTpUk27GCJsO1AoTe1vC/NmHKWRosn0qwP6ARFsr tJCLS4/8zmkQOrTeRnJbgtJoA7uy2a9Lz2VTp480IJcg8b7t0pExmnGa2tmZgDfwqh/UzMG iQdif8naHJ4ke78OJkR0By1lfpOeyo44Qa2NnZBNGFhiUM/k9UxVaDfVqC5wrcJKZQd91aZ /08ZNS+WUd25oSFJbuOpw== X-UI-Out-Filterresults: notjunk:1;V01:K0:ENyik3MVWuk=:X0JzC6jkYD51KbUwNcIem0 MG0SzPi94qxKcaKav0CWrem9ffOCcUVWnYGfeWV+R95W4SD+tm+2n6WwiPmE9dljryLXWsUD9 TepgJ3o4tFRmQRLPqAUZ4gFE80vWhC01AnheeH2cULH0noevYnraFwP8sWKQlBS1yxCH2x5Cc ABgea5SwhzeypOwoLzGL9SzYZ4LABzvhG4RordI5a9Pn5N4smFdAo/i1kpvuxKTJYCLeb+JhF 40NWj84OguHgAZX1Gka63f2AikY4Z/PLSylm7XYk05pF6gcKbu7N1dOKZhno9QsQHGKM5SreC s+KO1w1hOYVh0SALobqES1dA0+ANMOJSV7JZKX1TbQKDbBFnxaWgqR/fqyKDctMIblZqpKeBy bYZSPeRDEKTaZcyN7sDANnWFgiPH0/dtGkuQg2QUfXcnHlPMImemLGd6/JaAvBa0pcUOviP0T UK45y9438uJJKt77ZHzlVStSKXmlOVtMBFjCqV/E/GfueIEF4znfF7WdlQZUemxqysNHKjm0o pP6lf3dWqXwIz8DAp7pLeK+6somQrX5H+CgmJvvoe7I/KZRcFJcEeQSzLyE1M15eVLQmJqjeX w7FRgHDhrLRNBRaLQ/ty7dNSBKhBa8Tcn8aOoIfgj84J16BRG5+E3t+T33hprW/HAuj+BDMt8 55NTBHdJSaEfzyg9Erl/7hZcvmaH/1mO5hkPMGbHIV9Q/LXzD0RIS4ildF7sG6d7JZZUM6LuJ qiVI4XrEMnNa7P0911G0Bsowvr3Lb/OHK28OWXxD+6z17Z9LzWYIGdCawq7xdXnuBPTCyTzPu ShISBn9/BjCbZUsTXGJmkjSU47BnA== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) severity 29575 wishlist From unknown Mon Jun 23 07:53:06 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29575: 25.3; Secret Service API treats labels as unique Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Dec 2017 13:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29575 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Allen Li Cc: 29575@debbugs.gnu.org Received: via spool by 29575-submit@debbugs.gnu.org id=B29575.151299736817083 (code B ref 29575); Mon, 11 Dec 2017 13:03:02 +0000 Received: (at 29575) by debbugs.gnu.org; 11 Dec 2017 13:02:48 +0000 Received: from localhost ([127.0.0.1]:56153 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eONjL-0004RT-Lv for submit@debbugs.gnu.org; Mon, 11 Dec 2017 08:02:47 -0500 Received: from mout.gmx.net ([212.227.15.18]:64485) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eONjI-0004RC-Ku for 29575@debbugs.gnu.org; Mon, 11 Dec 2017 08:02:46 -0500 Received: from detlef.gmx.de ([212.86.43.245]) by mail.gmx.com (mrgmx002 [212.227.17.190]) with ESMTPSA (Nemesis) id 0LrNIC-1f33Zf1Xxc-0136QX; Mon, 11 Dec 2017 14:02:35 +0100 From: Michael Albinus References: Date: Mon, 11 Dec 2017 14:02:34 +0100 In-Reply-To: (Allen Li's message of "Mon, 4 Dec 2017 21:42:26 -0800") Message-ID: <87374hct91.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:sjAKvJftCn1eu5Rjsivhuk9jqw3rUPlaeLrpF4YtF37d6XH7yby +LkfjcLm7dq3FpyBdSpLzvi9+yL0Qh2xupAwHkrLSQcVuCcwgKgOqqaD5G42CrGaAz8/cMB 4WJY631XPUJ9gdzQM4r8ZltWvOfrvN8sj6QODIwNmcOF5yrlGopCyrnAILqtiMnDlBPHy54 gzQHoy9kly2kNf3jTuKbw== X-UI-Out-Filterresults: notjunk:1;V01:K0:5hsuNQaC2WI=:L1W2WzfsxvUn4GANeb53FB ag+CLKsEnxrShTfgmpP0N8OArrNjxLgBmvsCFqqfHzVFyYqSfeKz9BA9U6ZGyl1MP3v2/nlOR dAoADY0yJEZkQHMf232F1k5d1CY2641yytZwNLTDWLenaMtlXVL2R0Pc/cz/p4k2VnT1UUUxa TMrXDv20ACbx/I1klhp+53NXO8A3EBlh/ZjbKxklo63tYy9uUpIdzGPg6Mez71YqB3BPDL+cI QIEGxDbFdxA+rY9pWqqJKKW2cJ1pIou9H5WeirpXHD1YEq8/5huxw1mkqpgBXPeQFDo2GJZKj mXEP8f3v4ttx/k1G7e3OXmzKoEWT+CDSMELEM1mNADaZi8hJEWQFpSC9QNVlp3xuOiSYuZbjZ w/qCAr4AvIfYoj/2xGNfB/IhL27SaIlrjTB4Oaj8wfiILn+JQuKNimgZ2psg1OH2EamTS1a7W QohJZKCgMf3NZf1cpdwoIwHZ8GlTrEwF32/a7usXZ6Okn+xDXFXVx/wFlNgctOWiaIaPZ3rVM EBgpCM95+1d9cysqmb+Mki19gyprGGbxgYvF5u4s8ugn5GvZE4lnG5jKrZss4JI9+59njBrUC 17ImhakwSdfZmYKFhg4IqzaeMhW2bUu5CDNdLEf3ltwLVH42vR153zdl2qEaOrEUhaNM3Eito 5t35IwS5bmPwYkfyn9oZtmWLhJ5NFwKjjrDIjEIOxXZY8JwScAxTNAg6m5JqLKctfWNAzNVls Q4xTs9zUxahF5Ubjt9RzYemNUozOO8SKqwJHPQbn6rx2OEiYUfPaonYrZevV9vKDlLCHwX1HG gle+OLDdghXSz8DkKpQWirtS8KshuOLtTyWvKTKaNtRsWmJKeA= X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Allen Li writes: Hi Allen, > The Secret Service API [1] treats labels as unique keys for each > secret item in a collection. However, labels are not required to be > unique in a collection [2], the attribute key/value pairs are. > > It is perfectly valid to have multiple secrets with the same label, in > which case Emacs's Secret Service API is not able to retrieve all but > the most recently created (?) secret. > > This can be demonstrated by creating two such secrets using the > secret-tool utility: > > secret-tool store --label=Test1 id foo > secret-tool store --label=Test1 id bar > > You can see how the attributes uniquely identify secrets: > > secret-tool store --label=Test2 id foo # This overwrites the first secret. First of all: do you have a use case in mind for this? Whether we'll extend the Secret Service API depends on the real need. > Implementation idea: Use attribute plists instead of label strings to > uniquely identify secret items. Well, inside the org.freedesktop.Secret.{Service,Collection,Item} interfaces, an item is identified by an object path. We could extend our interface to allow both label and object path as item, and to throw away the "unique label rule" inside collections. > This would require creating a new copy of the API to preserve backward > compatibility. The change proposed above would be backward compatible. Best regards, Michael. From unknown Mon Jun 23 07:53:06 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29575: 25.3; Secret Service API treats labels as unique Resent-From: Allen Li Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Dec 2017 19:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29575 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Michael Albinus Cc: 29575@debbugs.gnu.org Received: via spool by 29575-submit@debbugs.gnu.org id=B29575.151302164115656 (code B ref 29575); Mon, 11 Dec 2017 19:48:02 +0000 Received: (at 29575) by debbugs.gnu.org; 11 Dec 2017 19:47:21 +0000 Received: from localhost ([127.0.0.1]:57238 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eOU2r-00044S-11 for submit@debbugs.gnu.org; Mon, 11 Dec 2017 14:47:21 -0500 Received: from mail-qt0-f181.google.com ([209.85.216.181]:42297) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eOU2p-00044A-7G for 29575@debbugs.gnu.org; Mon, 11 Dec 2017 14:47:19 -0500 Received: by mail-qt0-f181.google.com with SMTP id g9so41591071qth.9 for <29575@debbugs.gnu.org>; Mon, 11 Dec 2017 11:47:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=5uiOzhasHLvqc0pe2HbYBEzH0zwV38ag1VXutVQdzqI=; b=OrbvFJGrdnqhDJnVUV/YO4pXyDrC8Z+z5l/RM6udT2jhA5sQUJE3aiyR1tThYATVyd dIprieN6bSc360suw15+iLcSwRQRDNr25eIf3udYA/g87dy3QTP1LycT4X/2V66Hb/HI JY4S7+Hl0l28KfFrafpGuts3gjV0aSdS/rcnNV5uciABK3k59N95kK6CNquBu1D0QXB7 OjsM2rfvIcTjDwsjSdZgLXcuAOS+S7dTCbMKay4bIHW2rlNYcXWRhKBvbRCrnPegDeAZ PdQUiB8cNWfNNmDQNbXp4FZCLWeiQliWFGyQhCqaqwCigr7FKPrZ8oqcp+0/P13dxecW Zw4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=5uiOzhasHLvqc0pe2HbYBEzH0zwV38ag1VXutVQdzqI=; b=MEVfumK/S5MCqfRrmS0Azrkl8RcB1E6hfC6orHhwr0qA8pqzdaNecgsmPfyoWz6MQK C2Y3mE5PI9D2rMG65yMuCAnlaPluZqvHIC7RxzeThZRko5z2cmssmWeXQUUgRDCtiRRx EezlGLMU3nhAWCqQJi62XOmnhrPTMrZn8tkJLbwMkJl0R2/sW71MJ9F/YckwKCpyWRUs 1whauhEUrYxZWZkXB84Rx25mmfzc9uuUZGOGtJtgwFk0bCzyf5QPzdalDjMUEJ10B8gE p+ZsJK92NEhMgOeygtwxf+1w2jGYLvjbV1aaxGkXEVHPFBp5x+sv+sQUssSrqsBIRBli QK5Q== X-Gm-Message-State: AKGB3mIo3gG0hW++RzdUB7kORrQO9udOVdmDXjZrF5eq+xSuOTVFTPVY DqRb8tk6Yxk23ljADLm435AwlyjO3TEtd44EWq4= X-Google-Smtp-Source: ACJfBouIhRWXr0+Hi37t6uZt06zXsfmDgxL7a5fizqKhJy44011QP/mXB3gWjTiDZAA+ZGob9HBYN/+0+he3xuY7VSE= X-Received: by 10.55.55.146 with SMTP id e140mr2060733qka.106.1513021633589; Mon, 11 Dec 2017 11:47:13 -0800 (PST) MIME-Version: 1.0 Received: by 10.237.55.36 with HTTP; Mon, 11 Dec 2017 11:47:13 -0800 (PST) In-Reply-To: <87374hct91.fsf@gmx.de> References: <87374hct91.fsf@gmx.de> From: Allen Li Date: Mon, 11 Dec 2017 11:47:13 -0800 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Mon, Dec 11, 2017 at 5:02 AM, Michael Albinus w= rote: > Allen Li writes: > > Hi Allen, > >> The Secret Service API [1] treats labels as unique keys for each >> secret item in a collection. However, labels are not required to be >> unique in a collection [2], the attribute key/value pairs are. >> >> It is perfectly valid to have multiple secrets with the same label, in >> which case Emacs's Secret Service API is not able to retrieve all but >> the most recently created (?) secret. >> >> This can be demonstrated by creating two such secrets using the >> secret-tool utility: >> >> secret-tool store --label=3DTest1 id foo >> secret-tool store --label=3DTest1 id bar >> >> You can see how the attributes uniquely identify secrets: >> >> secret-tool store --label=3DTest2 id foo # This overwrites the first se= cret. > > First of all: do you have a use case in mind for this? Whether we'll > extend the Secret Service API depends on the real need. Yes, I plan on implementing a personal password manager using the API. I am not planning on a design that requires duplicate labels, but I hesitated on starting my project because I predict implementing other tools that interact with the same underlying keyring service that use duplicate labels for implementation simplicity or other reasons. >> Implementation idea: Use attribute plists instead of label strings to >> uniquely identify secret items. > > Well, inside the org.freedesktop.Secret.{Service,Collection,Item} > interfaces, an item is identified by an object path. We could extend our > interface to allow both label and object path as item, and to throw away > the "unique label rule" inside collections. That sounds like a better starting idea. One problem that comes to mind is that the object path could be a valid label value, I think. I don=E2=80=99t think the specification places any guarantees on the object p= ath either, e.g. if another program modifies an Item, does that change the object path from under us? That would cause race bugs. > >> This would require creating a new copy of the API to preserve backward >> compatibility. > > The change proposed above would be backward compatible. > > Best regards, Michael. From unknown Mon Jun 23 07:53:06 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29575: 25.3; Secret Service API treats labels as unique Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 12 Dec 2017 08:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29575 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Allen Li Cc: 29575@debbugs.gnu.org Received: via spool by 29575-submit@debbugs.gnu.org id=B29575.151306776421824 (code B ref 29575); Tue, 12 Dec 2017 08:37:02 +0000 Received: (at 29575) by debbugs.gnu.org; 12 Dec 2017 08:36:04 +0000 Received: from localhost ([127.0.0.1]:57651 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eOg2m-0005fw-3C for submit@debbugs.gnu.org; Tue, 12 Dec 2017 03:36:04 -0500 Received: from mout.gmx.net ([212.227.17.20]:50241) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eOg2j-0005fS-O0 for 29575@debbugs.gnu.org; Tue, 12 Dec 2017 03:36:02 -0500 Received: from detlef.gmx.de ([178.20.94.179]) by mail.gmx.com (mrgmx101 [212.227.17.168]) with ESMTPSA (Nemesis) id 0LiY3U-1euRQD4BQq-00cgnS; Tue, 12 Dec 2017 09:35:54 +0100 From: Michael Albinus References: <87374hct91.fsf@gmx.de> Date: Tue, 12 Dec 2017 09:35:52 +0100 In-Reply-To: (Allen Li's message of "Mon, 11 Dec 2017 11:47:13 -0800") Message-ID: <87lgi87387.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K0:CJQ86cWMgavvvLT/NMqjWSbN9XFWm5CeBZ5h+PfOoVncDTt8SmC tVrwpi+4X4hR25GHSX1dKTkzJ/xCxTD1HrANdbBnSP6YrKTTsDQPevXUpdd3j56/mHN15Jn uGO69gJCbEhPVxTVsHNQF4kE6LqkvZ5y+J7jdMIYQ+YNenzXBUufXOzRd+lwTkltMzk3xJE NBEfMEsboL7/UZDJOeXUA== X-UI-Out-Filterresults: notjunk:1;V01:K0:HhyGNJgVzcs=:RwOqEPh72f9bnZI9leKfKA 4lLyY3E2qW1o8ZWIlusNDTymHFdI2BAbhYXJBwdbzonT31TgV2PtgMVgseXxhUP00Akth1Pml ZCWIDozZYtnLiQvAWSxfPqndTU8+UFYNASydyUU/9WIApK7IflZv+fe3ceaad7Xcma2umWNF5 8raapRiavCiYq7IM6O3UtT5M9VpGpuYgCpXahc9J0epZzpiKuKeKolCTY4CCtmgBr600cEVa/ lyKdEiGp+T3/PzBrIg53B/Jf/9gLTkgIgwSezvJt1K8AIfmqKDfTeF/mOjRLJ3EcZNefCeVq/ MLSjvakXd0f5pvyyuLtf8L2DGf1zoUka0Eu1TsoN2GcIHegUfQb5o/LEydztG28EURpNWg7pt FswSVq1eReovnUkv0WbdlSZWVIZcmsoPWyJiHGzR9Wnsx4+Vk2nAjVBYPBBnHwFlUkkclEIZr /EuUTvG1rWYiU2m7x4d87cfzzQ6yej3Khzbd7pjK5Fri5T9iA+M+7bOJYWdEQqbkQNn1GUFxM CMQV8WG7/xkq3yAYIhvs0VyxD1T/yCUk80i+MDvyXwvMp4n5yh2uXW1T2gXeXMKc75DiPPemL w4iGoBqGGqsx8mEQNsCsZdu48/a6kmJgJAgiu6D/zCpzERotGYeB8eU4ykcFhHyfjE0udFA4r PQcPIDmGsNKWDu1wmgySvUIJW4/5uOxF+wjYEXbvlohpJMUmGwswpe4DgOucTRFARLYPzdjVJ eSecU9VG1TrbGcaYyhznQYmCAqP0JX+boMQOBcfsU81HnhoTz/mjypnkULT9kblYBq4NrMPn2 CV0soFWu9HvCzZnTk6jGaTvWoeNMtgTpvNROZgbeTSRZ6nNVnQ= X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Allen Li writes: Hi Allen, > Yes, I plan on implementing a personal password manager using the API. Is it a standalone program, or an Emacs package? In the latter case I recommend to try auth-sources.el. It is the default "password manager" in Emacs. The Secret Service API is integrated as one backend, although there's room for improvement. >> Well, inside the org.freedesktop.Secret.{Service,Collection,Item} >> interfaces, an item is identified by an object path. We could extend our >> interface to allow both label and object path as item, and to throw away >> the "unique label rule" inside collections. > > That sounds like a better starting idea. One problem that comes to > mind is that the object path could be a valid label value, I think. That's possible, yes. But I doubt it will happen in reality. At least in Emacs we could check, that a label doesn't look like an object path, and suppress such items for being considered. > I don=E2=80=99t think the specification places any guarantees on the obje= ct > path either, e.g. if another program modifies an Item, does that > change the object path from under us? That would cause race bugs. secrets.el registers for several signals already, like "org.freedesktop.DBus.NameOwnerChanged", "org.freedesktop.Secret.Service.CollectionCreated" and "org.freedesktop.Secret.Service.CollectionDeleted". We could also register for the signals "org.freedesktop.Secret.Collection.ItemCreated", "org.freedesktop.Secret.Collection.ItemDeleted" and "org.freedesktop.Secret.Collection.ItemChanged" in order to be notified about such changes. I don't know whether I have sufficient time to work on secrets.el next weeks. Would you be interested in providing respective patches for secrets.= el? Best regards, Michael. From unknown Mon Jun 23 07:53:06 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29575: 25.3; Secret Service API treats labels as unique Resent-From: Allen Li Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 13 Dec 2017 03:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29575 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Michael Albinus Cc: 29575@debbugs.gnu.org Received: via spool by 29575-submit@debbugs.gnu.org id=B29575.151313651917860 (code B ref 29575); Wed, 13 Dec 2017 03:42:02 +0000 Received: (at 29575) by debbugs.gnu.org; 13 Dec 2017 03:41:59 +0000 Received: from localhost ([127.0.0.1]:59258 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eOxvj-0004e0-Ao for submit@debbugs.gnu.org; Tue, 12 Dec 2017 22:41:59 -0500 Received: from mail-qk0-f179.google.com ([209.85.220.179]:35884) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eOxvh-0004dj-6z for 29575@debbugs.gnu.org; Tue, 12 Dec 2017 22:41:57 -0500 Received: by mail-qk0-f179.google.com with SMTP id 8so404519qkj.3 for <29575@debbugs.gnu.org>; Tue, 12 Dec 2017 19:41:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=2c00lCFfZMILGqgcZI8iTr044I22ccO2E4QwH7fUV5A=; b=nuCT3B2CvDRlBFDFcZClT1bovJLRBFIsRo6W+NZepgyvzkWmv/qq/hqHRTbUWCV6OE VcA7Rs8owo5isl6lVKkvBMZLdHOK4daogXZxwlyPwmZhC3tq7cWnyMxYKEhBtXsd1376 +/CtlF673PV4hDduNAVim6bjGnaxxUsULdmVjVOOBzj2grU6jU/v5k8263Xevnl1fcuJ yOm4S0y7UN0Gp+lLtcSJ5ZYB2jlc7VHl4VS55ZBZlgjqNCx4oZJ76LUxDEGEcvdBd363 56ZVK+o3TsufRaJQczORyiFBDDHWzvT28vX/33G0Kqb6fEFAl16KvrvZZroN5pJIfcOJ VgWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=2c00lCFfZMILGqgcZI8iTr044I22ccO2E4QwH7fUV5A=; b=skucRdehQF/KSq519YsV6EdWWc/vGNHTf8fsQ9pnVW4KKS4r7iXmTFbNNUYv15bxWc chLg7N8y445N2a2WLhiD45MExUyouwtBybEtwEZNcWEzJWLw2QCUt0mKfkQwZg2KzdWl uO37XThWNrN2icjd65T3f3U+OpJwZMb7EjQsgYCZpJE6/gDmdnoVJpMFd/+o3d4snSDg w+GDhorn2WarHBGdlnWjRjo/WqhVoUyaqA8r/QTdVqfVEJGf0MaqA6//HJ/PbCz7m7Tx Bqghf6YFSv3lnNJdB336vSL7HAKyAtm3oCZz4v4l5NQ1uwbkGhZ8ZOONoaeHnwgG/pO8 tCvQ== X-Gm-Message-State: AKGB3mL3YldyiW8ANjmZdkkhz9wfQPSjTDT7Kr8wmCiJSw8pSVSMkeph RsHN+ycmmP0k3OBobdHqNyEp4Um5b2mb3tSeKdY= X-Google-Smtp-Source: ACJfBosSljMkNkLsqLr2LuIOIyLwfZfKvHTgrI9nbTU5ha3q7DtvJTET7P4GZfnHYl1v1QwVXEmj+z41nza4QXWvhXs= X-Received: by 10.55.112.6 with SMTP id l6mr8743377qkc.329.1513136511630; Tue, 12 Dec 2017 19:41:51 -0800 (PST) MIME-Version: 1.0 Received: by 10.237.55.36 with HTTP; Tue, 12 Dec 2017 19:41:50 -0800 (PST) In-Reply-To: <87lgi87387.fsf@gmx.de> References: <87374hct91.fsf@gmx.de> <87lgi87387.fsf@gmx.de> From: Allen Li Date: Tue, 12 Dec 2017 19:41:50 -0800 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) On Tue, Dec 12, 2017 at 12:35 AM, Michael Albinus wrote: > Allen Li writes: > > Hi Allen, > >> Yes, I plan on implementing a personal password manager using the API. > > Is it a standalone program, or an Emacs package? In the latter case I > recommend to try auth-sources.el. It is the default "password manager" > in Emacs. The Secret Service API is integrated as one backend, although > there's room for improvement. I envision a frontend to a password store, so not a password manager in the sense that Emacs Lisp code calls out to it to retrieve passwords. My understanding is that auth-source.el fulfills the latter role. I want more something to store secrets that I can recall interactively through various frontends, one of which would be through Emacs. >>> Well, inside the org.freedesktop.Secret.{Service,Collection,Item} >>> interfaces, an item is identified by an object path. We could extend ou= r >>> interface to allow both label and object path as item, and to throw awa= y >>> the "unique label rule" inside collections. >> >> That sounds like a better starting idea. One problem that comes to >> mind is that the object path could be a valid label value, I think. > > That's possible, yes. But I doubt it will happen in reality. At least in > Emacs we could check, that a label doesn't look like an object path, and > suppress such items for being considered. > >> I don=E2=80=99t think the specification places any guarantees on the obj= ect >> path either, e.g. if another program modifies an Item, does that >> change the object path from under us? That would cause race bugs. > > secrets.el registers for several signals already, like > "org.freedesktop.DBus.NameOwnerChanged", > "org.freedesktop.Secret.Service.CollectionCreated" and > "org.freedesktop.Secret.Service.CollectionDeleted". > > We could also register for the signals > "org.freedesktop.Secret.Collection.ItemCreated", > "org.freedesktop.Secret.Collection.ItemDeleted" and > "org.freedesktop.Secret.Collection.ItemChanged" in order to be notified > about such changes. > > I don't know whether I have sufficient time to work on secrets.el next > weeks. Would you be interested in providing respective patches for secret= s.el? Sorry, I can=E2=80=99t commit to that. > > Best regards, Michael. From unknown Mon Jun 23 07:53:06 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29575: 25.3; Secret Service API treats labels as unique Resent-From: Ted Zlatanov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 13 Dec 2017 14:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29575 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Allen Li Cc: Michael Albinus , 29575@debbugs.gnu.org Received: via spool by 29575-submit@debbugs.gnu.org id=B29575.151317608810328 (code B ref 29575); Wed, 13 Dec 2017 14:42:02 +0000 Received: (at 29575) by debbugs.gnu.org; 13 Dec 2017 14:41:28 +0000 Received: from localhost ([127.0.0.1]:59636 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eP8Dw-0002gW-Kb for submit@debbugs.gnu.org; Wed, 13 Dec 2017 09:41:28 -0500 Received: from mail-qk0-f171.google.com ([209.85.220.171]:42702) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eP8Dv-0002gK-8k for 29575@debbugs.gnu.org; Wed, 13 Dec 2017 09:41:27 -0500 Received: by mail-qk0-f171.google.com with SMTP id a71so2194974qkc.9 for <29575@debbugs.gnu.org>; Wed, 13 Dec 2017 06:41:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lifelogs.com; s=google; h=from:to:cc:subject:organization:references:mail-copies-to:date :in-reply-to:message-id:user-agent:mime-version; bh=GpkSjPgIFlfL3UQy51GJAlLmtsTremy1xYQRaCD/T5M=; b=sn/7uqZdTEGK+ISq5E7FP9iJoy9z6dZIVpxpZZyCd6yxvJfL3Iq52p2oruywpwZ3cH I+Y6tuWtF1vdQXZAbF4jcod/0rWjgqteBCM3AJMq5QRTf/qMr9mCHb+CtROi65NU14XO hIlHR3Nahtntyh5vg5+zkdB7RqxrJMDc0J2/g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:organization:references :mail-copies-to:date:in-reply-to:message-id:user-agent:mime-version; bh=GpkSjPgIFlfL3UQy51GJAlLmtsTremy1xYQRaCD/T5M=; b=BNKu1HEeeyxRbpdVjT9dd3RVi/lqUznN+/xJflHIPYf7lvhwXtYXJi3CQCYkovi6Nf wpZZEg+eElo1GOZ1h+BUdtm+SuhFSD5IUoCs1iLqeh3gn5ynvDoZpeNTUmtLz5gYoyN8 yh3/ahA56KBq8W2U8wCXtYIQSlJL7d1zPiq5dYV0ysp6T9k8bghnZUFu6RDK5yiwTNvF BiX2PDPr4tT0nFjH1KuMspWLW+E82ET7KIiDH0TsYPP9cLi5GLSahtyh7rC4Tx8RDfBH +wzZGH00/CNx39niOFAR8vtXN3yfGYsSW/Vk+AquzhnXopTBwqFCwdC1BSqR0kuR2PIQ gsOg== X-Gm-Message-State: AKGB3mIqAdAFR6vUxlGjuvl1qa3yPmBoUWWkIWCJUgC9/YbGFrZhgXuq odQ5zItDwC3ND7uBU9SmpzTCNJ5mkJ8= X-Google-Smtp-Source: ACJfBotaY/AqWzGKQfTOsXkOsCao5PnG6tnNHSPMYB8qqpNSM0oI7Jmyot43g1luEGPRsDvL5Wsw3A== X-Received: by 10.55.201.11 with SMTP id q11mr10600165qki.303.1513176081307; Wed, 13 Dec 2017 06:41:21 -0800 (PST) Received: from flea (c-76-28-41-155.hsd1.ma.comcast.net. [76.28.41.155]) by smtp.gmail.com with ESMTPSA id a19sm994311qtj.74.2017.12.13.06.41.19 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 13 Dec 2017 06:41:20 -0800 (PST) From: Ted Zlatanov Organization: =?UTF-8?Q?=D0=A2=D0=B5=D0=BE=D0=B4=D0=BE=D1=80_?= =?UTF-8?Q?=D0=97=D0=BB=D0=B0=D1=82=D0=B0=D0=BD=D0=BE=D0=B2?= @ Cienfuegos References: <87374hct91.fsf@gmx.de> <87lgi87387.fsf@gmx.de> X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never Date: Wed, 13 Dec 2017 09:41:18 -0500 In-Reply-To: (Allen Li's message of "Tue, 12 Dec 2017 19:41:50 -0800") Message-ID: <87tvwu4rn5.fsf@lifelogs.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On Tue, 12 Dec 2017 19:41:50 -0800 Allen Li wrote: AL> I envision a frontend to a password store, so not a password manager AL> in the sense that Emacs Lisp code calls out to it to retrieve AL> passwords. My understanding is that auth-source.el fulfills the AL> latter role. I want more something to store secrets that I can recall AL> interactively through various frontends, one of which would be through AL> Emacs. Consider the password-store (http://passwordstore.org/) utility, for which there's an auth-sources backend in lisp/auth-sources-pass.el Thanks Ted From unknown Mon Jun 23 07:53:06 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29575: 25.3; Secret Service API treats labels as unique Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 15 May 2018 12:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29575 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Allen Li Cc: 29575@debbugs.gnu.org Received: via spool by 29575-submit@debbugs.gnu.org id=B29575.15263889933593 (code B ref 29575); Tue, 15 May 2018 12:57:01 +0000 Received: (at 29575) by debbugs.gnu.org; 15 May 2018 12:56:33 +0000 Received: from localhost ([127.0.0.1]:35188 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fIZVJ-0000vs-IQ for submit@debbugs.gnu.org; Tue, 15 May 2018 08:56:33 -0400 Received: from mout.gmx.net ([212.227.17.22]:35569) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fIZVG-0000vc-3C for 29575@debbugs.gnu.org; Tue, 15 May 2018 08:56:31 -0400 Received: from detlef.gmx.de ([212.86.40.50]) by mail.gmx.com (mrgmx103 [212.227.17.168]) with ESMTPSA (Nemesis) id 0Mh9cj-1ewlM73k6z-00MOmf; Tue, 15 May 2018 14:56:23 +0200 From: Michael Albinus References: <87374hct91.fsf@gmx.de> <87lgi87387.fsf@gmx.de> Date: Tue, 15 May 2018 14:56:22 +0200 In-Reply-To: <87lgi87387.fsf@gmx.de> (Michael Albinus's message of "Tue, 12 Dec 2017 09:35:52 +0100") Message-ID: <87bmdh3wnd.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:8Kdq6M/pheiZBDKtkv3gazR34dsE6i9BtrvrIY/+hEAcYvFDQd+ +XMQR5d8zvRVO5KUu1WXJryQ62zloQxhl0ObiBKmEGBGJTZcQp/YfL4TQPQnR2nPI2duPgF yXfb8Ctk9x4SV5aOrQsRcg/EgRUV0AjXnADBSAO1gTbNHk3+TpeZTphdt1gqnQ3/WrW0rF7 D61TqTgjI0F3qDOc2z4RA== X-UI-Out-Filterresults: notjunk:1;V01:K0:ievq7nZRPoQ=:YuR4n6Fk1Bl4gbP6ia9Q4n Vr9I0kMCjGtjU+do4legYYUy2l0f/N8JWSp7Q2zktnTSFJyUEMgAN2YUg7ZwCgBgoXriWpN5J LYRILvnFtIw3vO+x0u8IZmhZcc0wpZPDskCfw3dCqsA8nDjldJeeI2wLRxHBz+aS+odXx7k23 hV/kRQZVRn/711FfhHNs2xBRZzl+bvKUEOcjr3Ho/VbWhcZIDcTyKwI5w9djxyUOfq31b19Xy FERPQrp7ajcyDzGlDAQcez6N7qmTQ+khEC7IZ2Kv3LABmT2yaF+eoZ7x2VGRkRZ2E9932Usmb mlMTtUFxJpR7J+XanRR2M52Ck07iZYvYOV0ATYsaLJWaJFtvoXhuTcRvWSBUUBakaovqa9s1p 1m2v5DQPnJwYWRPP9+mgubbRx8tZLJNSGLvKQwORodONgJdWdPg0IRKjri5lAuPhIBdBzJv2s FrHci55cVc4ajrWh0ZrhEp1PBaElPsFGfDOHmzVeFttY4OLpmYz0LrwAXvCUtRVghdfulg8ye gIKNkQp0fajER4zgDBtAKInCZOGzZmQJQsr5kNFAETTOWEWqNC/bqpA+qVK/q5KJ/IHAY4mQq 3lASIa7+XdDDWK/YeK5JwtXNBrvbEX7kfAhiWn32vL6FisEr708RQJtFv0/g3S/Xk36NXGTmZ ChZiMqrR6HraNEv7GXocZPaRO0+lXA3eFRSL9al0Azz2spn2JOF8ZbtWVbj4itkqRSg1GoYyb /3u2G0gF7HkmTrGhMsP7NAZ7UfC4QERThcXkFfylR01k4daj0WoFcTHHDRU+fAREl5bq2FTcq 4f8Bbrj X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Michael Albinus writes: Hi Allen, >>> Well, inside the org.freedesktop.Secret.{Service,Collection,Item} >>> interfaces, an item is identified by an object path. We could extend our >>> interface to allow both label and object path as item, and to throw away >>> the "unique label rule" inside collections. >> >> That sounds like a better starting idea. One problem that comes to >> mind is that the object path could be a valid label value, I think. > > That's possible, yes. But I doubt it will happen in reality. At least in > Emacs we could check, that a label doesn't look like an object path, and > suppress such items for being considered. Finally, I found the time to implement this. `secrets-create-item' does allow labels now which exist already in a collection. `secrets-item-path', `secrets-get-secret', `secrets-get-attributes', 'secrets-get-attribute' and `secrets-delete-item' allow also object paths as argument. Pushed to the master branch. Could you pls check whether this fits your needs? Best regards, Michael. From unknown Mon Jun 23 07:53:06 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29575: 25.3; Secret Service API treats labels as unique Resent-From: Allen Li Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 21 May 2018 07:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29575 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Michael Albinus Cc: Allen Li , 29575@debbugs.gnu.org Received: via spool by 29575-submit@debbugs.gnu.org id=B29575.152688910916994 (code B ref 29575); Mon, 21 May 2018 07:52:01 +0000 Received: (at 29575) by debbugs.gnu.org; 21 May 2018 07:51:49 +0000 Received: from localhost ([127.0.0.1]:42431 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fKfbg-0004Q1-0F for submit@debbugs.gnu.org; Mon, 21 May 2018 03:51:48 -0400 Received: from mail-it0-f46.google.com ([209.85.214.46]:38311) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fKfbe-0004Po-3S for 29575@debbugs.gnu.org; Mon, 21 May 2018 03:51:46 -0400 Received: by mail-it0-f46.google.com with SMTP id q4-v6so20109095ite.3 for <29575@debbugs.gnu.org>; Mon, 21 May 2018 00:51:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=felesatra-moe.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gmQEUfy8pQJekL+EiNUH7wlKPSrapriuAQkYH2KHpF4=; b=K3+TgDoJd4NcwIQFehgDYu6aH/LlJmAoGMWxSlld9osYEzqH7zIBar58ReSqbN+3n/ rEjOA089jTPIJqgB774p6vGMPCFbZaj3Or2F9XI9y/pAOT06rxwGeG97ziQMfcTpl2wQ eli7AZ4WMGIT8zBWMilafM7wtSJ0+8HOj/LqoWzRTL5aHNoYvWrsbt4WpIA10GsWbMkF KQqzy11FqLKGwQQ4I+nxkQmdgtdSdh84J7f480AMBuMbmtIN5dHA/azjtHtitenljgA0 pdoIC6RfGtNtbVpeHLSCZ1BjwI+JLkBuEVtJ9qLaRleQkI979lZotzKoGcpe9NmxWNPF cK1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gmQEUfy8pQJekL+EiNUH7wlKPSrapriuAQkYH2KHpF4=; b=dmbkZy0MmUlOLbSon6f27DFEz2Upt5+BIP1rFemlmLt+F9C3PJik6UamFoTyn5OrPT xtyWbyxouGtnkiCLfL3GgEONr48iZjVyeKP8SOmLC8rH606ob9vLk1axurATm7HwmEYe K4F+2/u7wH7cBvCz+ke3zAvwt43I5mu51nX7EeuTuENe/l0bPXYJASc6bR8kboR7bOpw 4kwyFjgzx9aABrPoVk3UIZsQhVg+/FK5V+YqeearEhZUFxirIZlLX/5uMwB5msi6o93/ Qoe3YoM1Vpz4LFKhTfFeZV000pdo1nWm42ECY3kNeRBELObW55Zb0gzBsCto1V5hM5tU gwOw== X-Gm-Message-State: ALKqPwfyb3dGRiIFPOEcAHyjjd0+ViSYuAZ8T3LtmSNIjCS8Mc8xeBHn /uu9w6JGB8CypU8g2+YA1xbtE0h9lMHr9jR1jJuz+A== X-Google-Smtp-Source: AB8JxZq7Wbs7WQpcdZoDAOMJlIE+gtNhqIY6NNMff+cCZgZbv98xLTfn+KyBc+5+p/cKSvDBcpY+sBQtzsxyfxmr2/k= X-Received: by 2002:a24:548e:: with SMTP id t136-v6mr15552216ita.98.1526889100306; Mon, 21 May 2018 00:51:40 -0700 (PDT) MIME-Version: 1.0 References: <87374hct91.fsf@gmx.de> <87lgi87387.fsf@gmx.de> <87bmdh3wnd.fsf@gmx.de> In-Reply-To: <87bmdh3wnd.fsf@gmx.de> From: Allen Li Date: Mon, 21 May 2018 00:51:29 -0700 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Thanks. It doesn't look like there is a way to get the object path by searching attributes? That means there's no way to get the object path for a secret added from a cooperating application (that may not have a unique label). secrets-search-items returns labels. Ideally there would be a variant of secrets-search-items that returned object paths. Also, the docstring for secrets-create-items now has this line which I think is misleading: The label ITEM must not be unique in COLLECTION. Should it be: The label ITEM does not have to be unique in COLLECTION. On Tue, May 15, 2018 at 5:56 AM Michael Albinus wrote: > Michael Albinus writes: > Hi Allen, > >>> Well, inside the org.freedesktop.Secret.{Service,Collection,Item} > >>> interfaces, an item is identified by an object path. We could extend our > >>> interface to allow both label and object path as item, and to throw away > >>> the "unique label rule" inside collections. > >> > >> That sounds like a better starting idea. One problem that comes to > >> mind is that the object path could be a valid label value, I think. > > > > That's possible, yes. But I doubt it will happen in reality. At least in > > Emacs we could check, that a label doesn't look like an object path, and > > suppress such items for being considered. > Finally, I found the time to implement this. `secrets-create-item' does > allow labels now which exist already in a collection. `secrets-item-path', > `secrets-get-secret', `secrets-get-attributes', 'secrets-get-attribute' > and `secrets-delete-item' allow also object paths as argument. > Pushed to the master branch. Could you pls check whether this fits your needs? > Best regards, Michael. From unknown Mon Jun 23 07:53:06 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29575: 25.3; Secret Service API treats labels as unique Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 May 2018 09:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29575 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Allen Li Cc: Allen Li , 29575@debbugs.gnu.org Received: via spool by 29575-submit@debbugs.gnu.org id=B29575.152698176612784 (code B ref 29575); Tue, 22 May 2018 09:37:01 +0000 Received: (at 29575) by debbugs.gnu.org; 22 May 2018 09:36:06 +0000 Received: from localhost ([127.0.0.1]:43617 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fL3i9-0003K8-Px for submit@debbugs.gnu.org; Tue, 22 May 2018 05:36:05 -0400 Received: from mout.gmx.net ([212.227.15.15]:55747) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fL3i7-0003Jb-Ve for 29575@debbugs.gnu.org; Tue, 22 May 2018 05:36:04 -0400 Received: from detlef.gmx.de ([217.70.140.87]) by mail.gmx.com (mrgmx002 [212.227.17.190]) with ESMTPSA (Nemesis) id 0Mfn88-1fi6Ke0A0i-00ND8M; Tue, 22 May 2018 11:35:56 +0200 From: Michael Albinus References: <87374hct91.fsf@gmx.de> <87lgi87387.fsf@gmx.de> <87bmdh3wnd.fsf@gmx.de> Date: Tue, 22 May 2018 11:35:54 +0200 In-Reply-To: (Allen Li's message of "Mon, 21 May 2018 00:51:29 -0700") Message-ID: <8736ykdocl.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:icz4J4eSFFYebrqC5lEBqf9LicKyujZGsQdV9qZnTS7mY8M+IrN Hyq4EdjYpDPpNXbtNJ5aEMOWpZ7aKUVdfIKHZn/8jxM0gq1mUlZ8m3NuKLFeCWslfXyoBo8 g36yc4REEScR7myCGtnzbPIRuPMh1k/E65Nm/LcHlNyUB1gb0FU78zIYZvWgNDJDtlN4qy8 x06BdcNMJPhy9Nca/NQNg== X-UI-Out-Filterresults: notjunk:1;V01:K0:Q5bBSVTsZZE=:ueZ6+pq2PxW24+v+Nsiwvn YMZp8T9MYKiaV/P3vaXB7Gr64AkZERFvP8XBmfIMi8OOEQIR5vgyJIjFskbdYr0OMvhfFQ+AK rWliYBB8BVcqAZzSFCmU/yE6cN3MHJneUnQLl4+e0oiUEbxuDQ2fdDbxosG0yGRywIzALcTzI UVaeKVuHchWFI42kIIwDLMgBfmtdeC2+4XsaoMQcq5eKxXHSxvsnZaMnhENKfiCOEiutZdyNn Bss65HzjA1ysoLKtlGff34vMNjH4WqpSAtC0fnk94wO55sNnLCr5Qpb3llrxXM0iHJh59hXz9 itbhSytg0DfC9CwWzjCjHbF/LmK1Odt+fQlIcBaeAwk0qvXtFdA0MxdZfXJo+5JyZqinwmAG8 yS/Nxba5G2L0zRUCIMoz8hnMJojPgO9WClQ+GT5VlX5gE9EQGL1gfECO9dDJMrem0hv3wuwN4 EVFiEVcka1dZxPks0LUj6MST1UD4/Cw14vM7I1NqeV+6ONbsLkxiB5uVU7cPYg4f2azClr02V f2c6AM6Zea2jYJepRO2VO3F3IWzYsGcBmISZw8OhblhO/+z2K48UuWEEGnr6Yy6wfGIbvfyG/ ywjTQG5hl8ItZ0394Ve4HwiCigObecpW8bonqDya8OLDoXPbqJxN8ZIpf2OFJovd+3RghPGA6 4Qccw73+IZ+N9Pj5YNwFnBKdPE+eIc5R8QTQrqiETbag7RGu5jcXq/e9UUFKZX/XJQI1IwSh+ Zt4G7HxWnGyhAhWs8GPYzcncQjYqs8zsio01F/sJ/K8Fpl1PTpclx0PpIx1OxS1cGu6Z8nesq Am1b0gM X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Allen Li writes: Hi Allen, > Thanks. It doesn't look like there is a way to get the object path by > searching attributes? That means there's no way to get the object path for > a secret added from a cooperating application (that may not have a unique > label). secrets-search-items returns labels. Ideally there would be a > variant of secrets-search-items that returned object paths. Indeed. I've added the function `secrets-search-item-paths'. > Also, the docstring for secrets-create-items now has this line which I > think is misleading: > > The label ITEM must not be unique in COLLECTION. > > Should it be: > > The label ITEM does not have to be unique in COLLECTION. Yes, sounds better. I've adapted the docstring. All changes are pushed to master. Thanks for your feedback! Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 21 07:57:06 2018 Received: (at control) by debbugs.gnu.org; 21 Jun 2018 11:57:06 +0000 Received: from localhost ([127.0.0.1]:58332 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fVyD4-0006X7-2X for submit@debbugs.gnu.org; Thu, 21 Jun 2018 07:57:06 -0400 Received: from mout.gmx.net ([212.227.15.18]:56927) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fVyD2-0006W7-Co for control@debbugs.gnu.org; Thu, 21 Jun 2018 07:57:04 -0400 Received: from detlef.gmx.de ([212.86.58.122]) by mail.gmx.com (mrgmx003 [212.227.17.190]) with ESMTPSA (Nemesis) id 0Mb7pT-1fkcXh1JCV-00Kdgz for ; Thu, 21 Jun 2018 13:56:58 +0200 Date: Thu, 21 Jun 2018 13:56:57 +0200 Message-Id: <87r2l0z71y.fsf@gmx.de> To: control@debbugs.gnu.org From: Michael Albinus Subject: control message for bug #29575 X-Provags-ID: V03:K1:tr+Xh3jshEZE1kjV+AlHDwio144uY6J7zD6G2paW31W6f7/EB0c bqTYFdVqRdQuT1G1HCtTlH++uJ9V9jc9wh56B40qq5QY1S2gVoFHQ8aWprYBMbpsmOOuE0G vzrQvYjjtnWa95/QZyjBoEDHL7fpOZXi9z780BVvUuBL30O6RwipnvYMnGgKC2GJaqEVGUi 5SQ1B35Ulu2SdHinle7ng== X-UI-Out-Filterresults: notjunk:1;V01:K0:0Saryu4F9UY=:Rh7CIXv9BDgyuqCeIr7eGM s9PQxgeqFk/Sh1bCle88hkor9fc79PgCDCPA2meoNi41WkPiW/xZctod8/GCEDpLMUP8xI7Q8 3BwlNQgkW0Ac+S5TDRSduC9TLNqngNdfG0ps7bzw2VBgArMzdnamQu/jfIHu8msNiz7l92zAT QfHIeIigJ7s0556YSCisTlzInt2t0HpF7pxQepT1EeoRnY6769e+CGnAcUb0+CBIR9SzAzM+C euIkXDhG/e+lIW6zRwpUkS/5vo53ysK1XXw7fPP5ROQ5y1Kx3FM/Rh44yidjPMv+wdVniPnKL 9zCG9VwksYrw21+9Ltzl7gjLFOYv1y+j9l0BE8dFejVGlgvwZ979StPpfN8VPV6mXUpqJgeu/ 4rPkOkJLN5qoOAnZ9xTTMqN5ZJYw6VbeSRGUa5dsKK8od8GWDn5a3nnIw/kqvIf8eOIURtcJn TdkoAGz6NoHgsmi1HvGNIFvyIAEyazajhYDa59M8xJOl1xu1ylO3wVhNyTsnG3ro8ci8qHJnN 1sEBsSJN4xiD9Q95UqyebajhzPWv5w7tip6HcmSeWEQGK0MbrYGje98gvrcLuVh16rZ2pjQyT ltQMGz5yK/blj0JRhc2RtYYlIQoGR9+B3fPeSYBtTsMwIN8hieeOr002U5KwwUZfBEndqLlnM yySpzoZEQE8iC1ApftJ2D/S1AQV8QjKHEBRbL8fLMnXP//1DUFPiGb7bjXy0X+b3Y7HpYC+Nq QGcWJX5Mt3N20lBDa6PugZrMr70eH7E9sAd90Vxgx3xPhXsehYMxz6vq4X8= X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 29575 fixed From unknown Mon Jun 23 07:53:06 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29575: 25.3; Secret Service API treats labels as unique Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 Sep 2018 09:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29575 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed To: Allen Li Cc: Allen Li , 29575@debbugs.gnu.org Received: via spool by 29575-submit@debbugs.gnu.org id=B29575.15361380236573 (code B ref 29575); Wed, 05 Sep 2018 09:01:02 +0000 Received: (at 29575) by debbugs.gnu.org; 5 Sep 2018 09:00:23 +0000 Received: from localhost ([127.0.0.1]:46361 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fxTfj-0001hx-Hp for submit@debbugs.gnu.org; Wed, 05 Sep 2018 05:00:23 -0400 Received: from mout.gmx.net ([212.227.15.18]:54741) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fxTfh-0001hj-Nv for 29575@debbugs.gnu.org; Wed, 05 Sep 2018 05:00:22 -0400 Received: from detlef.gmx.de ([213.220.156.160]) by mail.gmx.com (mrgmx002 [212.227.17.190]) with ESMTPSA (Nemesis) id 0Ldq55-1fW9HD2WsV-00j0Oj; Wed, 05 Sep 2018 11:00:12 +0200 From: Michael Albinus References: <87374hct91.fsf@gmx.de> <87lgi87387.fsf@gmx.de> <87bmdh3wnd.fsf@gmx.de> <8736ykdocl.fsf@gmx.de> Date: Wed, 05 Sep 2018 11:00:10 +0200 In-Reply-To: <8736ykdocl.fsf@gmx.de> (Michael Albinus's message of "Tue, 22 May 2018 11:35:54 +0200") Message-ID: <87in3kgvz9.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:3ixaJFLVaAWo1aOjHEmMjpZWO/ZgNhQD3URWuhB2jIxjvXU9nNm WMJp1PNf/v9R+hGaewB2HaZ730PLJpW+w7CHEosjW6p+sp7VHUhUheDUWDYXhYjG42AnvFL E8I7PkoNWX33Kz5jJtFgQiEKSQVdAHtYUs+uxilbC6VOJyqaQJABiaRrkE+2v9at+kX7A6J /DAkENNu5CV6ngqm1GO+A== X-UI-Out-Filterresults: notjunk:1;V01:K0:u/fcVAjDrAQ=:O6IZ7kJPhcMSoXR1mt2WLV niiDDZV18ldmowvWi2ndoZnQzyKFHrXvjUDV+kQoMc7i9td8mUnY1lGTOUznpVOEIcyN2jBoB Ebs50uZXIuI5gyulVD8Q3AIJOmqSDCV0SUyy4MLXryLozXHD7dMBbQyu99ddhyVViJaHmELuf bHItW51fQxR3TrXnFoX37t5Al0nEbGYlmFljfAPv1l8kRZ5kY0RcYEPdjmIG7d148DohcTSXb AckHWIIIqJ6KAud5NlQ2A1qTAEXfIe3zX2gxY3ivoM07K4eJePylQ+HDoCXKIIgp57cm0l/+u ODYL4Wk7uaUKSWmN1eHvQks56aUG2cZ7Vmdz78smLRyZd72Nmdv+ZXG5CQewnaOCmBE28dBxR HjE0aHVhJ3x/7vRSqbKmMcQy5zHBsnJIPexoKwJaV52ECu77rtCn0Y3+1LItjaQZ7Gf6giFU/ u6QkttQejv7LQOmvMhMTVTKDngMtr/r1+D0RNYmG0tHbUrFDVS2fhJJB0yhXdfKUOc5cJ7Our csp3D66orC+3SqrSwMqCbOWjw1nVm1dZfJiz3tXM8GofedZXO2N+JLR83XF5kQtZKoTJPZZIe 43srosBWMymLtoqqEoVVqEEk9fudwoOR/GSCumnVhrvhd8IRihlhy9Et7JlAPyw0ukqr3Rs6K SChXWf2OejW6stDgdPC0SGMVsVAoISUlssCGJikP+MQXUlVbg4S+L0EXeQ/x7qswfxcngIJDZ z3pMCPmO9LO7mTlbGGw708Q4ttmy+ZOw7pf7ICD02zJy5WVBec4qM3qSKUnTv8eGqrPxVBSAd ZaDksxP X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Michael Albinus writes: Hi Allen, >> Thanks. It doesn't look like there is a way to get the object path by >> searching attributes? That means there's no way to get the object path for >> a secret added from a cooperating application (that may not have a unique >> label). secrets-search-items returns labels. Ideally there would be a >> variant of secrets-search-items that returned object paths. > > Indeed. I've added the function `secrets-search-item-paths'. > >> Also, the docstring for secrets-create-items now has this line which I >> think is misleading: >> >> The label ITEM must not be unique in COLLECTION. >> >> Should it be: >> >> The label ITEM does not have to be unique in COLLECTION. > > Yes, sounds better. I've adapted the docstring. > > All changes are pushed to master. Thanks for your feedback! Does it work for you? I'd like to close bugs which are fixed for a long time; this is one of them. Best regards, Michael. From unknown Mon Jun 23 07:53:06 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29575: 25.3; Secret Service API treats labels as unique Resent-From: Allen Li Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 08 Sep 2018 23:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29575 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed To: Michael Albinus Cc: Allen Li , 29575@debbugs.gnu.org Received: via spool by 29575-submit@debbugs.gnu.org id=B29575.153645111821166 (code B ref 29575); Sat, 08 Sep 2018 23:59:02 +0000 Received: (at 29575) by debbugs.gnu.org; 8 Sep 2018 23:58:38 +0000 Received: from localhost ([127.0.0.1]:50688 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fyn7e-0005VK-AS for submit@debbugs.gnu.org; Sat, 08 Sep 2018 19:58:38 -0400 Received: from mail-io1-f54.google.com ([209.85.166.54]:33734) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fyn7d-0005V9-Ev for 29575@debbugs.gnu.org; Sat, 08 Sep 2018 19:58:37 -0400 Received: by mail-io1-f54.google.com with SMTP id r196-v6so4270593iod.0 for <29575@debbugs.gnu.org>; Sat, 08 Sep 2018 16:58:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=felesatra-moe.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NTPBza8VmHx3afsy8YRzi8s22xOHrJZBLZuMX0DdwLU=; b=Nn//MinlHwhQb5Vl3kiLAy4SL4DbhBQ7j65zQVHJiVkEEar6OICw7pHf1OMlsfd3oA FyUfq2zdHSMGWMzXOBhLH9M3NWGYjjkFtcg6iqvKj68L6REeYtb4Zu6GuYA9pZ1oxydY +kJoenyfu6G9uAHe6CfAUTTSkQLXG9KJI/a6YcOeDvWEH3JUSP47+CyHUlk5UxlGpM3V yZV5bEu3hB7rJ2xyroxJGSxVsww4G5hqZIRBacRKJLUrRFwlQ4JG2FwU81ybE7hHIVCD /qivMG9dyuZLuWMNRGk7sMeohT3bnOCUZH5U1+csyNZ5LYhu8i41qQiYk+8C+hSgI5G+ xfyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NTPBza8VmHx3afsy8YRzi8s22xOHrJZBLZuMX0DdwLU=; b=unisIXGrjAsY61XNjvo/XB0RONnDxkaHL/Zfux+JBazXsebuqn3JvJ1aglshPucXCT PAuVsV4S3EzMmPypwtXNp7kGGWLwrsFUKbzRI64zL8D4RODT/LnvFxGoTNnAZgl72KMH 1djh7FMoOUpcscA+k5KwzOorMYLIGe7SvTg7Nq7Gl4HkOHDqyCyThfSHCnOOFQuVs/Vz ZGpT2C7uF8fBWgjdgFWICfIClpQgfY0hZ57RWLVp9XXdNXC0JaWG6NKQ2/M8dYLJQjlY xhlev03jpGrsxVZ1VeB6ciFVJr3IeCBuplF32Ep72Rh684nntgDaj0ZhPTyUilkOaMIF dB1w== X-Gm-Message-State: APzg51D7Zoc3/uN6HX1coOgrHGeR7aWZMwIoSDfmp43/rOu7zIh2NWGq 8JACdMtnHrYsDDTo/KPmIABwJns0qD/Dt33XM4741w== X-Google-Smtp-Source: ANB0VdY8ryd3+fwuedG5BkVaFyShYvi4tmUSGQ2t9XA57GWxElYrcxp/2pjN4GR8P47gH4FBw4KftzyQlJp5rWAQP+Y= X-Received: by 2002:a5e:d612:: with SMTP id w18-v6mr11649260iom.54.1536451111845; Sat, 08 Sep 2018 16:58:31 -0700 (PDT) MIME-Version: 1.0 References: <87374hct91.fsf@gmx.de> <87lgi87387.fsf@gmx.de> <87bmdh3wnd.fsf@gmx.de> <8736ykdocl.fsf@gmx.de> <87in3kgvz9.fsf@gmx.de> In-Reply-To: <87in3kgvz9.fsf@gmx.de> From: Allen Li Date: Sat, 8 Sep 2018 16:58:20 -0700 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Yes, it works. I think this needs to be documented in the auth-source manual, but otherwise all the functionality seems to be there and working, thanks. On Wed, Sep 5, 2018 at 2:00 AM Michael Albinus wrote: > > Michael Albinus writes: > > Hi Allen, > > >> Thanks. It doesn't look like there is a way to get the object path by > >> searching attributes? That means there's no way to get the object path for > >> a secret added from a cooperating application (that may not have a unique > >> label). secrets-search-items returns labels. Ideally there would be a > >> variant of secrets-search-items that returned object paths. > > > > Indeed. I've added the function `secrets-search-item-paths'. > > > >> Also, the docstring for secrets-create-items now has this line which I > >> think is misleading: > >> > >> The label ITEM must not be unique in COLLECTION. > >> > >> Should it be: > >> > >> The label ITEM does not have to be unique in COLLECTION. > > > > Yes, sounds better. I've adapted the docstring. > > > > All changes are pushed to master. Thanks for your feedback! > > Does it work for you? I'd like to close bugs which are fixed for a long > time; this is one of them. > > Best regards, Michael. From unknown Mon Jun 23 07:53:06 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Allen Li Subject: bug#29575: closed (Re: bug#29575: 25.3; Secret Service API treats labels as unique) Message-ID: References: <87h8iwjrdg.fsf@gmx.de> X-Gnu-PR-Message: they-closed 29575 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: fixed Reply-To: 29575@debbugs.gnu.org Date: Tue, 11 Sep 2018 09:50:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1536659402-32460-1" This is a multi-part message in MIME format... ------------=_1536659402-32460-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #29575: 25.3; Secret Service API treats labels as unique which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 29575@debbugs.gnu.org. --=20 29575: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D29575 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1536659402-32460-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 29575-done) by debbugs.gnu.org; 11 Sep 2018 09:49:43 +0000 Received: from localhost ([127.0.0.1]:36167 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fzfIl-0008Qr-4c for submit@debbugs.gnu.org; Tue, 11 Sep 2018 05:49:43 -0400 Received: from mout.gmx.net ([212.227.15.15]:44543) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fzfIj-0008Qd-Aj for 29575-done@debbugs.gnu.org; Tue, 11 Sep 2018 05:49:41 -0400 Received: from detlef.gmx.de ([212.91.242.176]) by mail.gmx.com (mrgmx002 [212.227.17.190]) with ESMTPSA (Nemesis) id 0MdrK9-1gDlGy09Tp-00PfdV; Tue, 11 Sep 2018 11:49:33 +0200 From: Michael Albinus To: Allen Li Subject: Re: bug#29575: 25.3; Secret Service API treats labels as unique References: <87374hct91.fsf@gmx.de> <87lgi87387.fsf@gmx.de> <87bmdh3wnd.fsf@gmx.de> <8736ykdocl.fsf@gmx.de> <87in3kgvz9.fsf@gmx.de> Date: Tue, 11 Sep 2018 11:49:31 +0200 In-Reply-To: (Allen Li's message of "Sat, 8 Sep 2018 16:58:20 -0700") Message-ID: <87h8iwjrdg.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:JJ5ja+j98rRPAY8Zu+g09V5QGJ4QpAs4GVB+kvgBC/kgpvmNt3Z WkuCEv3oTxMj8SXSulO0HDmE+B/GTNs+e3GLJ+pooHHSnTOidNrLpvWma91T/eVxHAWl5wJ BeGKRGzoAg+wVu/KLF7KCxDWGr+YBMbrxZDSELV22erG8OVE9OpXvHsQPHFSJZPG/hyblpK NFShJbtfCh165zo1ZzlBg== X-UI-Out-Filterresults: notjunk:1;V01:K0:SaobFzZafGU=:m8fgYBT0U9RwGDIvWvsFik hJU9g1TWcI+ol9f7xY2Er7yhDArwkf4Bl1q2p6IMJ/sntpXR90PPuJt5FF2HAnLlT0Wz8uCid G10Gp9G4v80XUk85ChI2NY0aAglBm6c9ZvoqySgvVpVaXfqEVTEi9S4FSXY7tXArQvttMIDEB Mv+4iZJBdvQlQ4dtaWoLMPid3eL4YJqEV/4/wMMso/ilKJeCvPml4IzrwxOxuOdxpwWboSdnY 64uUZJnoEouH8sR8uBpoDxkettPLq0wIz12+a6pC9UAowu9bq6+VsOH0Q4jN1auErrJ/2l95A Bt+ms8YNxmaYrD0Z6zCpuVEbScaxZtZsZpn6nj24aODe3Vyj9fo+QRdntLLu4ShCg8eaPddUU JEhBe6AnzGVL6rAW9nXdDeKeCuuVOaR9JJwU6YTSSNP2z93okZW/OvPvubn41z4+0VeAZJ4Yj nS7EWB+cArRv8SQpioQ4VNVRdGI30tkEIJ/8XfARDiH/PkeLWR9FVYCAX15QOZ0L6Z8xCy0QG +GCAd/7WVpv9R7xCE9y2EhbEf8g4bpvbN+DCCQBvfnfYD854pQ9kMLRpFlmfOJPPXtgiAHMMP WYnGi5DwzsG865FbHxX9zRzmUZnxV4Mm6EYG4nRPY8JtJdh9BsU2UPtVCRoweBc5e02L8mBiA ZU8zV6WaUYFBkpMeNbhBabdKweOlQdfU3aFSGXPb+3vdsaLnVH26lmctzJiqF6ckqolufX3mN KrPWB4UxOFEcDji0T7skdK0fDDiT7eydYqkRbnbzWX7EnBEHfteMo3WKg+zzUJiE3PzIYqDhc 4TnZbfL X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 29575-done Cc: Allen Li , 29575-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Version: 27.1 Allen Li writes: Hi Allen, > Yes, it works. I think this needs to be documented in the auth-source > manual, but otherwise all the functionality seems to be there and > working, thanks. Thanks for checking. I've updated the auth.texi manual, closing the bug. Best regards, Michael. ------------=_1536659402-32460-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 5 Dec 2017 05:42:39 +0000 Received: from localhost ([127.0.0.1]:46267 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eM606-0007nI-PP for submit@debbugs.gnu.org; Tue, 05 Dec 2017 00:42:39 -0500 Received: from eggs.gnu.org ([208.118.235.92]:39719) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eM605-0007n4-1x for submit@debbugs.gnu.org; Tue, 05 Dec 2017 00:42:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eM5zy-0004qX-Pi for submit@debbugs.gnu.org; Tue, 05 Dec 2017 00:42:31 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:40609) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eM5zy-0004qT-Ls for submit@debbugs.gnu.org; Tue, 05 Dec 2017 00:42:30 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58923) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eM5zx-0007Ls-EK for bug-gnu-emacs@gnu.org; Tue, 05 Dec 2017 00:42:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eM5zw-0004os-IR for bug-gnu-emacs@gnu.org; Tue, 05 Dec 2017 00:42:29 -0500 Received: from mail-qt0-x22c.google.com ([2607:f8b0:400d:c0d::22c]:41474) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eM5zw-0004oi-Ck for bug-gnu-emacs@gnu.org; Tue, 05 Dec 2017 00:42:28 -0500 Received: by mail-qt0-x22c.google.com with SMTP id i40so26581194qti.8 for ; Mon, 04 Dec 2017 21:42:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=rmqDLKrtrr2Sy1M2TlEAV8cAB1751+eqGSUNHPYgWJI=; b=Ql4VMVHd26vcaPe8qxTvHCpLvVqhlhyUC7va9wulG4vyDPLt6Jk0145H8zdsCHAcdv oxmKkiqBLDO3qJR9Vfj0otw8T75LhCd8KcQ5PrUWu0wFJkrAxzfLWA7RGBnm34XoRndT nWRClgfbKx0VQknQtAAy8jD2cg1zC9zsGboIXYICeZKE01jdaiX/4IJIyRFluJP0mRD6 y6k0Ov7nX7h5nNsM50V6XJklu3kzOdHv0EdgwRqhTwTrmQW4OAJ0EZiPsqTAJ9IXHmL2 /stOXAO8Xj9XuKVKS97RpyrQrsWOc3PL760rjkiuxT/AioE0bn88ATan3orUuZAjVQ24 Hbpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=rmqDLKrtrr2Sy1M2TlEAV8cAB1751+eqGSUNHPYgWJI=; b=KNyeQnujXjOzoSeS95P4Jwl+u6ABZIOlaNNpBJFjXChVI14tfDROBDAY4sAoef4IdU s8GGZRTb91jIhWT/Yz6ED2HQgcsZs9tVzxvjheZ1q8Y90zyl5MdTuAGxXStiLo1csmx+ 5kd8E94/HapciaJiCxb3iRp/Xm5ZEh04S0syc9jR9wVYcNKMI0x37vsnHGabEb4SGAzn m5z2ms2soLsOudwe40pqmCsve6seiFzoeeT4QjyHRoWOoEMiUWK1oHihgkv4nYMnt+qN veuqME6mKkHg2kdJ3xeLJgkY6gPhmI2mFxJeCm5ue52QP7kng47GvLkxo2ELIEzSBy26 BFlg== X-Gm-Message-State: AKGB3mKOlCkd+vr0osJY7zyqP01hgbaTx7kpDPCs3DPobNHhVgFIuRXF VU81yr9mZwri+YJySbKIqrqSHiiAjGC0HsYBn4ehn2Db X-Google-Smtp-Source: AGs4zMZAkPACYnzW97As5qrjm1kyA6HRN2F89nUdlXUcw1jWGJ7GXx+hNKVV+ssDmEdnp1iHGIbf9o1Fi+d3A5+DhEA= X-Received: by 10.55.18.134 with SMTP id 6mr22183642qks.136.1512452547269; Mon, 04 Dec 2017 21:42:27 -0800 (PST) MIME-Version: 1.0 Received: by 10.237.55.36 with HTTP; Mon, 4 Dec 2017 21:42:26 -0800 (PST) From: Allen Li Date: Mon, 4 Dec 2017 21:42:26 -0800 Message-ID: Subject: 25.3; Secret Service API treats labels as unique To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset="UTF-8" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) The Secret Service API [1] treats labels as unique keys for each secret item in a collection. However, labels are not required to be unique in a collection [2], the attribute key/value pairs are. It is perfectly valid to have multiple secrets with the same label, in which case Emacs's Secret Service API is not able to retrieve all but the most recently created (?) secret. This can be demonstrated by creating two such secrets using the secret-tool utility: secret-tool store --label=Test1 id foo secret-tool store --label=Test1 id bar You can see how the attributes uniquely identify secrets: secret-tool store --label=Test2 id foo # This overwrites the first secret. Implementation idea: Use attribute plists instead of label strings to uniquely identify secret items. This would require creating a new copy of the API to preserve backward compatibility. [1]: https://www.gnu.org/software/emacs/manual/html_node/auth/Secret-Service-API.html [2]: https://specifications.freedesktop.org/secret-service/re02.html In GNU Emacs 25.3.1 (x86_64-pc-linux-gnu, GTK+ Version 3.22.19) of 2017-09-16 built on juergen Windowing system distributor 'The X.Org Foundation', version 11.0.11905000 Configured using: 'configure --prefix=/usr --sysconfdir=/etc --libexecdir=/usr/lib --localstatedir=/var --with-x-toolkit=gtk3 --with-xft --with-modules 'CFLAGS=-march=x86-64 -mtune=generic -O2 -pipe -fstack-protector-strong -fno-plt' CPPFLAGS=-D_FORTIFY_SOURCE=2 LDFLAGS=-Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now' Configured features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GCONF GSETTINGS NOTIFY ACL GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 MODULES ------------=_1536659402-32460-1--