GNU bug report logs - #29574
Fwd: [PATCH] Add Krita to guix

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 29574 in the body.
You can then email your comments to 29574 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mark Meyer <mark <at> ofosos.org>
To: guix-patches <at> gnu.org
Subject: Fwd: [PATCH] Add Krita to guix
Date: Tue, 05 Dec 2017 02:35:57 +0100

[Message part 1 (text/plain, inline)]

On Tue, Dec 5, 2017, at 02:26, Mark Meyer wrote:
> Second  try.
> 
> I disabled all tests, since these required an X11 display to be present.
> It's running now. I created a new file and saved the output. Looks good.
> 
> Please find the patch attached.
> 
> Lints fine, but I didn't test if this is reproducible, since the build
> is taking a very long time (even with all tests disabled).
> 
> Cheers, Mark
> 
> -- 
>   Mark Meyer
>   mark <at> ofosos.org


-- 
  Mark Meyer
  mark <at> ofosos.org

[0001-gnu-packages-kde.scm-krita-Add-new-variable.patch (text/x-patch, attachment)]

Message #8 received at 29574 <at> debbugs.gnu.org (full text, mbox):

From: Kei Kebreau <kkebreau <at> posteo.net>
To: Mark Meyer <mark <at> ofosos.org>
Cc: 29574 <at> debbugs.gnu.org
Subject: Re: [bug#29574] Fwd: [PATCH] Add Krita to guix
Date: Sun, 10 Dec 2017 14:32:06 -0500

[Message part 1 (text/plain, inline)]

Mark Meyer <mark <at> ofosos.org> writes:

> On Tue, Dec 5, 2017, at 02:26, Mark Meyer wrote:
>> Second  try.
>> 
>> I disabled all tests, since these required an X11 display to be present.
>> It's running now. I created a new file and saved the output. Looks good.
>> 
>> Please find the patch attached.
>> 
>> Lints fine, but I didn't test if this is reproducible, since the build
>> is taking a very long time (even with all tests disabled).
>> 
>> Cheers, Mark
>> 
>> -- 
>>   Mark Meyer
>>   mark <at> ofosos.org

Hi Mark,

I built this package twice and it is reproducible! I've moved some
inputs to native-inputs in the attached patch because they didn't show
up as requisites for krita (i.e. I ran 'guix gc -R /gnu/store/...-krita-3.3.2.1'
to find this out).

Please tell me if this build works properly for you as it seems to for
me.

Thanks,
Kei

[0001-gnu-Add-krita.patch (text/plain, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 29574 <at> debbugs.gnu.org (full text, mbox):

From: Mark Meyer <mark <at> ofosos.org>
To: Kei Kebreau <kkebreau <at> posteo.net>
Cc: 29574 <at> debbugs.gnu.org
Subject: Re: [bug#29574] Fwd: [PATCH] Add Krita to guix
Date: Sun, 10 Dec 2017 22:27:29 +0100

Hi Kei,
I want to double check the output tomorrow morning. I think my copy
lacks JPG support, but I'm not sure. I'll check tomorrow.

Cheers, Mark

On Sun, Dec 10, 2017, at 20:32, Kei Kebreau wrote:
> Mark Meyer <mark <at> ofosos.org> writes:
> 
> > On Tue, Dec 5, 2017, at 02:26, Mark Meyer wrote:
> >> Second  try.
> >> 
> >> I disabled all tests, since these required an X11 display to be present.
> >> It's running now. I created a new file and saved the output. Looks good.
> >> 
> >> Please find the patch attached.
> >> 
> >> Lints fine, but I didn't test if this is reproducible, since the build
> >> is taking a very long time (even with all tests disabled).
> >> 
> >> Cheers, Mark
> >> 
> >> -- 
> >>   Mark Meyer
> >>   mark <at> ofosos.org
> 
> Hi Mark,
> 
> I built this package twice and it is reproducible! I've moved some
> inputs to native-inputs in the attached patch because they didn't show
> up as requisites for krita (i.e. I ran 'guix gc -R
> /gnu/store/...-krita-3.3.2.1'
> to find this out).
> 
> Please tell me if this build works properly for you as it seems to for
> me.
> 
> Thanks,
> Kei
> 
> Email had 2 attachments:
> + 0001-gnu-Add-krita.patch
>   5k (text/plain)
> + signature.asc
>   1k (application/pgp-signature)


-- 
  Mark Meyer
  mark <at> ofosos.org

Message #14 received at 29574 <at> debbugs.gnu.org (full text, mbox):

From: Mark Meyer <mark <at> ofosos.org>
To: Kei Kebreau <kkebreau <at> posteo.net>
Cc: 29574 <at> debbugs.gnu.org
Subject: Re: [bug#29574] Fwd: [PATCH] Add Krita to guix
Date: Mon, 11 Dec 2017 01:07:49 +0100

Hey Kei,
JPEG does not work and PDF also doesn't seem to work, we might as well
remove both dependencies, I think they're nice but not essential.

When I do `guix environment krita` and start a manual build I get:

-- The following OPTIONAL packages have not been found:

 * XCB , X protocol C-language Binding , <http://xcb.freedesktop.org>
 * OpenEXR , High dynamic-range (HDR) image file format ,
 <http://www.openexr.com>
   Required by the Krita OpenEXR filter
 * JPEG , Free library for JPEG image compression. Note: libjpeg8 is NOT
 supported. , <http://www.libjpeg-turbo.org>
   Required by the Krita JPEG filter
 * OCIO , The OpenColorIO Library , <http://www.opencolorio.org>
   Required by the Krita LUT docker
 * Vc (required version >= 1.1.0) , Portable, zero-overhead SIMD library
 for C++ , <https://github.com/VcDevel/Vc>
   Required by the Krita for vectorization
 * Poppler , A PDF rendering library , <http://poppler.freedesktop.org>
   Required by the Krita PDF filter.

I intend to enable OpenEXR JPEG and Poppler in a later patch.

So: looks good to me.

Cheers, Mark

On Sun, Dec 10, 2017, at 20:32, Kei Kebreau wrote:
> Mark Meyer <mark <at> ofosos.org> writes:
> 
> > On Tue, Dec 5, 2017, at 02:26, Mark Meyer wrote:
> >> Second  try.
> >> 
> >> I disabled all tests, since these required an X11 display to be present.
> >> It's running now. I created a new file and saved the output. Looks good.
> >> 
> >> Please find the patch attached.
> >> 
> >> Lints fine, but I didn't test if this is reproducible, since the build
> >> is taking a very long time (even with all tests disabled).
> >> 
> >> Cheers, Mark
> >> 
> >> -- 
> >>   Mark Meyer
> >>   mark <at> ofosos.org
> 
> Hi Mark,
> 
> I built this package twice and it is reproducible! I've moved some
> inputs to native-inputs in the attached patch because they didn't show
> up as requisites for krita (i.e. I ran 'guix gc -R
> /gnu/store/...-krita-3.3.2.1'
> to find this out).
> 
> Please tell me if this build works properly for you as it seems to for
> me.
> 
> Thanks,
> Kei
> 
> Email had 2 attachments:
> + 0001-gnu-Add-krita.patch
>   5k (text/plain)
> + signature.asc
>   1k (application/pgp-signature)


-- 
  Mark Meyer
  mark <at> ofosos.org

Message #17 received at 29574 <at> debbugs.gnu.org (full text, mbox):

From: Mark Meyer <mark <at> ofosos.org>
To: Kei Kebreau <kkebreau <at> posteo.net>
Cc: 29574 <at> debbugs.gnu.org
Subject: Re: [bug#29574] Fwd: [PATCH] Add Krita to guix
Date: Mon, 11 Dec 2017 01:29:18 +0100

[Message part 1 (text/plain, inline)]

Hi Kei,
Poppler was an easy target, it just pointed to the wrong package. JPEG
requires some more packaging and EXR some thought. Meanwhile the
attached patch should be ok.

Cheers, Mark

On Sun, Dec 10, 2017, at 20:32, Kei Kebreau wrote:
> Mark Meyer <mark <at> ofosos.org> writes:
> 
> > On Tue, Dec 5, 2017, at 02:26, Mark Meyer wrote:
> >> Second  try.
> >> 
> >> I disabled all tests, since these required an X11 display to be present.
> >> It's running now. I created a new file and saved the output. Looks good.
> >> 
> >> Please find the patch attached.
> >> 
> >> Lints fine, but I didn't test if this is reproducible, since the build
> >> is taking a very long time (even with all tests disabled).
> >> 
> >> Cheers, Mark
> >> 
> >> -- 
> >>   Mark Meyer
> >>   mark <at> ofosos.org
> 
> Hi Mark,
> 
> I built this package twice and it is reproducible! I've moved some
> inputs to native-inputs in the attached patch because they didn't show
> up as requisites for krita (i.e. I ran 'guix gc -R
> /gnu/store/...-krita-3.3.2.1'
> to find this out).
> 
> Please tell me if this build works properly for you as it seems to for
> me.
> 
> Thanks,
> Kei
> 
> Email had 2 attachments:
> + 0001-gnu-Add-krita.patch
>   5k (text/plain)
> + signature.asc
>   1k (application/pgp-signature)


-- 
  Mark Meyer
  mark <at> ofosos.org

[0001-gnu-packages-kde.scm-krita-Add-new-variable.patch (text/x-patch, attachment)]

Message #20 received at 29574 <at> debbugs.gnu.org (full text, mbox):

From: Kei Kebreau <kkebreau <at> posteo.net>
To: Mark Meyer <mark <at> ofosos.org>
Cc: 29574 <at> debbugs.gnu.org
Subject: Re: [bug#29574] Fwd: [PATCH] Add Krita to guix
Date: Tue, 12 Dec 2017 21:51:00 -0500

[Message part 1 (text/plain, inline)]

Mark Meyer <mark <at> ofosos.org> writes:

> Hi Kei,
> Poppler was an easy target, it just pointed to the wrong package. JPEG
> requires some more packaging and EXR some thought. Meanwhile the
> attached patch should be ok.
>
> Cheers, Mark
>
> On Sun, Dec 10, 2017, at 20:32, Kei Kebreau wrote:
>> Mark Meyer <mark <at> ofosos.org> writes:
>> 
>> > On Tue, Dec 5, 2017, at 02:26, Mark Meyer wrote:
>> >> Second  try.
>> >> 
>> >> I disabled all tests, since these required an X11 display to be present.
>> >> It's running now. I created a new file and saved the output. Looks good.
>> >> 
>> >> Please find the patch attached.
>> >> 
>> >> Lints fine, but I didn't test if this is reproducible, since the build
>> >> is taking a very long time (even with all tests disabled).
>> >> 
>> >> Cheers, Mark
>> >> 
>> >> -- 
>> >>   Mark Meyer
>> >>   mark <at> ofosos.org
>> 
>> Hi Mark,
>> 
>> I built this package twice and it is reproducible! I've moved some
>> inputs to native-inputs in the attached patch because they didn't show
>> up as requisites for krita (i.e. I ran 'guix gc -R
>> /gnu/store/...-krita-3.3.2.1'
>> to find this out).
>> 
>> Please tell me if this build works properly for you as it seems to for
>> me.
>> 
>> Thanks,
>> Kei
>> 
>> Email had 2 attachments:
>> + 0001-gnu-Add-krita.patch
>>   5k (text/plain)
>> + signature.asc
>>   1k (application/pgp-signature)

Great, LGTM. I added some detail to the description and pushed it to master, so you can close this bug.

Also, please be sure to follow our change log conventions, which are
something like these[0]. When in doubt, copy from a recent change log
for a change similar to yours from our repo. Most of the time this works
without a problem.

Thanks,
Kei

[0]: https://www.gnu.org/prep/standards/html_node/Style-of-Change-Logs.html

[signature.asc (application/pgp-signature, inline)]

Message #25 received at 29574-close <at> debbugs.gnu.org (full text, mbox):

From: Mark Meyer <mark <at> ofosos.org>
To: 29574-close <at> debbugs.gnu.org
Subject: Fixed
Date: Thu, 14 Dec 2017 01:14:19 +0100

Fixed.

-- 
  Mark Meyer
  mark <at> ofosos.org

Message #28 received at 29574-done <at> debbugs.gnu.org (full text, mbox):

From: ng0 <ng0 <at> n0.is>
To: 29574-done <at> debbugs.gnu.org, mark <at> ofosos.org
Subject: Re: bug#29574: Fixed
Date: Thu, 14 Dec 2017 08:59:14 +0000

[Message part 1 (text/plain, inline)]

Mark Meyer transcribed 0.1K bytes:
> Fixed.
> 
> -- 
>   Mark Meyer
>   mark <at> ofosos.org

If XXXX-close <at> debbugs.gnu.org does something, I think it could be similar to
"disregard, closing as not working on it, dropping this".
XXXX-done <at> debbugs.gnu.org is what we use for tickets that have been resolved.
There are notes in HACKING and in the chapter 'contributing' about this I
think
Please use this next time

Thanks
-- 
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://c.n0.is/ng0_pubkeys/tree/keys
  WWW: https://n0.is

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.