From unknown Sun Jun 22 20:58:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29573: 26.0.90; Suppress warnings during elisp completion macroexpansion Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 05 Dec 2017 01:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 29573 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 29573@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.151243704032719 (code B ref -1); Tue, 05 Dec 2017 01:24:02 +0000 Received: (at submit) by debbugs.gnu.org; 5 Dec 2017 01:24:00 +0000 Received: from localhost ([127.0.0.1]:46161 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eM1xn-0008Ve-Lk for submit@debbugs.gnu.org; Mon, 04 Dec 2017 20:23:59 -0500 Received: from eggs.gnu.org ([208.118.235.92]:60509) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eM1xm-0008VS-Bt for submit@debbugs.gnu.org; Mon, 04 Dec 2017 20:23:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eM1xg-0004e6-4b for submit@debbugs.gnu.org; Mon, 04 Dec 2017 20:23:53 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:32894) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eM1xg-0004dw-0m for submit@debbugs.gnu.org; Mon, 04 Dec 2017 20:23:52 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51472) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eM1xe-0004jl-SZ for bug-gnu-emacs@gnu.org; Mon, 04 Dec 2017 20:23:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eM1xZ-0004ba-0p for bug-gnu-emacs@gnu.org; Mon, 04 Dec 2017 20:23:50 -0500 Received: from mail-it0-x22f.google.com ([2607:f8b0:4001:c0b::22f]:45440) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eM1xY-0004bN-Qg for bug-gnu-emacs@gnu.org; Mon, 04 Dec 2017 20:23:44 -0500 Received: by mail-it0-x22f.google.com with SMTP id z6so17599946iti.4 for ; Mon, 04 Dec 2017 17:23:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:date:message-id:mime-version; bh=nlmAq3+HFkIv3PljTnxJHz6znYyXwWMqUzrt3A1RzUM=; b=Fj5LgJWBEzalDJb5IoUQWHXZBz7M5qrDR95pBZIiOz8tsrXFAYS8OFpQRVhGLO4POP ywHstpXV3eVDIbX6L6KFnlqi3r3PPXlxhuhxYxwi5480y9O5V13DX+OaUZ4Cn6ry/8UO BcQjM4KdUp+hA5760Srbxk9bFTIxVZczf7nhkW0ditbEEsqcOpuYU0AYRug/kEZvlOHU qg0IXaGuzf8IhoV7mwB9j5+t15EUwL63r724G7VtCOnQqcmByzdSpWPtH2xQZE4pqz9Q wQfRbqQnwqbmx8K4wsuvGG6qEQk575s9fBbENkmoJzjgdzGZUNBFj2umUHhe4Gw8DTcD JX/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id :mime-version; bh=nlmAq3+HFkIv3PljTnxJHz6znYyXwWMqUzrt3A1RzUM=; b=rM2pYQDJQFG8CpKaKOjhS9IdhSAT4i16jWftTHIJhObjt/j/kIURaGjzWRGY4GAsTF 9v0iV2xXfxpEsNPXYTVSPeWXFzLkBcefFJsD0lmfLX1Nd7SwS7NRt5GURLz5RkTvNEyD Y+rKdgUcHzD1AxBdm75Ccxku9Medqxxew+NOziQEvyG/UwJcspeYQMp8oObIg4y1Hw2y Y2ET9yd8EQhugrB76MFmu+x+AOCbqOa2PVKXJL9wZkh7WqMRDpPpAZR3JuqfB3dg82TS SrP5/oSkqNS3XxnvbLI9yhZVD/xiNCjCJjOWPwny+WNUUCDNL6KEnSO5uiOh+1QzOvJb DJiw== X-Gm-Message-State: AJaThX4DSxJ+Oz2iunJx1fKTmrfPjFNpjfLwAjO4Sd5psj5soPcevTJ1 qN06+zqVayiP7q1lgKd10OeXdw== X-Google-Smtp-Source: AGs4zMaq7MCsbabUttIqMonZ50F9IhGa7NO2f2GT4KitPf/lrxBwSkhkNdaIGPD9ntfaRUSvhlC+Bg== X-Received: by 10.36.51.202 with SMTP id k193mr15860257itk.126.1512437023999; Mon, 04 Dec 2017 17:23:43 -0800 (PST) Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id 30sm6717045iop.47.2017.12.04.17.23.42 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 04 Dec 2017 17:23:42 -0800 (PST) From: Noam Postavsky Date: Mon, 04 Dec 2017 20:23:42 -0500 Message-ID: <87efoage75.fsf@users.sourceforge.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -3.8 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.8 (---) --=-=-= Content-Type: text/plain Tags: patch Motivating example is use-package showing an error when given the `elisp--witness-lisp' symbol by completion [1]. [1]: https://github.com/jwiegley/use-package/issues/524 --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Suppress-warnings-during-elisp-completion-macroexpan.patch Content-Description: patch >From d73b0094c205e8b5762dc5e5833abdfb5841348f Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Mon, 4 Dec 2017 20:01:40 -0500 Subject: [PATCH] Suppress warnings during elisp completion macroexpansion Errors are already suppressed, therefore it is logical to suppress warnings as well. Some macros (e.g., use-package) may produce warnings when given the `elisp--witness--lisp' symbol. * lisp/progmodes/elisp-mode.el (elisp--local-variables): Let-bind warning-minimum-log-level to :emergency. --- lisp/progmodes/elisp-mode.el | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lisp/progmodes/elisp-mode.el b/lisp/progmodes/elisp-mode.el index 5ba0978909..4207edb8af 100644 --- a/lisp/progmodes/elisp-mode.el +++ b/lisp/progmodes/elisp-mode.el @@ -307,6 +307,8 @@ elisp--local-variables-1 (setq sexp (ignore-errors (butlast sexp))))) res)) +(defvar warning-minimum-log-level) + (defun elisp--local-variables () "Return a list of locally let-bound variables at point." (save-excursion @@ -328,7 +330,7 @@ elisp--local-variables (error form)))) (sexp (unwind-protect - (progn + (let ((warning-minimum-log-level :emergency)) (advice-add 'macroexpand :around macroexpand-advice) (macroexpand-all sexp)) (advice-remove 'macroexpand macroexpand-advice))) -- 2.11.0 --=-=-=-- From unknown Sun Jun 22 20:58:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29573: 26.0.90; Suppress warnings during elisp completion macroexpansion Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Dec 2017 23:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29573 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 29573@debbugs.gnu.org Received: via spool by 29573-submit@debbugs.gnu.org id=B29573.15130360838710 (code B ref 29573); Mon, 11 Dec 2017 23:49:02 +0000 Received: (at 29573) by debbugs.gnu.org; 11 Dec 2017 23:48:03 +0000 Received: from localhost ([127.0.0.1]:57442 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eOXnn-0002GK-JU for submit@debbugs.gnu.org; Mon, 11 Dec 2017 18:48:03 -0500 Received: from mail-it0-f44.google.com ([209.85.214.44]:38653) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eOXnl-0002Fj-EB; Mon, 11 Dec 2017 18:48:01 -0500 Received: by mail-it0-f44.google.com with SMTP id r6so20017918itr.3; Mon, 11 Dec 2017 15:48:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=DAPegMmqKVfyy+WsA6DHj7JgoAFFAxu9J6+UoD9wlYA=; b=TRRwlXL96mJkWHnLj7Ub8c5XkkhpaxBpPYtlJWwpmybMXGWFBO8WwnYm2Z4ypukCE7 nZo787/4gyEHbLA3MBphwPk3S9GLgB7OiFibMVMcNxu+g3IVjjK+SvlZL/12EjxtfkGZ b0jj6vEUn5G02kf+pwhbtbkPO3+P8qQ2117PEgppuCia1yOUGxZGWKzCAvg8N1blga1N ANrtpGKArtHpdjIzzYb/HFFkTqE71lEAOKz134z+6t4qkSCyqWOqvmh/enerAGU8XhMC WKWh52h9Jns+SQ4GCMcysAmlDwIrMnkEuH/evAyA6b6ISRq9+/jUxIWXD8+dFFIgW/9Q V3WQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=DAPegMmqKVfyy+WsA6DHj7JgoAFFAxu9J6+UoD9wlYA=; b=TzoZaO4jLpZ+ufhifof84QwaSOFooKewQNq9zMH2uE3RsEcXui2RPV0f4YDr4njw47 Apl3BD/zLR3tSGx+c3F3thbZplaHrMus3jpUW/GeuGMYgE+PALTf3l9jCqUmUl3WcH7r VrTvY8LBlny5Sl7bZ8mZ0se86NfmnRXGqlC5Vz9wTYy07IJSpuaABHU92RSWzeY6uDZl NoE8Kuf5r8sLSFOYMLmNGpdupAJ9OEs8a2vYkxoxefh9t5zJS1c/MZ4jgIfEhwnrk/bU EJWS0oxP6OMAFuz8R4yEQgki1+FSRMCZInOs0NZWJ9qdYZHVQdF3OnsNPlLPg43OtudL e4xQ== X-Gm-Message-State: AKGB3mL52CNHjwBADQMMkSbLSvEzXNRNzFnZUfiEz6/v5vvzmubsCee6 oijcNQdI4uppzkd3M9KjC7jezA== X-Google-Smtp-Source: ACJfBotGVe/VgJk5QKFZMnFB/iNrZ1VhfJ9ct5JumIVbB2kLXt9n66oT+m8kAg5raD2SaKf9NofiAQ== X-Received: by 10.36.240.75 with SMTP id p11mr76718iti.104.1513036075782; Mon, 11 Dec 2017 15:47:55 -0800 (PST) Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id x2sm4312626ite.24.2017.12.11.15.47.54 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 11 Dec 2017 15:47:54 -0800 (PST) From: Noam Postavsky References: <87efoage75.fsf@users.sourceforge.net> Date: Mon, 11 Dec 2017 18:47:53 -0500 In-Reply-To: <87efoage75.fsf@users.sourceforge.net> (Noam Postavsky's message of "Mon, 04 Dec 2017 20:23:42 -0500") Message-ID: <87po7kesie.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) tags 29573 fixed close 29573 26.1 quit Pushed to emacs-26. [2: 51911dae14]: 2017-12-11 17:38:28 -0500 Suppress warnings during elisp completion macroexpansion https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=51911dae14ecaf6c6eb22641c3189c6fa97ab24a