GNU bug report logs - #29567
[PATCH] src/xterm.c: use 'thickness' only in a case of !USE_CAIRO

Previous Next

Full log

Message #10 received at 29567-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Alexander Kuleshov <kuleshovmail <at> gmail.com>
Cc: 29567-done <at> debbugs.gnu.org
Subject: Re: bug#29567: [PATCH] src/xterm.c: use 'thickness' only in a case of
 !USE_CAIRO
Date: Mon, 04 Dec 2017 22:05:20 +0200

> From: Alexander Kuleshov <kuleshovmail <at> gmail.com>
> Date: Tue, 5 Dec 2017 00:11:47 +0600
> 
> I've attached simple patch with moving of the `thickness` var
> (from the x_draw_underwave() src/xterm.c) a little bit below, to get rid of:
> 
> xterm.c:3520:61: error: unused variable 'thickness' [-Werror,-Wunused-variable]
>   int wave_height = 3 * scale_y, wave_length = 2 * scale_x, thickness = scale_y;
> 
> as this variable is used only in a case of !USE_CAIRO

Thanks.  Did the patched source compile for you in the !USE_CAIRO
case?  Because 'thickness' needs to be declared as 'int' before it can
be used.

So I installed a slightly different change to avoid the warning.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.