From unknown Sat Jun 21 10:15:03 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#29567 <29567@debbugs.gnu.org> To: bug#29567 <29567@debbugs.gnu.org> Subject: Status: [PATCH] src/xterm.c: use 'thickness' only in a case of !USE_CAIRO Reply-To: bug#29567 <29567@debbugs.gnu.org> Date: Sat, 21 Jun 2025 17:15:03 +0000 retitle 29567 [PATCH] src/xterm.c: use 'thickness' only in a case of !USE_C= AIRO reassign 29567 emacs submitter 29567 Alexander Kuleshov severity 29567 normal tag 29567 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 04 13:12:19 2017 Received: (at submit) by debbugs.gnu.org; 4 Dec 2017 18:12:19 +0000 Received: from localhost ([127.0.0.1]:45819 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eLvE3-0000x3-F4 for submit@debbugs.gnu.org; Mon, 04 Dec 2017 13:12:19 -0500 Received: from eggs.gnu.org ([208.118.235.92]:39710) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eLvE1-0000wp-HL for submit@debbugs.gnu.org; Mon, 04 Dec 2017 13:12:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eLvDv-00055O-Im for submit@debbugs.gnu.org; Mon, 04 Dec 2017 13:12:12 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:39889) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eLvDv-00055E-Ek for submit@debbugs.gnu.org; Mon, 04 Dec 2017 13:12:11 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58892) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eLvDu-0002nC-FR for bug-gnu-emacs@gnu.org; Mon, 04 Dec 2017 13:12:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eLvDt-00054F-O7 for bug-gnu-emacs@gnu.org; Mon, 04 Dec 2017 13:12:10 -0500 Received: from mail-qt0-x22e.google.com ([2607:f8b0:400d:c0d::22e]:46031) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eLvDt-00053q-Ia for bug-gnu-emacs@gnu.org; Mon, 04 Dec 2017 13:12:09 -0500 Received: by mail-qt0-x22e.google.com with SMTP id g10so23053596qtj.12 for ; Mon, 04 Dec 2017 10:12:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=22XojNLOZsugwKUcAZSvoue0XthT22SpqH1KeVucHr0=; b=ZBEKJsoQSXt8sHnyfOHcZJdkOrx8p5O++2Av26Kc3qamWlpHgl/mMkz8TeiEzXOhJ9 ftEY47dKLvSJsYzQg9S2kAJRUcbzSRH+kJqkW9mVZTH+8yMVBth3oei2+2gpD5hX279v xbaZ11HXOn+yuju9AZbEUjljFrsfxnlZ5dO2GQLZOeTtIJGrmOHfYkTmeQFGBx9sX8EI nrku+UJ/xCzIqwSyA650cEy6euBfroZj+3dy5sTHoRcq2eML0ByfwunRH6y1KG5agQN9 LqjCnS29QmvU7HXkwXO6gHEzdml3qBcF9tEqcEyGYJXxYHy4q0IMQn4OD/GAkyySl++o xIWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=22XojNLOZsugwKUcAZSvoue0XthT22SpqH1KeVucHr0=; b=h4zhwRnUdGx5Hy97dlm2DhNUBD779nTpfVGK6ceUoHw3DaQEhKHJ8ySbKQIy4qPG+/ ZaiP/08+lv6RnJ+GgHN9fepTS00OnGrsBs+CL+Ha4gzCyaxF+wMWqYaWwqxYgNhKcgx1 zHc9J2cP2+WUomiEJwlAywkk3Ld0XR9HAZZvILchgTkF06kl4g6No2eKANaV3pOl60Ei XPcMRmHUL1oSQGXyIOidT0mJ5YLEiwdqKBkCNZ9UaElqUL23pV4LgNK3+Z3Pyqma8rgF oQHw1n3OgcIG2QdKbwFoedUfjTmvKBiUti6OQEw7RoJVNzcL4YieSGfn4fuAwEXgDTTn c9RA== X-Gm-Message-State: AKGB3mIljHKDbJ6BXQ6vtQ1HYcWsUeJFYzSVfxr4JV7qUYOkEufeqTJi mkUYbBjH6Yzn9tehBHp+q6OoG6rcZtkrh970BrUShg== X-Google-Smtp-Source: AGs4zMbMF7ROmGxQVh2rarRSWypG1TJDQrabTindrNEA1IYWuTbr0nJiARnjSedX7fTmMAsSUa7sexCwzpTG2QVDiAA= X-Received: by 10.200.55.75 with SMTP id p11mr21595000qtb.298.1512411128541; Mon, 04 Dec 2017 10:12:08 -0800 (PST) MIME-Version: 1.0 Received: by 10.237.38.1 with HTTP; Mon, 4 Dec 2017 10:11:47 -0800 (PST) From: Alexander Kuleshov Date: Tue, 5 Dec 2017 00:11:47 +0600 Message-ID: Subject: [PATCH] src/xterm.c: use 'thickness' only in a case of !USE_CAIRO To: bug-gnu-emacs@gnu.org Content-Type: multipart/mixed; boundary="001a113c28421250fa055f87a837" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --001a113c28421250fa055f87a837 Content-Type: text/plain; charset="UTF-8" Hello, I've attached simple patch with moving of the `thickness` var (from the x_draw_underwave() src/xterm.c) a little bit below, to get rid of: xterm.c:3520:61: error: unused variable 'thickness' [-Werror,-Wunused-variable] int wave_height = 3 * scale_y, wave_length = 2 * scale_x, thickness = scale_y; as this variable is used only in a case of !USE_CAIRO Thank you. --001a113c28421250fa055f87a837 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Move-thickness-assignment-where-it-is-used.patch" Content-Disposition: attachment; filename="0001-Move-thickness-assignment-where-it-is-used.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_jasiajno0 RnJvbSBkMTFhNjUxYTVkNGI2MWExODc5NGZkMjliNmZhYjY3MjJhODg1YzA2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGV4YW5kZXIgS3VsZXNob3YgPGt1bGVzaG92bWFpbEBnbWFp bC5jb20+CkRhdGU6IE1vbiwgNCBEZWMgMjAxNyAyMzo1ODowMCArMDYwMApTdWJqZWN0OiBbUEFU Q0hdIE1vdmUgdGhpY2tuZXNzIGFzc2lnbm1lbnQgd2hlcmUgaXQgaXMgdXNlZAoKKiBzcmMveHRl cm0uYyAoeF9kcmF3X3VuZGVyd2F2ZSk6IGFzc2lnbiBhIHZhbHVlIHRvICd0aGlja25lc3MnCnZh cmlhYmxlIG9ubHkgaW4gYSBjYXNlIG9mICFVU0VfQ0FJUk8KLS0tCiBzcmMveHRlcm0uYyB8IDMg KystCiAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZm IC0tZ2l0IGEvc3JjL3h0ZXJtLmMgYi9zcmMveHRlcm0uYwppbmRleCAxYjQ1Y2YxYjBiLi5iOGFl NjRjNmRmIDEwMDY0NAotLS0gYS9zcmMveHRlcm0uYworKysgYi9zcmMveHRlcm0uYwpAQCAtMzUx Nyw3ICszNTE3LDcgQEAgeF9kcmF3X3VuZGVyd2F2ZSAoc3RydWN0IGdseXBoX3N0cmluZyAqcykK IAogICB4X2dldF9zY2FsZV9mYWN0b3IgKHMtPmRpc3BsYXksICZzY2FsZV94LCAmc2NhbGVfeSk7 CiAKLSAgaW50IHdhdmVfaGVpZ2h0ID0gMyAqIHNjYWxlX3ksIHdhdmVfbGVuZ3RoID0gMiAqIHNj YWxlX3gsIHRoaWNrbmVzcyA9IHNjYWxlX3k7CisgIGludCB3YXZlX2hlaWdodCA9IDMgKiBzY2Fs ZV95LCB3YXZlX2xlbmd0aCA9IDIgKiBzY2FsZV94OwogCiAjaWZkZWYgVVNFX0NBSVJPCiAgIHhf ZHJhd19ob3Jpem9udGFsX3dhdmUgKHMtPmYsIHMtPmdjLCBzLT54LCBzLT55YmFzZSAtIHdhdmVf aGVpZ2h0ICsgMywKQEAgLTM1MjcsNiArMzUyNyw3IEBAIHhfZHJhd191bmRlcndhdmUgKHN0cnVj dCBnbHlwaF9zdHJpbmcgKnMpCiAgIGJvb2wgb2RkOwogICBYUmVjdGFuZ2xlIHdhdmVfY2xpcCwg c3RyaW5nX2NsaXAsIGZpbmFsX2NsaXA7CiAKKyAgdGhpY2tuZXNzID0gc2NhbGVfeTsKICAgZHgg PSB3YXZlX2xlbmd0aDsKICAgZHkgPSB3YXZlX2hlaWdodCAtIDE7CiAgIHgwID0gcy0+eDsKLS0g CjIuMTQuMwoK --001a113c28421250fa055f87a837-- From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 04 15:05:50 2017 Received: (at 29567-done) by debbugs.gnu.org; 4 Dec 2017 20:05:50 +0000 Received: from localhost ([127.0.0.1]:45948 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eLwzu-0005Zi-Gk for submit@debbugs.gnu.org; Mon, 04 Dec 2017 15:05:50 -0500 Received: from eggs.gnu.org ([208.118.235.92]:39616) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eLwzs-0005ZW-G6 for 29567-done@debbugs.gnu.org; Mon, 04 Dec 2017 15:05:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eLwzk-0003hN-Br for 29567-done@debbugs.gnu.org; Mon, 04 Dec 2017 15:05:43 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:33204) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eLwzk-0003hJ-8g; Mon, 04 Dec 2017 15:05:40 -0500 Received: from [176.228.60.248] (port=4656 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eLwzi-0003Bm-Fz; Mon, 04 Dec 2017 15:05:40 -0500 Date: Mon, 04 Dec 2017 22:05:20 +0200 Message-Id: <838teixnr3.fsf@gnu.org> From: Eli Zaretskii To: Alexander Kuleshov In-reply-to: (message from Alexander Kuleshov on Tue, 5 Dec 2017 00:11:47 +0600) Subject: Re: bug#29567: [PATCH] src/xterm.c: use 'thickness' only in a case of !USE_CAIRO References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 29567-done Cc: 29567-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Alexander Kuleshov > Date: Tue, 5 Dec 2017 00:11:47 +0600 > > I've attached simple patch with moving of the `thickness` var > (from the x_draw_underwave() src/xterm.c) a little bit below, to get rid of: > > xterm.c:3520:61: error: unused variable 'thickness' [-Werror,-Wunused-variable] > int wave_height = 3 * scale_y, wave_length = 2 * scale_x, thickness = scale_y; > > as this variable is used only in a case of !USE_CAIRO Thanks. Did the patched source compile for you in the !USE_CAIRO case? Because 'thickness' needs to be declared as 'int' before it can be used. So I installed a slightly different change to avoid the warning. From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 05 01:54:06 2017 Received: (at 29567-done) by debbugs.gnu.org; 5 Dec 2017 06:54:06 +0000 Received: from localhost ([127.0.0.1]:46311 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eM77G-00019R-8Z for submit@debbugs.gnu.org; Tue, 05 Dec 2017 01:54:06 -0500 Received: from mail-qt0-f174.google.com ([209.85.216.174]:43673) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eM77E-00018y-MW for 29567-done@debbugs.gnu.org; Tue, 05 Dec 2017 01:54:04 -0500 Received: by mail-qt0-f174.google.com with SMTP id w10so26813050qtb.10 for <29567-done@debbugs.gnu.org>; Mon, 04 Dec 2017 22:54:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=wypxuo+OC19D03SIT8ZFHVCjPb/IZCm6iTeqB85NrK0=; b=DCiCkDx+3EKkGW+5knmUUKBlTJoddgAXqMrRzqRxouKTNcoaFNQGFxnXTMCmOlRVxb vSEczIvaAN/bR8iItf7snrI5XFoVgyph6kQt/47MoeY1ND9yBwh7NDEsVDJRoWCapz3i gqGQj1DiZ2o7vI4bYm9og6mE3sKnpIW/kcukzVeDlxEAihX9avKGLN706NWnxXugC1v7 jtgibYu2DWeYZ4ngs1myAZYsKUn7zARa7kxIpcI7bfEQrEMdAI7Ox+xCO+UIy4bjRWOl 0uipId1aJ3P6npMxRyDiEx4WN/gB8i/DL/I5z4BOnI4U4r9vaF6W0gadDBj76XurOpIj oflg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=wypxuo+OC19D03SIT8ZFHVCjPb/IZCm6iTeqB85NrK0=; b=dagY69opztUqN/bMFe5NaLKeafkjpQVzWhWUMME8GrytWPEetyixHY94WIoCUFH5bv bxdgPWQCzKVkyCfALyzXgNnQE7u0+sYAH4LYCoOTq31gXIzaQyZ94trJ2H6zIxridRfK UbfQf0WvWTSDO+jQrpTuST5/RKPQcUQxjXbYHav4EtOHeBdIVvtawDw2jCdU3qIV96m7 N+Cf+XSV5M5/UPr8O9wJCgMWun9S8qBIqDRYsse6WfXLwa0v8KB+hpXcAeSp63G4jxQ4 EhawggNlGMvFdAKG5O8yJyTPWraLplZloO9+J7eSRWIPimOLajZyUDb0vcqGbW0jNl6B 3RiA== X-Gm-Message-State: AKGB3mLmf3BlxkwLmZEOJlmntMSOIUbSrnw0JpOy3vHdw+L9TUkCgbtP R+IHMukk4MEBDZpgmpAJCx2vMgxKfwzMQ7Xq5zY= X-Google-Smtp-Source: AGs4zMYzfY4URhn3M/ctX2Qz1Me5kIZWQ84yxbxP3LNxDmynelffKI8CwLWpTPzUaSdMllmwkzODFG0Ih3Ki7o5MmIg= X-Received: by 10.55.18.92 with SMTP id c89mr21498511qkh.297.1512456839097; Mon, 04 Dec 2017 22:53:59 -0800 (PST) MIME-Version: 1.0 Received: by 10.237.38.1 with HTTP; Mon, 4 Dec 2017 22:53:38 -0800 (PST) In-Reply-To: <838teixnr3.fsf@gnu.org> References: <838teixnr3.fsf@gnu.org> From: Alexander Kuleshov Date: Tue, 5 Dec 2017 12:53:38 +0600 Message-ID: Subject: Re: bug#29567: [PATCH] src/xterm.c: use 'thickness' only in a case of !USE_CAIRO To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 29567-done Cc: 29567-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) On Tue, Dec 5, 2017 at 2:05 AM, Eli Zaretskii wrote: >> From: Alexander Kuleshov >> Date: Tue, 5 Dec 2017 00:11:47 +0600 >> >> I've attached simple patch with moving of the `thickness` var >> (from the x_draw_underwave() src/xterm.c) a little bit below, to get rid of: >> >> xterm.c:3520:61: error: unused variable 'thickness' [-Werror,-Wunused-variable] >> int wave_height = 3 * scale_y, wave_length = 2 * scale_x, thickness = scale_y; >> >> as this variable is used only in a case of !USE_CAIRO > > Thanks. Did the patched source compile for you in the !USE_CAIRO > case? Because 'thickness' needs to be declared as 'int' before it can > be used. > > So I installed a slightly different change to avoid the warning. Ah yes, yes, it should be defined before. Thank you. From unknown Sat Jun 21 10:15:03 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 02 Jan 2018 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator