GNU bug report logs - #29561
[PATCH] Add bluez-alsa.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 29561 in the body.
You can then email your comments to 29561 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: guix-patches <at> gnu.org
Subject: [PATCH] Add bluez-alsa.
Date: Mon, 04 Dec 2017 12:42:46 +0100

This patch series adds bluez-alsa, an ALSA plugin for bluetooth playback
without pulseaudio.

-- 
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

Message #8 received at 29561 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: 29561 <at> debbugs.gnu.org
Cc: Ricardo Wurmus <rekado <at> elephly.net>
Subject: [PATCH 2/4] gnu: Add bctoolbox.
Date: Mon,  4 Dec 2017 12:46:41 +0100

* gnu/packages/telephony.scm (bctoolbox): New variable.
---
 gnu/packages/telephony.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/telephony.scm b/gnu/packages/telephony.scm
index 5df5e9e4a..6fd40d617 100644
--- a/gnu/packages/telephony.scm
+++ b/gnu/packages/telephony.scm
@@ -6,6 +6,7 @@
 ;;; Copyright © 2016 Lukas Gradl <lgradl <at> openmailbox.org>
 ;;; Copyright © 2016 Francesco Frassinelli <fraph24 <at> gmail.com>
 ;;; Copyright © 2016, 2017 ng0 <contact.ng0 <at> cryptolab.net>
+;;; Copyright © 2017 Ricardo Wurmus <rekado <at> elephly.net>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -27,6 +28,7 @@
   #:use-module (gnu packages autotools)
   #:use-module (gnu packages avahi)
   #:use-module (gnu packages boost)
+  #:use-module (gnu packages check)
   #:use-module (gnu packages protobuf)
   #:use-module (gnu packages gnupg)
   #:use-module (gnu packages linux)
@@ -247,6 +249,29 @@ and a supporting cryptographic kernel.")
     (home-page "https://github.com/cisco/libsrtp")
     (license license:bsd-3)))
 
+(define-public bctoolbox
+  (package
+    (name "bctoolbox")
+    (version "0.2.0")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "mirror://savannah/linphone/bctoolbox/bctoolbox-"
+                                  version ".tar.gz"))
+              (sha256
+               (base32
+                "14ivv6bh6qywys6yyb34scy9w78d636xl1f7cyxm3gwx2qv71lx5"))))
+    (build-system gnu-build-system)
+    (arguments '(#:make-flags '("CFLAGS=-fPIC")))
+    (native-inputs
+     `(("cunit" ,cunit)))
+    (inputs
+     `(("mbedtls" ,mbedtls-apache)))
+    (home-page "https://www.linphone.org")
+    (synopsis "Utilities library for linphone software")
+    (description "BCtoolbox is a utilities library used by Belledonne
+Communications softwares like linphone.")
+    (license license:gpl2+)))
+
 (define-public libiax2
   (let ((commit "0e5980f1d78ce462e2d1ed6bc39ff35c8341f201"))
     ;; This is the commit used by the Ring Project.
-- 
2.15.0

Message #11 received at 29561 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: 29561 <at> debbugs.gnu.org
Cc: Ricardo Wurmus <rekado <at> elephly.net>
Subject: [PATCH 4/4] gnu: Add bluez-alsa.
Date: Mon,  4 Dec 2017 12:46:43 +0100

* gnu/packages/audio.scm (bluez-alsa): New variable.
---
 gnu/packages/audio.scm | 49 +++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 49 insertions(+)

diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index 8e0ad0a87..df7031f54 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -63,6 +63,7 @@
   #:use-module (gnu packages image)
   #:use-module (gnu packages ncurses)
   #:use-module (gnu packages qt)
+  #:use-module (gnu packages libbsd)
   #:use-module (gnu packages linux)
   #:use-module (gnu packages llvm)
   #:use-module (gnu packages mp3) ;taglib
@@ -72,6 +73,7 @@
   #:use-module (gnu packages python)
   #:use-module (gnu packages rdf)
   #:use-module (gnu packages readline)
+  #:use-module (gnu packages telephony)
   #:use-module (gnu packages tls)
   #:use-module (gnu packages video)
   #:use-module (gnu packages vim) ;xxd
@@ -3028,6 +3030,53 @@ mixers.")
 (define-public python2-pyalsaaudio
   (package-with-python2 python-pyalsaaudio))
 
+(define-public bluez-alsa
+  (package
+    (name "bluez-alsa")
+    (version "1.2.0")
+    (source (origin
+              ;; The tarballs are mere snapshots and don't contain a
+              ;; bootstrapped build system.
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/Arkq/bluez-alsa.git")
+                    (commit (string-append "v" version))))
+              (sha256
+               (base32
+                "1qinf41wl2ihx54zmmhanycihwjkn7dn1cicq6pp4rqbiv79b95x"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-before 'configure 'bootstrap
+           (lambda _
+             (zero? (system* "autoreconf" "-vif")))))))
+    (native-inputs
+     `(("autoconf" ,autoconf)
+       ("automake" ,automake)
+       ("libtool" ,libtool)
+       ("pkg-config" ,pkg-config)))
+    (inputs
+     `(("alsa-lib" ,alsa-lib)
+       ("bluez" ,bluez)
+       ("glib" ,glib)
+       ("libbsd" ,libbsd)
+       ("ncurses" ,ncurses)
+       ("ortp" ,ortp)
+       ("sbc" ,sbc)))
+    (home-page "https://github.com/Arkq/bluez-alsa")
+    (synopsis "Bluetooth ALSA backend")
+    (description "This project is a rebirth of a direct integration between
+Bluez and ALSA.  Since Bluez >= 5, the build-in integration has been removed
+in favor of 3rd party audio applications.  From now on, Bluez acts as a
+middleware between an audio application, which implements Bluetooth audio
+profile, and a Bluetooth audio device.  BlueALSA registers all known Bluetooth
+audio profiles in Bluez, so in theory every Bluetooth device (with audio
+capabilities) can be connected.  In order to access the audio stream, one has
+to connect to the ALSA PCM device called @code{bluealsa}.  The device is based
+on the ALSA software PCM plugin.")
+    (license license:expat)))
+
 (define-public snd
   (package
     (name "snd")
-- 
2.15.0

Message #14 received at 29561 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: 29561 <at> debbugs.gnu.org
Cc: Ricardo Wurmus <rekado <at> elephly.net>
Subject: [PATCH 3/4] gnu: Add ortp.
Date: Mon,  4 Dec 2017 12:46:42 +0100

* gnu/packages/telephony.scm (ortp): New variable.
---
 gnu/packages/telephony.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/telephony.scm b/gnu/packages/telephony.scm
index 6fd40d617..cf1ab93c3 100644
--- a/gnu/packages/telephony.scm
+++ b/gnu/packages/telephony.scm
@@ -272,6 +272,29 @@ and a supporting cryptographic kernel.")
 Communications softwares like linphone.")
     (license license:gpl2+)))
 
+(define-public ortp
+  (package
+    (name "ortp")
+    (version "0.27.0")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "https://download.savannah.nongnu.org/"
+                                  "releases/linphone/ortp/sources/ortp-"
+                                  version ".tar.gz"))
+              (sha256
+               (base32
+                "1by0dqdqrj5avzcvjws30g8v5sa61wj12x00sxw0kn1smcrshqgb"))))
+    (build-system gnu-build-system)
+    (inputs
+     `(("bctoolbox" ,bctoolbox)))
+    (native-inputs
+     `(("pkg-config" ,pkg-config)))
+    (home-page "https://linphone.org/")
+    (synopsis "Implementation of the Real-time transport protocol")
+    (description "oRTP is a library implementing the Real-time transport
+protocol (RFC 3550).")
+    (license license:lgpl2.1+)))
+
 (define-public libiax2
   (let ((commit "0e5980f1d78ce462e2d1ed6bc39ff35c8341f201"))
     ;; This is the commit used by the Ring Project.
-- 
2.15.0

Message #17 received at 29561 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: 29561 <at> debbugs.gnu.org
Cc: Ricardo Wurmus <rekado <at> elephly.net>
Subject: [PATCH 1/4] gnu: mbedtls-apache: Build shared library.
Date: Mon,  4 Dec 2017 12:46:40 +0100

* gnu/packages/tls.scm (mbedtls-apache)[arguments]: Enable building of shared
library.
---
 gnu/packages/tls.scm | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/gnu/packages/tls.scm b/gnu/packages/tls.scm
index 23b5cc993..d8cc1ccbc 100644
--- a/gnu/packages/tls.scm
+++ b/gnu/packages/tls.scm
@@ -815,6 +815,9 @@ then ported to the GNU / Linux environment.")
         (base32
          "11wnj34rfqxjggmdgf042i49lr6civgbqwv2p7p8bn6k2919vg4r"))))
     (build-system cmake-build-system)
+    (arguments
+     `(#:configure-flags
+       (list "-DUSE_SHARED_MBEDTLS_LIBRARY=ON")))
     (native-inputs
      `(("perl" ,perl)))
     (synopsis "Small TLS library")
-- 
2.15.0

Message #20 received at 29561 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: 29561 <at> debbugs.gnu.org
Subject: Re: [bug#29561] [PATCH 4/4] gnu: Add bluez-alsa.
Date: Mon, 4 Dec 2017 14:09:31 -0500

[Message part 1 (text/plain, inline)]

On Mon, Dec 04, 2017 at 12:46:43PM +0100, Ricardo Wurmus wrote:
> * gnu/packages/audio.scm (bluez-alsa): New variable.

> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (add-before 'configure 'bootstrap
> +           (lambda _
> +             (zero? (system* "autoreconf" "-vif")))))))

I know that we are to do these bootstrapping phases after the unpack
phase, rather than before the configure phase, as described here:

https://lists.gnu.org/archive/html/guix-devel/2017-07/msg00101.html

Otherwise these patches LGTM.

[signature.asc (application/pgp-signature, inline)]

Message #25 received at 29561-done <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Leo Famulari <leo <at> famulari.name>
Cc: 29561-done <at> debbugs.gnu.org
Subject: Re: [bug#29561] [PATCH 4/4] gnu: Add bluez-alsa.
Date: Mon, 04 Dec 2017 20:55:51 +0100

Leo Famulari <leo <at> famulari.name> writes:

> On Mon, Dec 04, 2017 at 12:46:43PM +0100, Ricardo Wurmus wrote:
>> * gnu/packages/audio.scm (bluez-alsa): New variable.
>
>> +    (build-system gnu-build-system)
>> +    (arguments
>> +     `(#:phases
>> +       (modify-phases %standard-phases
>> +         (add-before 'configure 'bootstrap
>> +           (lambda _
>> +             (zero? (system* "autoreconf" "-vif")))))))
>
> I know that we are to do these bootstrapping phases after the unpack
> phase, rather than before the configure phase, as described here:
>
> https://lists.gnu.org/archive/html/guix-devel/2017-07/msg00101.html

Ah, thanks for the reminder and for the review.
I’ll push these patches after making this correction.

-- 
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

Message #28 received at 29561 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: 29561 <at> debbugs.gnu.org
Subject: Re: [bug#29561] [PATCH 2/4] gnu: Add bctoolbox.
Date: Fri, 08 Dec 2017 10:31:35 +0100

Ricardo Wurmus <rekado <at> elephly.net> skribis:

> * gnu/packages/telephony.scm (bctoolbox): New variable.

[...]

> +    (synopsis "Utilities library for linphone software")

“Linphone” should be capitalized.

Also, I suspect it should be just “Linphone” or “the Linphone program”,
no?

> +    (description "BCtoolbox is a utilities library used by Belledonne
> +Communications softwares like linphone.")
                          ^
Singular.

It would be nice to expound a bit, if possible.

Otherwise LGTM.

Thanks!

Ludo’.

Message #31 received at 29561 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: 29561 <at> debbugs.gnu.org
Subject: Re: [bug#29561] [PATCH 3/4] gnu: Add ortp.
Date: Fri, 08 Dec 2017 10:33:19 +0100

Ricardo Wurmus <rekado <at> elephly.net> skribis:

> * gnu/packages/telephony.scm (ortp): New variable.

[...]

> +              (uri (string-append "https://download.savannah.nongnu.org/"
> +                                  "releases/linphone/ortp/sources/ortp-"
> +                                  version ".tar.gz"))

Should be mirror://savannah.

> +    (home-page "https://linphone.org/")
> +    (synopsis "Implementation of the Real-time transport protocol")
> +    (description "oRTP is a library implementing the Real-time transport
> +protocol (RFC 3550).")

Perhaps add something like “It is used by applications such as FOO and
BAR to broadcast stuff in real time.”  :-)

Otherwise LGTM, thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.