From unknown Wed Jun 18 00:27:57 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#29557 <29557@debbugs.gnu.org> To: bug#29557 <29557@debbugs.gnu.org> Subject: Status: lookup_basic_face: Should we add VERTICAL_BORDER_FACE_ID? Reply-To: bug#29557 <29557@debbugs.gnu.org> Date: Wed, 18 Jun 2025 07:27:57 +0000 retitle 29557 lookup_basic_face: Should we add VERTICAL_BORDER_FACE_ID? reassign 29557 emacs submitter 29557 Keith David Bershatsky severity 29557 wishlist thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 03 20:59:54 2017 Received: (at submit) by debbugs.gnu.org; 4 Dec 2017 01:59:54 +0000 Received: from localhost ([127.0.0.1]:44040 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eLg30-0001b2-0P for submit@debbugs.gnu.org; Sun, 03 Dec 2017 20:59:54 -0500 Received: from eggs.gnu.org ([208.118.235.92]:55919) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eLg2x-0001an-HK for submit@debbugs.gnu.org; Sun, 03 Dec 2017 20:59:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eLg2r-0003cP-4b for submit@debbugs.gnu.org; Sun, 03 Dec 2017 20:59:45 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:57982) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eLg2r-0003cB-1h for submit@debbugs.gnu.org; Sun, 03 Dec 2017 20:59:45 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46875) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eLg2p-0002hj-Rw for bug-gnu-emacs@gnu.org; Sun, 03 Dec 2017 20:59:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eLg2k-0003YQ-SH for bug-gnu-emacs@gnu.org; Sun, 03 Dec 2017 20:59:43 -0500 Received: from gateway31.websitewelcome.com ([192.185.144.91]:34922) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eLg2k-0003XC-Kq for bug-gnu-emacs@gnu.org; Sun, 03 Dec 2017 20:59:38 -0500 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway31.websitewelcome.com (Postfix) with ESMTP id 707B93061B0 for ; Sun, 3 Dec 2017 19:59:36 -0600 (CST) Received: from gator3053.hostgator.com ([50.87.144.69]) by cmsmtp with SMTP id Lg2heAJlxmFImLg2iet66L; Sun, 03 Dec 2017 19:59:36 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lawlist.com ; s=default; h=Content-Type:MIME-Version:Subject:To:From:Message-ID:Date: Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=0QhM5wERO+1P7Zns3WVUhfIi8GlHl6n7wLoUMUnBl34=; b=ATsdlCLCIXxOW0lNnSdRichuhK kzZuPLeDe/4wDAYYe55dPMYrhinMk2gGebn9R5OAKsCN115uszXRno2ZBUITwDInilS+Pj1oeOb3N 3X9jW+s4gv4CsiLA4Bn/inCKJbuQnAXIHlUwWIdy8jQYQw1SDcRjLcdux8u1WtNMbQw5yDVDRMZzE t1BZsiwrCmioC33QokUVXNBU9mJ4jyseVoUbWkGzHmH/laagprMS4T7uoYJBNYCv/7eTCI/jv0qst jJqsDfJhy1996nQ+qqJ7AAfpk1d84DeWdGSVJPQ7PpOtc3nMIA93M3MvRCEdw2+dnMvEVP5133cNZ nYtruaaQ==; Received: from cpe-45-48-239-195.socal.res.rr.com ([45.48.239.195]:51918 helo=server.private) by gator3053.hostgator.com with esmtpsa (TLSv1:DHE-RSA-AES256-SHA:256) (Exim 4.89) (envelope-from ) id 1eLg2h-000fyf-Kb for bug-gnu-emacs@gnu.org; Sun, 03 Dec 2017 19:59:35 -0600 Date: Sun, 03 Dec 2017 17:59:34 -0800 Message-ID: From: Keith David Bershatsky To: Emacs Bug Reports Subject: lookup_basic_face: Should we add VERTICAL_BORDER_FACE_ID? MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator3053.hostgator.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lawlist.com X-BWhitelist: no X-Source-IP: 45.48.239.195 X-Source-L: No X-Exim-ID: 1eLg2h-000fyf-Kb X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: cpe-45-48-239-195.socal.res.rr.com (server.private) [45.48.239.195]:51918 X-Source-Auth: lawlist X-Email-Count: 1 X-Source-Cap: bGF3bGlzdDtsYXdsaXN0O2dhdG9yMzA1My5ob3N0Z2F0b3IuY29t X-Local-Domain: yes X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) I had assumed that VERTICAL_BORDER_FACE_ID was a basic face (see dispextern.h at line 1750). However, it is not identified as such within lookup_basic_face. Is this something that should be added? Without it, Emacs will throw an error if someone tries to look it up and its not there. case VERTICAL_BORDER_FACE_ID: name = Qvertical_border; break; Thanks, Keith From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 04 10:45:50 2017 Received: (at 29557-done) by debbugs.gnu.org; 4 Dec 2017 15:45:50 +0000 Received: from localhost ([127.0.0.1]:45651 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eLswG-0002qA-Je for submit@debbugs.gnu.org; Mon, 04 Dec 2017 10:45:50 -0500 Received: from eggs.gnu.org ([208.118.235.92]:42955) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eLswF-0002i8-3G for 29557-done@debbugs.gnu.org; Mon, 04 Dec 2017 10:45:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eLsw7-0002Cw-7j for 29557-done@debbugs.gnu.org; Mon, 04 Dec 2017 10:45:41 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_40,T_RP_MATCHES_RCVD, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:56582) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eLsw6-0002Cm-Tr; Mon, 04 Dec 2017 10:45:39 -0500 Received: from [176.228.60.248] (port=4272 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eLsw6-0005LT-9x; Mon, 04 Dec 2017 10:45:38 -0500 Date: Mon, 04 Dec 2017 17:45:26 +0200 Message-Id: <83y3mixzs9.fsf@gnu.org> From: Eli Zaretskii To: Keith David Bershatsky In-reply-to: (message from Keith David Bershatsky on Sun, 03 Dec 2017 17:59:34 -0800) Subject: Re: bug#29557: lookup_basic_face: Should we add VERTICAL_BORDER_FACE_ID? References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 29557-done Cc: 29557-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > Date: Sun, 03 Dec 2017 17:59:34 -0800 > From: Keith David Bershatsky > > I had assumed that VERTICAL_BORDER_FACE_ID was a basic face (see dispextern.h at line 1750). However, it is not identified as such within lookup_basic_face. Is this something that should be added? Without it, Emacs will throw an error if someone tries to look it up and its not there. Yes, it's an omission (and a very old one). Fixed on the master branch. Thanks for reporting this. From unknown Wed Jun 18 00:27:57 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 02 Jan 2018 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator