Subject: bug#29557: closed (Re: bug#29557: lookup_basic_face: Should we add VERTICAL_BORDER_FACE_ID?)

From: [email-masked] (GNU bug Tracking System)
Date: Mon, 04 Dec 2017 15:46:03 +0000

Your bug report

#29557: lookup_basic_face:  Should we add VERTICAL_BORDER_FACE_ID?

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
29557: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=29557
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#29557: lookup_basic_face: Should we add VERTICAL_BORDER_FACE_ID?
From: Eli Zaretskii <[email-masked]>
To: Keith David Bershatsky <[email-masked]>
Cc: [email-masked]
Date: Mon, 04 Dec 2017 17:45:26 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

> Date: Sun, 03 Dec 2017 17:59:34 -0800
> From: Keith David Bershatsky <[email-masked]>
> 
> I had assumed that VERTICAL_BORDER_FACE_ID was a basic face (see dispextern.h at line 1750).  However, it is not identified as such within lookup_basic_face.  Is this something that should be added?  Without it, Emacs will throw an error if someone tries to look it up and its not there.

Yes, it's an omission (and a very old one).

Fixed on the master branch.  Thanks for reporting this.

Subject: lookup_basic_face: Should we add VERTICAL_BORDER_FACE_ID?
From: Keith David Bershatsky <[email-masked]>
To: Emacs Bug Reports <[email-masked]>
Date: Sun, 03 Dec 2017 17:59:34 -0800
List-Id: <debbugs-submit.debbugs.gnu.org>

I had assumed that VERTICAL_BORDER_FACE_ID was a basic face (see dispextern.h at line 1750).  However, it is not identified as such within lookup_basic_face.  Is this something that should be added?  Without it, Emacs will throw an error if someone tries to look it up and its not there.

case VERTICAL_BORDER_FACE_ID: name = Qvertical_border; break;

Thanks,

Keith