Subject: Re: bug#29557: lookup_basic_face: Should we add VERTICAL_BORDER_FACE_ID?

From: Eli Zaretskii <[email-masked]>
Date: Mon, 04 Dec 2017 17:45:26 +0200

> Date: Sun, 03 Dec 2017 17:59:34 -0800
> From: Keith David Bershatsky <[email-masked]>
> 
> I had assumed that VERTICAL_BORDER_FACE_ID was a basic face (see dispextern.h at line 1750).  However, it is not identified as such within lookup_basic_face.  Is this something that should be added?  Without it, Emacs will throw an error if someone tries to look it up and its not there.

Yes, it's an omission (and a very old one).

Fixed on the master branch.  Thanks for reporting this.