GNU bug report logs - #29541
27.0.50; Use generic function when restoring eieio-persistent, remove validation

Previous Next

Full log

Message #10 received at 29541 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eric Abrahamsen <eric <at> ericabrahamsen.net>
Cc: 29541 <at> debbugs.gnu.org
Subject: Re: bug#29541: 27.0.50;
 Use generic function when restoring eieio-persistent, remove
 validation
Date: Mon, 24 Jun 2019 22:28:44 +0200

Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:

> The attached patch is a proposal that would replace the function
> `eieio-persistent-convert-list-to-object' with a generic method
> `eieio-persistent-make-instance'. It also removes all slot validation in
> the read process.
>
> Considerations:
>
> 1. `object-write' is already a method. That means the writing process
> can be overridden and customized, but the reading process can't, which
> removes most of the benefit of being able to override the write. This
> would allow "matching" methods for writing and reading.

This makes sense, and having a method instead of a function here
certainly seems cleaner...

Did anybody with a deeper knowledge of the eieio machinery provide any
feedback?  It's a quite large patch...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.