Subject: Re: [bug#29536] [PATCH] gnu: Add cava.

From: [email-masked] (Ludovic Courtès)
Date: Sat, 20 Jan 2018 00:51:46 +0100

Heya Oleg,

Oleg Pykhalov <[email-masked]> skribis:

>>>From af48537fc5c6af11993db03004a937251d8d60e9 Mon Sep 17 00:00:00 2001
> From: Oleg Pykhalov <[email-masked]>
> Date: Sat, 2 Dec 2017 22:36:36 +0300
> Subject: [PATCH] gnu: Add cava.
>
> * gnu/packages/audio.scm (cava): New variable.

[...]

> +       (modify-phases %standard-phases
> +         (add-after 'unpack 'bootstrap
> +           (lambda _
> +             (setenv "HOME" (getcwd))
> +             (zero? (system* "sh" "autogen.sh"))))

Please use ‘invoke’ instead of ‘system*’.

> +         (add-before 'build 'make-cava-ldflags
> +           (lambda _ (mkdir-p (string-append (assoc-ref %outputs "out") "/lib"))))

Please use:

  (lambda* (#:key outputs #:allow-other-keys)
    … outputs …)

> +         (add-after 'install 'data
> +           (lambda _ (for-each (lambda (file)
> +                            (install-file file (string-append
> +                                                (assoc-ref %outputs "out")
> +                                                "/share/doc/examples")))
> +                          (find-files "example_files")))))))

Likewise.

> +    (home-page "https://karlstav.github.io/cava/")
> +    (synopsis "CLI audio visualizer for Alsa, MPD and Pulseaudio")

Rather: “Console audio visualizer for ALSA, MPD, and PulseAudio”.

> +    (description "@code{cava} provides a command line audio visualizer for
> +MPD, Alsa and Pulseaudio.")

Based on their README:

  C.A.V.A. is a bar audio spectrum visualizer for the terminal using
  ALSA, MPD, PulseAudio, or a FIFO buffer as its input.

OK with these changes, thank you!

Ludo’.