Subject: Re: [bug#29536] [PATCH] gnu: Add cava.

From: ng0 <[email-masked]>
Date: Sat, 2 Dec 2017 22:07:08 +0000

Hi,

which patch would someone review? Aren't they supposed to be one patch?
We don't have cava (as you are obviously adding it) and the 2nd patch
makes a change to cava.
We try to logically group patches, and this is a case where having it
in one patch makes sense, when a new package is getting added.

Oleg Pykhalov transcribed 2.4K bytes:
> From 972835bcf71b67d2bc12c3d7a6bb80f51f0d0efa Mon Sep 17 00:00:00 2001
> From: Oleg Pykhalov <[email-masked]>
> Date: Sat, 2 Dec 2017 22:36:36 +0300
> Subject: [PATCH] gnu: Add cava.
> 
> * gnu/packages/audio.scm (cava): New variable.
> ---
>  gnu/packages/audio.scm | 43 +++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 43 insertions(+)
> 
> diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
> index da9314392..347f379e3 100644
> --- a/gnu/packages/audio.scm
> +++ b/gnu/packages/audio.scm
> @@ -3087,3 +3087,46 @@ mixers.")
>  customized and extended using either the s7 Scheme implementation (included in
>  the Snd sources), Ruby, or Forth.")
>      (license (license:non-copyleft "file://COPYING"))))
> +
> +(define-public cava
> +  (package
> +    (name "cava")
> +    (version "0.6.0")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> +                    "https://github.com/karlstav/cava/archive/"
> +                    version ".tar.gz"))
> +              (file-name (string-append name "-" version ".tar.gz"))
> +              (sha256
> +               (base32
> +                "1p24lz3h4d0h82ffylqr7mq8a8x1c66flm2r2bsv1liw51n1rma2"))))
> +    (build-system gnu-build-system)
> +    (native-inputs
> +     `(("autoconf" ,autoconf)
> +       ("automake" ,automake)
> +       ("libtool" ,libtool)))
> +    (inputs
> +     `(("fftw"       ,fftw)
> +       ("ncurses"    ,ncurses)
> +       ("pulseaudio" ,pulseaudio)))
> +    (arguments
> +     `(#:configure-flags
> +       (list (string-append "PREFIX=" %output)
> +             (string-append "FONT_DIR=" %output "/usr/share/consolefonts"))
> +       #:make-flags ; Add $libdir to the RUNPATH of all the executables.
> +       (let ((lib (string-append %output "/lib")))
> +         (list (string-append "cava_LDFLAGS = -L" lib " -Wl,-rpath " lib)))
> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-after 'unpack 'bootstrap
> +           (lambda _
> +             (setenv "HOME" (getcwd))
> +             (zero? (system* "sh" "autogen.sh"))))
> +         (add-before 'build 'make-cava-ldflags
> +           (lambda _ (mkdir-p (string-append (assoc-ref %outputs "out") "/lib")))))))
> +    (home-page "https://karlstav.github.io/cava/")
> +    (synopsis "CLI audio visualizer for Alsa, MPD and Pulseaudio")
> +    (description "@code{cava} provides a command line audio visualizer for
> +MPD, Alsa and Pulseaudio.")
> +    (license license:expat)))
> -- 
> 2.15.0
> 
> 
> 
> 
> 

-- 
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://c.n0.is/ng0_pubkeys/tree/keys
  WWW: https://n0.is