From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 02 14:38:24 2017 Received: (at submit) by debbugs.gnu.org; 2 Dec 2017 19:38:24 +0000 Received: from localhost ([127.0.0.1]:42209 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eLDcB-0006ND-Oa for submit@debbugs.gnu.org; Sat, 02 Dec 2017 14:38:24 -0500 Received: from eggs.gnu.org ([208.118.235.92]:38435) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eLDcA-0006N0-3Q for submit@debbugs.gnu.org; Sat, 02 Dec 2017 14:38:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eLDc3-0003Cq-OZ for submit@debbugs.gnu.org; Sat, 02 Dec 2017 14:38:12 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: ** X-Spam-Status: No, score=2.5 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID,URIBL_BLACK autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:39346) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eLDc3-0003CP-Lf for submit@debbugs.gnu.org; Sat, 02 Dec 2017 14:38:11 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57598) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eLDc2-0004II-9O for guix-patches@gnu.org; Sat, 02 Dec 2017 14:38:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eLDbx-00036l-Lm for guix-patches@gnu.org; Sat, 02 Dec 2017 14:38:09 -0500 Received: from mail-lf0-x232.google.com ([2a00:1450:4010:c07::232]:44844) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eLDbx-00031h-Bp for guix-patches@gnu.org; Sat, 02 Dec 2017 14:38:05 -0500 Received: by mail-lf0-x232.google.com with SMTP id x204so15077809lfa.11 for ; Sat, 02 Dec 2017 11:38:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version:content-disposition :content-description; bh=Owy7Ac2keOA+b+ehYtM2LFuL9cPo5lAG5gzeJxhM2P4=; b=eeHpG6IeiqjvbL77Zk+0HG0zeaxSUJzUoduuMaqK2p7jsynvgWmEYIB6WfFopqXyqM 6/tu19Lkizi8GRHzvISpgr9v6cMBERQ9bG73zbIQTDjqdgJt3sCvZWJ6NpTrKigdtWUG bIvI7zT/g5nNZGX+a7lSe587XMiboMHkXvP1ykZG9buNzYRJCM40CVITjWs2a16ydVTs Nxkp+WFuO5+6UD8l3nvBjq3OMBC+aqYpOZc5NuwD/4Jffzw+qr9hui5c/tO5h5VQtD4C Amv8j/RgRtT2uyTp5w1ZzzVGMWGR7NaGGO9vNLK2oVDhaVcaborlpnGJ9gOlnROqKEo4 sR4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-disposition:content-description; bh=Owy7Ac2keOA+b+ehYtM2LFuL9cPo5lAG5gzeJxhM2P4=; b=twFUgwH29UkJb8AgEmvN4YDozq5vq04v5EV7kb62jkPX7L6pxRZMKhMqt6AkZzqy6c 48GIwycK0DiK/ccO+sbOonHC4dqX8+eS6UhCl6Pz3XKUWeHNaZnfYp+JE7dA84dlavkU oH/pcODip6NJDImh3M3oE/E5HiYfWxSIcEYmd079wVkSh7TP/Su3jiWepJJz5GN8vsL+ lB0tMyxAeYIMNtTQi584XQ/MKLV7r4PpUvA3HjSM2CzQGJGVVZ20Nskuj9HGwrRObYDL /Ssnu3RQRiEhGC1jxaLv2lJ+nrGVleRQoRYL3AP72lFrjGjYxlN07AT/uc6qu2qqpdHs E8Lw== X-Gm-Message-State: AJaThX5nmnkjnQqXLCELwMfjEN541w8x2zRhZoBsgBEghnKv8Maw/Uaf PveOBzCIzND6tvC47JjU2EBlVA== X-Google-Smtp-Source: AGs4zMZZ9U6HZgs07yVGlGcq8cnc51QwC8ixfhCe7r0Df8DUeg1dwt8S6haue3T6C4FbRclfSBYhiQ== X-Received: by 10.46.41.68 with SMTP id u65mr7411512lje.47.1512243481331; Sat, 02 Dec 2017 11:38:01 -0800 (PST) Received: from magnolia (ppp78-37-138-34.pppoe.avangarddsl.ru. [78.37.138.34]) by smtp.gmail.com with ESMTPSA id p25sm1658164lfg.49.2017.12.02.11.38.00 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 02 Dec 2017 11:38:00 -0800 (PST) From: Oleg Pykhalov To: guix-patches@gnu.org Subject: [PATCH] gnu: Add cava. Date: Sat, 02 Dec 2017 22:37:53 +0300 Message-ID: <87efocor8u.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/x-patch Content-Disposition: inline; filename=0001-gnu-Add-cava.patch Content-Description: [PATCH] gnu: Add cava. X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) >From 972835bcf71b67d2bc12c3d7a6bb80f51f0d0efa Mon Sep 17 00:00:00 2001 From: Oleg Pykhalov Date: Sat, 2 Dec 2017 22:36:36 +0300 Subject: [PATCH] gnu: Add cava. * gnu/packages/audio.scm (cava): New variable. --- gnu/packages/audio.scm | 43 +++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 43 insertions(+) diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm index da9314392..347f379e3 100644 --- a/gnu/packages/audio.scm +++ b/gnu/packages/audio.scm @@ -3087,3 +3087,46 @@ mixers.") customized and extended using either the s7 Scheme implementation (included in the Snd sources), Ruby, or Forth.") (license (license:non-copyleft "file://COPYING")))) + +(define-public cava + (package + (name "cava") + (version "0.6.0") + (source (origin + (method url-fetch) + (uri (string-append + "https://github.com/karlstav/cava/archive/" + version ".tar.gz")) + (file-name (string-append name "-" version ".tar.gz")) + (sha256 + (base32 + "1p24lz3h4d0h82ffylqr7mq8a8x1c66flm2r2bsv1liw51n1rma2")))) + (build-system gnu-build-system) + (native-inputs + `(("autoconf" ,autoconf) + ("automake" ,automake) + ("libtool" ,libtool))) + (inputs + `(("fftw" ,fftw) + ("ncurses" ,ncurses) + ("pulseaudio" ,pulseaudio))) + (arguments + `(#:configure-flags + (list (string-append "PREFIX=" %output) + (string-append "FONT_DIR=" %output "/usr/share/consolefonts")) + #:make-flags ; Add $libdir to the RUNPATH of all the executables. + (let ((lib (string-append %output "/lib"))) + (list (string-append "cava_LDFLAGS = -L" lib " -Wl,-rpath " lib))) + #:phases + (modify-phases %standard-phases + (add-after 'unpack 'bootstrap + (lambda _ + (setenv "HOME" (getcwd)) + (zero? (system* "sh" "autogen.sh")))) + (add-before 'build 'make-cava-ldflags + (lambda _ (mkdir-p (string-append (assoc-ref %outputs "out") "/lib"))))))) + (home-page "https://karlstav.github.io/cava/") + (synopsis "CLI audio visualizer for Alsa, MPD and Pulseaudio") + (description "@code{cava} provides a command line audio visualizer for +MPD, Alsa and Pulseaudio.") + (license license:expat))) -- 2.15.0 From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 02 14:41:03 2017 Received: (at 29536) by debbugs.gnu.org; 2 Dec 2017 19:41:03 +0000 Received: from localhost ([127.0.0.1]:42214 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eLDep-0006Rn-Aq for submit@debbugs.gnu.org; Sat, 02 Dec 2017 14:41:03 -0500 Received: from mail-lf0-f46.google.com ([209.85.215.46]:37821) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eLDen-0006RD-AO for 29536@debbugs.gnu.org; Sat, 02 Dec 2017 14:41:01 -0500 Received: by mail-lf0-f46.google.com with SMTP id a12so15109637lfe.4 for <29536@debbugs.gnu.org>; Sat, 02 Dec 2017 11:41:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version:content-disposition :content-description; bh=YqNybCk90OuJZZnnD3GF2Z1jkbtKGqHHxzz+knk4jGk=; b=mwkISroHZ+Sc5yi8iQSCjIWHEHnEfHn/Kb1DKxkjvE+bQFJvGSq3epTgbsGJiptPrX PE3hQNsk/5iLlcPI/pu8yyqk5LN4wxSZH4CoQvbvahwO1FxUJhtaT2aMCxl5QkilZhIJ 5ahapi7APVtLzWTj73qRmF01f7knubgmtCfZaCFMcCGhj8sMS5C5OIoGnnPL0k0eXb49 LZmSPYE3UAEvpjePWhB7Zp4zQFZjmOcTCRoGZSuDdZNvevIWuU7dDq1ROMdSD+MzMuck O9atJXV40FmWkQv6JXYixtJlIxglNyreO3B1dI6KvlcbYFC9432PWMmyLojx8YbmNFvD P4cQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-disposition:content-description; bh=YqNybCk90OuJZZnnD3GF2Z1jkbtKGqHHxzz+knk4jGk=; b=rDgd1MXGo6FO9mm0jROwa9WCDy8glJCyBJq6aYzGzokPYrHJejrRvqse0KmUVjU+2j 8GPkjafgwYQo60wZu0V1cpAmrFh/D2P1XCLRRB8J2La/8XpRWMdW2j1K5gqD91bbpyhF aBmrhBY5J81SXsvV2DWdmbfuOxhJP/0UJDJs7kopxG5NFgqn1erzBMBjPLLILtP8TAas jDOK9lFxuuFuQDaA4ixpzO0s5pGqqJD/vRuVKH+HXJOW75TpF40r1bXMX9eh1BhejG4f YvuZXQKCEd1gOPMh+WOI0PyBmJmC3befWAy2zuCeXv3bMNdXlMQ73K+0mMXH8aXHVJGK TODw== X-Gm-Message-State: AJaThX4w/j1Hcvc2VIHLtSLgwu6216qV7dxXkAxs+mcKB6PBfP4IV0m9 o1V1IouNtaP5QUMZnRyCucB/Ew== X-Google-Smtp-Source: AGs4zMbStr2bNi5vgMIbGhooNkYejShUKRhEgwdgAIWV9MFORXJHgKSvh2XkHv8v/H5PDYkeJOcSog== X-Received: by 10.46.57.10 with SMTP id g10mr6446158lja.77.1512243654921; Sat, 02 Dec 2017 11:40:54 -0800 (PST) Received: from magnolia (ppp78-37-138-34.pppoe.avangarddsl.ru. [78.37.138.34]) by smtp.gmail.com with ESMTPSA id r2sm1652534lff.8.2017.12.02.11.40.53 for <29536@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 02 Dec 2017 11:40:54 -0800 (PST) From: Oleg Pykhalov To: bug#29536 <29536@debbugs.gnu.org> Subject: [PATCH] squash! gnu: Add cava. Date: Sat, 02 Dec 2017 22:40:50 +0300 Message-ID: <87bmjgor3x.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/x-patch Content-Disposition: inline; filename=0001-squash-gnu-Add-cava.patch Content-Description: [PATCH] squash! gnu: Add cava. X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 29536 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) >From a9d052f3ef8abcb830f279a09d99c9b6e7a0ad02 Mon Sep 17 00:00:00 2001 From: Oleg Pykhalov Date: Sat, 2 Dec 2017 22:39:01 +0300 Subject: [PATCH] squash! gnu: Add cava. --- gnu/packages/audio.scm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm index 347f379e3..e4481281f 100644 --- a/gnu/packages/audio.scm +++ b/gnu/packages/audio.scm @@ -3105,7 +3105,7 @@ the Snd sources), Ruby, or Forth.") (native-inputs `(("autoconf" ,autoconf) ("automake" ,automake) - ("libtool" ,libtool))) + ("libtool" ,libtool))) (inputs `(("fftw" ,fftw) ("ncurses" ,ncurses) @@ -3114,7 +3114,7 @@ the Snd sources), Ruby, or Forth.") `(#:configure-flags (list (string-append "PREFIX=" %output) (string-append "FONT_DIR=" %output "/usr/share/consolefonts")) - #:make-flags ; Add $libdir to the RUNPATH of all the executables. + #:make-flags (let ((lib (string-append %output "/lib"))) (list (string-append "cava_LDFLAGS = -L" lib " -Wl,-rpath " lib))) #:phases -- 2.15.0 From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 02 17:07:14 2017 Received: (at 29536) by debbugs.gnu.org; 2 Dec 2017 22:07:14 +0000 Received: from localhost ([127.0.0.1]:42256 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eLFwI-0001F3-3S for submit@debbugs.gnu.org; Sat, 02 Dec 2017 17:07:14 -0500 Received: from aibo.runbox.com ([91.220.196.211]:55602) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eLFwF-0001Eu-T5 for 29536@debbugs.gnu.org; Sat, 02 Dec 2017 17:07:12 -0500 Received: from [10.9.9.211] (helo=mailfront11.runbox.com) by mailtransmit03.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1eLFwE-0006O7-AC; Sat, 02 Dec 2017 23:07:10 +0100 Received: from dslb-088-078-089-228.088.078.pools.vodafone-ip.de ([88.78.89.228] helo=localhost) by mailfront11.runbox.com with esmtpsa (uid:892961 ) (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) id 1eLFwD-0006vJ-6f; Sat, 02 Dec 2017 23:07:09 +0100 Date: Sat, 2 Dec 2017 22:07:08 +0000 From: ng0 To: Oleg Pykhalov Subject: Re: [bug#29536] [PATCH] gnu: Add cava. Message-ID: <20171202220708.cg6xnqca7ovul5ng@abyayala> References: <87efocor8u.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="qs2htkes6n3m7lh5" Content-Disposition: inline In-Reply-To: <87efocor8u.fsf@gmail.com> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 29536 Cc: 29536@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) --qs2htkes6n3m7lh5 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, which patch would someone review? Aren't they supposed to be one patch? We don't have cava (as you are obviously adding it) and the 2nd patch makes a change to cava. We try to logically group patches, and this is a case where having it in one patch makes sense, when a new package is getting added. Oleg Pykhalov transcribed 2.4K bytes: > From 972835bcf71b67d2bc12c3d7a6bb80f51f0d0efa Mon Sep 17 00:00:00 2001 > From: Oleg Pykhalov > Date: Sat, 2 Dec 2017 22:36:36 +0300 > Subject: [PATCH] gnu: Add cava. >=20 > * gnu/packages/audio.scm (cava): New variable. > --- > gnu/packages/audio.scm | 43 +++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 43 insertions(+) >=20 > diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm > index da9314392..347f379e3 100644 > --- a/gnu/packages/audio.scm > +++ b/gnu/packages/audio.scm > @@ -3087,3 +3087,46 @@ mixers.") > customized and extended using either the s7 Scheme implementation (inclu= ded in > the Snd sources), Ruby, or Forth.") > (license (license:non-copyleft "file://COPYING")))) > + > +(define-public cava > + (package > + (name "cava") > + (version "0.6.0") > + (source (origin > + (method url-fetch) > + (uri (string-append > + "https://github.com/karlstav/cava/archive/" > + version ".tar.gz")) > + (file-name (string-append name "-" version ".tar.gz")) > + (sha256 > + (base32 > + "1p24lz3h4d0h82ffylqr7mq8a8x1c66flm2r2bsv1liw51n1rma2"))= )) > + (build-system gnu-build-system) > + (native-inputs > + `(("autoconf" ,autoconf) > + ("automake" ,automake) > + ("libtool" ,libtool))) > + (inputs > + `(("fftw" ,fftw) > + ("ncurses" ,ncurses) > + ("pulseaudio" ,pulseaudio))) > + (arguments > + `(#:configure-flags > + (list (string-append "PREFIX=3D" %output) > + (string-append "FONT_DIR=3D" %output "/usr/share/consolefon= ts")) > + #:make-flags ; Add $libdir to the RUNPATH of all the executables. > + (let ((lib (string-append %output "/lib"))) > + (list (string-append "cava_LDFLAGS =3D -L" lib " -Wl,-rpath " l= ib))) > + #:phases > + (modify-phases %standard-phases > + (add-after 'unpack 'bootstrap > + (lambda _ > + (setenv "HOME" (getcwd)) > + (zero? (system* "sh" "autogen.sh")))) > + (add-before 'build 'make-cava-ldflags > + (lambda _ (mkdir-p (string-append (assoc-ref %outputs "out") = "/lib"))))))) > + (home-page "https://karlstav.github.io/cava/") > + (synopsis "CLI audio visualizer for Alsa, MPD and Pulseaudio") > + (description "@code{cava} provides a command line audio visualizer f= or > +MPD, Alsa and Pulseaudio.") > + (license license:expat))) > --=20 > 2.15.0 >=20 >=20 >=20 >=20 >=20 --=20 GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588 GnuPG: https://c.n0.is/ng0_pubkeys/tree/keys WWW: https://n0.is --qs2htkes6n3m7lh5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEqIyK3RKYKNfqwC5S4i+bv+40hYgFAlojJAsACgkQ4i+bv+40 hYi4Rw//SAqGnT08mY9dyPzX9P2K/arEwcaj+hCJfMfA0SdCj3+PZ0xlfeWVVd1t 1E03/ztZTvpX3mMWdjhYF+fAc/u5xk8j5x87qSr9bV3+XW6WfmAtvHp7APvAv3wY KOO2vOQJ6S4N5pzvqT+8RlZSTkaS/r6ddsfpR61foY+feWNjfBDxc/1P0lShqVf+ 2CSPVV3+0rxywET9DCuKn+/ei++fyQYIQzJWfe+xvad0Tj7dKQ8z78uO0Lg5wo8E X5Wam4QjNUUfKHo61dBEYuXcLN76Z08bAdgzJqF1I8wcpvg2BVMf8G3l/EhmlhKS UQSn5lOAZqt25RM319px5Yrj5SNlmnc8ULa5evatfw9RVUZSlBoYv+r8ybHSdFMu 9Y+jTYFQPtXu2AWMl2CrNtvF3WoLuSAx6v5cgs73+4ibU5Ci42q2yio6k8lpXdh9 88wccSyJxDPhd+KFnD4oomiZOTPrr+XVZrUiAehMDv+SgpO/jhHefScx0B0ZksjI dnpi5AqW+1bnK8lSX+xOAUd2r59uv1LSqa0hFXF++Uc5w9e2aH140N1Jmyd5xyop bfxfnrpjsCQAsH1tK98EK8c/wLoK6kqZCeUJWDWrTEMbjQeX4aSKuoKFcZ1949UG f9RwdfyMPUCLHQ64Sy+IwNgkIyQjO+U20XAIDUqgzk82WSi4vUs= =fcnn -----END PGP SIGNATURE----- --qs2htkes6n3m7lh5-- From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 03 02:36:48 2017 Received: (at 29536) by debbugs.gnu.org; 3 Dec 2017 07:36:48 +0000 Received: from localhost ([127.0.0.1]:42391 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eLOpU-000754-6q for submit@debbugs.gnu.org; Sun, 03 Dec 2017 02:36:48 -0500 Received: from mail-lf0-f44.google.com ([209.85.215.44]:46416) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eLOpR-00074f-Hz for 29536@debbugs.gnu.org; Sun, 03 Dec 2017 02:36:46 -0500 Received: by mail-lf0-f44.google.com with SMTP id r143so15813756lfe.13 for <29536@debbugs.gnu.org>; Sat, 02 Dec 2017 23:36:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=FHuhUajUZNPFNtqhw7WhMfk5ia0XhkpuhZ801z8WI60=; b=a/TNt6DtyXdl/Atqa32wINeo6xh+FBhSARUs4koJUzujSb1SeJlS2QJXMBmDOEKoiD 0fPXr6yAJ3iC4Dj3btS6n2YRp/7gjIIfbZuA8P1d3xXld8zU4F058qoafmiycdujX4Bd cdAU097SV70F8Jd8bJMpNR0mBj9yg3k6eHGkGiHkI7wbyODPjqGC4Xrrqa5gCyORWZ62 9KDHvxeKjOW9/0MMzW7XzdQ6ZB2GqU+SuH3poSbCpnuyeo6uRxpG8xp1P4LvMTDZx1f3 gmpj78s5Wb7eK+BT6RhV18EcGMcgi1IPU+OwC5jl3jiNzGF0IjNUoiUlgw7F42Tj45xI f7pA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=FHuhUajUZNPFNtqhw7WhMfk5ia0XhkpuhZ801z8WI60=; b=G0JufOodTB7/g+KRfk81qfu3cqQ4fvT1uxFbLgKzwkoVgwidwipCn/0paLe1nDrtad IXJnhwHyAOF61LxBeAkwGC5roN7EbWJwdG6moqaMdK3wk6LJ8+UY/9D+59F7MtckFpi2 Y6bJ5ki+56WaYrwDIvxWVidTLgrm4WsvGWVAkufeZ1oevdvAssihiMX12Hg3ewVpy89F IbQjm/ZBCunUfFYcoJNUI3Si73rTrVQaaVWhzCEpaapfnIej6eg0GUckOcaZcDNTCgxZ 8pqEKPue+5SBI8mWDLTWj+K7M/m9tjsZaRDJpYSK+yPrB9rUqtlx9kGE/NeusUb6fMY3 TNEA== X-Gm-Message-State: AJaThX6hfRybw8rfSQlKg6gZjUrafJz40s56vPtWnTbUUDG/d+mIu8sT aWuCRL0pDq1MS6u5ADER9Pw0VQ== X-Google-Smtp-Source: AGs4zMbQholBDxjeiIiQ+IXqXxpYKdW5Y7Vsugt9L9u0VefITcO/cDtpUCi34fn+y9wkEkKU5A46Jg== X-Received: by 10.25.27.213 with SMTP id b204mr6973318lfb.130.1512286599151; Sat, 02 Dec 2017 23:36:39 -0800 (PST) Received: from magnolia (ppp78-37-138-34.pppoe.avangarddsl.ru. [78.37.138.34]) by smtp.gmail.com with ESMTPSA id r89sm2146588ljr.16.2017.12.02.23.36.38 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 02 Dec 2017 23:36:38 -0800 (PST) From: Oleg Pykhalov To: ng0 Subject: Re: [bug#29536] [PATCH] gnu: Add cava. References: <87efocor8u.fsf@gmail.com> <20171202220708.cg6xnqca7ovul5ng@abyayala> Date: Sun, 03 Dec 2017 10:16:18 +0300 In-Reply-To: <20171202220708.cg6xnqca7ovul5ng@abyayala> (ng0@n0.is's message of "Sat, 2 Dec 2017 22:07:08 +0000") Message-ID: <871skcwabh.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 29536 Cc: 29536@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --=-=-= Content-Type: text/plain Hello ng0, ng0 writes: > which patch would someone review? Aren't they supposed to be one patch? > We don't have cava (as you are obviously adding it) and the 2nd patch > makes a change to cava. > We try to logically group patches, and this is a case where having it > in one patch makes sense, when a new package is getting added. [...] Sorry for that. The second patch are just minor things (indent and remove missleading comment). It expected to be squashed as patch's message says. I also think about adding an example of configuration from origin tarball as I did https://debbugs.gnu.org/cgi/bugreport.cgi?bug=29535 cava unlike cli-visualizer creates a configuration file for the first time, but it's empty and useless without example or documentation. Oleg. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEc+OyAXw1EaDPCmAPckbhHGm3lWkFAlojpMIACgkQckbhHGm3 lWmYXhAAw17brd8kwUC/xTs0sil5qtkxkbGjFtx7VkTey1ekXYLQ2QNeY5xjFy1n nCothcFCOocQZBMlWOoXDjD8EptW4PQ160oRBQdCpplobP6/eBLL45DJE0fDL/OG t+41VQb++lBl9UB3Q1WBgz1Nv/QY4sAis+Q9yNWkjrPXo2uy5ujGkhb1BqJ91Dvt Ub0WDWW/KCQxSa3D0N6C1ibZOJ0HDWnGWTbQWkO6bgHVjlTuHU63i3YsTevbvIKY bfAONOlNFm1WNP5y0USE5kr4ndA6fKUZKsjzcAFrqUVp2vvMuXJ8ciUBQvEqBjne D0LyI+r7A9mJoYcCEBaJCfbKY2+y1KN3JzrRUm6UCEMS9YtOhkU+t1DOne4Gi6OQ NwEEbKjhQMl8mELgBK8AjzC7Ae4twytLF13NtuJIxsvVnhHvN6MFpMpqJHjyIMNy o1YHPRodJmBjJfyREYCxcSSft745qNhkIVCZ/Uz4FX2nFDLWyyYI5HgUouGQqX0G JcN1uF7EptlEwwNjUSWDs6V50hfAasjyTx7EZ1w33ppcuet0WNkgkM7Wc+4dbu4G 7WuTQSXlrhUGv5tztl97981f+ZXOoFyT+iSku8XZom/8RQQG5Od+dj5S9VJHanio f/sNsoL/cEJl5iiWOOsqSwgr0VpK0XBAJpIU64GoWyYhtDFe2t4= =CKsT -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 03 02:36:48 2017 Received: (at 29536) by debbugs.gnu.org; 3 Dec 2017 07:36:48 +0000 Received: from localhost ([127.0.0.1]:42393 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eLOpU-000756-I0 for submit@debbugs.gnu.org; Sun, 03 Dec 2017 02:36:48 -0500 Received: from mail-lf0-f46.google.com ([209.85.215.46]:46419) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eLOpS-00074h-Ol for 29536@debbugs.gnu.org; Sun, 03 Dec 2017 02:36:47 -0500 Received: by mail-lf0-f46.google.com with SMTP id r143so15813788lfe.13 for <29536@debbugs.gnu.org>; Sat, 02 Dec 2017 23:36:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-disposition:content-description; bh=FfsGEVtceZJzpcVr1e4o+7hMEDvxsPJokmZwZdmqEeM=; b=gn3RQSph7MAFxUgzv88gDkcT9GOv+7Es4OZfrS4Ib08mEsncLQ7yYtNVhFPb5R14jn 7SViL1f06vSssOfv/f+m1CG9tM/ozHpX4dRuiAy0bGgQd/01KBU+G1tsu9bFTEPses4H 1OZSv5BzEDTmAT8Ca7/Oxu0E8pxkQwdbOgwa61SuZcjeQ3tTw0foKe0ANtHvdV/pt6Az K0HHFHSvpQBde6njPUZqnujN7oPPJV/HieEHx0TECSZQUofId/g0StJqZBDtIhsAhmmr VO9mNzsavV7iw2eUs2ibeXCuLV/78u8bKt/FO60HpSLqqAQO2R0w0SaqCln/dzE078OB CJGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-disposition :content-description; bh=FfsGEVtceZJzpcVr1e4o+7hMEDvxsPJokmZwZdmqEeM=; b=fd8Om01fClcLZPz4sLxlCpKbHfe4eWOn3lJiGC3eL373ZoXykvU4gHKDF8HC9JFs60 web1gtarzei2TvB5tUc1jq3IV1xt8HjliX34HCX08W4EXoSGQlLxTRISwZHSvg2LgiVu FWB51zf5Qrfi0BJElIeYIUdFQa+xvL9OlqAzMn8zvgsqnQ5sT5M3RLmnq6jqVU+0mzr1 Fj7Npg+/eUzuzpwH+gnmqtJTQeCjX2ysfheGRyQiqSPMIIm0SUMEQvUAyicKsHW5MQIB f4iTPFg1aGYG/+23y0Wt0rhF3re10JbxXFWg4Uvxuelag2MaZ7UCHj41y5wqHhMxGrBA eG6A== X-Gm-Message-State: AJaThX4kyQkn010hgMDh0Ci0M+fkuuHeBzpfrvMy+XwKiWInv5px2pwG ScpKvNNKxyv2wovm7kLGzWN9LA== X-Google-Smtp-Source: AGs4zMYWjRuFaWNPLuWio+YZNW+CWi9e9XiHK7/xaSYiKfJ4Nbh0fxIQhcq5WtcW1Uq7VSBD6wc1KA== X-Received: by 10.25.42.145 with SMTP id q17mr5693031lfq.136.1512286600716; Sat, 02 Dec 2017 23:36:40 -0800 (PST) Received: from magnolia (ppp78-37-138-34.pppoe.avangarddsl.ru. [78.37.138.34]) by smtp.gmail.com with ESMTPSA id x27sm1790816lfb.23.2017.12.02.23.36.39 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 02 Dec 2017 23:36:39 -0800 (PST) From: Oleg Pykhalov To: ng0 Subject: Re: [bug#29536] [PATCH] gnu: Add cava. References: <87efocor8u.fsf@gmail.com> <20171202220708.cg6xnqca7ovul5ng@abyayala> Date: Sun, 03 Dec 2017 10:34:17 +0300 In-Reply-To: <20171202220708.cg6xnqca7ovul5ng@abyayala> (ng0@n0.is's message of "Sat, 2 Dec 2017 22:07:08 +0000") Message-ID: <87wp24uux2.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/x-patch Content-Disposition: inline; filename=0001-gnu-Add-cava.patch Content-Description: [PATCH] gnu: Add cava. X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 29536 Cc: 29536@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) >From af48537fc5c6af11993db03004a937251d8d60e9 Mon Sep 17 00:00:00 2001 From: Oleg Pykhalov Date: Sat, 2 Dec 2017 22:36:36 +0300 Subject: [PATCH] gnu: Add cava. * gnu/packages/audio.scm (cava): New variable. --- gnu/packages/audio.scm | 49 +++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 49 insertions(+) diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm index da9314392..97de6b024 100644 --- a/gnu/packages/audio.scm +++ b/gnu/packages/audio.scm @@ -3087,3 +3087,52 @@ mixers.") customized and extended using either the s7 Scheme implementation (included in the Snd sources), Ruby, or Forth.") (license (license:non-copyleft "file://COPYING")))) + +(define-public cava + (package + (name "cava") + (version "0.6.0") + (source (origin + (method url-fetch) + (uri (string-append + "https://github.com/karlstav/cava/archive/" + version ".tar.gz")) + (file-name (string-append name "-" version ".tar.gz")) + (sha256 + (base32 + "1p24lz3h4d0h82ffylqr7mq8a8x1c66flm2r2bsv1liw51n1rma2")))) + (build-system gnu-build-system) + (native-inputs + `(("autoconf" ,autoconf) + ("automake" ,automake) + ("libtool" ,libtool))) + (inputs + `(("fftw" ,fftw) + ("ncurses" ,ncurses) + ("pulseaudio" ,pulseaudio))) + (arguments + `(#:configure-flags + (list (string-append "PREFIX=" %output) + (string-append "FONT_DIR=" %output "/usr/share/consolefonts")) + #:make-flags + (let ((lib (string-append %output "/lib"))) + (list (string-append "cava_LDFLAGS = -L" lib " -Wl,-rpath " lib))) + #:phases + (modify-phases %standard-phases + (add-after 'unpack 'bootstrap + (lambda _ + (setenv "HOME" (getcwd)) + (zero? (system* "sh" "autogen.sh")))) + (add-before 'build 'make-cava-ldflags + (lambda _ (mkdir-p (string-append (assoc-ref %outputs "out") "/lib")))) + (add-after 'install 'data + (lambda _ (for-each (lambda (file) + (install-file file (string-append + (assoc-ref %outputs "out") + "/share/doc/examples"))) + (find-files "example_files"))))))) + (home-page "https://karlstav.github.io/cava/") + (synopsis "CLI audio visualizer for Alsa, MPD and Pulseaudio") + (description "@code{cava} provides a command line audio visualizer for +MPD, Alsa and Pulseaudio.") + (license license:expat))) -- 2.15.0 From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 19 18:51:53 2018 Received: (at 29536) by debbugs.gnu.org; 19 Jan 2018 23:51:53 +0000 Received: from localhost ([127.0.0.1]:35365 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ecgRr-0004AB-GL for submit@debbugs.gnu.org; Fri, 19 Jan 2018 18:51:51 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:59410) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ecgRp-0004A3-Hu for 29536@debbugs.gnu.org; Fri, 19 Jan 2018 18:51:50 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id DFC8F10AAC; Sat, 20 Jan 2018 00:51:48 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CsTJkxqVEE-H; Sat, 20 Jan 2018 00:51:47 +0100 (CET) Received: from ribbon (unknown [IPv6:2a01:e0a:1d:7270:af76:b9b:ca24:c465]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 367A610A92; Sat, 20 Jan 2018 00:51:47 +0100 (CET) From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Oleg Pykhalov Subject: Re: [bug#29536] [PATCH] gnu: Add cava. References: <87efocor8u.fsf@gmail.com> <20171202220708.cg6xnqca7ovul5ng@abyayala> <87wp24uux2.fsf@gmail.com> Date: Sat, 20 Jan 2018 00:51:46 +0100 In-Reply-To: <87wp24uux2.fsf@gmail.com> (Oleg Pykhalov's message of "Sun, 03 Dec 2017 10:34:17 +0300") Message-ID: <87o9lph0fh.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 2.7 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Heya Oleg, Oleg Pykhalov skribis: >>From af48537fc5c6af11993db03004a937251d8d60e9 Mon Sep 17 00:00:00 2001 > From: Oleg Pykhalov > Date: Sat, 2 Dec 2017 22:36:36 +0300 > Subject: [PATCH] gnu: Add cava. > > * gnu/packages/audio.scm (cava): New variable. [...] Content analysis details: (2.7 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.7 URIBL_BLACK Contains an URL listed in the URIBL blacklist [URIs: autogen.sh] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) X-Debbugs-Envelope-To: 29536 Cc: 29536@debbugs.gnu.org, ng0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.7 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Heya Oleg, Oleg Pykhalov skribis: >>From af48537fc5c6af11993db03004a937251d8d60e9 Mon Sep 17 00:00:00 2001 > From: Oleg Pykhalov > Date: Sat, 2 Dec 2017 22:36:36 +0300 > Subject: [PATCH] gnu: Add cava. > > * gnu/packages/audio.scm (cava): New variable. [...] Content analysis details: (2.7 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.7 URIBL_BLACK Contains an URL listed in the URIBL blacklist [URIs: autogen.sh] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) Heya Oleg, Oleg Pykhalov skribis: >>>From af48537fc5c6af11993db03004a937251d8d60e9 Mon Sep 17 00:00:00 2001 > From: Oleg Pykhalov > Date: Sat, 2 Dec 2017 22:36:36 +0300 > Subject: [PATCH] gnu: Add cava. > > * gnu/packages/audio.scm (cava): New variable. [...] > + (modify-phases %standard-phases > + (add-after 'unpack 'bootstrap > + (lambda _ > + (setenv "HOME" (getcwd)) > + (zero? (system* "sh" "autogen.sh")))) Please use =E2=80=98invoke=E2=80=99 instead of =E2=80=98system*=E2=80=99. > + (add-before 'build 'make-cava-ldflags > + (lambda _ (mkdir-p (string-append (assoc-ref %outputs "out") = "/lib")))) Please use: (lambda* (#:key outputs #:allow-other-keys) =E2=80=A6 outputs =E2=80=A6) > + (add-after 'install 'data > + (lambda _ (for-each (lambda (file) > + (install-file file (string-append > + (assoc-ref %outputs "out= ") > + "/share/doc/examples"))) > + (find-files "example_files"))))))) Likewise. > + (home-page "https://karlstav.github.io/cava/") > + (synopsis "CLI audio visualizer for Alsa, MPD and Pulseaudio") Rather: =E2=80=9CConsole audio visualizer for ALSA, MPD, and PulseAudio=E2= =80=9D. > + (description "@code{cava} provides a command line audio visualizer f= or > +MPD, Alsa and Pulseaudio.") Based on their README: C.A.V.A. is a bar audio spectrum visualizer for the terminal using ALSA, MPD, PulseAudio, or a FIFO buffer as its input. OK with these changes, thank you! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 25 14:49:21 2018 Received: (at 29536) by debbugs.gnu.org; 25 Jan 2018 19:49:21 +0000 Received: from localhost ([127.0.0.1]:42857 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eenWT-0008Eh-09 for submit@debbugs.gnu.org; Thu, 25 Jan 2018 14:49:21 -0500 Received: from mail-lf0-f46.google.com ([209.85.215.46]:37011) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eenWQ-0008EO-OU; Thu, 25 Jan 2018 14:49:19 -0500 Received: by mail-lf0-f46.google.com with SMTP id 63so4986514lfv.4; Thu, 25 Jan 2018 11:49:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:message-id:user-agent :mime-version; bh=3h5dyGFL3buroETKdd2oG5OaSHGkse56Q9QRmS4C35g=; b=BOGPYw3toUitgbmyibx3IPL71wTDGt3cJVuRKl/zEPSlWmmCSw+WRd15kHdVkoqMls Pn/u/7nVj+eyDe+j+mVcGsPOTxlwyGncqxH2rCuS/doDI2eagcM5Ey/n8a6FxeQEYgpC G8uRMU2WxG6oOR4mkL5gnhU9tNxlCnHtJ3DW23HsCvHKGmJPbu6NjquUjMUmIAqvtfLk rOonlwKl3yFzCYqc1UkohmV6Ufp87Y9zKSKJQH4czW7OXqvvWZ29zuAr2yAlHZagcwXT xCJTvtNQoU32ixmUdm7XJGksva7t5wM0FQFnmyZHqstYaLzgCNnFZcJRsmK7kYwSFxgn 7ILw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:message-id :user-agent:mime-version; bh=3h5dyGFL3buroETKdd2oG5OaSHGkse56Q9QRmS4C35g=; b=LFhXme/I+A5z9vMNJmJZ+EOfk/cUQPuawtIVqbWGTMh+/j3mQegFt6HyIciH2wDZS8 VDr0xM88IH8xU36zjwVOVooOhtKpNU70wbAs09fXo6DBYdyYX9xzLMWBYPN4PxoUre3Y GiY/URvZC+8HCShdhz89i5qrrrrYCDE3eoCyiX/7/9R6GAES42AnZrfCYkiBxUzYN1Ct nFP9CilURmOWXDez2MGlvZ3jNU3yRAhkywFl8v2t4RUNg6+YYZPbBrwxssYoYhBcJJQo pjpjamc0qZHwYFyc7/4MNKoQiPT+oWIthoS4ZWweLrcmxR/jt+i+311vTQJIm2/KW9mn EVYQ== X-Gm-Message-State: AKwxytdDinJUnJ/wggek/D5TZGRV613K5R3wOS++JovlTod6TDb8p5b7 jb1WEnkrwcdX/I6R7omqzz0= X-Google-Smtp-Source: AH8x227+qnl/yCnb8orShp/S+JLRUH6DUJ+/f6eSsI02r+OTCsFjK2ezLT391NCwEQD5g3B27qsp2g== X-Received: by 10.25.56.77 with SMTP id d13mr6698259lfj.46.1516909752554; Thu, 25 Jan 2018 11:49:12 -0800 (PST) Received: from magnolia ([178.71.61.83]) by smtp.gmail.com with ESMTPSA id z66sm1102790lfa.26.2018.01.25.11.49.10 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 25 Jan 2018 11:49:11 -0800 (PST) From: Oleg Pykhalov To: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [bug#29536] [PATCH] gnu: Add cava. References: <87efocor8u.fsf@gmail.com> <20171202220708.cg6xnqca7ovul5ng@abyayala> <87wp24uux2.fsf@gmail.com> <87o9lph0fh.fsf@gnu.org> Date: Thu, 25 Jan 2018 22:49:07 +0300 Message-ID: <87k1w5hg7g.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 1.7 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hello Ludovic, Thank you for review! ludo@gnu.org (Ludovic Courtès) writes: [...] Content analysis details: (1.7 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.7 URIBL_BLACK Contains an URL listed in the URIBL blacklist [URIs: autogen.sh] -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [209.85.215.46 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [209.85.215.46 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (go.wigust[at]gmail.com) -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid X-Debbugs-Envelope-To: 29536 Cc: 29536@debbugs.gnu.org, 29536-done@debbugs.gnu.org, ng0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.7 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hello Ludovic, Thank you for review! ludo@gnu.org (Ludovic Courtès) writes: [...] Content analysis details: (1.7 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.7 URIBL_BLACK Contains an URL listed in the URIBL blacklist [URIs: autogen.sh] -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [209.85.215.46 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [209.85.215.46 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (go.wigust[at]gmail.com) -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello Ludovic, Thank you for review! ludo@gnu.org (Ludovic Court=C3=A8s) writes: >>>>>From af48537fc5c6af11993db03004a937251d8d60e9 Mon Sep 17 00:00:00 2001 >> From: Oleg Pykhalov >> Date: Sat, 2 Dec 2017 22:36:36 +0300 >> Subject: [PATCH] gnu: Add cava. >> >> * gnu/packages/audio.scm (cava): New variable. > > [...] > >> + (modify-phases %standard-phases >> + (add-after 'unpack 'bootstrap >> + (lambda _ >> + (setenv "HOME" (getcwd)) >> + (zero? (system* "sh" "autogen.sh")))) > > Please use =E2=80=98invoke=E2=80=99 instead of =E2=80=98system*=E2=80=99. This is new. OK, will use. Thank you for notice! >> + (add-before 'build 'make-cava-ldflags >> + (lambda _ (mkdir-p (string-append (assoc-ref %outputs "out")= "/lib")))) > > Please use: > > (lambda* (#:key outputs #:allow-other-keys) > =E2=80=A6 outputs =E2=80=A6) Should be this? (lambda* (#:key outputs #:allow-other-keys) =E2=80=A6 (assoc-ref outputs "out") =E2=80=A6) >> + (add-after 'install 'data >> + (lambda _ (for-each (lambda (file) >> + (install-file file (string-append >> + (assoc-ref %outputs "ou= t") >> + "/share/doc/examples"))) >> + (find-files "example_files"))))))) > Likewise. OK. >> + (home-page "https://karlstav.github.io/cava/") >> + (synopsis "CLI audio visualizer for Alsa, MPD and Pulseaudio") > > Rather: =E2=80=9CConsole audio visualizer for ALSA, MPD, and PulseAudio= =E2=80=9D. OK. >> + (description "@code{cava} provides a command line audio visualizer = for >> +MPD, Alsa and Pulseaudio.") > > Based on their README: > > C.A.V.A. is a bar audio spectrum visualizer for the terminal using > ALSA, MPD, PulseAudio, or a FIFO buffer as its input. OK. > OK with these changes, thank you! Pushed as c2c0d66162152b05fc42fdd1be5f07b9eca3bc66 Oleg. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEc+OyAXw1EaDPCmAPckbhHGm3lWkFAlpqNLMACgkQckbhHGm3 lWmvdxAAj06PaWR9Cb+juqLoEcfkJcweKQh/HPdBS9UZi68Uu4aXSIYtl+7tWWMk a8j1QJebFVUZnbOmo2uyMbQZzCKdvRPhRtSB/mWmL1EsODTx3Rc3NPJv9il/Zcxe JUv88okmNqdlm48FXsBK3tMjZqekAVwauj8jbliz5DfoCteTXSE9aqt2tb3kM0Yk q8qbcTJpK7sOmrzMBOPZisOyWd7id8p7xL+yADfuV5ydEjFKTqCke2w0HGRiSDPB U7GEZcqo4zc8anx6aaPh2eBunXHwKeO/i5iBotSQcvhxNOCmCiFqBqwDdWYiOZlh 97RLvi0G+5M7tzkZ8X5fuEmBfAKBdAp2CGRng/RixhVoR6uRuRQ5zREMpXU2nZxW su1eH/wx0tzAzL5tYwYhj/3qmCPORTR1dfwEuwBySZFlFTDzEf9MLQKwjunlBorh DVAjqKwSkCvM8uDwsv6geIU46VN+6bYGJTFtkswAcRvyhPk/bKvQIy853CzHt5Ws b9IDkGc2jE9fJpazzX0TeCA2kvQJ2AhXbqf+t5BS1XLpbGpxf5Xbs8xeUjaM4n9r WWKlSXdsQPYIdI/PLe3ojxTY33YZmEsWDzfOqXdc5q6Rrtrf+broEdxEVBikI3oE yaRDnX9xRmNUxL+qLPyAcVmHqIejWRjcDex8jUnN82svygLjpeA= =2hEY -----END PGP SIGNATURE----- --=-=-=-- From unknown Wed Aug 20 05:17:06 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 23 Feb 2018 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator