GNU bug report logs - #29533
Fwd: [Feature Request] ERC: let erc-join-channel support to select channels from history or a defined list

Previous Next

Full log

Message #51 received at 29533 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: stardiviner <numbchild <at> gmail.com>
Cc: Lars Ingebrigtsen <larsi <at> gnus.org>, 29533 <at> debbugs.gnu.org
Subject: Re: bug#29533: Fwd: [Feature Request] ERC: let erc-join-channel
 support to select channels from history or a defined list
Date: Thu, 14 May 2020 07:40:54 -0700

stardiviner <numbchild <at> gmail.com> writes:

> +                           (mapcar 'car erc-join-channels-alist))
> lisp/erc/erc.el:4048: indent with spaces.
> +          erc-join-channels-alist)))))
> ```
>
> I didi an google search, but still don't know how to set this. Shouldn't it be
> space-indented?

Yes, you should prefer indenting with spaces for the most part.

Maybe there is something in your local git configuration that is causing
this?

> And here is my patch diff. How should I submit this patch to Emacs/erc ?

You should ideally send the patch as an attached file produced by:

    git format-patch -1 HEAD

Also, we have some requirements for contributions, such as including a
ChangeLog entry.  This is described in the CONTRIBUTE file, and you can
also see examples in the git log.  (You can use `C-x 4 a' so you don't
have to type as much.)

Are there any changes that needs doing in the manual?  Should this be
announced in etc/NEWS?

Best regards,
Stefan Kangas

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.