GNU bug report logs - #29529
next-line-add-newlines shouldn't be respected in next-line-or-history-element

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: "E. Choroba" <choroba <at> matfyz.cz>
Subject: bug#29529: closed (Re: bug#29529: next-line-add-newlines
 shouldn't be respected in next-line-or-history-element)
Date: Sun, 03 Dec 2017 16:02:03 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#29529: next-line-add-newlines shouldn't be respected in next-line-or-history-element

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 29529 <at> debbugs.gnu.org.

-- 
29529: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=29529
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: "E. Choroba" <choroba <at> matfyz.cz>
Cc: 29529-done <at> debbugs.gnu.org
Subject: Re: bug#29529: next-line-add-newlines shouldn't be respected in
 next-line-or-history-element
Date: Sun, 03 Dec 2017 18:00:36 +0200

> Date: Fri, 1 Dec 2017 23:49:56 +0100 (CET)
> From: "E. Choroba" <choroba <at> matfyz.cz>
> 
> I don't like the "end of buffer" errors, so I have switched 
> next-line-add-newlines to t. In recent Emacs versions, though, this makes it 
> impossible to browse the minibuffer history with cursor arrows: <down> adds a 
> newline into the minibufer instead of showing the next history element. M-n 
> works correctly, though.
> 
> Steps to reproduce (tested in 25.3.1):
> 
> emacs -Q
> (setq next-line-add-newlines t) C-x C-e
> C-x C-f <down>
> 
> Solution:
> 
> Set the variable to nil locally in next-line-or-history-element.
> 
> Patch:

Thanks, I installed your patch.

[Message part 3 (message/rfc822, inline)]

From: "E. Choroba" <choroba <at> matfyz.cz>
To: bug-gnu-emacs <at> gnu.org
Subject: next-line-add-newlines shouldn't be respected in
 next-line-or-history-element
Date: Fri, 1 Dec 2017 23:49:56 +0100 (CET)

Hi,

I don't like the "end of buffer" errors, so I have switched 
next-line-add-newlines to t. In recent Emacs versions, though, this makes it 
impossible to browse the minibuffer history with cursor arrows: <down> adds a 
newline into the minibufer instead of showing the next history element. M-n 
works correctly, though.

Steps to reproduce (tested in 25.3.1):

emacs -Q
(setq next-line-add-newlines t) C-x C-e
C-x C-f <down>

Solution:

Set the variable to nil locally in next-line-or-history-element.

Patch:

diff -u <(zcat /usr/local/share/emacs/25.3/lisp/simple.el.gz) ~/simple.el
--- /dev/fd/63  2017-12-01 23:45:06.338468797 +0100
+++ /home/choroba/simple.el     2017-12-01 23:45:04.166450109 +0100
@@ -2038,6 +2038,7 @@
   (interactive "^p")
   (or arg (setq arg 1))
   (let* ((old-point (point))
+         (next-line-add-newlines nil)
         ;; Remember the original goal column of possibly multi-line input
         ;; excluding the length of the prompt on the first line.
         (prompt-end (minibuffer-prompt-end))


Cheers,

Ch.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.