GNU bug report logs - #29517
[PATCH] gnu: gl: Add virtualgl.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 29517 in the body.
You can then email your comments to 29517 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Rutger Helling <rhelling <at> mykolab.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: gl: Add virtualgl.
Date: Fri, 01 Dec 2017 08:26:46 +0100

[Message part 1 (text/plain, inline)]

Hey Guix, 

this patch adds VirtualGL.

[Message part 2 (text/html, inline)]

[0001-gnu-gl-Add-virtualgl.patch (text/x-diff, attachment)]

Message #8 received at 29517 <at> debbugs.gnu.org (full text, mbox):

From: Rutger Helling <rhelling <at> mykolab.com>
To: 29517 <at> debbugs.gnu.org
Subject: [PATCH] gnu: gl: Add virtualgl. (v2)
Date: Thu, 07 Dec 2017 09:14:58 +0100

[Message part 1 (text/plain, inline)]

Here's a second version of the patch that also makes sure the libraries
are installed in /lib.

[Message part 2 (text/html, inline)]

[0001-gnu-gl-Add-virtualgl-v2.patch (text/x-diff, attachment)]

Message #11 received at 29517 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Rutger Helling <rhelling <at> mykolab.com>
Cc: 29517 <at> debbugs.gnu.org
Subject: Re: [bug#29517] [PATCH] gnu: gl: Add virtualgl. (v2)
Date: Fri, 08 Dec 2017 10:21:43 +0100

Hi,

Rutger Helling <rhelling <at> mykolab.com> skribis:

> From d2b7f7243a8831542538bad5bab14fba0693a4fc Mon Sep 17 00:00:00 2001
> From: Rutger Helling <rhelling <at> mykolab.com>
> Date: Thu, 7 Dec 2017 09:11:08 +0100
> Subject: [PATCH] gnu: gl: Add virtualgl.
>
> * gnu/packages/gl.scm (virtualgl): New variable.

LGTM, with a few minor issues:

> +    (home-page "https://www.virtualgl.org")
> +    (synopsis "Redirects 3D commands from an OpenGL application onto a 3D
> +graphics card")
> +    (description "VirtualGL is a free software program that redirects the 3D

s/free software//

(Everything’s free software in Guix.  :-))

> +rendering commands from Unix and Linux OpenGL applications to 3D accelerator

s/Unix and Linux//g

> +hardware in a dedicated server and displays the rendered output interactively to
> +a thin client located elsewhere on the network.")
> +    (license license:lgpl2.1)))

Source code headers read this:

 * This library is free software and may be redistributed and/or modified under
 * the terms of the wxWindows Library License, Version 3.1 or (at your option)
 * any later version.  The full license is in the LICENSE.txt file included
 * with this distribution.
 *
 * This library is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * wxWindows Library License for more details.

We don’t have that license in (guix licenses) yet.  Could you add it and
send updated patches?

Thanks,
Ludo’.

Message #14 received at 29517 <at> debbugs.gnu.org (full text, mbox):

From: Rutger Helling <rhelling <at> mykolab.com>
To: ludo <at> gnu.org
Cc: 29517 <at> debbugs.gnu.org
Subject: Re: [bug#29517] [PATCH] gnu: gl: Add virtualgl. (v2)
Date: Fri, 08 Dec 2017 11:38:07 +0100

[Message part 1 (text/plain, inline)]

Hi Ludo, 

thanks for the review! Here are updated patches based on your feedback. 

On 2017-12-08 10:21, ludo <at> gnu.org wrote:

> Hi,
> 
> Rutger Helling <rhelling <at> mykolab.com> skribis:
> 
>> From d2b7f7243a8831542538bad5bab14fba0693a4fc Mon Sep 17 00:00:00 2001
>> From: Rutger Helling <rhelling <at> mykolab.com>
>> Date: Thu, 7 Dec 2017 09:11:08 +0100
>> Subject: [PATCH] gnu: gl: Add virtualgl.
>> 
>> * gnu/packages/gl.scm (virtualgl): New variable.
> 
> LGTM, with a few minor issues:
> 
>> +    (home-page "https://www.virtualgl.org")
>> +    (synopsis "Redirects 3D commands from an OpenGL application onto a 3D
>> +graphics card")
>> +    (description "VirtualGL is a free software program that redirects the 3D
> 
> s/free software//
> 
> (Everything's free software in Guix.  :-))
> 
>> +rendering commands from Unix and Linux OpenGL applications to 3D accelerator
> 
> s/Unix and Linux//g
> 
>> +hardware in a dedicated server and displays the rendered output interactively to
>> +a thin client located elsewhere on the network.")
>> +    (license license:lgpl2.1)))
> 
> Source code headers read this:
> 
> * This library is free software and may be redistributed and/or modified under
> * the terms of the wxWindows Library License, Version 3.1 or (at your option)
> * any later version.  The full license is in the LICENSE.txt file included
> * with this distribution.
> *
> * This library is distributed in the hope that it will be useful,
> * but WITHOUT ANY WARRANTY; without even the implied warranty of
> * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> * wxWindows Library License for more details.
> 
> We don't have that license in (guix licenses) yet.  Could you add it and
> send updated patches?
> 
> Thanks,
> Ludo'.

[Message part 2 (text/html, inline)]

[0001-guix-licenses-Add-wxWindows-3.1-license.patch (text/x-diff, attachment)]

[0002-gnu-gl-Add-virtualgl.patch (text/x-diff, attachment)]

Message #17 received at 29517 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Rutger Helling <rhelling <at> mykolab.com>
Cc: 29517 <at> debbugs.gnu.org
Subject: Re: [bug#29517] [PATCH] gnu: gl: Add virtualgl. (v2)
Date: Fri, 08 Dec 2017 15:00:56 +0100

[Message part 1 (text/plain, inline)]

Rutger Helling <rhelling <at> mykolab.com> skribis:

> From c593bd89f7f991cc8d9a19e1d06f0439f16d7805 Mon Sep 17 00:00:00 2001
> From: Rutger Helling <rhelling <at> mykolab.com>
> Date: Fri, 8 Dec 2017 11:31:57 +0100
> Subject: [PATCH] guix: licenses: Add wxWindows 3.1 license.
>
> * guix/licenses.scm: Add wxWindows 3.1 license.

I adjusted the commit log and made these changes (reflect the “or any
later version” with ‘+’, have the first field be the URI of the license
and the second be the comments about the license):

[Message part 2 (text/x-patch, inline)]

diff --git a/guix/licenses.scm b/guix/licenses.scm
index 8fa121fd4..269d97c72 100644
--- a/guix/licenses.scm
+++ b/guix/licenses.scm
@@ -92,7 +92,7 @@
             zlib
             fsf-free
             wtfpl2
-            wxwindows3.1
+            wxwindows3.1+
             fsdg-compatible))
 
 (define-record-type <license>
@@ -583,10 +583,10 @@ at URI, which may be a file:// URI pointing the package's tree."
            "http://www.wtfpl.net"
            "http://www.wtfpl.net/about/"))
 
-(define wxwindows3.1
-  (license "wxWindows 3.1"
-           "https://wxwidgets.org"
-           "https://wxwidgets.org/about/licence"))
+(define wxwindows3.1+
+  (license "wxWindows 3.1+"
+           "https://wxwidgets.org/about/licence"
+           "https://www.gnu.org/licenses/license-list.html#Wxwind"))
 
 (define x11
   (license "X11"

[Message part 3 (text/plain, inline)]

Ludo’.

Message #22 received at 29517-done <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Rutger Helling <rhelling <at> mykolab.com>
Cc: 29517-done <at> debbugs.gnu.org
Subject: Re: [bug#29517] [PATCH] gnu: gl: Add virtualgl. (v2)
Date: Fri, 08 Dec 2017 15:04:17 +0100

Rutger Helling <rhelling <at> mykolab.com> skribis:

> From 3039ed703888a50cc7f5552578a2c4073a77b829 Mon Sep 17 00:00:00 2001
> From: Rutger Helling <rhelling <at> mykolab.com>
> Date: Fri, 8 Dec 2017 11:33:54 +0100
> Subject: [PATCH] gnu: gl: Add virtualgl.
>
> * gnu/packages/gl.scm (virtualgl): New variable.

I adjusted the ‘license’ field to add ‘+’ and pushed.

Thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.