GNU bug report logs - #29504
26.0.90; Can't enter Japanes text in a read-only buffer even if inhibit-read-only is t

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 29504 in the body.
You can then email your comments to 29504 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Katsumi Yamaoka <yamaoka <at> jpl.org>
To: bug-gnu-emacs <at> gnu.org
Subject: 26.0.90; Can't enter Japanes text in a read-only buffer even if
 inhibit-read-only is t
Date: Thu, 30 Nov 2017 12:39:28 +0900

Hi,

Not only Japanese, every input method should work in a read-only
buffer (such as that of eww) where the `inhibit-read-only' text
or overlay property is set in some areas.  Here is a recipe to
reproduce the problem:

Launch Emacs with -Q, eval this form in the *scratch* buffer,
and type `C-x o', `C-\', and `a'.  "あ" should appear.

(set-input-method 'japanese)

(let ((buffer (get-buffer-create "*texting*")))
  (with-current-buffer buffer
    (setq buffer-read-only nil)
    (erase-buffer)
    (insert (propertize " " 'inhibit-read-only t 'front-sticky t))
    (setq buffer-read-only t)
    (goto-char (point-min)))
  (display-buffer buffer))

Thanks.

Message #8 received at 29504 <at> debbugs.gnu.org (full text, mbox):

From: Katsumi Yamaoka <yamaoka <at> jpl.org>
To: 29504 <at> debbugs.gnu.org
Subject: Re: bug#29504: 26.0.90;
 Can't enter Japanes text in a read-only buffer even if
 inhibit-read-only is t
Date: Thu, 30 Nov 2017 13:03:30 +0900

On Thu, 30 Nov 2017 12:39:28 +0900, Katsumi Yamaoka wrote:
> Not only Japanese, every input method should work in a read-only
> buffer (such as that of eww) where the `inhibit-read-only' text
> or overlay property is set in some areas.

A patch:

--- lisp/international/quail.el~	2017-11-26 22:09:06.936385900 +0000
+++ lisp/international/quail.el	2017-11-30 04:01:39.868772300 +0000
@@ -1332,3 +1332,5 @@
 (defun quail-input-method (key)
-  (if (or buffer-read-only
+  (if (or (and buffer-read-only
+	       (not (or inhibit-read-only
+			(get-char-property (point) 'inhibit-read-only))))
 	  (and overriding-terminal-local-map

Message #11 received at 29504 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Katsumi Yamaoka <yamaoka <at> jpl.org>
Cc: 29504 <at> debbugs.gnu.org
Subject: Re: bug#29504: 26.0.90;
 Can't enter Japanes text in a read-only buffer even if
 inhibit-read-only is t
Date: Sat, 09 Dec 2017 11:05:49 +0200

> Date: Thu, 30 Nov 2017 13:03:30 +0900
> From: Katsumi Yamaoka <yamaoka <at> jpl.org>
> 
> On Thu, 30 Nov 2017 12:39:28 +0900, Katsumi Yamaoka wrote:
> > Not only Japanese, every input method should work in a read-only
> > buffer (such as that of eww) where the `inhibit-read-only' text
> > or overlay property is set in some areas.
> 
> A patch:
> 
> --- lisp/international/quail.el~	2017-11-26 22:09:06.936385900 +0000
> +++ lisp/international/quail.el	2017-11-30 04:01:39.868772300 +0000
> @@ -1332,3 +1332,5 @@
>  (defun quail-input-method (key)
> -  (if (or buffer-read-only
> +  (if (or (and buffer-read-only
> +	       (not (or inhibit-read-only
> +			(get-char-property (point) 'inhibit-read-only))))
>  	  (and overriding-terminal-local-map
> 

Looks OK to me.  Please push to the emacs-26 branch, and thanks.

Message #16 received at 29504-done <at> debbugs.gnu.org (full text, mbox):

From: Katsumi Yamaoka <yamaoka <at> jpl.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 29504-done <at> debbugs.gnu.org
Subject: Re: bug#29504: 26.0.90;
 Can't enter Japanes text in a read-only buffer even if
 inhibit-read-only is t
Date: Mon, 11 Dec 2017 10:28:32 +0900

On Sat, 09 Dec 2017 11:05:49 +0200, Eli Zaretskii wrote:
> Looks OK to me.  Please push to the emacs-26 branch, and thanks.

Done.  Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.