GNU bug report logs - #29496
[PATCH] doc: Update the example VCS snapshot package definition.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Kei Kebreau <kkebreau <at> posteo.net>
Subject: bug#29496: closed (Re: [bug#29496] [PATCH] doc: Update the
 example VCS snapshot package definition.)
Date: Thu, 30 Nov 2017 17:23:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#29496: [PATCH] doc: Update the example VCS snapshot package definition.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 29496 <at> debbugs.gnu.org.

-- 
29496: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=29496
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Kei Kebreau <kkebreau <at> posteo.net>
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: 29496-done <at> debbugs.gnu.org
Subject: Re: [bug#29496] [PATCH] doc: Update the example VCS snapshot package
 definition.
Date: Thu, 30 Nov 2017 12:21:53 -0500

[Message part 3 (text/plain, inline)]

ludo <at> gnu.org (Ludovic Courtès) writes:

> Kei Kebreau <kkebreau <at> posteo.net> skribis:
>
>> In commit ee17a9e06e636400e3354796a42ac445dbcc8f96, the helpers git-version
>> and git-file-name removed the need to build version and file name strings
>> manually for packages that use VCS snapshots.
>>
>> doc/guix.texi (Version Numbers): Use git-version and git-file-name.
>
> LGTM, thanks!
>
> Ludo’, who didn’t know about ‘git-version’.

Pushed! Thanks to you for reviewing and to Leo for making me this change.

[signature.asc (application/pgp-signature, inline)]

[Message part 5 (message/rfc822, inline)]

From: Kei Kebreau <kkebreau <at> posteo.net>
To: guix-patches <at> gnu.org
Cc: Kei Kebreau <kkebreau <at> posteo.net>
Subject: [PATCH] doc: Update the example VCS snapshot package definition.
Date: Tue, 28 Nov 2017 18:38:53 -0500

In commit ee17a9e06e636400e3354796a42ac445dbcc8f96, the helpers git-version
and git-file-name removed the need to build version and file name strings
manually for packages that use VCS snapshots.

doc/guix.texi (Version Numbers): Use git-version and git-file-name.
---
 doc/guix.texi | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/doc/guix.texi b/doc/guix.texi
index 777ca2738..0bd6b6a79 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -19880,16 +19880,14 @@ definition may look like this:
   (let ((commit "c3f29bc928d5900971f65965feaae59e1272a3f7")
         (revision "1"))          ;Guix package revision
     (package
-      (version (string-append "0.9-" revision "."
-                              (string-take commit 7)))
+      (version (git-version "0.9" revision commit))
       (source (origin
                 (method git-fetch)
                 (uri (git-reference
                       (url "git://example.org/my-package.git")
                       (commit commit)))
                 (sha256 (base32 "1mbikn <at> dots{}"))
-                (file-name (string-append "my-package-" version
-                                          "-checkout"))))
+                (file-name (git-file-name name version))))
       ;; @dots{}
       )))
 @end example
-- 
2.15.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.