Subject: Re: bug#29489: Obsolete gnus-remove-if and gnus-remove-if-not

From: Eric Abrahamsen <[email-masked]>
Date: Tue, 28 Nov 2017 19:31:16 -0800

Noam Postavsky <[email-masked]> writes:

> Eric Abrahamsen <[email-masked]> writes:
>
>> For the interim, all that matters is consistency:
>>
>> (let ((list nil)
>>       (ob (make-vector 3 0)))
>>   (intern "foo" ob)
>>   (intern "bar" ob)
>>   (intern "xxx" ob)
>>   (gnus-remove-if-not (lambda (_) t) ob)) ;=> (xxx 0 0)
>
> But:
>
> (let ((list nil)
>       (ob (make-vector 3 0)))
>   (intern "foo" ob)
>   (intern "bar" ob)
>   (intern "xxx" ob)
>   (gnus-remove-if-not (lambda (_) t)
>                       ob t)) ;=> (xxx bar foo)

Good catch! Thanks for that. I was too hasty, and had already moved on
to running the next patch.

There are only two places in the code where that third argument is
passed. I can rework those two locations so that they work properly,
until the next step is taken.