From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 28 12:02:56 2017 Received: (at submit) by debbugs.gnu.org; 28 Nov 2017 17:02:57 +0000 Received: from localhost ([127.0.0.1]:34859 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJjHc-0001b3-F7 for submit@debbugs.gnu.org; Tue, 28 Nov 2017 12:02:56 -0500 Received: from mail.ericabrahamsen.net ([50.56.99.223]:42057) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJjHY-0001as-AM for submit@debbugs.gnu.org; Tue, 28 Nov 2017 12:02:53 -0500 Received: from localhost (71-212-22-173.tukw.qwest.net [71.212.22.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 60258C0329 for ; Tue, 28 Nov 2017 17:02:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mail.ericabrahamsen.net; s=mail; t=1511888570; bh=vXBzKzj9MCEMwKPbrD9hScAkJFZxBbUYY/CfIts3u3g=; h=From:To:Subject:Date:From; b=ElnhdVBX2817YqZYp+DLVWg777g0MUz6/RaDXTqxCP8uiTlrMZB9t5kxmqgSAPN7W EanFXBJKpzy8Zi4HsUPejFGl+ZrDoFJuLFF1Yemmvt+vDeqIH6/Sunl3VY4Pfajou4 kqdjzczCpyLHw4PorSkg+F1EzQDiMQ61BKCOSzxc= From: Eric Abrahamsen To: submit@debbugs.gnu.org (The Gnus Bugfixing Girls + Boys) Subject: Obsolete gnus-remove-if and gnus-remove-if-not X-Debbugs-Version: 5.13 X-Debbugs-Package: emacs,gnus Date: Tue, 28 Nov 2017 09:02:49 -0800 Message-ID: <87o9nmgwue.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain Here's another one of these. I've replaced these with `seq-remove' and `seq-filter', and I suppose someone might object to that -- the other option would be `cl-remove-if' and `cl-remove-if-not'. I don't believe there's much practical difference. Gnus v5.13 GNU Emacs 27.0.50 (build 13, x86_64-pc-linux-gnu, GTK+ Version 3.22.26) of 2017-11-27 --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Obsolete-gnus-remove-if-and-gnus-remove-if-not.patch >From 39b8e2bf7371df930081642b5127db268fcf4d46 Mon Sep 17 00:00:00 2001 From: Eric Abrahamsen Date: Sat, 25 Nov 2017 18:42:55 -0800 Subject: [PATCH] Obsolete gnus-remove-if and gnus-remove-if-not Use seq-remove and seq-filter, respectively, instead. * lisp/gnus/gnus-util.el: Remove functions and replace with define-obsolete-function-alias calls. * lisp/gnus/gnus.el: Require seq here. * lisp/gnus/gnus-art.el (gnus-mime-view-part-as-type): * lisp/gnus/gnus-icalendar.el (gnus-icalendar-event--get-attendee-names): * lisp/gnus/gnus-score.el (gnus-summary-score-effect): * lisp/gnus/gnus-sum.el (gnus-read-move-group-name): * lisp/gnus/gnus-topic.el (gnus-group-prepare-topics): * lisp/gnus/gnus-win.el (gnus-get-buffer-window): * lisp/gnus/nnmail.el (nnmail-purge-split-history): * lisp/gnus/nnmaildir.el (nnmaildir-request-scan): * lisp/gnus/nnrss.el (nnrss-make-hash-index): Replace calls in all these locations. --- lisp/gnus/gnus-art.el | 2 +- lisp/gnus/gnus-icalendar.el | 4 ++-- lisp/gnus/gnus-score.el | 2 +- lisp/gnus/gnus-sum.el | 4 ++-- lisp/gnus/gnus-topic.el | 4 ++-- lisp/gnus/gnus-util.el | 38 +++----------------------------------- lisp/gnus/gnus-win.el | 2 +- lisp/gnus/gnus.el | 1 + lisp/gnus/nnmail.el | 2 +- lisp/gnus/nnmaildir.el | 2 +- lisp/gnus/nnrss.el | 2 +- 11 files changed, 16 insertions(+), 47 deletions(-) diff --git a/lisp/gnus/gnus-art.el b/lisp/gnus/gnus-art.el index 97aa878ab6..6ee0d7b023 100644 --- a/lisp/gnus/gnus-art.el +++ b/lisp/gnus/gnus-art.el @@ -5219,7 +5219,7 @@ gnus-mime-view-part-as-type (gnus-completing-read "View as MIME type" (if pred - (gnus-remove-if-not pred (mailcap-mime-types)) + (seq-filter pred (mailcap-mime-types)) (mailcap-mime-types)) nil nil nil (car default))))) diff --git a/lisp/gnus/gnus-icalendar.el b/lisp/gnus/gnus-icalendar.el index cca4a81d1c..38c3ea36d6 100644 --- a/lisp/gnus/gnus-icalendar.el +++ b/lisp/gnus/gnus-icalendar.el @@ -169,7 +169,7 @@ gnus-icalendar-event--find-attendee (defun gnus-icalendar-event--get-attendee-names (ical) (let* ((event (car (icalendar--all-events ical))) - (attendee-props (gnus-remove-if-not + (attendee-props (seq-filter (lambda (p) (eq (car p) 'ATTENDEE)) (caddr event)))) @@ -180,7 +180,7 @@ gnus-icalendar-event--get-attendee-names (or (plist-get (cadr prop) 'CN) (replace-regexp-in-string "^.*MAILTO:" "" (caddr prop)))) (attendees-by-type (type) - (gnus-remove-if-not + (seq-filter (lambda (p) (string= (attendee-role p) type)) attendee-props)) (attendee-names-by-type diff --git a/lisp/gnus/gnus-score.el b/lisp/gnus/gnus-score.el index 765dfab570..a2cc07db46 100644 --- a/lisp/gnus/gnus-score.el +++ b/lisp/gnus/gnus-score.el @@ -921,7 +921,7 @@ gnus-summary-score-effect (interactive (list (gnus-completing-read "Header" (mapcar 'car - (gnus-remove-if-not + (seq-filter (lambda (x) (fboundp (nth 2 x))) gnus-header-index)) t) diff --git a/lisp/gnus/gnus-sum.el b/lisp/gnus/gnus-sum.el index e599a8460f..dfecd2713d 100644 --- a/lisp/gnus/gnus-sum.el +++ b/lisp/gnus/gnus-sum.el @@ -12275,12 +12275,12 @@ gnus-read-move-group-name ((null split-name) (gnus-group-completing-read prom - (gnus-remove-if-not 'gnus-valid-move-group-p gnus-active-hashtb t) + (seq-filter 'gnus-valid-move-group-p gnus-active-hashtb) nil prefix nil default)) ((= 1 (length split-name)) (gnus-group-completing-read prom - (gnus-remove-if-not 'gnus-valid-move-group-p gnus-active-hashtb t) + (seq-filter 'gnus-valid-move-group-p gnus-active-hashtb) nil prefix 'gnus-group-history (car split-name))) (t (gnus-completing-read diff --git a/lisp/gnus/gnus-topic.el b/lisp/gnus/gnus-topic.el index ba756e0314..065215b471 100644 --- a/lisp/gnus/gnus-topic.el +++ b/lisp/gnus/gnus-topic.el @@ -460,9 +460,9 @@ gnus-group-prepare-topics (unless gnus-killed-hashtb (gnus-make-hashtable-from-killed)) (gnus-group-prepare-flat-list-dead - (gnus-remove-if (lambda (group) + (seq-remove (lambda (group) (or (gnus-group-entry group) - (gnus-gethash group gnus-killed-hashtb))) + (gethash group gnus-killed-hashtb))) not-in-list) gnus-level-killed ?K regexp))) diff --git a/lisp/gnus/gnus-util.el b/lisp/gnus/gnus-util.el index b7477a7fa8..ed112273ca 100644 --- a/lisp/gnus/gnus-util.el +++ b/lisp/gnus/gnus-util.el @@ -1117,41 +1117,9 @@ gnus-alive-p (with-current-buffer gnus-group-buffer (eq major-mode 'gnus-group-mode)))) -(defun gnus-remove-if (predicate sequence &optional hash-table-p) - "Return a copy of SEQUENCE with all items satisfying PREDICATE removed. -SEQUENCE should be a list, a vector, or a string. Returns always a list. -If HASH-TABLE-P is non-nil, regards SEQUENCE as a hash table." - (let (out) - (if hash-table-p - (mapatoms (lambda (symbol) - (unless (funcall predicate symbol) - (push symbol out))) - sequence) - (unless (listp sequence) - (setq sequence (append sequence nil))) - (while sequence - (unless (funcall predicate (car sequence)) - (push (car sequence) out)) - (setq sequence (cdr sequence)))) - (nreverse out))) - -(defun gnus-remove-if-not (predicate sequence &optional hash-table-p) - "Return a copy of SEQUENCE with all items not satisfying PREDICATE removed. -SEQUENCE should be a list, a vector, or a string. Returns always a list. -If HASH-TABLE-P is non-nil, regards SEQUENCE as a hash table." - (let (out) - (if hash-table-p - (mapatoms (lambda (symbol) - (when (funcall predicate symbol) - (push symbol out))) - sequence) - (unless (listp sequence) - (setq sequence (append sequence nil))) - (while sequence - (when (funcall predicate (car sequence)) - (push (car sequence) out)) - (setq sequence (cdr sequence)))) - (nreverse out))) +(define-obsolete-function-alias 'gnus-remove-if 'seq-remove "27.1") + +(define-obsolete-function-alias 'gnus-remove-if-not 'seq-filter "27.1") (defun gnus-grep-in-list (word list) "Find if a WORD matches any regular expression in the given LIST." diff --git a/lisp/gnus/gnus-win.el b/lisp/gnus/gnus-win.el index 8e47ae3f98..4f720463b4 100644 --- a/lisp/gnus/gnus-win.el +++ b/lisp/gnus/gnus-win.el @@ -513,7 +513,7 @@ gnus-get-buffer-window (memq frame '(t 0 visible))) (car (let ((frames (frames-on-display-list))) - (gnus-remove-if (lambda (win) (not (memq (window-frame win) + (seq-remove (lambda (win) (not (memq (window-frame win) frames))) (get-buffer-window-list buffer nil frame))))) (t diff --git a/lisp/gnus/gnus.el b/lisp/gnus/gnus.el index 3458fdea71..597470c381 100644 --- a/lisp/gnus/gnus.el +++ b/lisp/gnus/gnus.el @@ -33,6 +33,7 @@ (require 'wid-edit) (require 'mm-util) (require 'nnheader) +(require 'seq) ;; These are defined afterwards with gnus-define-group-parameter (defvar gnus-ham-process-destinations) diff --git a/lisp/gnus/nnmail.el b/lisp/gnus/nnmail.el index ad58d29208..5ed80a9bb6 100644 --- a/lisp/gnus/nnmail.el +++ b/lisp/gnus/nnmail.el @@ -2034,7 +2034,7 @@ nnmail-purge-split-history "Remove all instances of GROUP from `nnmail-split-history'." (let ((history nnmail-split-history)) (while history - (setcar history (gnus-remove-if (lambda (e) (string= (car e) group)) + (setcar history (seq-remove (lambda (e) (string= (car e) group)) (car history))) (pop history)) (setq nnmail-split-history (delq nil nnmail-split-history)))) diff --git a/lisp/gnus/nnmaildir.el b/lisp/gnus/nnmaildir.el index 708a3426af..3e4a87cee7 100644 --- a/lisp/gnus/nnmaildir.el +++ b/lisp/gnus/nnmaildir.el @@ -915,7 +915,7 @@ nnmaildir-request-scan (setq dirs (funcall srv-ls srv-dir nil "\\`[^.]" 'nosort) dirs (if (zerop (length target-prefix)) dirs - (gnus-remove-if + (seq-remove (lambda (dir) (and (>= (length dir) (length target-prefix)) (string= (substring dir 0 diff --git a/lisp/gnus/nnrss.el b/lisp/gnus/nnrss.el index 9a3a562a5d..aa19c376d1 100644 --- a/lisp/gnus/nnrss.el +++ b/lisp/gnus/nnrss.el @@ -625,7 +625,7 @@ nnrss-mime-encode-string ;;; Snarf functions (defun nnrss-make-hash-index (item) (gnus-message 9 "nnrss: Making hash index of %s" (gnus-prin1-to-string item)) - (setq item (gnus-remove-if + (setq item (seq-remove (lambda (field) (when (listp field) (memq (car field) nnrss-ignore-article-fields))) -- 2.15.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 28 12:23:37 2017 Received: (at 29489) by debbugs.gnu.org; 28 Nov 2017 17:23:37 +0000 Received: from localhost ([127.0.0.1]:34946 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJjbd-00045i-1k for submit@debbugs.gnu.org; Tue, 28 Nov 2017 12:23:37 -0500 Received: from eggs.gnu.org ([208.118.235.92]:51608) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJjbc-00045W-3j for 29489@debbugs.gnu.org; Tue, 28 Nov 2017 12:23:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eJjbR-0002tM-V1 for 29489@debbugs.gnu.org; Tue, 28 Nov 2017 12:23:30 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_40,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:49350) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eJjbR-0002tE-R8; Tue, 28 Nov 2017 12:23:25 -0500 Received: from auth2-smtp.messagingengine.com ([66.111.4.228]:38055) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.82) (envelope-from ) id 1eJjbR-0007B0-Gk; Tue, 28 Nov 2017 12:23:25 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailauth.nyi.internal (Postfix) with ESMTP id 818A920C21; Tue, 28 Nov 2017 12:23:24 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute4.internal (MEProxy); Tue, 28 Nov 2017 12:23:24 -0500 X-ME-Sender: Received: from localhost (d-69-91-135-157.dhcp4.washington.edu [69.91.135.157]) by mail.messagingengine.com (Postfix) with ESMTPA id 3696B7E56E; Tue, 28 Nov 2017 12:23:24 -0500 (EST) From: "John Wiegley" To: Eric Abrahamsen Subject: Re: bug#29489: Obsolete gnus-remove-if and gnus-remove-if-not In-Reply-To: <87o9nmgwue.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Tue, 28 Nov 2017 09:02:49 -0800") Date: Tue, 28 Nov 2017 09:23:21 -0800 Message-ID: References: <87o9nmgwue.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (darwin) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 29489 Cc: 29489@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) >>>>> "EA" == Eric Abrahamsen writes: EA> I've replaced these with `seq-remove' and `seq-filter', and I suppose EA> someone might object to that -- the other option would be `cl-remove-if' EA> and `cl-remove-if-not'. I don't believe there's much practical difference. I have no objection to using seq over its cl- equivalents. -- John Wiegley GPG fingerprint = 4710 CF98 AF9B 327B B80F http://newartisans.com 60E1 46C4 BD1A 7AC1 4BA2 From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 28 12:28:32 2017 Received: (at control) by debbugs.gnu.org; 28 Nov 2017 17:28:32 +0000 Received: from localhost ([127.0.0.1]:34957 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJjgO-0004D9-Hm for submit@debbugs.gnu.org; Tue, 28 Nov 2017 12:28:32 -0500 Received: from mail.ericabrahamsen.net ([50.56.99.223]:53237) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJjgN-0004D2-Mv for control@debbugs.gnu.org; Tue, 28 Nov 2017 12:28:31 -0500 Received: from localhost (71-212-22-173.tukw.qwest.net [71.212.22.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id B6408C0329 for ; Tue, 28 Nov 2017 17:28:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mail.ericabrahamsen.net; s=mail; t=1511890110; bh=UrRHf26NyFIT3imOBhbUQCgO3geJ00+EKdYm0QifYKU=; h=From:To:Subject:Date:From; b=kx94HP3xyrVGXOrO/lghiNs+0J48uPmvlRY9u+sawFbxaHrROxQSfCAStNBEtimFZ EglFD4fsVq0fI0cSMebjKLA6GzLdf9ucjzBTcUWAH4u5VZviImGeZ1IW7soYapA1L6 uwqXQDySnh9sC/UJuVycDofgCcPd+1oPTpJxwCFc= From: Eric Abrahamsen To: control@debbugs.gnu.org Subject: Close 28856 and 28867 Date: Tue, 28 Nov 2017 09:06:44 -0800 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Message-ID: <87a7z6gvnm.fsf@ericabrahamsen.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) close 28856 close 28867 tags 29489 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 28 13:02:17 2017 Received: (at submit) by debbugs.gnu.org; 28 Nov 2017 18:02:17 +0000 Received: from localhost ([127.0.0.1]:35013 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJkD2-0006xQ-TC for submit@debbugs.gnu.org; Tue, 28 Nov 2017 13:02:17 -0500 Received: from eggs.gnu.org ([208.118.235.92]:47810) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJkCz-0006xC-O4 for submit@debbugs.gnu.org; Tue, 28 Nov 2017 13:02:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eJkCl-0007Nh-70 for submit@debbugs.gnu.org; Tue, 28 Nov 2017 13:02:08 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:40932) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eJkCl-0007Nb-3J for submit@debbugs.gnu.org; Tue, 28 Nov 2017 13:01:59 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38744) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eJkCk-0002B6-2s for bug-gnu-emacs@gnu.org; Tue, 28 Nov 2017 13:01:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eJkCg-0007Kv-TX for bug-gnu-emacs@gnu.org; Tue, 28 Nov 2017 13:01:58 -0500 Received: from [195.159.176.226] (port=56147 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eJkCg-0007K0-Lh for bug-gnu-emacs@gnu.org; Tue, 28 Nov 2017 13:01:54 -0500 Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1eJkCV-0008DY-Fg for bug-gnu-emacs@gnu.org; Tue, 28 Nov 2017 19:01:43 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org From: Eric Abrahamsen Subject: Re: bug#29489: Obsolete gnus-remove-if and gnus-remove-if-not Date: Tue, 28 Nov 2017 10:01:36 -0800 Lines: 14 Message-ID: <87zi76ffjz.fsf@ericabrahamsen.net> References: <87o9nmgwue.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain X-Complaints-To: usenet@blaine.gmane.org User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cancel-Lock: sha1:o0+DlflBzM1bA2hm2vRIgsM9Ceg= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) "John Wiegley" writes: >>>>>> "EA" == Eric Abrahamsen writes: > > EA> I've replaced these with `seq-remove' and `seq-filter', and I suppose > EA> someone might object to that -- the other option would be `cl-remove-if' > EA> and `cl-remove-if-not'. I don't believe there's much practical difference. > > I have no objection to using seq over its cl- equivalents. Cool. I'll run this patch a while longer, then push. Thanks, Eric From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 28 18:44:15 2017 Received: (at 29489) by debbugs.gnu.org; 28 Nov 2017 23:44:15 +0000 Received: from localhost ([127.0.0.1]:35327 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJpXz-0000Lw-4e for submit@debbugs.gnu.org; Tue, 28 Nov 2017 18:44:15 -0500 Received: from mail-io0-f171.google.com ([209.85.223.171]:35837) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJpXy-0000Lk-6e for 29489@debbugs.gnu.org; Tue, 28 Nov 2017 18:44:14 -0500 Received: by mail-io0-f171.google.com with SMTP id q15so1813621ioh.2 for <29489@debbugs.gnu.org>; Tue, 28 Nov 2017 15:44:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=5aZzepeyyaWGeWlaSDl2x6Tcb4RkXlJFNuk0o9OxADo=; b=J/D3Gx1jYxITtMR7PZEZsdtcQUgaY58NX8+qv5CBBZ/gjePzgOeI8Hw/BMUidTKlm7 v5QSKWUuq3L1XPPpNO58kdrNB0aicnDOBpgjHZDNh0dFSAyXPS0hxDFOcPXR+uboCyDx IOpMLKLMfQgNpE6GrF3aitbru7j8DmXnIdzLf6y/r9a/yvpCdX2N8htN74QRNn+knE7X Yp54QxGBm4nz1jJenY/cgk3Qy1KqqM+yJWgFoIoNgS6xV5Jtuu1lxZoo7SAnQMmnfI7X iV/2fAzlecfvyXzhyux3c4M47o04XilpLsEIr7l4m9/lsiyExLo8+HBnVvrblfRsYDRA 7xFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=5aZzepeyyaWGeWlaSDl2x6Tcb4RkXlJFNuk0o9OxADo=; b=GJAFEFHnk1CzRCJhZcxe/XtoFiX7JG4TI9DZUNCccdWi1uiplDzR9VGJtVpfbhO4hX qf+QEazrcf3rp8D5VbNRELyIkrr0e4hKQRW7mQLxxORrLPgnlnTJhk4vuQJdgYJxhm1U m9L5HFPJoUaLZsJ9QjLE25vM1vvO40Ye6J31qQ22EUWuWXdOg50iZV1vyod0qHm8HqPc OPWvjoQjOcAa7K9VzHEYcoCX56uepd8CJ6GfcFEBNPJV6e5dlsx4yb8Lo0GYs5p4YGrn UhewhdXx5uXvP7kBoaCe0wDhnZ+2OKKQGCZo5gIXUSBznPq/K0g8hHATnz4sjsT8CXAO rFxQ== X-Gm-Message-State: AJaThX4lI3b6Cfat69Il8ED8Df2EacpZ4h4EQ/NG0dL/olfzct/QMhzg uF9YWOg2NhOpoNH5+aDk/As4ng== X-Google-Smtp-Source: AGs4zMYiuKoBnrPw5ILiOb4/kBT+KOpADCHC+7F0D1AlWN5Ged0LhC/p7cs/hua0/WgRc4v4mgabaQ== X-Received: by 10.107.143.85 with SMTP id r82mr1105835iod.299.1511912648143; Tue, 28 Nov 2017 15:44:08 -0800 (PST) Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id l126sm171169ioe.65.2017.11.28.15.44.06 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 28 Nov 2017 15:44:06 -0800 (PST) From: Noam Postavsky To: Eric Abrahamsen Subject: Re: bug#29489: Obsolete gnus-remove-if and gnus-remove-if-not References: <87o9nmgwue.fsf@ericabrahamsen.net> Date: Tue, 28 Nov 2017 18:44:05 -0500 In-Reply-To: <87o9nmgwue.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Tue, 28 Nov 2017 09:02:49 -0800") Message-ID: <87r2sim0je.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 29489 Cc: 29489@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Eric Abrahamsen writes: > Here's another one of these. > > I've replaced these with `seq-remove' and `seq-filter', and I suppose > someone might object to that -- the other option would be `cl-remove-if' > and `cl-remove-if-not'. I don't believe there's much practical difference. Neither the seq nor cl functions handle hash tables right? > - (gnus-remove-if-not 'gnus-valid-move-group-p gnus-active-hashtb t) > + (seq-filter 'gnus-valid-move-group-p gnus-active-hashtb) > nil prefix nil default)) > ((= 1 (length split-name)) > (gnus-group-completing-read > prom > - (gnus-remove-if-not 'gnus-valid-move-group-p gnus-active-hashtb t) > + (seq-filter 'gnus-valid-move-group-p gnus-active-hashtb) > nil prefix 'gnus-group-history (car split-name))) > -(defun gnus-remove-if (predicate sequence &optional hash-table-p) > - "Return a copy of SEQUENCE with all items satisfying PREDICATE removed. > -SEQUENCE should be a list, a vector, or a string. Returns always a list. > -If HASH-TABLE-P is non-nil, regards SEQUENCE as a hash table." Although the docstring claims "hash table", while the code says... > - (if hash-table-p > - (mapatoms (lambda (symbol) > - (unless (funcall predicate symbol) > - (push symbol out))) > - sequence) obarray? From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 28 19:07:35 2017 Received: (at submit) by debbugs.gnu.org; 29 Nov 2017 00:07:35 +0000 Received: from localhost ([127.0.0.1]:35332 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJpuZ-0000t2-5d for submit@debbugs.gnu.org; Tue, 28 Nov 2017 19:07:35 -0500 Received: from eggs.gnu.org ([208.118.235.92]:35133) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJpuY-0000sq-29 for submit@debbugs.gnu.org; Tue, 28 Nov 2017 19:07:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eJpuS-0003dl-1U for submit@debbugs.gnu.org; Tue, 28 Nov 2017 19:07:28 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_40 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:58421) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eJpuR-0003db-Ub for submit@debbugs.gnu.org; Tue, 28 Nov 2017 19:07:27 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54308) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eJpuQ-0007we-PU for bug-gnu-emacs@gnu.org; Tue, 28 Nov 2017 19:07:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eJpuM-0003bS-PF for bug-gnu-emacs@gnu.org; Tue, 28 Nov 2017 19:07:26 -0500 Received: from [195.159.176.226] (port=38776 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eJpuM-0003av-In for bug-gnu-emacs@gnu.org; Tue, 28 Nov 2017 19:07:22 -0500 Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1eJpu7-0004bq-UI for bug-gnu-emacs@gnu.org; Wed, 29 Nov 2017 01:07:07 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org From: Eric Abrahamsen Subject: Re: bug#29489: Obsolete gnus-remove-if and gnus-remove-if-not Date: Tue, 28 Nov 2017 16:07:03 -0800 Lines: 44 Message-ID: <87a7z6c5i0.fsf@ericabrahamsen.net> References: <87o9nmgwue.fsf@ericabrahamsen.net> <87r2sim0je.fsf@users.sourceforge.net> Mime-Version: 1.0 Content-Type: text/plain X-Complaints-To: usenet@blaine.gmane.org User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cancel-Lock: sha1:+hv328HPfBUngQu8K87lPHhRT1A= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Noam Postavsky writes: > Eric Abrahamsen writes: > >> Here's another one of these. >> >> I've replaced these with `seq-remove' and `seq-filter', and I suppose >> someone might object to that -- the other option would be `cl-remove-if' >> and `cl-remove-if-not'. I don't believe there's much practical difference. > > Neither the seq nor cl functions handle hash tables right? > >> - (gnus-remove-if-not 'gnus-valid-move-group-p gnus-active-hashtb t) >> + (seq-filter 'gnus-valid-move-group-p gnus-active-hashtb) >> nil prefix nil default)) >> ((= 1 (length split-name)) >> (gnus-group-completing-read >> prom >> - (gnus-remove-if-not 'gnus-valid-move-group-p gnus-active-hashtb t) >> + (seq-filter 'gnus-valid-move-group-p gnus-active-hashtb) >> nil prefix 'gnus-group-history (car split-name))) > >> -(defun gnus-remove-if (predicate sequence &optional hash-table-p) >> - "Return a copy of SEQUENCE with all items satisfying PREDICATE removed. >> -SEQUENCE should be a list, a vector, or a string. Returns always a list. >> -If HASH-TABLE-P is non-nil, regards SEQUENCE as a hash table." > > Although the docstring claims "hash table", while the code says... > >> - (if hash-table-p >> - (mapatoms (lambda (symbol) >> - (unless (funcall predicate symbol) >> - (push symbol out))) >> - sequence) > > obarray? Shhh, that's my next patch to Gnus! Turning its "hash tables" into actual hash tables. The obarrays are an impressive and horrible hack. For this version of the patch, `seq-filter' works on vectors. In the next patch, it's replaced by seq-filter->map-keys. Eric From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 28 19:40:59 2017 Received: (at 29489) by debbugs.gnu.org; 29 Nov 2017 00:40:59 +0000 Received: from localhost ([127.0.0.1]:35340 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJqQs-0001do-Sv for submit@debbugs.gnu.org; Tue, 28 Nov 2017 19:40:59 -0500 Received: from mail-it0-f47.google.com ([209.85.214.47]:38088) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJqQq-0001db-Rh for 29489@debbugs.gnu.org; Tue, 28 Nov 2017 19:40:57 -0500 Received: by mail-it0-f47.google.com with SMTP id r6so2061638itr.3 for <29489@debbugs.gnu.org>; Tue, 28 Nov 2017 16:40:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=3sdagyD/2g7fXfZrKrV293/TCYsRfKGKu3Z+Uk26nMA=; b=A1RcDnHz3+gPoPTwPQiCdssQuBM7t23jlNIXcGa0xao+AQcL0ShZPjlRvBo3uKIwyH /5gqojXm27VqIDPJDabGYpJ9qSYl5sZVGuX1TwzkFQTYxBm2NQtVKzBrAc/MwuUm9p7+ +v8wYcCUchptAl5FjvEGACj9x2jOEsmGIc3O4CftW2HltWcyqxcoJ+4oq0mpbGbhvecj n8znoSFi9kE8U6s0lLxTNteyfUCM1p+yXbTIOp5d8NJ2vrmuyoRMKoJKiRizLssknqh8 c9PU5/Hgs9DruSCYkZQVsmxS0m9J4mwMdo5/qzbzKyhySkuUbQTstSeb5q9R7SFRLbEZ uyAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=3sdagyD/2g7fXfZrKrV293/TCYsRfKGKu3Z+Uk26nMA=; b=BJn6Qmr+P6lBnGNOsBSc/ZxYpiP34cYrddV+taCSxJgOy5iLYvitvwGLAavjNmBYRN g/YW23coM9BSreisv3XSb/74V1Lywb1MlhNotv+/SPIp/xygHCG3F23F5cTxC0Eg2Wh/ yLN+Lv/NGEHHx4BDfB+uZ46AzZ1LQ05Ct4J70sSmgOXwtZ648BTOhtfqaogHvFb1unPR XVjOoI+uEu0tbfTSMgaG2O5SdMNs0dTbu2mKtfkqiT2QGVGkEOK/J8QLft2Zv3nDQB4p b7ogqPj3uvB73jZi7G7Mn2ZGWvSznVcXWa/7V2dIYGgNRqEFbcJ/ku5FLXl0F+pYBxpm 1Idg== X-Gm-Message-State: AJaThX4ZKW/fsPJ6t/h2RqVxdDPlS6FaOYbZcZn5Z++186JnDPo34L7S NyMcn0xMXriC7Grm7bg2vQrJCQ== X-Google-Smtp-Source: AGs4zMaBUxgPMPNpb3rFiGC1V9uJAHAQx5F/e4MOvrJ4lcdrwNveUPEWvv/WLLw7H3EYw6U8S9Vj6g== X-Received: by 10.36.105.66 with SMTP id e63mr5135230itc.46.1511916050733; Tue, 28 Nov 2017 16:40:50 -0800 (PST) Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id 134sm234794ion.0.2017.11.28.16.40.48 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 28 Nov 2017 16:40:49 -0800 (PST) From: Noam Postavsky To: Eric Abrahamsen Subject: Re: bug#29489: Obsolete gnus-remove-if and gnus-remove-if-not References: <87o9nmgwue.fsf@ericabrahamsen.net> <87r2sim0je.fsf@users.sourceforge.net> <87a7z6c5i0.fsf@ericabrahamsen.net> Date: Tue, 28 Nov 2017 19:40:47 -0500 In-Reply-To: <87a7z6c5i0.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Tue, 28 Nov 2017 16:07:03 -0800") Message-ID: <87mv35nchc.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 29489 Cc: 29489@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Eric Abrahamsen writes: >> Although the docstring claims "hash table", while the code says... >> >>> - (if hash-table-p >>> - (mapatoms (lambda (symbol) >>> - (unless (funcall predicate symbol) >>> - (push symbol out))) >>> - sequence) >> >> obarray? > > Shhh, that's my next patch to Gnus! Turning its "hash tables" into > actual hash tables. The obarrays are an impressive and horrible hack. > > For this version of the patch, `seq-filter' works on vectors. In the > next patch, it's replaced by seq-filter->map-keys. Hmm, seq-filter works on vectors, but it's not reliable for obarrays: (let ((list nil) (ob (make-vector 3 0))) (intern "foo" ob) (intern "bar" ob) (intern "xxx" ob) (seq-filter (lambda (_) t) ob)) ;=> (xxx 0 0) From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 28 20:42:32 2017 Received: (at submit) by debbugs.gnu.org; 29 Nov 2017 01:42:32 +0000 Received: from localhost ([127.0.0.1]:35366 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJrOR-000380-TS for submit@debbugs.gnu.org; Tue, 28 Nov 2017 20:42:32 -0500 Received: from eggs.gnu.org ([208.118.235.92]:44188) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJrOP-00037i-3i for submit@debbugs.gnu.org; Tue, 28 Nov 2017 20:42:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eJrOI-00047y-K0 for submit@debbugs.gnu.org; Tue, 28 Nov 2017 20:42:23 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:39757) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eJrOI-00047o-HE for submit@debbugs.gnu.org; Tue, 28 Nov 2017 20:42:22 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35145) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eJrOH-0002XK-8X for bug-gnu-emacs@gnu.org; Tue, 28 Nov 2017 20:42:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eJrOE-00046C-0K for bug-gnu-emacs@gnu.org; Tue, 28 Nov 2017 20:42:21 -0500 Received: from [195.159.176.226] (port=35186 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eJrOD-00045W-P7 for bug-gnu-emacs@gnu.org; Tue, 28 Nov 2017 20:42:17 -0500 Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1eJrO3-0006s4-HD for bug-gnu-emacs@gnu.org; Wed, 29 Nov 2017 02:42:07 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org From: Eric Abrahamsen Subject: Re: bug#29489: Obsolete gnus-remove-if and gnus-remove-if-not Date: Tue, 28 Nov 2017 17:42:08 -0800 Lines: 40 Message-ID: <87609tdfnz.fsf@ericabrahamsen.net> References: <87o9nmgwue.fsf@ericabrahamsen.net> <87r2sim0je.fsf@users.sourceforge.net> <87a7z6c5i0.fsf@ericabrahamsen.net> <87mv35nchc.fsf@users.sourceforge.net> Mime-Version: 1.0 Content-Type: text/plain X-Complaints-To: usenet@blaine.gmane.org User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cancel-Lock: sha1:rFshlwEbMlUZhIkZz81JaPKIlSE= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Noam Postavsky writes: > Eric Abrahamsen writes: > >>> Although the docstring claims "hash table", while the code says... >>> >>>> - (if hash-table-p >>>> - (mapatoms (lambda (symbol) >>>> - (unless (funcall predicate symbol) >>>> - (push symbol out))) >>>> - sequence) >>> >>> obarray? >> >> Shhh, that's my next patch to Gnus! Turning its "hash tables" into >> actual hash tables. The obarrays are an impressive and horrible hack. >> >> For this version of the patch, `seq-filter' works on vectors. In the >> next patch, it's replaced by seq-filter->map-keys. > > Hmm, seq-filter works on vectors, but it's not reliable for obarrays: > > (let ((list nil) > (ob (make-vector 3 0))) > (intern "foo" ob) > (intern "bar" ob) > (intern "xxx" ob) > (seq-filter (lambda (_) t) ob)) ;=> (xxx 0 0) For the interim, all that matters is consistency: (let ((list nil) (ob (make-vector 3 0))) (intern "foo" ob) (intern "bar" ob) (intern "xxx" ob) (gnus-remove-if-not (lambda (_) t) ob)) ;=> (xxx 0 0) The goal of this patch series is to get Gnus into a state where behavior is at-a-glance comprehensible. From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 28 21:36:40 2017 Received: (at 29489) by debbugs.gnu.org; 29 Nov 2017 02:36:40 +0000 Received: from localhost ([127.0.0.1]:35496 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJsEq-0001tO-6k for submit@debbugs.gnu.org; Tue, 28 Nov 2017 21:36:40 -0500 Received: from mail-it0-f47.google.com ([209.85.214.47]:43962) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJsEp-0001tC-16 for 29489@debbugs.gnu.org; Tue, 28 Nov 2017 21:36:39 -0500 Received: by mail-it0-f47.google.com with SMTP id u62so2283405ita.2 for <29489@debbugs.gnu.org>; Tue, 28 Nov 2017 18:36:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=bdP8WJ973uZ4XiI4kCOVb1VlDXpbHyVXJkoVzqwd6GU=; b=ZZ3uAu/Linvdzc6vc+4Q1GOQiLxjPqbA3E6WJ2fI7zIjhJdvjHPSJvhZFVyaRAReyg fzoC0EtFByPHGZvdHiBv9wjVSb9lbMDhoTSvV8OCwAhRyaE6+c498sxgt6Iw6W27iDj5 cN6hjSwOz+jJnuFAtj97KWqWOSLwVhneMQV7ugnjHgRlo8hIqui8iU7E9GVAO6tF7MBZ UFCxoMxPZYvHTfQU5KdYzdaZjU+IDi+g4ZBQCuZzpe0pKAc7UfDysAsrvS1OyZeUQnQl XLHWGGCS3cU4RqETc4KoT+xgzM5n9seDExuuEChO4QFmTcpwc1L1/2rM0Ug4grye9nbO dw6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=bdP8WJ973uZ4XiI4kCOVb1VlDXpbHyVXJkoVzqwd6GU=; b=R1ZeYcUv4JOckvrnusjygqKDZplSDYtBsDGxZci3KZDcNFgDPVaR7Hhm6P4/CKi+y5 +MXG4y4+rdu+ZXpmcPnljdxp4YrHj++8pqpmxSxagk4KK3UYAEXP8bt5dnIcKrlxskCd 6c/WqM6PGOrrmDo5kPS0JN43Gg7d7hMRX/XKZabf2XXMpx6trYjJ6UpV/ZRHSoJqSrHQ nYDImkA2EYH+JTJ3KSllSlR4M2tNyKqpjdK/X0MQ7WjT0Ugmf407gmftsCw5ErDG147h qlfF94etyRretSRlD6Oj6Y60sIuwIeEwUH/vIhvD/iYW7KLhPbVxl6VEZ0/cRyTJmU0M dziw== X-Gm-Message-State: AJaThX5CEfyRihTBvUlEEMLbvCGUYg5K+D/61mkLMog7BcCq4yPlPR/2 XDxGHgW+GQJCunxWLJyY46mfAv+P X-Google-Smtp-Source: AGs4zMbgkocovVC9EcWGF5KIVOqARCsINyL6xb7BHmr5tx4fDfNkuAjDHaY5Y1nM1VDjZ14/OafBpQ== X-Received: by 10.36.4.144 with SMTP id 138mr5634618itb.78.1511922993437; Tue, 28 Nov 2017 18:36:33 -0800 (PST) Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id r65sm522890ith.1.2017.11.28.18.36.32 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 28 Nov 2017 18:36:32 -0800 (PST) From: Noam Postavsky To: Eric Abrahamsen Subject: Re: bug#29489: Obsolete gnus-remove-if and gnus-remove-if-not References: <87o9nmgwue.fsf@ericabrahamsen.net> <87r2sim0je.fsf@users.sourceforge.net> <87a7z6c5i0.fsf@ericabrahamsen.net> <87mv35nchc.fsf@users.sourceforge.net> <87609tdfnz.fsf@ericabrahamsen.net> Date: Tue, 28 Nov 2017 21:36:31 -0500 In-Reply-To: <87609tdfnz.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Tue, 28 Nov 2017 17:42:08 -0800") Message-ID: <871skhlsk0.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 29489 Cc: 29489@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Eric Abrahamsen writes: > For the interim, all that matters is consistency: > > (let ((list nil) > (ob (make-vector 3 0))) > (intern "foo" ob) > (intern "bar" ob) > (intern "xxx" ob) > (gnus-remove-if-not (lambda (_) t) ob)) ;=> (xxx 0 0) But: (let ((list nil) (ob (make-vector 3 0))) (intern "foo" ob) (intern "bar" ob) (intern "xxx" ob) (gnus-remove-if-not (lambda (_) t) ob t)) ;=> (xxx bar foo) From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 28 22:31:21 2017 Received: (at 29489) by debbugs.gnu.org; 29 Nov 2017 03:31:21 +0000 Received: from localhost ([127.0.0.1]:35515 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJt5j-00070N-JS for submit@debbugs.gnu.org; Tue, 28 Nov 2017 22:31:21 -0500 Received: from mail.ericabrahamsen.net ([50.56.99.223]:39540) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJt5i-00070F-IJ for 29489@debbugs.gnu.org; Tue, 28 Nov 2017 22:31:18 -0500 Received: from localhost (71-212-22-173.tukw.qwest.net [71.212.22.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id A3747BF303; Wed, 29 Nov 2017 03:31:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mail.ericabrahamsen.net; s=mail; t=1511926277; bh=r+Q01PG/22G0L5lJpnMKTU39YgRH62tqZtiR/S3WrH4=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=JlxzzXF1wFOGbhsr1UxhQXqcMiyQ4/3qK15+l1gdJQGFai2bw+bTJhuXnZrxc7i7l c7l1i6IPdjSJUMySH9lc+xteFQJjWhctRNxn5njBZXvIpTo/m1XBXhjUXEameo5lLJ DdFhwsb3+BfokLBghJM0nu4ksMh7dySCoxCXZH8s= From: Eric Abrahamsen To: Noam Postavsky Subject: Re: bug#29489: Obsolete gnus-remove-if and gnus-remove-if-not References: <87o9nmgwue.fsf@ericabrahamsen.net> <87r2sim0je.fsf@users.sourceforge.net> <87a7z6c5i0.fsf@ericabrahamsen.net> <87mv35nchc.fsf@users.sourceforge.net> <87609tdfnz.fsf@ericabrahamsen.net> <871skhlsk0.fsf@users.sourceforge.net> Date: Tue, 28 Nov 2017 19:31:16 -0800 In-Reply-To: <871skhlsk0.fsf@users.sourceforge.net> (Noam Postavsky's message of "Tue, 28 Nov 2017 21:36:31 -0500") Message-ID: <871skhdam3.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 29489 Cc: 29489@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Noam Postavsky writes: > Eric Abrahamsen writes: > >> For the interim, all that matters is consistency: >> >> (let ((list nil) >> (ob (make-vector 3 0))) >> (intern "foo" ob) >> (intern "bar" ob) >> (intern "xxx" ob) >> (gnus-remove-if-not (lambda (_) t) ob)) ;=> (xxx 0 0) > > But: > > (let ((list nil) > (ob (make-vector 3 0))) > (intern "foo" ob) > (intern "bar" ob) > (intern "xxx" ob) > (gnus-remove-if-not (lambda (_) t) > ob t)) ;=> (xxx bar foo) Good catch! Thanks for that. I was too hasty, and had already moved on to running the next patch. There are only two places in the code where that third argument is passed. I can rework those two locations so that they work properly, until the next step is taken. From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 01 12:17:32 2017 Received: (at submit) by debbugs.gnu.org; 1 Dec 2017 17:17:32 +0000 Received: from localhost ([127.0.0.1]:40334 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eKowO-0003wy-DB for submit@debbugs.gnu.org; Fri, 01 Dec 2017 12:17:32 -0500 Received: from eggs.gnu.org ([208.118.235.92]:43288) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eKowN-0003wm-Lo for submit@debbugs.gnu.org; Fri, 01 Dec 2017 12:17:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eKowG-0006GO-Dq for submit@debbugs.gnu.org; Fri, 01 Dec 2017 12:17:26 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=1.8 required=5.0 tests=BAYES_50,DATE_IN_PAST_12_24 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:33748) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eKowG-0006GI-8A for submit@debbugs.gnu.org; Fri, 01 Dec 2017 12:17:24 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34152) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eKowD-0007jI-H4 for bug-gnu-emacs@gnu.org; Fri, 01 Dec 2017 12:17:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eKowA-00068g-5a for bug-gnu-emacs@gnu.org; Fri, 01 Dec 2017 12:17:21 -0500 Received: from [195.159.176.226] (port=34691 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eKow8-00064D-IT for bug-gnu-emacs@gnu.org; Fri, 01 Dec 2017 12:17:18 -0500 Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1eKTai-0006bW-EG for bug-gnu-emacs@gnu.org; Thu, 30 Nov 2017 19:29:44 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org From: Eric Abrahamsen Subject: Re: bug#29489: Obsolete gnus-remove-if and gnus-remove-if-not Date: Thu, 30 Nov 2017 10:29:44 -0800 Lines: 308 Message-ID: <87zi73tyav.fsf@ericabrahamsen.net> References: <87o9nmgwue.fsf@ericabrahamsen.net> <87r2sim0je.fsf@users.sourceforge.net> <87a7z6c5i0.fsf@ericabrahamsen.net> <87mv35nchc.fsf@users.sourceforge.net> <87609tdfnz.fsf@ericabrahamsen.net> <871skhlsk0.fsf@users.sourceforge.net> <871skhdam3.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Complaints-To: usenet@blaine.gmane.org User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cancel-Lock: sha1:LThlK6Lj169snAz5pF68XixdpiQ= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.2 (----) --=-=-= Content-Type: text/plain Eric Abrahamsen writes: > Noam Postavsky writes: > >> Eric Abrahamsen writes: >> >>> For the interim, all that matters is consistency: >>> >>> (let ((list nil) >>> (ob (make-vector 3 0))) >>> (intern "foo" ob) >>> (intern "bar" ob) >>> (intern "xxx" ob) >>> (gnus-remove-if-not (lambda (_) t) ob)) ;=> (xxx 0 0) >> >> But: >> >> (let ((list nil) >> (ob (make-vector 3 0))) >> (intern "foo" ob) >> (intern "bar" ob) >> (intern "xxx" ob) >> (gnus-remove-if-not (lambda (_) t) >> ob t)) ;=> (xxx bar foo) > > Good catch! Thanks for that. I was too hasty, and had already moved on > to running the next patch. > > There are only two places in the code where that third argument is > passed. I can rework those two locations so that they work properly, > until the next step is taken. For a brief, amusing moment, I thought I could write a seq-filter method that specialized on obarrays, but unfortunately there's no specializer for obarrays. Oh well. Here's another version of the patch. It's not pretty, but I do hope it's temporary. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Obsolete-gnus-remove-if-and-gnus-remove-if-not.patch >From 75ef198feb472c84a3fab5fd3e8d5f7e03ecdb01 Mon Sep 17 00:00:00 2001 From: Eric Abrahamsen Date: Sat, 25 Nov 2017 18:42:55 -0800 Subject: [PATCH] Obsolete gnus-remove-if and gnus-remove-if-not Use seq-remove and seq-filter, respectively, instead. * lisp/gnus/gnus-util.el: Remove functions and replace with define-obsolete-function-alias calls. * lisp/gnus/gnus.el: Require seq here. * lisp/gnus/gnus-art.el (gnus-mime-view-part-as-type): * lisp/gnus/gnus-icalendar.el (gnus-icalendar-event--get-attendee-names): * lisp/gnus/gnus-score.el (gnus-summary-score-effect): * lisp/gnus/gnus-sum.el (gnus-read-move-group-name): * lisp/gnus/gnus-topic.el (gnus-group-prepare-topics): * lisp/gnus/gnus-win.el (gnus-get-buffer-window): * lisp/gnus/nnmail.el (nnmail-purge-split-history): * lisp/gnus/nnmaildir.el (nnmaildir-request-scan): * lisp/gnus/nnrss.el (nnrss-make-hash-index): Replace calls in all these locations. --- lisp/gnus/gnus-art.el | 2 +- lisp/gnus/gnus-icalendar.el | 4 ++-- lisp/gnus/gnus-score.el | 2 +- lisp/gnus/gnus-sum.el | 34 ++++++++++++++++++++-------------- lisp/gnus/gnus-topic.el | 4 ++-- lisp/gnus/gnus-util.el | 38 +++----------------------------------- lisp/gnus/gnus-win.el | 2 +- lisp/gnus/gnus.el | 1 + lisp/gnus/nnmail.el | 2 +- lisp/gnus/nnmaildir.el | 2 +- lisp/gnus/nnrss.el | 2 +- 11 files changed, 34 insertions(+), 59 deletions(-) diff --git a/lisp/gnus/gnus-art.el b/lisp/gnus/gnus-art.el index 97aa878ab6..6ee0d7b023 100644 --- a/lisp/gnus/gnus-art.el +++ b/lisp/gnus/gnus-art.el @@ -5219,7 +5219,7 @@ gnus-mime-view-part-as-type (gnus-completing-read "View as MIME type" (if pred - (gnus-remove-if-not pred (mailcap-mime-types)) + (seq-filter pred (mailcap-mime-types)) (mailcap-mime-types)) nil nil nil (car default))))) diff --git a/lisp/gnus/gnus-icalendar.el b/lisp/gnus/gnus-icalendar.el index cca4a81d1c..38c3ea36d6 100644 --- a/lisp/gnus/gnus-icalendar.el +++ b/lisp/gnus/gnus-icalendar.el @@ -169,7 +169,7 @@ gnus-icalendar-event--find-attendee (defun gnus-icalendar-event--get-attendee-names (ical) (let* ((event (car (icalendar--all-events ical))) - (attendee-props (gnus-remove-if-not + (attendee-props (seq-filter (lambda (p) (eq (car p) 'ATTENDEE)) (caddr event)))) @@ -180,7 +180,7 @@ gnus-icalendar-event--get-attendee-names (or (plist-get (cadr prop) 'CN) (replace-regexp-in-string "^.*MAILTO:" "" (caddr prop)))) (attendees-by-type (type) - (gnus-remove-if-not + (seq-filter (lambda (p) (string= (attendee-role p) type)) attendee-props)) (attendee-names-by-type diff --git a/lisp/gnus/gnus-score.el b/lisp/gnus/gnus-score.el index 765dfab570..a2cc07db46 100644 --- a/lisp/gnus/gnus-score.el +++ b/lisp/gnus/gnus-score.el @@ -921,7 +921,7 @@ gnus-summary-score-effect (interactive (list (gnus-completing-read "Header" (mapcar 'car - (gnus-remove-if-not + (seq-filter (lambda (x) (fboundp (nth 2 x))) gnus-header-index)) t) diff --git a/lisp/gnus/gnus-sum.el b/lisp/gnus/gnus-sum.el index e599a8460f..4dee306c81 100644 --- a/lisp/gnus/gnus-sum.el +++ b/lisp/gnus/gnus-sum.el @@ -12270,21 +12270,27 @@ gnus-read-move-group-name (if (> (length articles) 1) (format "these %d articles" (length articles)) "this article"))) + valid-names (to-newsgroup - (cond - ((null split-name) - (gnus-group-completing-read - prom - (gnus-remove-if-not 'gnus-valid-move-group-p gnus-active-hashtb t) - nil prefix nil default)) - ((= 1 (length split-name)) - (gnus-group-completing-read - prom - (gnus-remove-if-not 'gnus-valid-move-group-p gnus-active-hashtb t) - nil prefix 'gnus-group-history (car split-name))) - (t - (gnus-completing-read - prom (nreverse split-name) nil nil 'gnus-group-history)))) + (progn + (mapatoms (lambda (g) + (when (gnus-valid-move-group-p g) + (push g valid-names))) + gnus-active-hashtb) + (cond + ((null split-name) + (gnus-group-completing-read + prom + valid-names + nil prefix nil default)) + ((= 1 (length split-name)) + (gnus-group-completing-read + prom + valid-names + nil prefix 'gnus-group-history (car split-name))) + (t + (gnus-completing-read + prom (nreverse split-name) nil nil 'gnus-group-history))))) (to-method (gnus-server-to-method (gnus-group-method to-newsgroup))) encoded) (when to-newsgroup diff --git a/lisp/gnus/gnus-topic.el b/lisp/gnus/gnus-topic.el index ba756e0314..065215b471 100644 --- a/lisp/gnus/gnus-topic.el +++ b/lisp/gnus/gnus-topic.el @@ -460,9 +460,9 @@ gnus-group-prepare-topics (unless gnus-killed-hashtb (gnus-make-hashtable-from-killed)) (gnus-group-prepare-flat-list-dead - (gnus-remove-if (lambda (group) + (seq-remove (lambda (group) (or (gnus-group-entry group) - (gnus-gethash group gnus-killed-hashtb))) + (gethash group gnus-killed-hashtb))) not-in-list) gnus-level-killed ?K regexp))) diff --git a/lisp/gnus/gnus-util.el b/lisp/gnus/gnus-util.el index b7477a7fa8..ed112273ca 100644 --- a/lisp/gnus/gnus-util.el +++ b/lisp/gnus/gnus-util.el @@ -1117,41 +1117,9 @@ gnus-alive-p (with-current-buffer gnus-group-buffer (eq major-mode 'gnus-group-mode)))) -(defun gnus-remove-if (predicate sequence &optional hash-table-p) - "Return a copy of SEQUENCE with all items satisfying PREDICATE removed. -SEQUENCE should be a list, a vector, or a string. Returns always a list. -If HASH-TABLE-P is non-nil, regards SEQUENCE as a hash table." - (let (out) - (if hash-table-p - (mapatoms (lambda (symbol) - (unless (funcall predicate symbol) - (push symbol out))) - sequence) - (unless (listp sequence) - (setq sequence (append sequence nil))) - (while sequence - (unless (funcall predicate (car sequence)) - (push (car sequence) out)) - (setq sequence (cdr sequence)))) - (nreverse out))) - -(defun gnus-remove-if-not (predicate sequence &optional hash-table-p) - "Return a copy of SEQUENCE with all items not satisfying PREDICATE removed. -SEQUENCE should be a list, a vector, or a string. Returns always a list. -If HASH-TABLE-P is non-nil, regards SEQUENCE as a hash table." - (let (out) - (if hash-table-p - (mapatoms (lambda (symbol) - (when (funcall predicate symbol) - (push symbol out))) - sequence) - (unless (listp sequence) - (setq sequence (append sequence nil))) - (while sequence - (when (funcall predicate (car sequence)) - (push (car sequence) out)) - (setq sequence (cdr sequence)))) - (nreverse out))) +(define-obsolete-function-alias 'gnus-remove-if 'seq-remove "27.1") + +(define-obsolete-function-alias 'gnus-remove-if-not 'seq-filter "27.1") (defun gnus-grep-in-list (word list) "Find if a WORD matches any regular expression in the given LIST." diff --git a/lisp/gnus/gnus-win.el b/lisp/gnus/gnus-win.el index 8e47ae3f98..4f720463b4 100644 --- a/lisp/gnus/gnus-win.el +++ b/lisp/gnus/gnus-win.el @@ -513,7 +513,7 @@ gnus-get-buffer-window (memq frame '(t 0 visible))) (car (let ((frames (frames-on-display-list))) - (gnus-remove-if (lambda (win) (not (memq (window-frame win) + (seq-remove (lambda (win) (not (memq (window-frame win) frames))) (get-buffer-window-list buffer nil frame))))) (t diff --git a/lisp/gnus/gnus.el b/lisp/gnus/gnus.el index 3458fdea71..597470c381 100644 --- a/lisp/gnus/gnus.el +++ b/lisp/gnus/gnus.el @@ -33,6 +33,7 @@ (require 'wid-edit) (require 'mm-util) (require 'nnheader) +(require 'seq) ;; These are defined afterwards with gnus-define-group-parameter (defvar gnus-ham-process-destinations) diff --git a/lisp/gnus/nnmail.el b/lisp/gnus/nnmail.el index ad58d29208..5ed80a9bb6 100644 --- a/lisp/gnus/nnmail.el +++ b/lisp/gnus/nnmail.el @@ -2034,7 +2034,7 @@ nnmail-purge-split-history "Remove all instances of GROUP from `nnmail-split-history'." (let ((history nnmail-split-history)) (while history - (setcar history (gnus-remove-if (lambda (e) (string= (car e) group)) + (setcar history (seq-remove (lambda (e) (string= (car e) group)) (car history))) (pop history)) (setq nnmail-split-history (delq nil nnmail-split-history)))) diff --git a/lisp/gnus/nnmaildir.el b/lisp/gnus/nnmaildir.el index 708a3426af..3e4a87cee7 100644 --- a/lisp/gnus/nnmaildir.el +++ b/lisp/gnus/nnmaildir.el @@ -915,7 +915,7 @@ nnmaildir-request-scan (setq dirs (funcall srv-ls srv-dir nil "\\`[^.]" 'nosort) dirs (if (zerop (length target-prefix)) dirs - (gnus-remove-if + (seq-remove (lambda (dir) (and (>= (length dir) (length target-prefix)) (string= (substring dir 0 diff --git a/lisp/gnus/nnrss.el b/lisp/gnus/nnrss.el index 9a3a562a5d..aa19c376d1 100644 --- a/lisp/gnus/nnrss.el +++ b/lisp/gnus/nnrss.el @@ -625,7 +625,7 @@ nnrss-mime-encode-string ;;; Snarf functions (defun nnrss-make-hash-index (item) (gnus-message 9 "nnrss: Making hash index of %s" (gnus-prin1-to-string item)) - (setq item (gnus-remove-if + (setq item (seq-remove (lambda (field) (when (listp field) (memq (car field) nnrss-ignore-article-fields))) -- 2.15.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 01 21:38:33 2017 Received: (at 29489) by debbugs.gnu.org; 2 Dec 2017 02:38:33 +0000 Received: from localhost ([127.0.0.1]:40791 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eKxhI-0005rE-VY for submit@debbugs.gnu.org; Fri, 01 Dec 2017 21:38:33 -0500 Received: from mail-it0-f47.google.com ([209.85.214.47]:39351) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eKxhE-0005qz-RB for 29489@debbugs.gnu.org; Fri, 01 Dec 2017 21:38:29 -0500 Received: by mail-it0-f47.google.com with SMTP id 68so4505949ite.4 for <29489@debbugs.gnu.org>; Fri, 01 Dec 2017 18:38:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=wQzELjWv4AbCavox1T+DUyE9sH+/ftmo4UDa3n0sLfw=; b=V9/xcOFYpSysvyIbXjssNkypvYCDux6jrBMF6dopXXDFaEA8blvxB2TJHlDYd6LkIR VnjjrsWnsSpL6RlSbQDBgV5f4a++PN2WaCfvyvp/ZCJADZv6SHsLfOKcW0Nz8VZTE8NH K/zlvHfe7mRyr6n8vef2ve1W1HBZYSrDj+GmwOCVME0oKEJTzDmmsMvC5WmuHyNMn2ec trDshGh2HQqIgfbukKLwV5nfszz3Et0abalXZvlu3hsDkfXZStVYF5LEtNvVex8A98XB XdiH9qziZmCsYtst55wLhPQkziauIrBlpdQxPIMcUmryt4PEPq173TY1HiRelNblyAvq +3xQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=wQzELjWv4AbCavox1T+DUyE9sH+/ftmo4UDa3n0sLfw=; b=Wg36JbZa0s0MUfvqCibOhHLhB8K/b0jkk1akUUtkGt8bVcB/Rz4s0VCGaERdyvxkAS /RLY3T4+umaFL94FRA0v+crTEfg4sNT7ExxFRMOUlE3xeOTtueVOkv1Vqs1gj6eQ1Fa8 zLF38taUSgb702asoMSPN1kjN/0EZ/CuXUNYu8/a22uLlh7NN5Epd54GFDBnj7t8swT/ 5fucCZ61hinh1oIumLSXCRwoBvzdXZ5KDitcd8xb0wjpC2jbg/CIM73udhlmCwUynK/L EBuUoFBmKgHZCgETFT2Ug8N/SdhXDcIf5DBlPrsWq8TYEY1y6oYl9kfhjVQdxCXTyFvT hK/w== X-Gm-Message-State: AKGB3mK+A/pwlJrU2SyIpHKa1fpo2b5x0Oj1eDy6E39Io5VZTjnq5z15 2i7s1mJT5qy8HAKebzVADZfbPQ== X-Google-Smtp-Source: AGs4zMZElPZIRlFYFhqWRhImofo31ec2j8Bm5clFFKrtnhlchUFU/uSEl98WMJ+MqKCYhAEYHJYsrQ== X-Received: by 10.36.87.131 with SMTP id u125mr4648774ita.45.1512182303040; Fri, 01 Dec 2017 18:38:23 -0800 (PST) Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id v71sm3538034ioi.64.2017.12.01.18.38.21 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 01 Dec 2017 18:38:22 -0800 (PST) From: Noam Postavsky To: Eric Abrahamsen Subject: Re: bug#29489: Obsolete gnus-remove-if and gnus-remove-if-not References: <87o9nmgwue.fsf@ericabrahamsen.net> <87r2sim0je.fsf@users.sourceforge.net> <87a7z6c5i0.fsf@ericabrahamsen.net> <87mv35nchc.fsf@users.sourceforge.net> <87609tdfnz.fsf@ericabrahamsen.net> <871skhlsk0.fsf@users.sourceforge.net> <871skhdam3.fsf@ericabrahamsen.net> <87zi73tyav.fsf@ericabrahamsen.net> Date: Fri, 01 Dec 2017 21:38:20 -0500 In-Reply-To: <87zi73tyav.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Thu, 30 Nov 2017 10:29:44 -0800") Message-ID: <87lgilkg6b.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 29489 Cc: 29489@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Eric Abrahamsen writes: > - (gnus-gethash group gnus-killed-hashtb))) > + (gethash group gnus-killed-hashtb))) Is this from a future patch? As far as I can tell, you haven't changed gnus-killed-hashtb to a hashtable yet, it's still an obarray. From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 02 13:52:20 2017 Received: (at 29489) by debbugs.gnu.org; 2 Dec 2017 18:52:20 +0000 Received: from localhost ([127.0.0.1]:42174 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eLCtg-0003Q4-Fa for submit@debbugs.gnu.org; Sat, 02 Dec 2017 13:52:20 -0500 Received: from mail.ericabrahamsen.net ([50.56.99.223]:57886) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eLCtd-0003Pv-KG for 29489@debbugs.gnu.org; Sat, 02 Dec 2017 13:52:19 -0500 Received: from localhost (71-212-22-173.tukw.qwest.net [71.212.22.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id ABC9DC079B; Sat, 2 Dec 2017 18:52:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mail.ericabrahamsen.net; s=mail; t=1512240735; bh=uKB9z+mAQpum4OoMHWDhGby/kYNIwkAhFiXKpH/8LvU=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=ai57VKyo1ywPbDVuGg50ONKbVAjClRhqlZdJkXf5KpE7rYapG3GZv9FJtBK5CQ3sw UK5fyRIXkcckXsYobxFAhSqe/ewxhsgikjIDDmFEOQEMKZCMvDCJVBlwdoC9Ptab+i XNFwA0lX5Je/Yt+sTW0iQqHzxdFlMKhqNVIr53cs= From: Eric Abrahamsen To: Noam Postavsky Subject: Re: bug#29489: Obsolete gnus-remove-if and gnus-remove-if-not References: <87o9nmgwue.fsf@ericabrahamsen.net> <87r2sim0je.fsf@users.sourceforge.net> <87a7z6c5i0.fsf@ericabrahamsen.net> <87mv35nchc.fsf@users.sourceforge.net> <87609tdfnz.fsf@ericabrahamsen.net> <871skhlsk0.fsf@users.sourceforge.net> <871skhdam3.fsf@ericabrahamsen.net> <87zi73tyav.fsf@ericabrahamsen.net> <87lgilkg6b.fsf@users.sourceforge.net> Date: Sat, 02 Dec 2017 10:50:24 -0800 In-Reply-To: <87lgilkg6b.fsf@users.sourceforge.net> (Noam Postavsky's message of "Fri, 01 Dec 2017 21:38:20 -0500") Message-ID: <878telj767.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 29489 Cc: 29489@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) On 12/01/17 21:38 PM, Noam Postavsky wrote: > Eric Abrahamsen writes: > >> - (gnus-gethash group gnus-killed-hashtb))) >> + (gethash group gnus-killed-hashtb))) > > Is this from a future patch? As far as I can tell, you haven't changed > gnus-killed-hashtb to a hashtable yet, it's still an obarray. Bah! I'm sorry you've had to wade through my dumb mistakes. I'll make better use of branches to keep these things separated cleanly. Do you see anything else obviously wrong with this? I'll spend some more time testing it, as well. Eric From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 02 13:54:46 2017 Received: (at 29489) by debbugs.gnu.org; 2 Dec 2017 18:54:46 +0000 Received: from localhost ([127.0.0.1]:42183 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eLCw2-0003Ti-AK for submit@debbugs.gnu.org; Sat, 02 Dec 2017 13:54:46 -0500 Received: from mail-it0-f50.google.com ([209.85.214.50]:46814) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eLCvy-0003TU-Us for 29489@debbugs.gnu.org; Sat, 02 Dec 2017 13:54:44 -0500 Received: by mail-it0-f50.google.com with SMTP id t1so5922505ite.5 for <29489@debbugs.gnu.org>; Sat, 02 Dec 2017 10:54:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=m4qSBC2FCkLjbSkXAQiCujwhvdApw/z5SjGHZKsa2HA=; b=ls5YlTJGLkesFHo9W4rZ23S/jeU4sLHHE627SNadJOTPThHXSWN+I9iYatvfp+Rmkc bnDQPealcQziOfuKonypBw0+aJRVjtnzq90VvQw3yMK9cNjrNg/zR32HPdj6dGH4i7tq 6E8YecdwdA1F2sNa2ZCRFJyxJ654lFe7T8tUowCoy4HPn8hnAtu/r9vG8D6YoAkJKKyo WdCWHhjJf6Olpstadq45GV5l7LBXooOmieH4Rt4RWGzZlaKMNm1ZyqtCXmTt0u0LyrKd wkyBBFz0W69ZgtJOj+KMw09A0man9yKCfS3Wu2C/fWlO4CbLtNA7TAFjA0uEn7WZewXo TW8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=m4qSBC2FCkLjbSkXAQiCujwhvdApw/z5SjGHZKsa2HA=; b=CyaCrqlAV7tZdPOox4u0jUvZ0dbuxTrZO+KVJOmJ2Wj7neW+AGI+upGLjJb1cqfsWB gyxK3866RvSD/uEeWHdTxx5k/lumpNJJ1bbWXor4LuZoLCVpcxjURPtmbsjSNwr4LksL qBJAZw22Fkx5cCLD4ax2inhSvuonoQ556GXRedaYmOHJMpgmxRJIhocvUc9FgU+XkG6x bTtjVcU6p+jLsU5tPZBEETDIpdP9Rsih95td+54ULk0s2EnYicZ8FTHuJoA8IVvGE36x zNYeocBWBR1PDgINkzHHas26aZIxbq3w9Jb+lsaME7+fPJmIz0Y2GkVlj0uINJwWsUDm Gmjg== X-Gm-Message-State: AKGB3mIaI4J3FeyVfDtCN9sAqeWm3wX0dDBTuKSArXt13OQaX7i5Ae0z RPCe+pQqS1RvTq3jM4T+UQybJw== X-Google-Smtp-Source: AGs4zMaZw6l/XDNWmw6kDJkrqIG+pxQZokSpf/hy6liIiHY44Lj6NoVuMXyprtgL8Wl63qJfZxxBRg== X-Received: by 10.36.22.147 with SMTP id a141mr7140672ita.30.1512240876929; Sat, 02 Dec 2017 10:54:36 -0800 (PST) Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id g187sm1870320itb.29.2017.12.02.10.54.35 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 02 Dec 2017 10:54:36 -0800 (PST) From: Noam Postavsky To: Eric Abrahamsen Subject: Re: bug#29489: Obsolete gnus-remove-if and gnus-remove-if-not References: <87o9nmgwue.fsf@ericabrahamsen.net> <87r2sim0je.fsf@users.sourceforge.net> <87a7z6c5i0.fsf@ericabrahamsen.net> <87mv35nchc.fsf@users.sourceforge.net> <87609tdfnz.fsf@ericabrahamsen.net> <871skhlsk0.fsf@users.sourceforge.net> <871skhdam3.fsf@ericabrahamsen.net> <87zi73tyav.fsf@ericabrahamsen.net> <87lgilkg6b.fsf@users.sourceforge.net> <878telj767.fsf@ericabrahamsen.net> Date: Sat, 02 Dec 2017 13:54:35 -0500 In-Reply-To: <878telj767.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Sat, 02 Dec 2017 10:50:24 -0800") Message-ID: <877eu5j6z8.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 29489 Cc: 29489@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Eric Abrahamsen writes: > Do you see anything else obviously wrong with this? I'll spend some more > time testing it, as well. No, it all looks fine apart from that (though I've only eyeballed the code, not tried to run anything). From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 02 13:55:38 2017 Received: (at 29489) by debbugs.gnu.org; 2 Dec 2017 18:55:39 +0000 Received: from localhost ([127.0.0.1]:42188 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eLCws-0003VB-LB for submit@debbugs.gnu.org; Sat, 02 Dec 2017 13:55:38 -0500 Received: from mail.ericabrahamsen.net ([50.56.99.223]:54095) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eLCwq-0003V3-7j for 29489@debbugs.gnu.org; Sat, 02 Dec 2017 13:55:37 -0500 Received: from localhost (71-212-22-173.tukw.qwest.net [71.212.22.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id AD16AC079B; Sat, 2 Dec 2017 18:55:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mail.ericabrahamsen.net; s=mail; t=1512240935; bh=69Qoy5SEAmxTX8sLNdzxhay4SBAmDWbRHVBiYLyG9t0=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=v1cL1easSWnAb0YYgJul/kHFtOFbgCqXKCM75Do4eQ3dsJ5aer7x8UEx0CxsIwXcu za3EwpWqDPj9yzOBel5nYMmIi1sf0+SBTgyoOJ2ONoQnoVNRHUD00YQTM9RKEer+4S W7vvVwvlgdCFuVxa8kXMPKDowjXIdFpES8uQYsdk= From: Eric Abrahamsen To: Noam Postavsky Subject: Re: bug#29489: Obsolete gnus-remove-if and gnus-remove-if-not References: <87o9nmgwue.fsf@ericabrahamsen.net> <87r2sim0je.fsf@users.sourceforge.net> <87a7z6c5i0.fsf@ericabrahamsen.net> <87mv35nchc.fsf@users.sourceforge.net> <87609tdfnz.fsf@ericabrahamsen.net> <871skhlsk0.fsf@users.sourceforge.net> <871skhdam3.fsf@ericabrahamsen.net> <87zi73tyav.fsf@ericabrahamsen.net> <87lgilkg6b.fsf@users.sourceforge.net> <878telj767.fsf@ericabrahamsen.net> <877eu5j6z8.fsf@users.sourceforge.net> Date: Sat, 02 Dec 2017 10:53:46 -0800 In-Reply-To: <877eu5j6z8.fsf@users.sourceforge.net> (Noam Postavsky's message of "Sat, 02 Dec 2017 13:54:35 -0500") Message-ID: <87374tj70l.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 29489 Cc: 29489@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) On 12/02/17 13:54 PM, Noam Postavsky wrote: > Eric Abrahamsen writes: > >> Do you see anything else obviously wrong with this? I'll spend some more >> time testing it, as well. > > No, it all looks fine apart from that (though I've only eyeballed the > code, not tried to run anything). Okay good. I'll test more. From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 10 13:05:06 2017 Received: (at control) by debbugs.gnu.org; 10 Dec 2017 18:05:06 +0000 Received: from localhost ([127.0.0.1]:55576 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eO5yM-0002B9-1S for submit@debbugs.gnu.org; Sun, 10 Dec 2017 13:05:06 -0500 Received: from mail.ericabrahamsen.net ([50.56.99.223]:50430) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eO5yK-0002B2-Lm for control@debbugs.gnu.org; Sun, 10 Dec 2017 13:05:05 -0500 Received: from localhost (71-212-75-109.tukw.qwest.net [71.212.75.109]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id DF555C00A5 for ; Sun, 10 Dec 2017 18:05:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mail.ericabrahamsen.net; s=mail; t=1512929103; bh=8F/SdDoLJc6zYebbJUbWqdVFcqaAZY/aaGlVZTw6euw=; h=From:To:Subject:Date:From; b=bew5R1Gp8/U8QvOI89p8nU9PMC2u8hg1Xch8P0jzNdD9OkyfF1aYL+M3Mvm+gyF4p VdbVr3mvVKHUYNGZUEdp6kOXMjRNgL8GgRUcsVzVobTVK/wNGRb/0VKr/ZiIep+EXa oTNsVi8zD6px/VKG72pIFpi1NLipDLNWrbLcXirE= From: Eric Abrahamsen To: control@debbugs.gnu.org Subject: close 29489 Date: Sun, 10 Dec 2017 10:05:01 -0800 Message-ID: <87lgiawjaq.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) close 29489 quit From unknown Mon Jun 23 07:49:59 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 08 Jan 2018 12:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator