GNU bug report logs - #29468
[PATCH 0/2] Fix some functionality in gnome-disks.

Previous Next

Full log

Message #25 received at 29468-done <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 29468-done <at> debbugs.gnu.org
Subject: Re: [bug#29468] [PATCH 2/2] gnu: Patch udisks to directly reference
 cryptsetup and parted.
Date: Mon, 27 Nov 2017 19:47:31 +0000

[Message part 1 (text/plain, inline)]

Ludovic Courtès writes:

> Christopher Baines <mail <at> cbaines.net> skribis:
>
>> This fixes some functionality in gnome-disks, which uses udisks. Adding
>> cryptsetup enables creating partitions using LUKS, and adding parted enables
>> editing the partition tables through the disks application.
>>
>> * gnu/packages/freedesktop.scm (udisks)[inputs]: Add cryptsetup and parted.
>>   (arguments): Rename set-mount-file-name phase, and add cryptsetup and
>>   parted.
>
> I think the explanation above should be a comment, but otherwise LGTM.
>
> Thanks for fixing it!

No problem, I've added a couple of comments and pushed.

Thanks for reviewing :)

Chris

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.