GNU bug report logs - #29468
[PATCH 0/2] Fix some functionality in gnome-disks.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Christopher Baines <mail <at> cbaines.net>
Subject: bug#29468: closed (Re: [bug#29468] [PATCH 2/2] gnu: Patch udisks
 to directly reference cryptsetup and parted.)
Date: Mon, 27 Nov 2017 19:48:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#29468: [PATCH 0/2] Fix some functionality in gnome-disks.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 29468 <at> debbugs.gnu.org.

-- 
29468: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=29468
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Christopher Baines <mail <at> cbaines.net>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 29468-done <at> debbugs.gnu.org
Subject: Re: [bug#29468] [PATCH 2/2] gnu: Patch udisks to directly reference
 cryptsetup and parted.
Date: Mon, 27 Nov 2017 19:47:31 +0000

[Message part 3 (text/plain, inline)]

Ludovic Courtès writes:

> Christopher Baines <mail <at> cbaines.net> skribis:
>
>> This fixes some functionality in gnome-disks, which uses udisks. Adding
>> cryptsetup enables creating partitions using LUKS, and adding parted enables
>> editing the partition tables through the disks application.
>>
>> * gnu/packages/freedesktop.scm (udisks)[inputs]: Add cryptsetup and parted.
>>   (arguments): Rename set-mount-file-name phase, and add cryptsetup and
>>   parted.
>
> I think the explanation above should be a comment, but otherwise LGTM.
>
> Thanks for fixing it!

No problem, I've added a couple of comments and pushed.

Thanks for reviewing :)

Chris

[signature.asc (application/pgp-signature, inline)]

[Message part 5 (message/rfc822, inline)]

From: Christopher Baines <mail <at> cbaines.net>
To: guix-patches <at> gnu.org
Subject: [PATCH 0/2] Fix some functionality in gnome-disks.
Date: Mon, 27 Nov 2017 08:38:53 +0000

[Message part 6 (text/plain, inline)]

These patches fix the ability to remove partitions using gnome-disks,
and the ability to create encrypted volumes.

Christopher Baines (2):
  services: desktop: Create /var/run/udisks2 for the udisks service.
  gnu: Patch udisks to directly reference cryptsetup and parted.

 gnu/packages/freedesktop.scm | 14 +++++++++++---
 gnu/services/desktop.scm     | 11 +++++++++++
 2 files changed, 22 insertions(+), 3 deletions(-)

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.