From unknown Mon Aug 18 04:42:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29465: 25.3; Confusing message for dired-do-shell-command substitution Resent-From: Allen Li Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 27 Nov 2017 07:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 29465 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 29465@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.151176703229366 (code B ref -1); Mon, 27 Nov 2017 07:18:02 +0000 Received: (at submit) by debbugs.gnu.org; 27 Nov 2017 07:17:12 +0000 Received: from localhost ([127.0.0.1]:59958 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJDfE-0007da-K9 for submit@debbugs.gnu.org; Mon, 27 Nov 2017 02:17:12 -0500 Received: from eggs.gnu.org ([208.118.235.92]:46100) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJDfD-0007dN-0R for submit@debbugs.gnu.org; Mon, 27 Nov 2017 02:17:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eJDf6-0006pU-UI for submit@debbugs.gnu.org; Mon, 27 Nov 2017 02:17:05 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:59374) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eJDf6-0006pQ-Qx for submit@debbugs.gnu.org; Mon, 27 Nov 2017 02:17:04 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37050) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eJDf4-0003kg-BY for bug-gnu-emacs@gnu.org; Mon, 27 Nov 2017 02:17:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eJDf3-0006n5-A7 for bug-gnu-emacs@gnu.org; Mon, 27 Nov 2017 02:17:02 -0500 Received: from mail-qk0-x244.google.com ([2607:f8b0:400d:c09::244]:46154) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eJDf3-0006mc-4z for bug-gnu-emacs@gnu.org; Mon, 27 Nov 2017 02:17:01 -0500 Received: by mail-qk0-x244.google.com with SMTP id b85so31189489qkc.13 for ; Sun, 26 Nov 2017 23:17:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=CVLo3rkjs0YXPdH1YyQoFW5ILaxNq8xJ/SMARDvk9gk=; b=SHCTCuabf1nexs8xTqS6mVok/btUpPcBUp9sP7MHGljt7c0WukjnX7/U6EtykvsFQb 71Nvb0bXVGSFFb/gtjOCmDU1u17PaHWKGRcQtkULYtRCtfMhYiQrS7Bj4HOUv+8VKTUr eI72RsAVByiH3SZBaxfXpb5swTQm46eAGPpcXmniBFoeurCiYJ15dvPN5sPA8cnQRIpN fHcdjrYFD6sg1d603oplElZOVHX0iz68vGP0hcg3KB6Zwsyf6EmK2XFlTP4dxvgSa2ec DRMO1swZWcMoxlP06Ry0TkHrdou9RdmRm0Qf1XYpZsTfCZDZ1GjkazPIMnF94iBX+Bps oEcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=CVLo3rkjs0YXPdH1YyQoFW5ILaxNq8xJ/SMARDvk9gk=; b=bhPLfbHxiGMyocbSunWRCnxWH3lNRGihXPe63Ps+e4vODS0glE8zr9JZRu3c7X+crW h0qGtMIfji0rfgY3JjSohTs3qRnzBJWVGN76PsG55Hrgfg47AAjTgirW2xsS1uaj0Ftj fw+mfpyyzDgkMIL96XoepLknxbm9U7dXv/hoBc77Ns78/6h43MDfGEIk3udQzQimPh4r YNXDYbDz5B9M/ppBGjvTdwM9mX+9PD09QmaH0kYsARw2WDy7F7h3qQ+gtaTrFBJU1yD1 HY4BdNpcFw2Djt9nuafLwe2bZK2/Jix2MNuYOCmnhdgCNFVvC7lNiH3ONKmYzObAcJHT u5xg== X-Gm-Message-State: AJaThX7ha49j4d737q3luSpR/g974MkNPLKQs4us0RcGKakPZjb/ZGhO xwT+5Aqj8LYxidRlIxBV7XAz2x+xMpPB+NByvUcyHCOW X-Google-Smtp-Source: AGs4zMZjk/ZxkFiiSBuWea9s1KBKPgzm9LIJL+rWG4reNbQJsW+4QGGCrRoMoqK5245pGMUCrye+9lDvOdmqxOcktwM= X-Received: by 10.55.112.6 with SMTP id l6mr10877639qkc.329.1511767020082; Sun, 26 Nov 2017 23:17:00 -0800 (PST) MIME-Version: 1.0 Received: by 10.237.52.161 with HTTP; Sun, 26 Nov 2017 23:16:59 -0800 (PST) From: Allen Li Date: Sun, 26 Nov 2017 23:16:59 -0800 Message-ID: Content-Type: text/plain; charset="UTF-8" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) When you use * or ? in dired-do-shell-command without the intent for Dired to replace it, you are prompted with Confirm--do you mean to use `*' as a wildcard? This message is confusing, because there are lots of ways for * to be passed to the shell without globbing. I am also more familiar with the term globbing than wildcard, which makes it doubly confusing, for example if I run find ? -name '*.txt' I get the message: Confirm--do you mean to use `*' as a wildcard? What the question is really asking is, should * be passed to the shell directly, as whether or not it is interpreted as a glob is determined by the shell and the quoting rules in question. I think this confirmation message should be removed entirely. 1. The edge case that it is trying to protect against is not very common. 2. There is no reasonable behavior that the user could expect from this edge case. 3. The documentation string clearly describes how * and ? are interpreted. 4. The confirmation message is not very informative and is possible misleading. 5. This confirmation message shows up every time an advanced user wants to run any command containing * or ?, e.g. for find, grep, sed, or many other tools. 6. The confirmation message is not even shown consistently. For example it is shown for find ? -name '*.txt' but not for find * -name '*.txt' Thus, it isn't even useful for protecting against some hypothetical unwanted behavior. In GNU Emacs 25.3.1 (x86_64-pc-linux-gnu, GTK+ Version 3.22.19) of 2017-09-16 built on juergen Windowing system distributor 'The X.Org Foundation', version 11.0.11905000 Configured using: 'configure --prefix=/usr --sysconfdir=/etc --libexecdir=/usr/lib --localstatedir=/var --with-x-toolkit=gtk3 --with-xft --with-modules 'CFLAGS=-march=x86-64 -mtune=generic -O2 -pipe -fstack-protector-strong -fno-plt' CPPFLAGS=-D_FORTIFY_SOURCE=2 LDFLAGS=-Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now' From unknown Mon Aug 18 04:42:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29465: 25.3; Confusing message for dired-do-shell-command substitution References: In-Reply-To: Resent-From: Allen Li Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 27 Nov 2017 07:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29465 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 29465@debbugs.gnu.org Received: via spool by 29465-submit@debbugs.gnu.org id=B29465.151176808130996 (code B ref 29465); Mon, 27 Nov 2017 07:35:02 +0000 Received: (at 29465) by debbugs.gnu.org; 27 Nov 2017 07:34:41 +0000 Received: from localhost ([127.0.0.1]:59969 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJDw9-00083q-6B for submit@debbugs.gnu.org; Mon, 27 Nov 2017 02:34:41 -0500 Received: from mail-qt0-f169.google.com ([209.85.216.169]:38193) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJDw8-00083e-5p for 29465@debbugs.gnu.org; Mon, 27 Nov 2017 02:34:40 -0500 Received: by mail-qt0-f169.google.com with SMTP id q13so26453638qtb.5 for <29465@debbugs.gnu.org>; Sun, 26 Nov 2017 23:34:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=/3470ZnFscklgfqHasFpdILIpmylb7oEleRK9YHGbso=; b=YIWxVCe2vhUL/Ju8Fk5nJSl3kTKe8rRsJxKZCCX/nwbfC0Y6MGxwjw5/TpXkffxlnr +/dxqFROcMo8xVw6jsjUMebjckKf9My3x4TaBUyZfKvuVZ26VaW59D7UxIxZE2HGo7I4 ROovkIYRXWw8UQ5g4WSWHEptH1HpHZZp0DGZfpBWmYEE0IC6Tc2WTGQhiqcZEi6R35b4 u2/Vc/FqP9ljKLVnGybAQnEQ7+vmzlsIoi6iZjBqxpr3p7MNdUrYIed1Hd1uYBvgZ3qJ zUDPEgV84P0+Luh7p4z4BoQTAEHmj1/k3dkKkGX2PJq02go/1fcqvnSUkaYF/EEBvYif ezUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=/3470ZnFscklgfqHasFpdILIpmylb7oEleRK9YHGbso=; b=G3bv1qftXeChBG/0C1iBjuOfWhtFVp1pVuJ6MBX0sMJ+k6YRhsFAmLPMdmkUKZlb3I srxwdsa6KO23EgWturbAkFbeYYjzwXSI5B5Cn3ucvAe8R8u6/lRrKIM2n2VZVa4PPKUB IRQexXrU3u8rpiUE7amGrh1zKA2qOuKHI+UITrok0zrwpmkpeR29MN6Y0QrBwfGOaASF LEtYU1RT6HSeqxEv78jrlfnc71Np6DpD7IcUULf4WBmQUE/jc4dEtLxHNFV4hs3zIsqW REg3oEDpR0cQt/o6PvjXpkcuJIh+dGLdjB/5uIsJlyZui3ndGUYQ/aRmuFwXXBcstwor nSMw== X-Gm-Message-State: AJaThX51B67T/RE9nTnTJKasaoJG1plG63n1r+C7LLysZ5XrVMUCTXo6 3QZRf79exvXtI4Jo1SgNKDXzOJSOj6LsW6NYVQhmn87A X-Google-Smtp-Source: AGs4zMZYhzLhUH4zGN3HBEQJ+n1on8PamTNyvkLt6e7n9VUiT0JNpN3A7/GC2zBM1E0tFSjrcpQwtxNllp1QQ2Bl8Io= X-Received: by 10.200.54.93 with SMTP id n29mr60148473qtb.179.1511768074315; Sun, 26 Nov 2017 23:34:34 -0800 (PST) MIME-Version: 1.0 Received: by 10.237.52.161 with HTTP; Sun, 26 Nov 2017 23:34:33 -0800 (PST) From: Allen Li Date: Sun, 26 Nov 2017 23:34:33 -0800 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) I have included two patches. The first is to fix the documentation string which I encountered while reading the code, the second is for my proposed solution of removing the confirmation message. Subject: [PATCH 1/2] Clarify dired-do-shell-command docstring The docstring seemed to imply that if * and ? were used together, * would take priority. However, it is explicitly checked that * and ? are not used together. * lisp/dired-aux.el (dired-do-shell-command): Fix docstring --- lisp/dired-aux.el | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/lisp/dired-aux.el b/lisp/dired-aux.el index f1f7cf0b0e..57eb216231 100644 --- a/lisp/dired-aux.el +++ b/lisp/dired-aux.el @@ -686,13 +686,15 @@ dired-do-shell-command If there is a `*' in COMMAND, surrounded by whitespace, this runs COMMAND just once with the entire file list substituted there. -If there is no `*', but there is a `?' in COMMAND, surrounded by -whitespace, or a `\\=`?\\=`' this runs COMMAND on each file -individually with the file name substituted for `?' or `\\=`?\\=`'. +If there is a `?' in COMMAND, surrounded by whitespace, or a +`\\=`?\\=`' this runs COMMAND on each file individually with the +file name substituted for `?' or `\\=`?\\=`'. Otherwise, this runs COMMAND on each file individually with the file name added at the end of COMMAND (separated by a space). +`*' and `?' cannot be used together. + `*' and `?' when not surrounded by whitespace nor `\\=`' have no special significance for `dired-do-shell-command', and are passed through normally to the shell, but you must confirm first. -- 2.15.0 Subject: [PATCH 2/2] Remove confirmation when using * or ? for the shell These confirmation messages are misleading, do not trigger for all cases, and obstruct many commands that use * or ?, like find, sed, grep, etc. * lisp/dired-aux.el (dired-do-shell-command): Remove substitution mark confirmation --- lisp/dired-aux.el | 20 +++++--------------- 1 file changed, 5 insertions(+), 15 deletions(-) diff --git a/lisp/dired-aux.el b/lisp/dired-aux.el index 57eb216231..15bb3173b7 100644 --- a/lisp/dired-aux.el +++ b/lisp/dired-aux.el @@ -744,20 +744,10 @@ dired-do-shell-command (dired--star-or-qmark-p res str)) (setq res (replace-match "" t t res 2))) (string-match regexp res)))) - (let* ((on-each (not (dired--star-or-qmark-p command "*" 'keep))) - (no-subst (not (dired--star-or-qmark-p command "?" 'keep))) - ;; Get confirmation for wildcards that may have been meant - ;; to control substitution of a file name or the file name list. - (ok (cond ((not (or on-each no-subst)) - (error "You can not combine `*' and `?' substitution marks")) - ((need-confirm-p command "*") - (y-or-n-p (format-message - "Confirm--do you mean to use `*' as a wildcard? "))) - ((need-confirm-p command "?") - (y-or-n-p (format-message - "Confirm--do you mean to use `?' as a wildcard? "))) - (t)))) - (when ok + (let* ((on-each (not (dired--star-or-qmark-p command "*" 'keep))) + (no-subst (not (dired--star-or-qmark-p command "?" 'keep)))) + (unless (or on-each no-subst) + (error "You can not combine `*' and `?' substitution marks")) (if on-each (dired-bunch-files (- 10000 (length command)) (lambda (&rest files) @@ -766,7 +756,7 @@ dired-do-shell-command nil file-list) ;; execute the shell command (dired-run-shell-command - (dired-shell-stuff-it command file-list nil arg))))))) + (dired-shell-stuff-it command file-list nil arg)))))) ;; Might use {,} for bash or csh: (defvar dired-mark-prefix "" -- 2.15.0 From unknown Mon Aug 18 04:42:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29465: 25.3; Confusing message for dired-do-shell-command substitution Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 27 Nov 2017 09:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29465 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Allen Li Cc: 29465@debbugs.gnu.org Received: via spool by 29465-submit@debbugs.gnu.org id=B29465.15117736507147 (code B ref 29465); Mon, 27 Nov 2017 09:08:01 +0000 Received: (at 29465) by debbugs.gnu.org; 27 Nov 2017 09:07:30 +0000 Received: from localhost ([127.0.0.1]:60051 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJFNy-0001rD-Di for submit@debbugs.gnu.org; Mon, 27 Nov 2017 04:07:30 -0500 Received: from mout.web.de ([212.227.17.12]:51224) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJFNx-0001r0-6S for 29465@debbugs.gnu.org; Mon, 27 Nov 2017 04:07:29 -0500 Received: from drachen.dragon ([88.66.201.17]) by smtp.web.de (mrweb101 [213.165.67.124]) with ESMTPSA (Nemesis) id 0MEVYz-1eLCGf2rhB-00FnWX; Mon, 27 Nov 2017 10:07:20 +0100 From: Michael Heerdegen References: Date: Mon, 27 Nov 2017 10:07:20 +0100 In-Reply-To: (Allen Li's message of "Sun, 26 Nov 2017 23:34:33 -0800") Message-ID: <87zi78jdiv.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:6LweJ31KdCdmrLYf6WAbaWw9Ug0uLsDlA3+zFC5UY00SBdoNOta 8C2adHsD+pKVLjTJmhHlATshUX6N9kuhFtz4VG8hvYn2I+gcvEJdeE+0wLWyaKgeojB9QJp 9Ote+rsfu+j9L9eMD6Jh1lGVwidZbyfV7P9T4cC5/8guVG2MYdKz504UYA065CyHVyqhiZ9 CRfSStWPVQzTYxUBc2OTg== X-UI-Out-Filterresults: notjunk:1;V01:K0:KLwXaDHIGR4=:7MEMKGSRCNqoom4lXkIdgu tENy6nT8pG77TbNFWxnbnO72OFuAT0orQqwwbLdQgRf0BM8LB7QdADaxWyihaBgLAB+wPCS5C v8gAURpRgnI6eG4FeXcNh25wSaDGQnAmd+IP1TUy8aBhsBKwDT7IUse28ra9Y0XXo6vsb9Cpl 35GOQNk2VEpHJjazJKr7c24+A5y/C1fG+leqQRVOO+Wd8V/E4zJ9e8IwU/HHsJU0cCguiCvgf p8ss8RMDOmLdc4g73Dhsv4JNfJVCs3PNIP6BnWEdiQ+1cJ/RStgIu4rO2pP0ra+Nk5Hl/JONN IJQWfmLMxTsu1EOvVvMbwO3OZODS5gOWVRPTHkQeAUmibfq3CLVUtbXQ944iVATAEUCl/yK18 dLpLarQy/+Cr/yEEJ9hv2QxyVmYv1YaGm/ahIC6+8WyymizUC6fmj34cSp5gYnaNQS3Oakm/E iVWokt/tgHqTIuItzUlx8O/Dlvk/E8xSM5ftoT4DnXTVhZC6TdbIWMB2fQeAbmcgZXMDew6to Qzv66Pz1IErEVXGUfdxk1okO7ZqeoaVpYrr9UBR2r2jrn/LaHXKUHW1iTflNIh+ZTOtqt3Pdf OqqqhLb1QofY9gLMuFCZ0nQIU6rX8bqKqj7QNY33LhIZo47lB3w8SSp+UG5QhHpAtcSMTElMC SqrmkRDalTgFJFN1roXhbPBk0ztjIU7CrPdUqDSJrC8OaFJmrOqyD05o79EJtd9gqoZKx9Cjf hjK1rt/RW4KBv3m2tMUWA2xfdiu+WLc8c/cXT5ca3sSU3QQHSZhSvrlABJACUSRGFTa/OAC1u G47feY637FKB4NWQeAJFQAtxT7IXdyXj8f7vfEH/0recz7EPk4= X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Allen Li writes: > I have included two patches. The first is to fix the documentation > string which I encountered while reading the code, the second is for > my proposed solution of removing the confirmation message. I think this would also solve Bug#28969 that I had reported some time ago. I wanted to try your patch but... > diff --git a/lisp/dired-aux.el b/lisp/dired-aux.el > index 57eb216231..15bb3173b7 100644 > --- a/lisp/dired-aux.el > +++ b/lisp/dired-aux.el > @@ -744,20 +744,10 @@ dired-do-shell-command > (dired--star-or-qmark-p res str)) > (setq res (replace-match "" t t res 2))) > (string-match regexp res)))) > - (let* ((on-each (not (dired--star-or-qmark-p command "*" 'keep))) > - (no-subst (not (dired--star-or-qmark-p command "?" 'keep))) Here seems to be a problem with leading whitespace in the first line - applying this patch fails for me. Michael. From unknown Mon Aug 18 04:42:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29465: 25.3; Confusing message for dired-do-shell-command substitution Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 27 Nov 2017 15:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29465 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Allen Li , Tino Calancha Cc: 29465@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 29465-submit@debbugs.gnu.org id=B29465.151179830821346 (code B ref 29465); Mon, 27 Nov 2017 15:59:02 +0000 Received: (at 29465) by debbugs.gnu.org; 27 Nov 2017 15:58:28 +0000 Received: from localhost ([127.0.0.1]:32874 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJLnf-0005YE-Um for submit@debbugs.gnu.org; Mon, 27 Nov 2017 10:58:28 -0500 Received: from eggs.gnu.org ([208.118.235.92]:44876) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJLnd-0005Y0-Mk for 29465@debbugs.gnu.org; Mon, 27 Nov 2017 10:58:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eJLnU-0007J1-DX for 29465@debbugs.gnu.org; Mon, 27 Nov 2017 10:58:20 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:50668) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eJLnU-0007Iu-AI; Mon, 27 Nov 2017 10:58:16 -0500 Received: from [176.228.60.248] (port=2081 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eJLnT-0006sq-Ha; Mon, 27 Nov 2017 10:58:16 -0500 Date: Mon, 27 Nov 2017 17:58:04 +0200 Message-Id: <83vahv67eb.fsf@gnu.org> From: Eli Zaretskii In-reply-to: (message from Allen Li on Sun, 26 Nov 2017 23:16:59 -0800) References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Allen Li > Date: Sun, 26 Nov 2017 23:16:59 -0800 > > When you use * or ? in dired-do-shell-command without the intent for > Dired to replace it, you are prompted with > > Confirm--do you mean to use `*' as a wildcard? > > This message is confusing, because there are lots of ways for * to be > passed to the shell without globbing. I am also more familiar with > the term globbing than wildcard, which makes it doubly confusing, for > example if I run > > find ? -name '*.txt' > > I get the message: > > Confirm--do you mean to use `*' as a wildcard? > > What the question is really asking is, should * be passed to the shell > directly, as whether or not it is interpreted as a glob is determined > by the shell and the quoting rules in question. Actually, AFAICT the command wants to ask this: Are you sure you want `*' to be passed to the shell? (as opposed to letting dired-do-shell-command interpret `*' as described in the doc string). > I think this confirmation message should be removed entirely. > > 1. The edge case that it is trying to protect against is not very common. > 2. There is no reasonable behavior that the user could expect from > this edge case. > 3. The documentation string clearly describes how * and ? are interpreted. > 4. The confirmation message is not very informative and is possible misleading. > 5. This confirmation message shows up every time an advanced user > wants to run any command containing * or ?, e.g. for find, grep, sed, > or many other tools. > 6. The confirmation message is not even shown consistently. For > example it is shown for > > find ? -name '*.txt' > > but not for > > find * -name '*.txt' > > Thus, it isn't even useful for protecting against some hypothetical > unwanted behavior. Tino added this confirmation last July, so I will let him defend his change. If we want to remove this confirmation, now is the time, because it wasn't yet released with any Emacs version. Once this confirmation is out at large, it will be much harder to remove it, as that would be an incompatible change. From unknown Mon Aug 18 04:42:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29465: 25.3; Confusing message for dired-do-shell-command substitution Resent-From: Tino Calancha Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 28 Nov 2017 03:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29465 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Allen Li Cc: Eli Zaretskii , 29465@debbugs.gnu.org, rms@gnu.org Received: via spool by 29465-submit@debbugs.gnu.org id=B29465.151184106922370 (code B ref 29465); Tue, 28 Nov 2017 03:52:02 +0000 Received: (at 29465) by debbugs.gnu.org; 28 Nov 2017 03:51:09 +0000 Received: from localhost ([127.0.0.1]:33331 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJWvM-0005ok-Vh for submit@debbugs.gnu.org; Mon, 27 Nov 2017 22:51:09 -0500 Received: from mail-pl0-f42.google.com ([209.85.160.42]:40216) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJWvK-0005oD-6b for 29465@debbugs.gnu.org; Mon, 27 Nov 2017 22:51:06 -0500 Received: by mail-pl0-f42.google.com with SMTP id 62so9845843plc.7 for <29465@debbugs.gnu.org>; Mon, 27 Nov 2017 19:51:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=EJmgKbMr4MK52O/JAokXYI2dtK+rK0NvnLs9AMQHBfk=; b=jTzl9/J4z4LPl9Jn+FVgSMVbGThKIvU38cR7kJgc0DsS1sXg6bm35WWj73YSK+pMQH dJ/IWBj4qWvcs2e71FcQHH6SKRfidHLymgDJVUYZqKr8FHw5SosBv8wbjRzYRD69Aq3n vKkzCwHls/ALLzeHZL0D2mPxSwrgk9NJAgBYiFuxMoW5DjUDOcJi9V3VQOgCwScfjnzC eYnIYhqh/+HTEbcoA8WqWJE+seBiK8RHv1MJrPBZd6GNdJ/wOBzDW7zzdH56luqIq7Cr pX3xzxofZFVOGe0vk16H9d6Y5Fx0O063VrkVKRWihSgI5XRxEErdBysTvmQgkVYdUTFy nTyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=EJmgKbMr4MK52O/JAokXYI2dtK+rK0NvnLs9AMQHBfk=; b=lSZOHPfmoZevobAfu8Twk1u/eVGFaiSQKYu6QcC1eMJdsW10qdQJn9saF+E7g+ByWc sOtnMjWtn1U62iUsGDU/Ei3fPxYMH6vzjLTEElFFUWOvAfx6ckvFP5ykq80ykeoYhw+L wF6RBj3mbrfOiBQqIJyT9mUiXvi/zVZHwiTqHSev6o7Swrq7i73PYquEFmlimd3nt11C XK6lkNtK+lGVubJAkoRPQbqP5+DbggN3pPqi2kM7IJ1toheWihbTTTVQTnZlOyQxNkFb +yJ+8f5boZJGJY85PUIx8NFAILlHwykJ7DWuuCRyAF98x3keKuxzhBw2z2kXz0v15wu0 Hixw== X-Gm-Message-State: AJaThX7iebeNfnaEVjWA2h5XaD8kCCqBasfbu1Fu39vJDGqtK+fkmaIO 93Qki9qfLv8VSoPtxHVqYzI= X-Google-Smtp-Source: AGs4zMZUaTIWXvRMtsvniUPbyzyiQ+AvvcTdDbT78cN96Tf5CrmzvbahgowfQQvOSdf5pOClvl0EWQ== X-Received: by 10.84.201.6 with SMTP id u6mr40427675pld.51.1511841060321; Mon, 27 Nov 2017 19:51:00 -0800 (PST) Received: from calancha-pc (155.7.236.133.dy.bbexcite.jp. [133.236.7.155]) by smtp.gmail.com with ESMTPSA id w9sm51390971pfk.16.2017.11.27.19.50.57 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 27 Nov 2017 19:50:59 -0800 (PST) From: Tino Calancha References: <83vahv67eb.fsf@gnu.org> Date: Tue, 28 Nov 2017 12:50:52 +0900 In-Reply-To: <83vahv67eb.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 27 Nov 2017 17:58:04 +0200") Message-ID: <87fu8zukmb.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Eli Zaretskii writes: >> From: Allen Li >> >> find ? -name '*.txt' >> >> but not for >> >> find * -name '*.txt' >> >> Thus, it isn't even useful for protecting against some hypothetical >> unwanted behavior. > > Tino added this confirmation last July, so I will let him defend his > change. > > If we want to remove this confirmation, now is the time, because it > wasn't yet released with any Emacs version. Once this confirmation is > out at large, it will be much harder to remove it, as that would be an > incompatible change. Thanks for your report Allen! FWIW the confirmation was added by RMS in 2002 (eab9ed67eb50bab4fc736058a799508d544606a0). See also commits: commit e52c37fad057b29d68c51cf3a70b2e0d94f656cb commit edb8d73e62552cf2f95cbf871050913862dc5f18 My commit "Ask confirmation for all suspicious wildcards" (6e39940adba7b96dfe520caa52a1b92a1a84a84f) extends that confirmation to cover Bug#27496. Before 6e39940adb, not all `?' or `*' were checked for being between white spaces: ! echo ./? RET ; This ask confirmation ! echo ./? ? RET ; This doesn't After 6e39940adb, all occurrences of `?' or `*' are checked for being between white spaces; the user is asked confirmation if any of them are not surrounded by whites. I made this change for consistency: I thought it has sense to check all `?' `*' occurrences, not just one. In fact, this change causes that you are prompted in your snippet: ! find * -name '*.txt' RET ;; After (before) 6e39940adb you are (not) prompted. Compare with the following: ! find ? -name '*.txt' RET ;; After and before 6e39940adb you are prompted. Your second patch disables the confirmation prompts that have being around since 2002. Since the source of this bug report seems to be 6e39940adb, I would rather revert just this commit. From unknown Mon Aug 18 04:42:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29465: 25.3; Confusing message for dired-do-shell-command substitution Resent-From: Allen Li Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 28 Nov 2017 08:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29465 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Tino Calancha Cc: Eli Zaretskii , 29465@debbugs.gnu.org, rms@gnu.org Received: via spool by 29465-submit@debbugs.gnu.org id=B29465.151185752615659 (code B ref 29465); Tue, 28 Nov 2017 08:26:02 +0000 Received: (at 29465) by debbugs.gnu.org; 28 Nov 2017 08:25:26 +0000 Received: from localhost ([127.0.0.1]:33432 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJbCo-00044V-3u for submit@debbugs.gnu.org; Tue, 28 Nov 2017 03:25:26 -0500 Received: from mail-qt0-f179.google.com ([209.85.216.179]:36701) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJbCl-00044F-Vs for 29465@debbugs.gnu.org; Tue, 28 Nov 2017 03:25:24 -0500 Received: by mail-qt0-f179.google.com with SMTP id a19so42631837qtb.3 for <29465@debbugs.gnu.org>; Tue, 28 Nov 2017 00:25:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=W+80SPk3GKBau3QrxA50DQKexqIfqNFQ25ONmwKzZxU=; b=TFWntESuHFSiW/NS+2yBMST3JMme9fQH94aOEhoN9gEL3pAaVqNgUgWxrqCp9GWLJs Y6w3HfCnGNEPPIB0kVQhjKDWMemUyNqhi7asGIrfj09zIYAhFbUPIY4VPwX+ha7YMScn ziEMaT4wPGHDG7+meN9Caj3a42ncHOpwL6aO1vxT0idoVt8QgX3dBD/+oYpMwwwfViPe Lb8elkCxJQODhgymbxo03i8tgCSEweG+lOkIUUshmL1P5l475gmoekKEeQKuRmqTqyM/ cU3unZrHDxCDMz2Is4Kmfct9iWSoDQ297LLQbQqSYKZ8zc4XkiKCeW/AZInuUDLGlT7m AdTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=W+80SPk3GKBau3QrxA50DQKexqIfqNFQ25ONmwKzZxU=; b=ecFilge4UJfm6kZDKX5vq+1go9RuhXFCy0DwXA6tW1yugx3oI3WXsL9JT97ajC+q1u Uj4dEFi9Nt1CmRlQTKrmJMnS9ANYy50kRp2gnbY2+6C9KJeKV3GmF+RWCqVNdzqQ02FC PZ7iuRdvC/RvN81rQpmqSi8oF6wQWak/FUKwU/d5GaBLaGIDVLuDyXDcZdwioH43iKgC fgqagNMJD7o9djCleoROSWT1HVaLD4hqVjDieRsVGGjWY7LC5nLSy9bE65I5Dc639vrP uNOg4dztWY9p3/iqOL//fz3AarPTIeentmpOyX+5L8kTGTcGiaOpW5rgrcX4hXgTQlZm 4zng== X-Gm-Message-State: AJaThX70kfI/KjEmk8VwcSi2Tz4am9rmDBZKujI70D8RPcGCKlytN4Gs fcw/uf0SRrYWe8Fcpld7x5YtG7tMce3xK5e4AIk= X-Google-Smtp-Source: AGs4zMbb+1NLZA3W5APFVa2aUSii1dlWI+ESgCAQHDuWs1Xu5fTanuG+fA7vQK5JHx+rGymfCL0F+9X2QAwjEaUPA9g= X-Received: by 10.200.45.168 with SMTP id p37mr64206330qta.247.1511857518142; Tue, 28 Nov 2017 00:25:18 -0800 (PST) MIME-Version: 1.0 Received: by 10.237.52.161 with HTTP; Tue, 28 Nov 2017 00:25:17 -0800 (PST) In-Reply-To: <87fu8zukmb.fsf@gmail.com> References: <83vahv67eb.fsf@gnu.org> <87fu8zukmb.fsf@gmail.com> From: Allen Li Date: Tue, 28 Nov 2017 00:25:17 -0800 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Mon, Nov 27, 2017 at 7:50 PM, Tino Calancha wr= ote: > FWIW the confirmation was added by RMS in 2002 > (eab9ed67eb50bab4fc736058a799508d544606a0). > See also commits: > commit e52c37fad057b29d68c51cf3a70b2e0d94f656cb > commit edb8d73e62552cf2f95cbf871050913862dc5f18 > > My commit "Ask confirmation for all suspicious wildcards" > (6e39940adba7b96dfe520caa52a1b92a1a84a84f) > extends that confirmation to cover Bug#27496. > > Before 6e39940adb, not all `?' or `*' were checked for > being between white spaces: > ! echo ./? RET ; This ask confirmation > ! echo ./? ? RET ; This doesn't > > After 6e39940adb, all occurrences of `?' or `*' are checked for > being between white spaces; the user is asked confirmation if > any of them are not surrounded by whites. > I made this change for consistency: I thought it has sense to > check all `?' `*' occurrences, not just one. > > In fact, this change causes that you are prompted in your snippet: > ! find * -name '*.txt' RET > ;; After (before) 6e39940adb you are (not) prompted. > > Compare with the following: > ! find ? -name '*.txt' RET > ;; After and before 6e39940adb you are prompted. > > Your second patch disables the confirmation prompts that have > being around since 2002. Since the source of this bug report > seems to be 6e39940adb, I would rather revert just this commit. I see. I actually do not have your commit yet (on 25.3.1), so I am encountering the inconsistent behavior that you fixed. However, your commit doesn't solve the problem that the message is misleading; unfortunately by making the prompt appear consistently the message is now even more confusing. Before (right now on 25.3.1), this did not show a prompt: find * -name '*.txt' Now it does show a prompt: Confirm--do you mean to use `*' as a wildcard? I would have no idea what this means. Does it mean that Dired is going to replace the *? Does it mean that Dired is going to replace the =E2=80=99*.txt=E2=80=99? Or perhaps both? What am I confirming exactl= y? The second issue is that the prompt is very annoying for advanced users; I have filed a second bug for this (#29190). Since your commit fixes the inconsistency problem, that's one less reason for my advocating to remove the confirmation. If we can make the message less confusing and add an option to disable the prompt, I would be happy. However, I think writing a useful confirmation prompt for this is hard; hopefully someone has a good idea. One idea would be what Eli suggested: Are you sure you want `*' to be passed to the shell? However, what if the command contains both `*' and `?'? find * -name =E2=80=99*.txt=E2=80=99 -o -name =E2=80=99x??=E2=80=99 Are you sure you want `*' to be passed to the shell? (Does that include the `?' or not?) What if the user typos the intended substitution character? find *x -name =E2=80=99*.txt=E2=80=99 -o -name =E2=80=99x??=E2=80=99 Are you sure you want `*' to be passed to the shell? (Which one?) Since I was not confident that a good message could be written, I suggested removing the confirmation. Also, I am not sure what this is supposed to be protecting against. It seems more useful to confirm when dired-do-shell-command is going to replace * or ? rather than when it is not. If the user did not read the documentation string, the user would most likely expect these characters to be passed to the shell. If the user did read the documentation string, the prompt would only be an annoyance. The original commit by RMS (eab9ed67eb50bab4fc736058a799508d544606a0) does not provide a reason for the confirmation. If I were to hazard a guess, the behavior of the command was changed, so the prompt was added to warn users accustomed to the old behavior. However, it is now 15 years since; I don=E2=80=99t think there=E2=80=99s any value keeping= the confirmation around for its original (?) purpose. From unknown Mon Aug 18 04:42:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29465: 25.3; Confusing message for dired-do-shell-command substitution Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 28 Nov 2017 16:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29465 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Tino Calancha Cc: vianchielfaura@gmail.com, 29465@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 29465-submit@debbugs.gnu.org id=B29465.15118857371895 (code B ref 29465); Tue, 28 Nov 2017 16:16:01 +0000 Received: (at 29465) by debbugs.gnu.org; 28 Nov 2017 16:15:37 +0000 Received: from localhost ([127.0.0.1]:34811 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJiXo-0000UV-Lb for submit@debbugs.gnu.org; Tue, 28 Nov 2017 11:15:36 -0500 Received: from eggs.gnu.org ([208.118.235.92]:54224) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJiXn-0000UI-8v for 29465@debbugs.gnu.org; Tue, 28 Nov 2017 11:15:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eJiXc-0003v2-89 for 29465@debbugs.gnu.org; Tue, 28 Nov 2017 11:15:30 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:47606) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eJiXc-0003uo-2m; Tue, 28 Nov 2017 11:15:24 -0500 Received: from [176.228.60.248] (port=3130 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eJiXb-00077I-Hz; Tue, 28 Nov 2017 11:15:23 -0500 Date: Tue, 28 Nov 2017 18:15:15 +0200 Message-Id: <837eua5qi4.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <87fu8zukmb.fsf@gmail.com> (message from Tino Calancha on Tue, 28 Nov 2017 12:50:52 +0900) References: <83vahv67eb.fsf@gnu.org> <87fu8zukmb.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Tino Calancha > Cc: 29465@debbugs.gnu.org, Eli Zaretskii , rms@gnu.org > Date: Tue, 28 Nov 2017 12:50:52 +0900 > > Eli Zaretskii writes: > > >> From: Allen Li > >> > >> find ? -name '*.txt' > >> > >> but not for > >> > >> find * -name '*.txt' > >> > >> Thus, it isn't even useful for protecting against some hypothetical > >> unwanted behavior. > > > > Tino added this confirmation last July, so I will let him defend his > > change. > > > > If we want to remove this confirmation, now is the time, because it > > wasn't yet released with any Emacs version. Once this confirmation is > > out at large, it will be much harder to remove it, as that would be an > > incompatible change. > Thanks for your report Allen! > > FWIW the confirmation was added by RMS in 2002 > (eab9ed67eb50bab4fc736058a799508d544606a0). > See also commits: > commit e52c37fad057b29d68c51cf3a70b2e0d94f656cb > commit edb8d73e62552cf2f95cbf871050913862dc5f18 > > My commit "Ask confirmation for all suspicious wildcards" > (6e39940adba7b96dfe520caa52a1b92a1a84a84f) > extends that confirmation to cover Bug#27496. Oops, I apologize for my faulty forensic job. From unknown Mon Aug 18 04:42:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29465: 25.3; Confusing message for dired-do-shell-command substitution Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 28 Nov 2017 16:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29465 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Allen Li Cc: 29465@debbugs.gnu.org, tino.calancha@gmail.com Reply-To: Eli Zaretskii Received: via spool by 29465-submit@debbugs.gnu.org id=B29465.15118864322917 (code B ref 29465); Tue, 28 Nov 2017 16:28:02 +0000 Received: (at 29465) by debbugs.gnu.org; 28 Nov 2017 16:27:12 +0000 Received: from localhost ([127.0.0.1]:34822 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJij0-0000kx-PT for submit@debbugs.gnu.org; Tue, 28 Nov 2017 11:27:11 -0500 Received: from eggs.gnu.org ([208.118.235.92]:56606) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJiiz-0000km-AF for 29465@debbugs.gnu.org; Tue, 28 Nov 2017 11:27:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eJiiq-0007v9-P6 for 29465@debbugs.gnu.org; Tue, 28 Nov 2017 11:27:04 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:47867) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eJiiq-0007uz-Ls; Tue, 28 Nov 2017 11:27:00 -0500 Received: from [176.228.60.248] (port=3144 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eJiiq-0008KF-0R; Tue, 28 Nov 2017 11:27:00 -0500 Date: Tue, 28 Nov 2017 18:26:52 +0200 Message-Id: <83609u5pyr.fsf@gnu.org> From: Eli Zaretskii In-reply-to: (message from Allen Li on Tue, 28 Nov 2017 00:25:17 -0800) References: <83vahv67eb.fsf@gnu.org> <87fu8zukmb.fsf@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Allen Li > Date: Tue, 28 Nov 2017 00:25:17 -0800 > Cc: 29465@debbugs.gnu.org, Eli Zaretskii , rms@gnu.org > > Since your commit fixes the inconsistency problem, that's one less > reason for my advocating to remove the confirmation. If we can make > the message less confusing and add an option to disable the prompt, I > would be happy. I think clarifying the prompt and adding an option is indeed the way forward. > However, I think writing a useful confirmation prompt for this is > hard; hopefully someone has a good idea. > > One idea would be what Eli suggested: > > Are you sure you want `*' to be passed to the shell? > > However, what if the command contains both `*' and `?'? Then the prompt should say that: Are you sure you want `*' and `?' to be passed to the shell? > Since I was not confident that a good message could be written, I > suggested removing the confirmation. I think we should try to make the prompt more clear, it cannot be that hard. Removing the prompt will introduce backward incompatibility with what Emacs was doing for the past 15 years, so it's a worse alternative, IMO. > Also, I am not sure what this is supposed to be protecting against. > It seems more useful to confirm when dired-do-shell-command is going > to replace * or ? rather than when it is not. If the user did not > read the documentation string, the user would most likely expect these > characters to be passed to the shell. If the user did read the > documentation string, the prompt would only be an annoyance. > > The original commit by RMS (eab9ed67eb50bab4fc736058a799508d544606a0) > does not provide a reason for the confirmation. You need to look up relevant discussions on Emacs mailing lists around the date of the commit. In this case, read this thread: http://lists.gnu.org/archive/html/emacs-devel/2002-01/msg00233.html and also the original bug report and its followups: http://lists.gnu.org/archive/html/bug-gnu-emacs/2002-01/msg00230.html > If I were to hazard a guess, the behavior of the command was > changed, so the prompt was added to warn users accustomed to the old > behavior. No, it was a bug report about a potentially risky feature, where a user mistyping a command could have their files wiped out or cause some other grave accident. > However, it is now 15 years since; I don’t think there’s any value > keeping the confirmation around for its original (?) purpose. The syntax of the shell commands supported by dired-do-shell-command and its features regarding '*' and '?' are still very complicated, as they were back then. Just the doc string describing the behavior is so long it can scare. So I don't see how the time that has passed is of relevance here. From unknown Mon Aug 18 04:42:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29465: 25.3; Confusing message for dired-do-shell-command substitution Resent-From: Allen Li Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 28 Nov 2017 20:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29465 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 29465@debbugs.gnu.org, Tino Calancha Received: via spool by 29465-submit@debbugs.gnu.org id=B29465.151190000114344 (code B ref 29465); Tue, 28 Nov 2017 20:14:01 +0000 Received: (at 29465) by debbugs.gnu.org; 28 Nov 2017 20:13:21 +0000 Received: from localhost ([127.0.0.1]:35169 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJmFr-0003jE-DI for submit@debbugs.gnu.org; Tue, 28 Nov 2017 15:13:21 -0500 Received: from mail-qk0-f180.google.com ([209.85.220.180]:38961) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJmFp-0003iw-B1 for 29465@debbugs.gnu.org; Tue, 28 Nov 2017 15:13:17 -0500 Received: by mail-qk0-f180.google.com with SMTP id u184so1514802qkd.6 for <29465@debbugs.gnu.org>; Tue, 28 Nov 2017 12:13:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Y1mrzPDNqdH4SoctE5RrJqQ/5kiXy3cmYsfgqZJwOTs=; b=qPvS141VGPtdFwJNwK1IkrxywXaMFRa5GKaQ1ddCLewNHMz9tuIQI5r8JUI3Qoq/Sk uSWNcjrR+n3iXPHHr7ICqnrDNULm9kdmmnSl/FHqGN5/IN+KjaXNvTyHwpjnycarQlcW aGULXF1ORH6PANKZZy5sknWACHAncxvG0J2QypTbY/5L4DnC+9UX6CD2dnyvYqmfrpZh mKR9X6oGUE0CLDZjZCgrQjGRlQxAyyU0PgNSFFE1KlfRkQiR4KzYi6tHFCm78iKjard/ bXB9OVFzdLs++4iYMszscdhypaPJFcLJv8pT+5wINrGBAHEQSr2L+VHO4NT/LubtHKyu 5yJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Y1mrzPDNqdH4SoctE5RrJqQ/5kiXy3cmYsfgqZJwOTs=; b=Kajnee03i7XIjogXbPT29QzyhKONZldjrFiRjiINKBuwNnpCIHXbIU1G8mqi5dhOCY OwL4PfLnUAoLse5E5VTd/CWLEgIDvB0s9wr+j85S2mt65bNwEhPqmGOPSje76xv/Jt7f 1y94ray+ek/lKg/3ghKb4CsO7pFA4XwTIVUb9RWFteC+ZeophSiLjceTzIZ+AXKO4EWu Sv7utDwiue0jQX4QxFdxP4zTwlk9d+G+CMLqA0WlmOhNYUUn9Y1ZDrv33EDzWM8a+Q+3 U7drfavgoeT6dj2V1tugdxFGiYVwU6rbr4HujW2yvSkVY6/4djwrq1oYyVjzQvl0v8zW 4gRA== X-Gm-Message-State: AJaThX4DjnGzp6SVRnp+Bt3onaKhw2ebZ1ZKrXKlUC0/axgmF642SW14 B2SQrhXioJ3U8s4ptPedr29HOtz5mhLtOgEdWT8= X-Google-Smtp-Source: AGs4zMZUzk4cQdIAQ/Qot2YwRA51X0kZ5DoDl6/n/SGgRi/9bsngEPMKkUMemOodSSGdMaVs8EybbPQ/+TI5l5ZQZ3s= X-Received: by 10.55.54.146 with SMTP id d140mr641961qka.39.1511899991578; Tue, 28 Nov 2017 12:13:11 -0800 (PST) MIME-Version: 1.0 Received: by 10.237.52.161 with HTTP; Tue, 28 Nov 2017 12:13:11 -0800 (PST) In-Reply-To: <83609u5pyr.fsf@gnu.org> References: <83vahv67eb.fsf@gnu.org> <87fu8zukmb.fsf@gmail.com> <83609u5pyr.fsf@gnu.org> From: Allen Li Date: Tue, 28 Nov 2017 12:13:11 -0800 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) On Tue, Nov 28, 2017 at 8:26 AM, Eli Zaretskii wrote: > I think we should try to make the prompt more clear, it cannot be that > hard. Removing the prompt will introduce backward incompatibility > with what Emacs was doing for the past 15 years, so it's a worse > alternative, IMO. I don't care personally, if there's an option to disable it, but I am not convinced for the sake of the betterment of Emacs. I don't see how removing the prompt introduces backward incompatibility issues unless someone has a keyboard macro saved that includes a "y" to handle this case (which I suppose is a possible use case, but I think we have to draw the line somewhere; would improving Emacs performance be a breaking change because someone was relying on a certain function call taking at least a certain amount of time?). This is changing interactive usage, not API usage. > You need to look up relevant discussions on Emacs mailing lists around > the date of the commit. In this case, read this thread: > > http://lists.gnu.org/archive/html/emacs-devel/2002-01/msg00233.html > > and also the original bug report and its followups: > > http://lists.gnu.org/archive/html/bug-gnu-emacs/2002-01/msg00230.html > >> If I were to hazard a guess, the behavior of the command was >> changed, so the prompt was added to warn users accustomed to the old >> behavior. > > No, it was a bug report about a potentially risky feature, where a > user mistyping a command could have their files wiped out or cause > some other grave accident. Thanks for that. But the confirmation prompt doesn't actually address said bug. Mistyping `M-! rm *' instead of `! rm *' will still wipe out your files with no confirmation. I don't accept that `! rm *""', the case covered by the confirmation prompt, is a common typo. Basically, I'm not convinced that this is protecting against a common case of user error. I would appreciate it if someone could provide a concrete example of such a user error (or ideally two or three examples). > The syntax of the shell commands supported by dired-do-shell-command > and its features regarding '*' and '?' are still very complicated, as > they were back then. Just the doc string describing the behavior is > so long it can scare. So I don't see how the time that has passed is > of relevance here. If dired-do-shell-command is complicated enough to scare, as you say, I think presenting the user with an ambiguous confirmation prompt scares even more. The confirmation prompt implies that the user is doing something dangerous, when in all likelihood the user is doing nothing of the sort. Again, I would like to see a concrete example of a user error this prompt actually protects against. With all of that said, I am fine with adding an option, since I can just set it and be on my merry way. But I think Emacs would benefit from not having this prompt (and I would be happy to be convinced otherwise). From unknown Mon Aug 18 04:42:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29465: 25.3; Confusing message for dired-do-shell-command substitution Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 29 Nov 2017 04:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29465 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Allen Li , Eli Zaretskii Cc: 29465@debbugs.gnu.org, Tino Calancha Received: via spool by 29465-submit@debbugs.gnu.org id=B29465.151192925131466 (code B ref 29465); Wed, 29 Nov 2017 04:21:02 +0000 Received: (at 29465) by debbugs.gnu.org; 29 Nov 2017 04:20:51 +0000 Received: from localhost ([127.0.0.1]:35530 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJtrf-0008BS-G3 for submit@debbugs.gnu.org; Tue, 28 Nov 2017 23:20:51 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:27489) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJtrd-0008BD-Sg for 29465@debbugs.gnu.org; Tue, 28 Nov 2017 23:20:50 -0500 Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id vAT4Kg3j011583 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 29 Nov 2017 04:20:42 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id vAT4Kf2H030341 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 29 Nov 2017 04:20:41 GMT Received: from abhmp0019.oracle.com (abhmp0019.oracle.com [141.146.116.25]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id vAT4Kdw9008892; Wed, 29 Nov 2017 04:20:39 GMT MIME-Version: 1.0 Message-ID: <29b407d1-e1f6-4676-a686-ccdf19af8bb4@default> Date: Tue, 28 Nov 2017 20:20:38 -0800 (PST) From: Drew Adams References: <83vahv67eb.fsf@gnu.org> <87fu8zukmb.fsf@gmail.com> <83609u5pyr.fsf@gnu.org> In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4615.0 (x86)] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Source-IP: aserv0022.oracle.com [141.146.126.234] X-Spam-Score: -2.4 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) I have not been following this thread, so apologies if this doesn't help or isn't very relevant. IF we feel it helps a user to prompt about something, and IF we feel there is a possibility that some users might not understand the prompt, in spite of our best efforts to come up with a good prompt, and IF we feel that understanding the prompt is important, THEN the doc string should make clear whatever it is that it is important that users understand about that prompting. It's quite possible for a user not to understand even a good prompt. S?he should be able to get the point by doing `C-h f', in that case. From unknown Mon Aug 18 04:42:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29465: 25.3; Confusing message for dired-do-shell-command substitution Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 01 Dec 2017 08:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29465 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Drew Adams Cc: vianchielfaura@gmail.com, 29465@debbugs.gnu.org, tino.calancha@gmail.com Reply-To: Eli Zaretskii Received: via spool by 29465-submit@debbugs.gnu.org id=B29465.151211741116447 (code B ref 29465); Fri, 01 Dec 2017 08:37:01 +0000 Received: (at 29465) by debbugs.gnu.org; 1 Dec 2017 08:36:51 +0000 Received: from localhost ([127.0.0.1]:38950 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eKgoV-0004HC-C0 for submit@debbugs.gnu.org; Fri, 01 Dec 2017 03:36:51 -0500 Received: from eggs.gnu.org ([208.118.235.92]:46426) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eKgoT-0004Gy-B4 for 29465@debbugs.gnu.org; Fri, 01 Dec 2017 03:36:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eKgoN-0007s9-BW for 29465@debbugs.gnu.org; Fri, 01 Dec 2017 03:36:44 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:40204) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eKgoI-0007o1-Cx; Fri, 01 Dec 2017 03:36:38 -0500 Received: from [176.228.60.248] (port=1817 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eKgoH-0005ps-P6; Fri, 01 Dec 2017 03:36:38 -0500 Date: Fri, 01 Dec 2017 10:36:18 +0200 Message-Id: <83mv323kvx.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <29b407d1-e1f6-4676-a686-ccdf19af8bb4@default> (message from Drew Adams on Tue, 28 Nov 2017 20:20:38 -0800 (PST)) References: <83vahv67eb.fsf@gnu.org> <87fu8zukmb.fsf@gmail.com> <83609u5pyr.fsf@gnu.org> <29b407d1-e1f6-4676-a686-ccdf19af8bb4@default> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > Date: Tue, 28 Nov 2017 20:20:38 -0800 (PST) > From: Drew Adams > Cc: 29465@debbugs.gnu.org, Tino Calancha > > IF we feel it helps a user to prompt about something, > and IF we feel there is a possibility that some users > might not understand the prompt, in spite of our best > efforts to come up with a good prompt, and IF we feel > that understanding the prompt is important, THEN the > doc string should make clear whatever it is that it > is important that users understand about that prompting. > > It's quite possible for a user not to understand even > a good prompt. S?he should be able to get the point > by doing `C-h f', in that case. The doc string already attempts to do that: `*' and `?' when not surrounded by whitespace nor `\\=`' have no special significance for `dired-do-shell-command', and are passed through normally to the shell, but you must confirm first. We could make the intent of the confirmation even more clear, e.g. `*' and `?' when not surrounded by whitespace nor `\\=`' have no special significance for `dired-do-shell-command', and are passed through normally to the shell, but you must confirm first, to avoid inadvertently passing a wildcard to a shell command, which would cause that command to act on more files than you intended. Is anything else needed to make this prompt's intent more clear? From unknown Mon Aug 18 04:42:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29465: 25.3; Confusing message for dired-do-shell-command substitution Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 01 Dec 2017 15:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29465 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii , Drew Adams Cc: vianchielfaura@gmail.com, 29465@debbugs.gnu.org, tino.calancha@gmail.com Received: via spool by 29465-submit@debbugs.gnu.org id=B29465.15121429765961 (code B ref 29465); Fri, 01 Dec 2017 15:43:01 +0000 Received: (at 29465) by debbugs.gnu.org; 1 Dec 2017 15:42:56 +0000 Received: from localhost ([127.0.0.1]:40146 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eKnSq-0001Y5-5h for submit@debbugs.gnu.org; Fri, 01 Dec 2017 10:42:56 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:46634) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eKnSp-0001Xs-06 for 29465@debbugs.gnu.org; Fri, 01 Dec 2017 10:42:55 -0500 Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id vB1Fgm8p009888 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 1 Dec 2017 15:42:48 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserv0021.oracle.com (8.14.4/8.14.4) with ESMTP id vB1FgkgW005406 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 1 Dec 2017 15:42:47 GMT Received: from abhmp0010.oracle.com (abhmp0010.oracle.com [141.146.116.16]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id vB1Fgju6006365; Fri, 1 Dec 2017 15:42:46 GMT MIME-Version: 1.0 Message-ID: <0543611b-5e7c-49df-b0fd-d522b3c95187@default> Date: Fri, 1 Dec 2017 07:42:44 -0800 (PST) From: Drew Adams References: <> <<83vahv67eb.fsf@gnu.org>> <<87fu8zukmb.fsf@gmail.com>> <> <<83609u5pyr.fsf@gnu.org>> <> <<29b407d1-e1f6-4676-a686-ccdf19af8bb4@default>> <<83mv323kvx.fsf@gnu.org>> In-Reply-To: <<83mv323kvx.fsf@gnu.org>> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4615.0 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: aserv0021.oracle.com [141.146.126.233] X-Spam-Score: -2.4 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) > > IF we feel it helps a user to prompt about something, > > and IF we feel there is a possibility that some users > > might not understand the prompt, in spite of our best > > efforts to come up with a good prompt, and IF we feel > > that understanding the prompt is important, THEN the > > doc string should make clear whatever it is that it > > is important that users understand about that prompting. > > > > It's quite possible for a user not to understand even > > a good prompt. S?he should be able to get the point > > by doing `C-h f', in that case. >=20 > The doc string already attempts to do that: >=20 > `*' and `?' when not surrounded by whitespace nor `\\=3D`' have... `*' and `?', unless surrounded by whitespace or `\\=3D', have... is easier to understand, I think. > We could make the intent of the confirmation even more clear, e.g. >=20 > `*' and `?' when not surrounded by whitespace nor `\\=3D`' have no > special > significance for `dired-do-shell-command', and are passed through > normally to the shell, but you must confirm first, to avoid > inadvertently passing a wildcard to a shell command, which would > cause that command to act on more files than you intended. Please consider splitting that in two: "...to the shell. But..." > Is anything else needed to make this prompt's intent more clear? That seems good enough for the doc string. I don't have a suggestion for the prompt itself. (I don't think it's super clear, though.) From unknown Mon Aug 18 04:42:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29465: 25.3; Confusing message for dired-do-shell-command substitution Resent-From: Allen Li Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 02 Dec 2017 06:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29465 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 29465@debbugs.gnu.org, Drew Adams , Tino Calancha Received: via spool by 29465-submit@debbugs.gnu.org id=B29465.151219627518113 (code B ref 29465); Sat, 02 Dec 2017 06:32:01 +0000 Received: (at 29465) by debbugs.gnu.org; 2 Dec 2017 06:31:15 +0000 Received: from localhost ([127.0.0.1]:40900 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eL1KT-0004i2-2p for submit@debbugs.gnu.org; Sat, 02 Dec 2017 01:31:14 -0500 Received: from mail-qt0-f172.google.com ([209.85.216.172]:38766) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eL1KP-0004ho-Pg for 29465@debbugs.gnu.org; Sat, 02 Dec 2017 01:31:10 -0500 Received: by mail-qt0-f172.google.com with SMTP id d4so15700903qtj.5 for <29465@debbugs.gnu.org>; Fri, 01 Dec 2017 22:31:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=otDQaSAh5VEEp5Eu8ygSAPu119s3ijWrYglgc+KzG6I=; b=mucj7OY/WKbywIFbGbcq1/0QHBLGeHiPwMWeTQ/oAvftMXR87B0QkOOLpdVu5Rjpad G5Tv20vl0GaaQbOet19RK5goY5maujcJ2574UFunH+SgFJ4cGJX6LcVUS4qQ5sJ7PtuD AM5lwkKK6gHtPzpMl6riJJiNjB389MJngQLOJ6Y9DJKOFOvZHtyjowTWMDS54+qWCxYW df+nrCXkWC5D5m0XuaYjGLHTUoKKV1SlVNV4WvO/YZy3hkUeivVbv4OpLOT6x0szyfBl gRR+bokWBj+IAjjCRNNFKBWJ02zSuiKO2kCxvudQxi/bR4HltkH25wnEJ+++8L9I8iow RDqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=otDQaSAh5VEEp5Eu8ygSAPu119s3ijWrYglgc+KzG6I=; b=lhqIsvnx+gXoi5OarrVA8qEbjzFuLCMO6jLLd4mJ6LemedX9VvIKzhBG9i2tg9n1DO 3T9AaxNmANDZn3wJDC6z/EVVFgk7DFbKzMo5mRsTU1GL7JTvTckJeLkRt1+TNColDdhg dd8U34o5jj7g+c1rDSoHUukS/IiewqovuB7G8MJp8t0MP1hHqeq4O4eP47iSe5U5vPTw d4bcS7dCSqQ3XNQMOjdQpf2BufztHxucdBvsu/9GvfHh4Ed4o3Kno1w6QML8uJKAp+8/ qh1R91JqSpJVXZl6S81YO3SRLfOgmzAv0va01T5uNd2HVXIV4aOnPBf6HBw8DP03EGfu NXew== X-Gm-Message-State: AKGB3mIKWfoRS1wsf6F1wAoIfZhaqbeb3QiGkZDmyiWpTIG+M6ONIinL ytmzk+VVUQuWTWtXyx37nToMDZfuxF7CygBMNPk= X-Google-Smtp-Source: AGs4zMZNhgpyplPyrLkYfu5FcQ06lY6IGLM1caoUkO/5YZJxRNd15UOB12u61rEKNtv0b1LO4hwag8MvnTwHdMCXr1s= X-Received: by 10.200.25.78 with SMTP id g14mr12525945qtk.119.1512196264213; Fri, 01 Dec 2017 22:31:04 -0800 (PST) MIME-Version: 1.0 Received: by 10.237.52.161 with HTTP; Fri, 1 Dec 2017 22:31:03 -0800 (PST) In-Reply-To: <83mv323kvx.fsf@gnu.org> References: <83vahv67eb.fsf@gnu.org> <87fu8zukmb.fsf@gmail.com> <83609u5pyr.fsf@gnu.org> <29b407d1-e1f6-4676-a686-ccdf19af8bb4@default> <83mv323kvx.fsf@gnu.org> From: Allen Li Date: Fri, 1 Dec 2017 22:31:03 -0800 Message-ID: Content-Type: multipart/mixed; boundary="001a114f20b8291a87055f55a19f" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --001a114f20b8291a87055f55a19f Content-Type: text/plain; charset="UTF-8" On Fri, Dec 1, 2017 at 12:36 AM, Eli Zaretskii wrote: >> Date: Tue, 28 Nov 2017 20:20:38 -0800 (PST) >> From: Drew Adams >> Cc: 29465@debbugs.gnu.org, Tino Calancha >> >> IF we feel it helps a user to prompt about something, >> and IF we feel there is a possibility that some users >> might not understand the prompt, in spite of our best >> efforts to come up with a good prompt, and IF we feel >> that understanding the prompt is important, THEN the >> doc string should make clear whatever it is that it >> is important that users understand about that prompting. >> >> It's quite possible for a user not to understand even >> a good prompt. S?he should be able to get the point >> by doing `C-h f', in that case. > > The doc string already attempts to do that: > > `*' and `?' when not surrounded by whitespace nor `\\=`' have no special > significance for `dired-do-shell-command', and are passed through > normally to the shell, but you must confirm first. > > We could make the intent of the confirmation even more clear, e.g. > > `*' and `?' when not surrounded by whitespace nor `\\=`' have no special > significance for `dired-do-shell-command', and are passed through > normally to the shell, but you must confirm first, to avoid > inadvertently passing a wildcard to a shell command, which would cause > that command to act on more files than you intended. > > Is anything else needed to make this prompt's intent more clear? I made some small changes to the docstring and I added an option for disabling the prompt, in two separate patches against master. I have attached the patches. Since I don't have a good idea for the prompt text itself, I fixed these two issues first. Aside: is there a recommended way of formatting and sending patches? What's easiest for me is using git format-patch and then attaching the files, but I don't know if Emacs maintainers prefer anything specific (e.g. mail readers that don't support MIME attachments?) --001a114f20b8291a87055f55a19f Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Clarify-dired-do-shell-command-docstring.patch" Content-Disposition: attachment; filename="0001-Clarify-dired-do-shell-command-docstring.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_jaoyh4jq0 RnJvbSA1NGIwMTc0MWJkNjFkZDAyM2Q5Y2VmMTJmMmMxZmIyODkwZDg1OTkwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGxlbiBMaSA8ZGFya2ZlbGluZUBmZWxlc2F0cmEubW9lPgpE YXRlOiBTdW4sIDI2IE5vdiAyMDE3IDIzOjIxOjM0IC0wODAwClN1YmplY3Q6IFtQQVRDSCAxLzJd IENsYXJpZnkgZGlyZWQtZG8tc2hlbGwtY29tbWFuZCBkb2NzdHJpbmcKClRoZSBkb2NzdHJpbmcg c2VlbWVkIHRvIGltcGx5IHRoYXQgaWYgKiBhbmQgPyB3ZXJlIHVzZWQgdG9nZXRoZXIsICoKd291 bGQgdGFrZSBwcmlvcml0eS4gIEhvd2V2ZXIsIGl0IGlzIGV4cGxpY2l0bHkgY2hlY2tlZCB0aGF0 ICogYW5kID8KYXJlIG5vdCB1c2VkIHRvZ2V0aGVyLgoKKiBsaXNwL2RpcmVkLWF1eC5lbCAoZGly ZWQtZG8tc2hlbGwtY29tbWFuZCk6IEZpeCBkb2NzdHJpbmcKLS0tCiBsaXNwL2RpcmVkLWF1eC5l bCB8IDggKysrKystLS0KIDEgZmlsZSBjaGFuZ2VkLCA1IGluc2VydGlvbnMoKyksIDMgZGVsZXRp b25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9kaXJlZC1hdXguZWwgYi9saXNwL2RpcmVkLWF1eC5l bAppbmRleCBmMWY3Y2YwYjBlLi41N2ViMjE2MjMxIDEwMDY0NAotLS0gYS9saXNwL2RpcmVkLWF1 eC5lbAorKysgYi9saXNwL2RpcmVkLWF1eC5lbApAQCAtNjg2LDEzICs2ODYsMTUgQEAgZGlyZWQt ZG8tc2hlbGwtY29tbWFuZAogSWYgdGhlcmUgaXMgYSBgKicgaW4gQ09NTUFORCwgc3Vycm91bmRl ZCBieSB3aGl0ZXNwYWNlLCB0aGlzIHJ1bnMKIENPTU1BTkQganVzdCBvbmNlIHdpdGggdGhlIGVu dGlyZSBmaWxlIGxpc3Qgc3Vic3RpdHV0ZWQgdGhlcmUuCiAKLUlmIHRoZXJlIGlzIG5vIGAqJywg YnV0IHRoZXJlIGlzIGEgYD8nIGluIENPTU1BTkQsIHN1cnJvdW5kZWQgYnkKLXdoaXRlc3BhY2Us IG9yIGEgYFxcPWA/XFw9YCcgdGhpcyBydW5zIENPTU1BTkQgb24gZWFjaCBmaWxlCi1pbmRpdmlk dWFsbHkgd2l0aCB0aGUgZmlsZSBuYW1lIHN1YnN0aXR1dGVkIGZvciBgPycgb3IgYFxcPWA/XFw9 YCcuCitJZiB0aGVyZSBpcyBhIGA/JyBpbiBDT01NQU5ELCBzdXJyb3VuZGVkIGJ5IHdoaXRlc3Bh Y2UsIG9yIGEKK2BcXD1gP1xcPWAnIHRoaXMgcnVucyBDT01NQU5EIG9uIGVhY2ggZmlsZSBpbmRp dmlkdWFsbHkgd2l0aCB0aGUKK2ZpbGUgbmFtZSBzdWJzdGl0dXRlZCBmb3IgYD8nIG9yIGBcXD1g P1xcPWAnLgogCiBPdGhlcndpc2UsIHRoaXMgcnVucyBDT01NQU5EIG9uIGVhY2ggZmlsZSBpbmRp dmlkdWFsbHkgd2l0aCB0aGUKIGZpbGUgbmFtZSBhZGRlZCBhdCB0aGUgZW5kIG9mIENPTU1BTkQg KHNlcGFyYXRlZCBieSBhIHNwYWNlKS4KIAorYConIGFuZCBgPycgY2Fubm90IGJlIHVzZWQgdG9n ZXRoZXIuCisKIGAqJyBhbmQgYD8nIHdoZW4gbm90IHN1cnJvdW5kZWQgYnkgd2hpdGVzcGFjZSBu b3IgYFxcPWAnIGhhdmUgbm8gc3BlY2lhbAogc2lnbmlmaWNhbmNlIGZvciBgZGlyZWQtZG8tc2hl bGwtY29tbWFuZCcsIGFuZCBhcmUgcGFzc2VkIHRocm91Z2gKIG5vcm1hbGx5IHRvIHRoZSBzaGVs bCwgYnV0IHlvdSBtdXN0IGNvbmZpcm0gZmlyc3QuCi0tIAoyLjE1LjEKCg== --001a114f20b8291a87055f55a19f Content-Type: text/x-patch; charset="US-ASCII"; name="0002-Add-option-for-controlling-dired-do-shell-command-pr.patch" Content-Disposition: attachment; filename="0002-Add-option-for-controlling-dired-do-shell-command-pr.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_jaoyh4kb1 RnJvbSAwYTcxNjYyNzc0YWRmYjg0ODA2NDRjNGM3MzZiOGQzZjA0YmM5YTAyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGxlbiBMaSA8ZGFya2ZlbGluZUBmZWxlc2F0cmEubW9lPgpE YXRlOiBGcmksIDEgRGVjIDIwMTcgMjI6MjI6NTMgLTA4MDAKU3ViamVjdDogW1BBVENIIDIvMl0g QWRkIG9wdGlvbiBmb3IgY29udHJvbGxpbmcgZGlyZWQtZG8tc2hlbGwtY29tbWFuZCBwcm9tcHQK CiogZG9jL2VtYWNzL2RpcmVkLnRleGkgKFNoZWxsIENvbW1hbmRzIGluIERpcmVkKTogRG9jdW1l bnQgb3B0aW9uCiogbGlzcC9kaXJlZC1hdXguZWwgKGRpcmVkLWNvbmZpcm0tc2hlbGwtY29tbWFu ZCk6IEFkZCBvcHRpb24KKGRpcmVkLWRvLXNoZWxsLWNvbW1hbmQpOiBDaGVjayBvcHRpb24gYmVm b3JlIHByb21wdGluZwotLS0KIGRvYy9lbWFjcy9kaXJlZC50ZXhpIHwgIDQgKysrLQogbGlzcC9k aXJlZC1hdXguZWwgICAgfCAyNiArKysrKysrKysrKysrKysrKysrLS0tLS0tLQogMiBmaWxlcyBj aGFuZ2VkLCAyMiBpbnNlcnRpb25zKCspLCA4IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2Rv Yy9lbWFjcy9kaXJlZC50ZXhpIGIvZG9jL2VtYWNzL2RpcmVkLnRleGkKaW5kZXggOTM0OGVmNTA0 Mi4uNGMwODI2ZTFhMyAxMDA2NDQKLS0tIGEvZG9jL2VtYWNzL2RpcmVkLnRleGkKKysrIGIvZG9j L2VtYWNzL2RpcmVkLnRleGkKQEAgLTg2Niw2ICs4NjYsNyBAQCBTaGVsbCBDb21tYW5kcyBpbiBE aXJlZAogQGZpbmRleCBkaXJlZC1kby1zaGVsbC1jb21tYW5kCiBAa2luZGV4ICEgQHJ7KERpcmVk KX0KIEBraW5kZXggWCBAcnsoRGlyZWQpfQorQHZpbmRleCBkaXJlZC1jb25maXJtLXNoZWxsLWNv bW1hbmQKIFRoZSBEaXJlZCBjb21tYW5kIEBrYmR7IX0gKEBjb2Rle2RpcmVkLWRvLXNoZWxsLWNv bW1hbmR9KSByZWFkcyBhCiBzaGVsbCBjb21tYW5kIHN0cmluZyBpbiB0aGUgbWluaWJ1ZmZlciwg YW5kIHJ1bnMgdGhhdCBzaGVsbCBjb21tYW5kIG9uCiBvbmUgb3IgbW9yZSBmaWxlcy4gIFRoZSBm aWxlcyB0aGF0IHRoZSBzaGVsbCBjb21tYW5kIG9wZXJhdGVzIG9uIGFyZQpAQCAtOTAyLDcgKzkw Myw4IEBAIFNoZWxsIENvbW1hbmRzIGluIERpcmVkCiBJZiB5b3Ugd2FudCB0byB1c2UgQHNhbXB7 Kn0gYXMgYSBzaGVsbCB3aWxkY2FyZCB3aXRoIHdoaXRlc3BhY2UgYXJvdW5kCiBpdCwgd3JpdGUg QHNhbXB7KiIifS4gIEluIHRoZSBzaGVsbCwgdGhpcyBpcyBlcXVpdmFsZW50IHRvIEBzYW1weyp9 OwogYnV0IHNpbmNlIHRoZSBAc2FtcHsqfSBpcyBub3Qgc3Vycm91bmRlZCBieSB3aGl0ZXNwYWNl LCBEaXJlZCBkb2VzIG5vdAotdHJlYXQgaXQgc3BlY2lhbGx5LgordHJlYXQgaXQgc3BlY2lhbGx5 LiAgRW1hY3Mgd2lsbCBwcm9tcHQgZm9yIGNvbmZpcm1hdGlvbiBpZiB5b3UgZG8KK3RoaXMsIHVu bGVzcyBAY29kZXtkaXJlZC1jb25maXJtLXNoZWxsLWNvbW1hbmR9IGlzIEBjb2Rle25pbH0uCiAK IEBpdGVtCiBPdGhlcndpc2UsIGlmIHRoZSBjb21tYW5kIHN0cmluZyBjb250YWlucyBAc2FtcHs/ fSBzdXJyb3VuZGVkIGJ5CmRpZmYgLS1naXQgYS9saXNwL2RpcmVkLWF1eC5lbCBiL2xpc3AvZGly ZWQtYXV4LmVsCmluZGV4IDU3ZWIyMTYyMzEuLjdiZDNhYTEyYTIgMTAwNjQ0Ci0tLSBhL2xpc3Av ZGlyZWQtYXV4LmVsCisrKyBiL2xpc3AvZGlyZWQtYXV4LmVsCkBAIC02NDksNiArNjQ5LDE2IEBA IGRpcmVkLXJlYWQtc2hlbGwtY29tbWFuZAogICAgICAgKGRpcmVkLW1hcmstcG9wLXVwIG5pbCAn c2hlbGwgZmlsZXMKIAkJCSAncmVhZC1zaGVsbC1jb21tYW5kIHByb21wdCBuaWwgbmlsKSkpKQog Cis7OzsjIyNhdXRvbG9hZAorKGRlZmN1c3RvbSBkaXJlZC1jb25maXJtLXNoZWxsLWNvbW1hbmQg dAorICAiV2hldGhlciB0byBwcm9tcHQgZm9yIGNvbmZpcm1hdGlvbiBmb3IgRGlyZWQgc2hlbGwg Y29tbWFuZHMuCitJZiB0LCBwcm9tcHQiCisgIDp0eXBlICcoY2hvaWNlIChjb25zdCA6dGFnICJO byByZXN0cmljdGlvbnMiIG5pbCkKKwkJIChjb25zdCA6dGFnICJXaGVuIHBvaW50IGlzIG9uIGEg ZmlsZSBuYW1lIGluaXRpYWxseSwgc2VhcmNoIGZpbGUgbmFtZXMiIGR3aW0pCisJCSAoY29uc3Qg OnRhZyAiQWx3YXlzIHNlYXJjaCBpbiBmaWxlIG5hbWVzIiB0KSkKKyAgOmdyb3VwICdkaXJlZAor ICA6dmVyc2lvbiAiMjYuMCIpCisKIDs7OyMjI2F1dG9sb2FkCiAoZGVmdW4gZGlyZWQtZG8tYXN5 bmMtc2hlbGwtY29tbWFuZCAoY29tbWFuZCAmb3B0aW9uYWwgYXJnIGZpbGUtbGlzdCkKICAgIlJ1 biBhIHNoZWxsIGNvbW1hbmQgQ09NTUFORCBvbiB0aGUgbWFya2VkIGZpbGVzIGFzeW5jaHJvbm91 c2x5LgpAQCAtNzM3LDEzICs3NDcsMTUgQEAgZGlyZWQtZG8tc2hlbGwtY29tbWFuZAogICAgICAg ZmlsZXMpKSkKICAgKGNsLWZsZXQgKChuZWVkLWNvbmZpcm0tcAogICAgICAgICAgICAgIChjbWQg c3RyKQotICAgICAgICAgICAgIChsZXQgKChyZXMgY21kKQotICAgICAgICAgICAgICAgICAgIChy ZWdleHAgKHJlZ2V4cC1xdW90ZSBzdHIpKSkKLSAgICAgICAgICAgICAgIDs7IERyb3AgYWxsID8g YW5kICogc3Vycm91bmRlZCBieSBzcGFjZXMgYW5kIGA/YC4KLSAgICAgICAgICAgICAgICh3aGls ZSAoYW5kIChzdHJpbmctbWF0Y2ggcmVnZXhwIHJlcykKLSAgICAgICAgICAgICAgICAgICAgICAg ICAgIChkaXJlZC0tc3Rhci1vci1xbWFyay1wIHJlcyBzdHIpKQotICAgICAgICAgICAgICAgICAo c2V0cSByZXMgKHJlcGxhY2UtbWF0Y2ggIiIgdCB0IHJlcyAyKSkpCi0gICAgICAgICAgICAgICAo c3RyaW5nLW1hdGNoIHJlZ2V4cCByZXMpKSkpCisgICAgICAgICAgICAgKHdoZW4KKyAgICAgICAg ICAgICAgICAgZGlyZWQtY29uZmlybS1zaGVsbC1jb21tYW5kCisgICAgICAgICAgICAgICAobGV0 ICgocmVzIGNtZCkKKyAgICAgICAgICAgICAgICAgICAgIChyZWdleHAgKHJlZ2V4cC1xdW90ZSBz dHIpKSkKKyAgICAgICAgICAgICAgICAgOzsgRHJvcCBhbGwgPyBhbmQgKiBzdXJyb3VuZGVkIGJ5 IHNwYWNlcyBhbmQgYD9gLgorICAgICAgICAgICAgICAgICAod2hpbGUgKGFuZCAoc3RyaW5nLW1h dGNoIHJlZ2V4cCByZXMpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChkaXJlZC0tc3Rh ci1vci1xbWFyay1wIHJlcyBzdHIpKQorICAgICAgICAgICAgICAgICAgIChzZXRxIHJlcyAocmVw bGFjZS1tYXRjaCAiIiB0IHQgcmVzIDIpKSkKKyAgICAgICAgICAgICAgICAgKHN0cmluZy1tYXRj aCByZWdleHAgcmVzKSkpKSkKICAgKGxldCogKChvbi1lYWNoIChub3QgKGRpcmVkLS1zdGFyLW9y LXFtYXJrLXAgY29tbWFuZCAiKiIgJ2tlZXApKSkKIAkgKG5vLXN1YnN0IChub3QgKGRpcmVkLS1z dGFyLW9yLXFtYXJrLXAgY29tbWFuZCAiPyIgJ2tlZXApKSkKICAgICAgICAgIDs7IEdldCBjb25m aXJtYXRpb24gZm9yIHdpbGRjYXJkcyB0aGF0IG1heSBoYXZlIGJlZW4gbWVhbnQKLS0gCjIuMTUu MQoK --001a114f20b8291a87055f55a19f-- From unknown Mon Aug 18 04:42:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29465: 25.3; Confusing message for dired-do-shell-command substitution Resent-From: Tino Calancha Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 02 Dec 2017 07:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29465 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Allen Li Cc: Eli Zaretskii , 29465@debbugs.gnu.org, Drew Adams Received: via spool by 29465-submit@debbugs.gnu.org id=B29465.151219994823519 (code B ref 29465); Sat, 02 Dec 2017 07:33:02 +0000 Received: (at 29465) by debbugs.gnu.org; 2 Dec 2017 07:32:28 +0000 Received: from localhost ([127.0.0.1]:40940 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eL2Hk-00067H-IG for submit@debbugs.gnu.org; Sat, 02 Dec 2017 02:32:28 -0500 Received: from mail-wm0-f48.google.com ([74.125.82.48]:35713) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eL2Hj-000673-7h for 29465@debbugs.gnu.org; Sat, 02 Dec 2017 02:32:27 -0500 Received: by mail-wm0-f48.google.com with SMTP id f9so6741111wmh.0 for <29465@debbugs.gnu.org>; Fri, 01 Dec 2017 23:32:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=w8kwXMpobtrSQVd7cq8Xh+Ccz/5kihGssJhDqRPq0GQ=; b=ECtOfV1EUPZtvxCJjGr1a4UTKGY4TkOF7H7l+b47NQyQsJvHK+eyr06M2GdM9kCUHX jufMr+Ofjhsh6AhwE0Dey/4+/Xl+rHap2zKBfgwgx8sJJKisZPT0G1ZuQNOBjghKbaiF N7I8V6KqIlgho8kkkx1vrlr/aJ/b9YIGYXPNSdf4Cw346o/YT57FdsZFAMZ6TfgiFsNL KlZnO6sGpd6mjk2kL0DOwyGREP6ps+zbVwZJoX1nJ/2Yrugnt66VG8Dvg17uzN9gCTCz RerWiFO0/vPsgyp98A4k9bfQyuP1tihgbKrMOHnceEf/5fa8QEthZeFiuN/2vXqRX4N1 m38g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=w8kwXMpobtrSQVd7cq8Xh+Ccz/5kihGssJhDqRPq0GQ=; b=ZzPpR88WCi6tJbHX/KeA/VeYUoBlBZ/Bo+LiaWosnWv/1BDbGQgerQu538kwniF76+ fn8TiAGSHymkCDcTQTQiogwYjNNgq9nvGk8tnjdspHNjPKJAz7zKAfVeIqsttmW0G8pi 15/m6a/uTSWheGeln98W3gPES3GGL8jemn45zqNTEQl5Ju+VFlYN+bXwCiA3Og12tvf0 5O7sbt6BNOTk/Co+f+XWvfMe6db1rF4fgnhcVyTsYdPea8wC0zHid0tW5aVzLpM9bvGC Wr57i/Kqz9HTqs0+90LSx7tT0sno7HDCdw5to7ffKmBAuIG9Kp5bXggqK4Iklbwxcy1n J5BQ== X-Gm-Message-State: AKGB3mIWZFVX1QRYRLQh0BP6zSYWoHbLXeqOKOm2nqJ9beM50cPgEicd kGg1uLxp6zJZxfS0A10LffQ= X-Google-Smtp-Source: AGs4zMbQey9ynAcpUEFQJ9xyvSW/pmcuQL4Z5jO8Gwkl9rgD0lxBueRM1/eQQFgH35IeV1Vc2ZH4Ng== X-Received: by 10.28.105.76 with SMTP id e73mr2816410wmc.116.1512199941525; Fri, 01 Dec 2017 23:32:21 -0800 (PST) Received: from calancha-pc (228.red-83-40-68.dynamicip.rima-tde.net. [83.40.68.228]) by smtp.gmail.com with ESMTPSA id b16sm11580011wrd.69.2017.12.01.23.32.20 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 01 Dec 2017 23:32:20 -0800 (PST) From: Tino Calancha References: <83vahv67eb.fsf@gnu.org> <87fu8zukmb.fsf@gmail.com> <83609u5pyr.fsf@gnu.org> <29b407d1-e1f6-4676-a686-ccdf19af8bb4@default> <83mv323kvx.fsf@gnu.org> Date: Sat, 02 Dec 2017 16:32:16 +0900 In-Reply-To: (Allen Li's message of "Fri, 1 Dec 2017 22:31:03 -0800") Message-ID: <87a7z1vb3z.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Allen Li writes: Thank you for the new patches Allen! I don't have strong opinions on this thread; probably because I am already in Christmass mode or something... Anyway, I think you guys are discussing pretty well the thing! I have just two comments in the second patch: > +;;;###autoload > +(defcustom dired-confirm-shell-command t > + "Whether to prompt for confirmation for Dired shell commands. > +If t, prompt" > + :type '(choice (const :tag "No restrictions" nil) > + (const :tag "When point is on a file name initially, search file names" dwim) > + (const :tag "Always search in file names" t)) > + :group 'dired > + :version "26.0") ^^^^ * Version must be 26.1 * The :type looks unrelated with the option. Maybe better something like this: :type '(choice (const :tag "Ask confirmation" t) (const :tag "Never ask confirmation" nil)) > + > - (string-match regexp res)))) > + (when > + dired-confirm-shell-command > + (let ((res cmd) You might put the option in the same line as `when', i.e.: (when dired-confirm-shell-command From unknown Mon Aug 18 04:42:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29465: 25.3; Confusing message for dired-do-shell-command substitution Resent-From: Allen Li Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 02 Dec 2017 08:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29465 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Tino Calancha Cc: Eli Zaretskii , 29465@debbugs.gnu.org, Drew Adams Received: via spool by 29465-submit@debbugs.gnu.org id=B29465.151220294627925 (code B ref 29465); Sat, 02 Dec 2017 08:23:01 +0000 Received: (at 29465) by debbugs.gnu.org; 2 Dec 2017 08:22:26 +0000 Received: from localhost ([127.0.0.1]:40959 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eL345-0007GK-QM for submit@debbugs.gnu.org; Sat, 02 Dec 2017 03:22:26 -0500 Received: from mail-qk0-f171.google.com ([209.85.220.171]:45842) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eL343-0007G7-G4 for 29465@debbugs.gnu.org; Sat, 02 Dec 2017 03:22:23 -0500 Received: by mail-qk0-f171.google.com with SMTP id d141so15972837qkc.12 for <29465@debbugs.gnu.org>; Sat, 02 Dec 2017 00:22:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=LQC17Utbr59x+Vp7BfKjbGtCLGlyP+L/JtJHMrroPA4=; b=JrefIQbgkcX0vv++m/l80Ar17yo5FFAM8fFoEXF0uPZgdAUyV95d6a7lrIYc2N9Ujs coLmBlzt4YbIq6zWIwdrQW38epQKsSC8XzJb6WvrqJN5vcWvCOfYqCkjOeLo6DZRFVIF 4pMiCqYgxheFMIMUK8YBbVqt1VZKcZsQhxzsTuLvXJ0U2Kttv7d0jqcv0mxP3HB40IVZ /l80zyKYk9mlI2u8yeKQ68AtcX5+wu8q2Z3LfmuEnhULeRQ0gVqnx6ZtghvJRDYmcTyN pvvii+6ZE6EhbVczrY9gU6N/vG3q8/egDuLZ7sPSkECsmJ8vaMxOQCprnUZ16NCo07d0 ddAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=LQC17Utbr59x+Vp7BfKjbGtCLGlyP+L/JtJHMrroPA4=; b=hoFbY0s4Rh8FHF66nxyzYzOoIaoDmzHPgLnmsI3YJG2MVwsJCj2qf6I9vQktAMC2Ob aLwrpjHbsFp92dLLbNJ3jPFnK6iRcOteIeRcl8kUhzsan/z5ZAF3WnyNKG4LWx7B8UDl eiD8uj9rNUo9H9ea2KCDNhXB9ZZPRhwwstl3I1kJAtqpGcxHOk0WFUGyuzGlnr5Huhxf FniupTXarsfMZo/BEFajhpACknRBMDlz5dPYBNtOLMHDoU5feNb3e7MhNu9c+HgbBdMX 6MSwdglzV+W0jnPgp7aGF6SaPLqrM5oswIzkDXedaE+q9jmVaa35k7gxectlkWu0Mi5D 08Yg== X-Gm-Message-State: AKGB3mJq2Ch1ZrKg9YOeIfkZ8Y1zgNyPuRfkN0Ex85+QMZlKG/v27mW6 /kRk2Sf3YPB0SRcbT1cNhLiVNKU8Mb9Q1Jl4wnY= X-Google-Smtp-Source: AGs4zMZw0NACikVxz2txkQSggavkw0afNIOp+nA3Dvq+Mh3qGHH3qKGX/5mthJOvd1LHflDMXw3sSYG3yf2qqOPqlmI= X-Received: by 10.55.142.3 with SMTP id q3mr11950743qkd.276.1512202937930; Sat, 02 Dec 2017 00:22:17 -0800 (PST) MIME-Version: 1.0 Received: by 10.237.52.161 with HTTP; Sat, 2 Dec 2017 00:22:17 -0800 (PST) In-Reply-To: <87a7z1vb3z.fsf@gmail.com> References: <83vahv67eb.fsf@gnu.org> <87fu8zukmb.fsf@gmail.com> <83609u5pyr.fsf@gnu.org> <29b407d1-e1f6-4676-a686-ccdf19af8bb4@default> <83mv323kvx.fsf@gnu.org> <87a7z1vb3z.fsf@gmail.com> From: Allen Li Date: Sat, 2 Dec 2017 00:22:17 -0800 Message-ID: Content-Type: multipart/mixed; boundary="94eb2c0853faf1d7c9055f572e4c" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --94eb2c0853faf1d7c9055f572e4c Content-Type: text/plain; charset="UTF-8" On Fri, Dec 1, 2017 at 11:32 PM, Tino Calancha wrote: > Allen Li writes: > > Thank you for the new patches Allen! > I don't have strong opinions on this thread; probably because > I am already in Christmass mode or something... Anyway, I think > you guys are discussing pretty well the thing! > > I have just two comments in the second patch: >> +;;;###autoload >> +(defcustom dired-confirm-shell-command t >> + "Whether to prompt for confirmation for Dired shell commands. >> +If t, prompt" >> + :type '(choice (const :tag "No restrictions" nil) >> + (const :tag "When point is on a file name initially, search file names" dwim) >> + (const :tag "Always search in file names" t)) >> + :group 'dired >> + :version "26.0") > ^^^^ > > * Version must be 26.1 > * The :type looks unrelated with the option. > Maybe better something like this: > > :type '(choice (const :tag "Ask confirmation" t) > (const :tag "Never ask confirmation" nil)) >> + >> - (string-match regexp res)))) >> + (when >> + dired-confirm-shell-command >> + (let ((res cmd) > You might put the option in the same line as `when', i.e.: > (when dired-confirm-shell-command Thanks, attached new second patch. --94eb2c0853faf1d7c9055f572e4c Content-Type: text/x-patch; charset="UTF-8"; name="0002-Add-option-for-controlling-dired-do-shell-command-pr.patch" Content-Disposition: attachment; filename="0002-Add-option-for-controlling-dired-do-shell-command-pr.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_jap2knz80 RnJvbSAzYTY4NjE1NTJkMmE0OWUwNTJiNzZiMTBkNWI3N2I5Y2UyZWVkMDE2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGxlbiBMaSA8ZGFya2ZlbGluZUBmZWxlc2F0cmEubW9lPgpE YXRlOiBGcmksIDEgRGVjIDIwMTcgMjI6MjI6NTMgLTA4MDAKU3ViamVjdDogW1BBVENIIDIvMl0g QWRkIG9wdGlvbiBmb3IgY29udHJvbGxpbmcgZGlyZWQtZG8tc2hlbGwtY29tbWFuZCBwcm9tcHQK CiogZG9jL2VtYWNzL2RpcmVkLnRleGkgKFNoZWxsIENvbW1hbmRzIGluIERpcmVkKTogRG9jdW1l bnQgb3B0aW9uCiogbGlzcC9kaXJlZC1hdXguZWwgKGRpcmVkLWNvbmZpcm0tc2hlbGwtY29tbWFu ZCk6IEFkZCBvcHRpb24KKGRpcmVkLWRvLXNoZWxsLWNvbW1hbmQpOiBDaGVjayBvcHRpb24gYmVm b3JlIHByb21wdGluZwotLS0KIGRvYy9lbWFjcy9kaXJlZC50ZXhpIHwgIDQgKysrLQogbGlzcC9k aXJlZC1hdXguZWwgICAgfCAyNCArKysrKysrKysrKysrKysrKy0tLS0tLS0KIDIgZmlsZXMgY2hh bmdlZCwgMjAgaW5zZXJ0aW9ucygrKSwgOCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9kb2Mv ZW1hY3MvZGlyZWQudGV4aSBiL2RvYy9lbWFjcy9kaXJlZC50ZXhpCmluZGV4IDkzNDhlZjUwNDIu LjRjMDgyNmUxYTMgMTAwNjQ0Ci0tLSBhL2RvYy9lbWFjcy9kaXJlZC50ZXhpCisrKyBiL2RvYy9l bWFjcy9kaXJlZC50ZXhpCkBAIC04NjYsNiArODY2LDcgQEAgU2hlbGwgQ29tbWFuZHMgaW4gRGly ZWQKIEBmaW5kZXggZGlyZWQtZG8tc2hlbGwtY29tbWFuZAogQGtpbmRleCAhIEByeyhEaXJlZCl9 CiBAa2luZGV4IFggQHJ7KERpcmVkKX0KK0B2aW5kZXggZGlyZWQtY29uZmlybS1zaGVsbC1jb21t YW5kCiBUaGUgRGlyZWQgY29tbWFuZCBAa2JkeyF9IChAY29kZXtkaXJlZC1kby1zaGVsbC1jb21t YW5kfSkgcmVhZHMgYQogc2hlbGwgY29tbWFuZCBzdHJpbmcgaW4gdGhlIG1pbmlidWZmZXIsIGFu ZCBydW5zIHRoYXQgc2hlbGwgY29tbWFuZCBvbgogb25lIG9yIG1vcmUgZmlsZXMuICBUaGUgZmls ZXMgdGhhdCB0aGUgc2hlbGwgY29tbWFuZCBvcGVyYXRlcyBvbiBhcmUKQEAgLTkwMiw3ICs5MDMs OCBAQCBTaGVsbCBDb21tYW5kcyBpbiBEaXJlZAogSWYgeW91IHdhbnQgdG8gdXNlIEBzYW1weyp9 IGFzIGEgc2hlbGwgd2lsZGNhcmQgd2l0aCB3aGl0ZXNwYWNlIGFyb3VuZAogaXQsIHdyaXRlIEBz YW1weyoiIn0uICBJbiB0aGUgc2hlbGwsIHRoaXMgaXMgZXF1aXZhbGVudCB0byBAc2FtcHsqfTsK IGJ1dCBzaW5jZSB0aGUgQHNhbXB7Kn0gaXMgbm90IHN1cnJvdW5kZWQgYnkgd2hpdGVzcGFjZSwg RGlyZWQgZG9lcyBub3QKLXRyZWF0IGl0IHNwZWNpYWxseS4KK3RyZWF0IGl0IHNwZWNpYWxseS4g IEVtYWNzIHdpbGwgcHJvbXB0IGZvciBjb25maXJtYXRpb24gaWYgeW91IGRvCit0aGlzLCB1bmxl c3MgQGNvZGV7ZGlyZWQtY29uZmlybS1zaGVsbC1jb21tYW5kfSBpcyBAY29kZXtuaWx9LgogCiBA aXRlbQogT3RoZXJ3aXNlLCBpZiB0aGUgY29tbWFuZCBzdHJpbmcgY29udGFpbnMgQHNhbXB7P30g c3Vycm91bmRlZCBieQpkaWZmIC0tZ2l0IGEvbGlzcC9kaXJlZC1hdXguZWwgYi9saXNwL2RpcmVk LWF1eC5lbAppbmRleCA1N2ViMjE2MjMxLi5jOWYyNDBkZDQ2IDEwMDY0NAotLS0gYS9saXNwL2Rp cmVkLWF1eC5lbAorKysgYi9saXNwL2RpcmVkLWF1eC5lbApAQCAtNjQ5LDYgKzY0OSwxNSBAQCBk aXJlZC1yZWFkLXNoZWxsLWNvbW1hbmQKICAgICAgIChkaXJlZC1tYXJrLXBvcC11cCBuaWwgJ3No ZWxsIGZpbGVzCiAJCQkgJ3JlYWQtc2hlbGwtY29tbWFuZCBwcm9tcHQgbmlsIG5pbCkpKSkKIAor Ozs7IyMjYXV0b2xvYWQKKyhkZWZjdXN0b20gZGlyZWQtY29uZmlybS1zaGVsbC1jb21tYW5kIHQK KyAgIldoZXRoZXIgdG8gcHJvbXB0IGZvciBjb25maXJtYXRpb24gZm9yIOKAmGRpcmVkLWRvLXNo ZWxsLWNvbW1hbmTigJkuCitJZiB0LCBwcm9tcHQgZm9yIGNvbmZpcm1hdGlvbiBpZiB0aGUgY29t bWFuZCBjb250YWlucyBwb3RlbnRpYWxseQorZGFuZ2Vyb3VzIGNoYXJhY3RlcnMuICBJZiBuaWws IG5ldmVyIHByb21wdCBmb3IgY29uZmlybWF0aW9uLiIKKyAgOnR5cGUgJ2Jvb2xlYW4KKyAgOmdy b3VwICdkaXJlZAorICA6dmVyc2lvbiAiMjYuMSIpCisKIDs7OyMjI2F1dG9sb2FkCiAoZGVmdW4g ZGlyZWQtZG8tYXN5bmMtc2hlbGwtY29tbWFuZCAoY29tbWFuZCAmb3B0aW9uYWwgYXJnIGZpbGUt bGlzdCkKICAgIlJ1biBhIHNoZWxsIGNvbW1hbmQgQ09NTUFORCBvbiB0aGUgbWFya2VkIGZpbGVz IGFzeW5jaHJvbm91c2x5LgpAQCAtNzM3LDEzICs3NDYsMTQgQEAgZGlyZWQtZG8tc2hlbGwtY29t bWFuZAogICAgICAgZmlsZXMpKSkKICAgKGNsLWZsZXQgKChuZWVkLWNvbmZpcm0tcAogICAgICAg ICAgICAgIChjbWQgc3RyKQotICAgICAgICAgICAgIChsZXQgKChyZXMgY21kKQotICAgICAgICAg ICAgICAgICAgIChyZWdleHAgKHJlZ2V4cC1xdW90ZSBzdHIpKSkKLSAgICAgICAgICAgICAgIDs7 IERyb3AgYWxsID8gYW5kICogc3Vycm91bmRlZCBieSBzcGFjZXMgYW5kIGA/YC4KLSAgICAgICAg ICAgICAgICh3aGlsZSAoYW5kIChzdHJpbmctbWF0Y2ggcmVnZXhwIHJlcykKLSAgICAgICAgICAg ICAgICAgICAgICAgICAgIChkaXJlZC0tc3Rhci1vci1xbWFyay1wIHJlcyBzdHIpKQotICAgICAg ICAgICAgICAgICAoc2V0cSByZXMgKHJlcGxhY2UtbWF0Y2ggIiIgdCB0IHJlcyAyKSkpCi0gICAg ICAgICAgICAgICAoc3RyaW5nLW1hdGNoIHJlZ2V4cCByZXMpKSkpCisgICAgICAgICAgICAgKHdo ZW4gZGlyZWQtY29uZmlybS1zaGVsbC1jb21tYW5kCisgICAgICAgICAgICAgICAobGV0ICgocmVz IGNtZCkKKyAgICAgICAgICAgICAgICAgICAgIChyZWdleHAgKHJlZ2V4cC1xdW90ZSBzdHIpKSkK KyAgICAgICAgICAgICAgICAgOzsgRHJvcCBhbGwgPyBhbmQgKiBzdXJyb3VuZGVkIGJ5IHNwYWNl cyBhbmQgYD9gLgorICAgICAgICAgICAgICAgICAod2hpbGUgKGFuZCAoc3RyaW5nLW1hdGNoIHJl Z2V4cCByZXMpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChkaXJlZC0tc3Rhci1vci1x bWFyay1wIHJlcyBzdHIpKQorICAgICAgICAgICAgICAgICAgIChzZXRxIHJlcyAocmVwbGFjZS1t YXRjaCAiIiB0IHQgcmVzIDIpKSkKKyAgICAgICAgICAgICAgICAgKHN0cmluZy1tYXRjaCByZWdl eHAgcmVzKSkpKSkKICAgKGxldCogKChvbi1lYWNoIChub3QgKGRpcmVkLS1zdGFyLW9yLXFtYXJr LXAgY29tbWFuZCAiKiIgJ2tlZXApKSkKIAkgKG5vLXN1YnN0IChub3QgKGRpcmVkLS1zdGFyLW9y LXFtYXJrLXAgY29tbWFuZCAiPyIgJ2tlZXApKSkKICAgICAgICAgIDs7IEdldCBjb25maXJtYXRp b24gZm9yIHdpbGRjYXJkcyB0aGF0IG1heSBoYXZlIGJlZW4gbWVhbnQKLS0gCjIuMTUuMQoK --94eb2c0853faf1d7c9055f572e4c-- From unknown Mon Aug 18 04:42:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#29465: 25.3; Confusing message for dired-do-shell-command substitution Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Mar 2022 16:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29465 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Allen Li Cc: Eli Zaretskii , 29465@debbugs.gnu.org, Drew Adams , Tino Calancha Received: via spool by 29465-submit@debbugs.gnu.org id=B29465.164796772617799 (code B ref 29465); Tue, 22 Mar 2022 16:49:01 +0000 Received: (at 29465) by debbugs.gnu.org; 22 Mar 2022 16:48:46 +0000 Received: from localhost ([127.0.0.1]:41712 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nWhgc-0004d1-IM for submit@debbugs.gnu.org; Tue, 22 Mar 2022 12:48:46 -0400 Received: from quimby.gnus.org ([95.216.78.240]:36548) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nWhga-0004cn-5a for 29465@debbugs.gnu.org; Tue, 22 Mar 2022 12:48:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=PPUIIQxclefLO7oM4PHRMBE7AQ6PnPAK3kXbZwjrCNw=; b=Z/CytA5DNRa3Zd6155sMjwpt/9 Whd4i4nkL6XTYz+7UgHFM0b7+Y/m9IRlg7j7eX5xRW8uxLxH+TR6H5AGsmVoag6Tkc4e6gdU0wC1K WxIYgN9Bu0lCOOx1bMn/FcszyVAfxh5vNlHkAGT3UQt/bVmTjy3hTA1r0GxbuZYzTgdw=; Received: from 109.179.236.69.tmi.telenormobil.no ([109.179.236.69] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nWhgP-0008FK-L3; Tue, 22 Mar 2022 17:48:36 +0100 From: Lars Ingebrigtsen References: <83vahv67eb.fsf@gnu.org> <87fu8zukmb.fsf@gmail.com> <83609u5pyr.fsf@gnu.org> <29b407d1-e1f6-4676-a686-ccdf19af8bb4@default> <83mv323kvx.fsf@gnu.org> <87a7z1vb3z.fsf@gmail.com> Date: Tue, 22 Mar 2022 17:48:32 +0100 In-Reply-To: (Allen Li's message of "Sat, 2 Dec 2017 00:22:17 -0800") Message-ID: <875yo6j5lr.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Allen Li writes: > Thanks, attached new second patch. Thanks; pushed to Emacs 29 now (with some changes). Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP 0.0 TVD_RCVD_IP Message was received from an IP address -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Allen Li writes: > Thanks, attached new second patch. Thanks; pushed to Emacs 29 now (with some changes). -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 22 12:48:51 2022 Received: (at control) by debbugs.gnu.org; 22 Mar 2022 16:48:51 +0000 Received: from localhost ([127.0.0.1]:41715 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nWhgg-0004dI-OX for submit@debbugs.gnu.org; Tue, 22 Mar 2022 12:48:51 -0400 Received: from quimby.gnus.org ([95.216.78.240]:36562) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nWhgc-0004cq-P9 for control@debbugs.gnu.org; Tue, 22 Mar 2022 12:48:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=X0q4Tz9UAsXeEUinA3Ippzt/jFqunD3W9DV1u264bqE=; b=COBp7lGmxeGVcf8vjKrQKCiqXC b0wydIIlPaFKK9BJ7P22hWkBesgBjjdfD8Bdo5WduIGbh/wmAbKo6TCLHj1NCtVgIBCidu9ccxz+C r6TfBfmqsov0Yvuz1jo82m7jvRr5EUDXaxyKkdaRcEqrMrQ4GJSFTtrbk30aA1kFwef8=; Received: from 109.179.236.69.tmi.telenormobil.no ([109.179.236.69] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nWhgV-0008FR-FP for control@debbugs.gnu.org; Tue, 22 Mar 2022 17:48:41 +0100 Date: Tue, 22 Mar 2022 17:48:38 +0100 Message-Id: <874k3qj5ll.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #29465 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 29465 29.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP 0.0 TVD_RCVD_IP Message was received from an IP address -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 29465 29.1 quit