GNU bug report logs - #29454
wait_reading_process_output duplication

Previous Next

Package: emacs;

Reported by: charles <at> aurox.ch (Charles A. Roelli)

Date: Sun, 26 Nov 2017 09:45:02 UTC

Severity: normal

Done: charles <at> aurox.ch (Charles A. Roelli)

Bug is archived. No further changes may be made.

Full log

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: charles <at> aurox.ch (Charles A. Roelli)
To: bug-gnu-emacs <at> gnu.org
Subject: wait_reading_process_output duplication
Date: Sun, 26 Nov 2017 10:45:53 +0100

Looks like these two blocks are duplicated in
wait_reading_process_output in process.c:

5628 #ifdef WINDOWSNT
5629 	      /* FIXME: Is this special case still needed?  */
5630 	      /* Note that we cannot distinguish between no input
5631 		 available now and a closed pipe.
5632 		 With luck, a closed pipe will be accompanied by
5633 		 subprocess termination and SIGCHLD.  */
5634 	      else if (nread == 0 && !NETCONN_P (proc) && !SERIALCONN_P (proc)
5635 		       && !PIPECONN_P (proc))
5636 		;
5637 #endif

5664 	      /* If we can detect process termination, don't consider the
5665 		 process gone just because its pipe is closed.  */
5666 	      else if (nread == 0 && !NETCONN_P (proc) && !SERIALCONN_P (proc)
5667 		       && !PIPECONN_P (proc))
5668 		;

Can the first be deleted?
This bug report was last modified 7 years and 239 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.