From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 26 04:44:51 2017 Received: (at submit) by debbugs.gnu.org; 26 Nov 2017 09:44:51 +0000 Received: from localhost ([127.0.0.1]:58555 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eItUZ-0006Tc-7H for submit@debbugs.gnu.org; Sun, 26 Nov 2017 04:44:51 -0500 Received: from eggs.gnu.org ([208.118.235.92]:43705) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eItUX-0006TP-Jg for submit@debbugs.gnu.org; Sun, 26 Nov 2017 04:44:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eItUR-0001if-B8 for submit@debbugs.gnu.org; Sun, 26 Nov 2017 04:44:44 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:58921) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eItUR-0001ib-84 for submit@debbugs.gnu.org; Sun, 26 Nov 2017 04:44:43 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34676) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eItUQ-0003CZ-95 for bug-gnu-emacs@gnu.org; Sun, 26 Nov 2017 04:44:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eItUN-0001hP-6R for bug-gnu-emacs@gnu.org; Sun, 26 Nov 2017 04:44:42 -0500 Received: from [2a03:2040:2:1b::1] (port=40466 helo=sinyavsky.aurox.ch) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eItUM-0001fV-Tt for bug-gnu-emacs@gnu.org; Sun, 26 Nov 2017 04:44:39 -0500 Received: from sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) by sinyavsky.aurox.ch (Postfix) with ESMTP id D0179225D4 for ; Sun, 26 Nov 2017 09:37:08 +0000 (UTC) Authentication-Results: sinyavsky.aurox.ch (amavisd-new); dkim=pass (1024-bit key) reason="pass (just generated, assumed good)" header.d=aurox.ch DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aurox.ch; h= subject:subject:to:from:from:message-id:date:date; s=dkim; t= 1511689027; x=1512553028; bh=U1BF6UxYmSB7IY4C401W1dwU+ZXz9stKSsc Om8TN0eg=; b=rOY+dhFAZ17zv1ckvqRA064J1JgpzoWBaOR+z62bCzbT6L3hM89 JIe96a9P0TDHy38RejqyTdqVnCcuuyDsjQHXP6+2Ahjq4rMeQy9dqHxwW339Zt6c 0VKcR54qxx78jxYJlDleKDniypSFY4D/21xBe4Ykk1sFQq7S1FPzOc3c= X-Virus-Scanned: Debian amavisd-new at test.virtualizor.com Received: from sinyavsky.aurox.ch ([127.0.0.1]) by sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 103CzmgjhGz5 for ; Sun, 26 Nov 2017 09:37:07 +0000 (UTC) Received: from gray (125.85.192.178.dynamic.wline.res.cust.swisscom.ch [178.192.85.125]) by sinyavsky.aurox.ch (Postfix) with ESMTPSA id 46783225C0 for ; Sun, 26 Nov 2017 09:37:07 +0000 (UTC) Date: Sun, 26 Nov 2017 10:45:53 +0100 Message-Id: From: charles@aurox.ch (Charles A. Roelli) To: bug-gnu-emacs@gnu.org Subject: wait_reading_process_output duplication X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) Looks like these two blocks are duplicated in wait_reading_process_output in process.c: 5628 #ifdef WINDOWSNT 5629 /* FIXME: Is this special case still needed? */ 5630 /* Note that we cannot distinguish between no input 5631 available now and a closed pipe. 5632 With luck, a closed pipe will be accompanied by 5633 subprocess termination and SIGCHLD. */ 5634 else if (nread == 0 && !NETCONN_P (proc) && !SERIALCONN_P (proc) 5635 && !PIPECONN_P (proc)) 5636 ; 5637 #endif 5664 /* If we can detect process termination, don't consider the 5665 process gone just because its pipe is closed. */ 5666 else if (nread == 0 && !NETCONN_P (proc) && !SERIALCONN_P (proc) 5667 && !PIPECONN_P (proc)) 5668 ; Can the first be deleted? From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 26 10:54:20 2017 Received: (at 29454) by debbugs.gnu.org; 26 Nov 2017 15:54:20 +0000 Received: from localhost ([127.0.0.1]:59503 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eIzG8-0007a7-KP for submit@debbugs.gnu.org; Sun, 26 Nov 2017 10:54:20 -0500 Received: from eggs.gnu.org ([208.118.235.92]:35771) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eIzG7-0007Zw-Fr for 29454@debbugs.gnu.org; Sun, 26 Nov 2017 10:54:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eIzG1-0006m4-Fe for 29454@debbugs.gnu.org; Sun, 26 Nov 2017 10:54:14 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:42881) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eIzG1-0006m0-CQ; Sun, 26 Nov 2017 10:54:13 -0500 Received: from [176.228.60.248] (port=4931 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eIzG0-0002wd-Oi; Sun, 26 Nov 2017 10:54:13 -0500 Date: Sun, 26 Nov 2017 17:54:00 +0200 Message-Id: <83h8th6non.fsf@gnu.org> From: Eli Zaretskii To: charles@aurox.ch (Charles A. Roelli) In-reply-to: (charles@aurox.ch) Subject: Re: bug#29454: wait_reading_process_output duplication References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 29454 Cc: 29454@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > Date: Sun, 26 Nov 2017 10:45:53 +0100 > From: charles@aurox.ch (Charles A. Roelli) > > Looks like these two blocks are duplicated in > wait_reading_process_output in process.c: > > 5628 #ifdef WINDOWSNT > 5629 /* FIXME: Is this special case still needed? */ > 5630 /* Note that we cannot distinguish between no input > 5631 available now and a closed pipe. > 5632 With luck, a closed pipe will be accompanied by > 5633 subprocess termination and SIGCHLD. */ > 5634 else if (nread == 0 && !NETCONN_P (proc) && !SERIALCONN_P (proc) > 5635 && !PIPECONN_P (proc)) > 5636 ; > 5637 #endif > > 5664 /* If we can detect process termination, don't consider the > 5665 process gone just because its pipe is closed. */ > 5666 else if (nread == 0 && !NETCONN_P (proc) && !SERIALCONN_P (proc) > 5667 && !PIPECONN_P (proc)) > 5668 ; > > Can the first be deleted? Yes. (The second was originally conditioned on SIGCHLD, which is why it was separate.) Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 26 14:43:11 2017 Received: (at 29454-done) by debbugs.gnu.org; 26 Nov 2017 19:43:12 +0000 Received: from localhost ([127.0.0.1]:59647 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJ2pb-0003n7-MX for submit@debbugs.gnu.org; Sun, 26 Nov 2017 14:43:11 -0500 Received: from sinyavsky.aurox.ch ([37.35.109.145]:53704) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJ2pY-0003mp-Gs for 29454-done@debbugs.gnu.org; Sun, 26 Nov 2017 14:43:10 -0500 Received: from sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) by sinyavsky.aurox.ch (Postfix) with ESMTP id F038C225D8 for <29454-done@debbugs.gnu.org>; Sun, 26 Nov 2017 19:35:40 +0000 (UTC) Authentication-Results: sinyavsky.aurox.ch (amavisd-new); dkim=pass (1024-bit key) reason="pass (just generated, assumed good)" header.d=aurox.ch DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aurox.ch; h= references:subject:subject:in-reply-to:to:from:from:message-id :date:date; s=dkim; t=1511724939; x=1512588940; bh=ywnOT2mrXcGyY ZStOchr81Di9ZofRCluQEN6vATb6rA=; b=ML6AuyPz/OwG9j4syWFMMQ+Mdm2Oe ZdWPJTFP0erl8LNv3Z8f9Mjm1a9TpjbTOnVeCoUmjXfVYc9v+af1T0LwkzORyoj0 DDBbPNm9eydudGwWrqXnzocidzDzNLHLSIiC5X1AidmhvorAnXPGW53z2ddxtBr3 cfcD5mRZi8ju/0= X-Virus-Scanned: Debian amavisd-new at test.virtualizor.com Received: from sinyavsky.aurox.ch ([127.0.0.1]) by sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id rGjEA9m-MzcS for <29454-done@debbugs.gnu.org>; Sun, 26 Nov 2017 19:35:39 +0000 (UTC) Received: from gray (125.85.192.178.dynamic.wline.res.cust.swisscom.ch [178.192.85.125]) by sinyavsky.aurox.ch (Postfix) with ESMTPSA id B083E225C8; Sun, 26 Nov 2017 19:35:38 +0000 (UTC) Date: Sun, 26 Nov 2017 20:44:27 +0100 Message-Id: From: charles@aurox.ch (Charles A. Roelli) To: Eli Zaretskii In-reply-to: <83h8th6non.fsf@gnu.org> (message from Eli Zaretskii on Sun, 26 Nov 2017 17:54:00 +0200) Subject: Re: bug#29454: wait_reading_process_output duplication References: <83h8th6non.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 29454-done Cc: 29454-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) > Date: Sun, 26 Nov 2017 17:54:00 +0200 > From: Eli Zaretskii > CC: 29454@debbugs.gnu.org > Reply-to: Eli Zaretskii > > > Date: Sun, 26 Nov 2017 10:45:53 +0100 > > From: charles@aurox.ch (Charles A. Roelli) > > > > Looks like these two blocks are duplicated in > > wait_reading_process_output in process.c: > > > > 5628 #ifdef WINDOWSNT > > 5629 /* FIXME: Is this special case still needed? */ > > 5630 /* Note that we cannot distinguish between no input > > 5631 available now and a closed pipe. > > 5632 With luck, a closed pipe will be accompanied by > > 5633 subprocess termination and SIGCHLD. */ > > 5634 else if (nread == 0 && !NETCONN_P (proc) && !SERIALCONN_P (proc) > > 5635 && !PIPECONN_P (proc)) > > 5636 ; > > 5637 #endif > > > > 5664 /* If we can detect process termination, don't consider the > > 5665 process gone just because its pipe is closed. */ > > 5666 else if (nread == 0 && !NETCONN_P (proc) && !SERIALCONN_P (proc) > > 5667 && !PIPECONN_P (proc)) > > 5668 ; > > > > Can the first be deleted? > > Yes. (The second was originally conditioned on SIGCHLD, which is why > it was separate.) > > Thanks. Thanks, it's pushed to master. commit 6ec5d497b6623e612ca6936ac848234725d4fc61 Date: Sun Nov 26 20:18:54 2017 +0100 * src/process.c (wait_reading_process_output): Deduplicate check. (Bug#29454) From unknown Tue Aug 19 23:15:43 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 25 Dec 2017 12:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator