From unknown Sat Jun 21 03:31:02 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#29449] [PATCH] gnu: node: Update to 8.9.1. Resent-From: Mike Gerwitz Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 26 Nov 2017 01:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 29449 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 29449@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.151166081712570 (code B ref -1); Sun, 26 Nov 2017 01:47:02 +0000 Received: (at submit) by debbugs.gnu.org; 26 Nov 2017 01:46:57 +0000 Received: from localhost ([127.0.0.1]:58376 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eIm21-0003Gc-Qf for submit@debbugs.gnu.org; Sat, 25 Nov 2017 20:46:57 -0500 Received: from eggs.gnu.org ([208.118.235.92]:35691) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eIm20-0003GQ-CE for submit@debbugs.gnu.org; Sat, 25 Nov 2017 20:46:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eIm1u-0002Dl-0X for submit@debbugs.gnu.org; Sat, 25 Nov 2017 20:46:47 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:36552) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eIm1t-0002De-SM for submit@debbugs.gnu.org; Sat, 25 Nov 2017 20:46:45 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54885) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eIm1s-00019a-Bb for guix-patches@gnu.org; Sat, 25 Nov 2017 20:46:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eIm1r-0002AH-5w for guix-patches@gnu.org; Sat, 25 Nov 2017 20:46:44 -0500 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:36346) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eIm1r-0002A1-0t for guix-patches@gnu.org; Sat, 25 Nov 2017 20:46:43 -0500 Received: from localhost ([::1]:55984 helo=mikegerwitz-pc.gerwitz.local) by fencepost.gnu.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1eIm1q-0005AA-Ls for guix-patches@gnu.org; Sat, 25 Nov 2017 20:46:42 -0500 From: Mike Gerwitz Date: Sat, 25 Nov 2017 20:45:40 -0500 Message-ID: <877eudg6d7.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) OpenPGP: id=22175B02E626BC98D7C0C2E5F22BB8158EE30EAB MIME-Version: 1.0 Content-Type: multipart/signed; boundary="===-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) --===-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain Let me know if there is a better way to accomplish removing the `doc-only' invocation as part of the `check' target. It invokes npm and attempts to download `js-yaml', so I figured we may as well just skip it altogether since it isn't otherwise used. --=-=-= Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" --==-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-gnu-node-Update-to-8.9.1.patch Content-Transfer-Encoding: quoted-printable From=20918303981e0dd3212f1e0c1f1f87fc8ca608cc5e Mon Sep 17 00:00:00 2001 From: Mike Gerwitz Date: Sat, 25 Nov 2017 20:34:12 -0500 Subject: [PATCH] gnu: node: Update to 8.9.1. * gnu/packages/node.scm (node): Update to 8.9.1. [arguments]: Skip 'doc-only' target in 'check', which attempts to use npm to retrieve 'js-yaml' package. Remove test/doctool/test-make-doc.js. Do not remove now-missing test case. Remove new test case that fails in containers due to networking. =2D-- gnu/packages/node.scm | 18 +++++++++++++++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/gnu/packages/node.scm b/gnu/packages/node.scm index e354130ad..4e2990ca3 100644 =2D-- a/gnu/packages/node.scm +++ b/gnu/packages/node.scm @@ -40,14 +40,14 @@ (define-public node (package (name "node") =2D (version "8.7.0") + (version "8.9.1") (source (origin (method url-fetch) (uri (string-append "http://nodejs.org/dist/v" version "/node-v" version ".tar.gz")) (sha256 (base32 =2D "1a0ginagx3pav6v7adyp76jisia4qgbsq6pz3als4kshwlk4a667"))= )) + "1qbiz7hgwlirhwpd71c8yzcbwsyi5bjlfp6lxb6v55j6rizinj9j")))) (build-system gnu-build-system) (arguments ;; TODO: Purge the bundled copies from the source. @@ -76,6 +76,10 @@ (("'/usr/bin/env'") (string-append "'" (which "env") "'"))) =20 + + ;; test-make-doc needs doc-only target, which is inhibited be= low + (for-each delete-file + '("test/doctool/test-make-doc.js")) ;; FIXME: This test seems to depends on files that are not ;; available in the bundled v8. See ;; https://github.com/nodejs/node/issues/13344 @@ -88,12 +92,12 @@ "test/parallel/test-util-inspect.js" "test/parallel/test-v8-serdes.js" "test/parallel/test-dgram-membership.js" =2D "test/parallel/test-dgram-multicast-set-interfa= ce-lo.js" "test/parallel/test-dns-cancel-reverse-lookup.js" "test/parallel/test-dns-resolveany.js" "test/parallel/test-cluster-master-error.js" "test/parallel/test-cluster-master-kill.js" "test/parallel/test-npm-install.js" + "test/parallel/test-regress-GH-746.js" "test/sequential/test-child-process-emfile.js" "test/sequential/test-benchmark-child-process.js" "test/sequential/test-http-regr-gh-2928.js")) @@ -115,6 +119,14 @@ (string-append (assoc-ref inputs "python") "/bin/python") "configure" flags))))) + (add-before 'check 'skip-check-doc-only + (lambda _ + (substitute* "Makefile" + ;; requires js-yaml, which is not part of the distribution, + ;; and falls back to using npm to download it + (("\\$\\(MAKE\\) doc-only" all) + (string-append "#" all))) + #t)) (add-after 'patch-shebangs 'patch-npm-shebang (lambda* (#:key outputs #:allow-other-keys) (let* ((bindir (string-append (assoc-ref outputs "out") =2D-=20 2.15.0 --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCgAGBQJaGhzEAAoJEIyRe39dxRuicUAQAIWlpQm9UgIc0IFBC73ZzRYL FAk14GMPJZug4bUVIp4FktmthH3YKwkXMLbwugcBabRdnp3OrcQAy59GF/MBxZ1B zQ9A0y3Obn508qcr222L2dePu9nuIUqqYsEyoUl3qGQ24MgejwZ4+7EOj73ifRKR ZqS6p0en2Tb/jB8NowzcaCQi5QIwR1UM+Ej5QowsOcNLJKJarRkExM2HWimPIUeE OT7itm6c+UnE6Ua6KP70iGKiUPcrRzbHg83GRowx0PrYgSzm7r9zZ2oWh7zr6dyc 0RXVlSZq4VP63PVCq1Gx19coO5U0CkX1WW17xRoXuv9DbgqZI9zPg3Z2sXSfmJ5Q RhtwPK0qzA6R9v9EEbFrO273coAWmwGc1e7UTMCVThYr1ZZVKr8RNOjb/CdOt5QY Sr+BELutpiqDzEuHueaZ0aZ06kF/olC1hwuMKn3Xhnf48gIRXfuuKzGh/NweXbHq OrzjJzudd8eiLd98ogq+ej0zXc0N3ondRyS6aXctKxY06Fl69HLD5UFw6nmcTCXV 2WyajuC0acfQPT2tUrTdVMRnKvOg73IKaPfe5/sH0p7zXdVCqgimfYzD1UaPtm46 fQDGENIPEFuAujxUHz5gCAlV713LoYCqlx1J/DW6jgW/5/Hqud7eItV5jpSbCRGo zxv4lNqC9G4UZm7rMpJR =eOp6 -----END PGP SIGNATURE----- --==-=-=-- --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable =2D-=20 Mike Gerwitz Free Software Hacker+Activist | GNU Maintainer & Volunteer GPG: D6E9 B930 028A 6C38 F43B 2388 FEF6 3574 5E6F 6D05 https://mikegerwitz.com --=-=-=-- --===-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCgAGBQJaGhzKAAoJEIyRe39dxRui4/EQAKDgnQNrnTf9EQanHS4F+pxG yDFgd5XmZd/mb2mrIlsANLslbZc4FHB7zjlaedAO++bcKaxl93BPsz0+Mw0N9xYH nCm7pqmCgBuZIXfHGOco9dp0Z9dYD18/Ka+rhVvzr55gs0FtAK93F0AhsI1bCEcF nYOYh5sOTnFROwxPWnOLM+Tl724zOI6GcQbbbTaa+r6FCkdlS2l+D/20PggJefkk Gz8wC//yNBvkAmbdXsatPUgnZaHCxt2Vpn/DSrBwBCOxTnbYehduoUeidHio6H8K 9K/cSPC/jTbPmnfq89FvEumwG3cIw6iF6xx/VTH8q7zZCRCnE4k72x27OZMPsfpf PrdLx82u4AtTOiidFFbtUYHl+973WopOxgCytk8H7I9CoAZyX7XcdDRrQGZ3WXT0 lMn1fNQIHDeu7JUaqVa7QVT/SVm8UtoFYxxlJtGIOz5AHUWmArjapjIPYcHEJTHw gq9v3Gz0TtrruRoV3tpCyVVy1AU//drnGv9b26s260S/GzoGzx/ZLSivJvNUuVbu eC+RVACovaFBRUIH1Ypk9+fQLCJ1GmMOgB6GNxfoIsjkl0NHRqe472YWxADwjRpV YoUudkSdwTtnT4ZUcaB5t5QILLTMZaDhYlAIBqy9zk/4r8BKRENjwE4eAmGXE5Yk 6EA55YUNh134ilwKXuQQ =pd4l -----END PGP SIGNATURE----- --===-=-=-- From unknown Sat Jun 21 03:31:02 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#29449] [PATCH] gnu: node: Update to 8.9.1. Resent-From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 26 Nov 2017 17:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29449 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Mike Gerwitz Cc: 29449@debbugs.gnu.org Received: via spool by 29449-submit@debbugs.gnu.org id=B29449.151171811421190 (code B ref 29449); Sun, 26 Nov 2017 17:42:01 +0000 Received: (at 29449) by debbugs.gnu.org; 26 Nov 2017 17:41:54 +0000 Received: from localhost ([127.0.0.1]:59574 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJ0wE-0005Vi-Ac for submit@debbugs.gnu.org; Sun, 26 Nov 2017 12:41:54 -0500 Received: from hera.aquilenet.fr ([141.255.128.1]:46798) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJ0wB-0005VY-Uu for 29449@debbugs.gnu.org; Sun, 26 Nov 2017 12:41:52 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id DE036F91B; Sun, 26 Nov 2017 18:41:52 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vglAYbHqN5Xi; Sun, 26 Nov 2017 18:41:51 +0100 (CET) Received: from ribbon (unknown [IPv6:2a01:e0a:1d:7270:af76:b9b:ca24:c465]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 12A3DF29E; Sun, 26 Nov 2017 18:41:50 +0100 (CET) From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <877eudg6d7.fsf@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 6 Frimaire an 226 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sun, 26 Nov 2017 18:41:47 +0100 In-Reply-To: <877eudg6d7.fsf@gnu.org> (Mike Gerwitz's message of "Sat, 25 Nov 2017 20:45:40 -0500") Message-ID: <87zi79ueck.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) Hello Mike, Mike Gerwitz skribis: > Let me know if there is a better way to accomplish removing the > `doc-only' invocation as part of the `check' target. It invokes npm and > attempts to download `js-yaml', so I figured we may as well just skip it > altogether since it isn't otherwise used. What you did LGTM. > From 918303981e0dd3212f1e0c1f1f87fc8ca608cc5e Mon Sep 17 00:00:00 2001 > From: Mike Gerwitz > Date: Sat, 25 Nov 2017 20:34:12 -0500 > Subject: [PATCH] gnu: node: Update to 8.9.1. > > * gnu/packages/node.scm (node): Update to 8.9.1. > [arguments]: Skip 'doc-only' target in 'check', which attempts to use > npm to retrieve 'js-yaml' package. Remove test/doctool/test-make-doc.js. > Do not remove now-missing test case. Remove new test case that fails in > containers due to networking. The =E2=80=98check=E2=80=99 phase fails for me (on x86_64): --8<---------------cut here---------------start------------->8--- [----------] 10 tests from InspectorSocketServerTest (88 ms total) [----------] Global test environment tear-down [=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D] 62 tests from 7 test cases ran. (3863 ms t= otal) [ PASSED ] 62 tests. /gnu/store/zlbbayv8rv6z7gnhz435gjq8pzjm06v6-python-2.7.13/bin/python tools/= test.py --mode=3Drelease -J \ async-hooks \ default \ addons addons-napi \ doctool \ known_issues =3D=3D=3D release test-http2-server-rst-stream =3D=3D=3D Path: parallel/test-http2-server-rst-stream (node:12213) ExperimentalWarning: The http2 module is an experimental API. assert.js:42 throw new errors.AssertionError({ ^ AssertionError [ERR_ASSERTION]: rstWithCancel is not match rstCode at ClientHttp2Stream.req.on.common.mustCall (/tmp/guix-build-node-8.9.1= .drv-0/node-v8.9.1/test/parallel/test-http2-server-rst-stream.js:55:14) at ClientHttp2Stream. (/tmp/guix-build-node-8.9.1.drv-0/node= -v8.9.1/test/common/index.js:533:15) at emitOne (events.js:121:20) at ClientHttp2Stream.emit (events.js:211:7) at emit (internal/http2/core.js:140:8) at _combinedTickCallback (internal/process/next_tick.js:141:11) at process._tickCallback (internal/process/next_tick.js:180:9) Command: out/Release/node /tmp/guix-build-node-8.9.1.drv-0/node-v8.9.1/test= /parallel/test-http2-server-rst-stream.js [10:05|% 100|+ 2010|- 1]: Done=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20 make: *** [Makefile:218: test] Error 1 phase `check' failed after 667.7 seconds --8<---------------cut here---------------end--------------->8--- Any ideas? Could it be a non-deterministic issue? Thanks, Ludo=E2=80=99. From unknown Sat Jun 21 03:31:02 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#29449] [PATCH] gnu: node: Update to 8.9.1. Resent-From: Mike Gerwitz Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 26 Nov 2017 19:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29449 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Cc: 29449@debbugs.gnu.org Received: via spool by 29449-submit@debbugs.gnu.org id=B29449.151172349311569 (code B ref 29449); Sun, 26 Nov 2017 19:12:02 +0000 Received: (at 29449) by debbugs.gnu.org; 26 Nov 2017 19:11:33 +0000 Received: from localhost ([127.0.0.1]:59611 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJ2Kz-00030W-D4 for submit@debbugs.gnu.org; Sun, 26 Nov 2017 14:11:33 -0500 Received: from eggs.gnu.org ([208.118.235.92]:58126) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJ2Ky-00030H-1s for 29449@debbugs.gnu.org; Sun, 26 Nov 2017 14:11:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eJ2Kr-0003vT-Vm for 29449@debbugs.gnu.org; Sun, 26 Nov 2017 14:11:26 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:47672) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eJ2Kp-0003tn-Gr; Sun, 26 Nov 2017 14:11:23 -0500 Received: from localhost ([::1]:39077 helo=mikegerwitz-pc.gerwitz.local) by fencepost.gnu.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1eJ2Kp-0002b0-4k; Sun, 26 Nov 2017 14:11:23 -0500 From: Mike Gerwitz In-Reply-To: <87zi79ueck.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Sun, 26 Nov 2017 18:41:47 +0100") Date: Sun, 26 Nov 2017 14:10:53 -0500 Message-ID: <87po84dfeq.fsf@gnu.org> References: <877eudg6d7.fsf@gnu.org> <87zi79ueck.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) OpenPGP: id=22175B02E626BC98D7C0C2E5F22BB8158EE30EAB MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Sun, Nov 26, 2017 at 18:41:47 +0100, Ludovic Court=C3=A8s wrote: > The =E2=80=98check=E2=80=99 phase fails for me (on x86_64): [...] > Any ideas? Could it be a non-deterministic issue? I'm inclined to think so...I just re-ran that test in one of the build environments I still had in /tmp and it failed with the same error...! I feel like this is a question that might have an easy answer, but: how do I force Guix to re-build the package? I've tried `./pre-inst-env guix build --check' and `--rounds=3D2' and such but it keeps returning the current derivation without doing any actual work. =2D-=20 Mike Gerwitz Free Software Hacker+Activist | GNU Maintainer & Volunteer GPG: D6E9 B930 028A 6C38 F43B 2388 FEF6 3574 5E6F 6D05 https://mikegerwitz.com --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCgAGBQJaGxG9AAoJEIyRe39dxRuiOcsQAJMiP92SPqWopeRC6zuKm4H7 h2nCFGhsckV/u46Z++TDPkJPv8DtkQZIWEeHlQALhygmIO5vrckVPiC4k+BeJyD9 elgDf8isPB4sFipbWctGKC0OB2gsO4wuiIy7td0tBNzviA3fz2cYOHkQtg/btlUQ YMUMmBGIPkb9XPOtsDybPrKKgyqf6TfwvLmGilsC9CUBmmEmoZNDNNIuiicKH/p6 A+Afj6QJD4glvJNPqv5ITdudihWnQz8BW+5aDrhznWOm5yS9MBtrpK2wASSZrLMM 9YpaEZO5iECd5ffkGFsGTOOOVb/bh/noy7WnSwPGqzB3OTuZs+x2z0cEd9m8GMq8 FHFOXzrE+EYRKWLaTHSB+r9ZIE1X0vLZ7VL2t/7ndimxJivTa047gehe6HMNIs5d e2IAn+YXyDRLeTK4cOa/1jXfqjHJZuclNON3cV1sibJ7v64OL0tKIbDIOgxHHPle Qk0NfxHYwyMyhNsOv2ELf158QjU7WA2SWrhuRleLnP4GZKNSef8kwVdX17892Fis OoOhZcR7pWrgAIQDgLRG4ae4we92dPTNhXWPnzZpXx2KTkA8EXE3zI4OkoJtNG/1 q1TDd90AzjjsBMDCx5wYs2ihIbvZxeuPVBZU9abU+G+/g3+FzBVFYrhKNSVk3qPw bCCg5HAnuMqJfbMpSgCM =RyNo -----END PGP SIGNATURE----- --=-=-=-- From unknown Sat Jun 21 03:31:02 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#29449] [PATCH] gnu: node: Update to 8.9.1. Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 26 Nov 2017 19:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29449 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Mike Gerwitz Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , 29449@debbugs.gnu.org Received: via spool by 29449-submit@debbugs.gnu.org id=B29449.151172424912734 (code B ref 29449); Sun, 26 Nov 2017 19:25:02 +0000 Received: (at 29449) by debbugs.gnu.org; 26 Nov 2017 19:24:09 +0000 Received: from localhost ([127.0.0.1]:59618 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJ2XB-0003JK-Ha for submit@debbugs.gnu.org; Sun, 26 Nov 2017 14:24:09 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:40051) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJ2XA-0003JD-Ff for 29449@debbugs.gnu.org; Sun, 26 Nov 2017 14:24:08 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 2924620BBE; Sun, 26 Nov 2017 14:24:08 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute4.internal (MEProxy); Sun, 26 Nov 2017 14:24:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= mesmtp; bh=ZBDpGIc98dQjJ+gw73lJiRP5v7v1yQrCTMD7eRzU5HQ=; b=FVFhr COJAa/2pLB+KKTzQrkicpArO80RDB/mZLq44yz4qlx1cAI+vZEX+qyMNWM12UBJr M6jIkONPGWy5pPV/whvMIpNK+NGKKxwrhzEakIAD38t+9ByYEW90bxkEYPpgR9Bu sKRwPalBgZcaa6oTrjLR9tswVRuW1rUcjGSCF8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; bh=ZBDpGIc98dQjJ+gw73lJiRP5v7v1y QrCTMD7eRzU5HQ=; b=NkzdeQtUO7nvbj9fHCXwVW+WeuUeYRgse+/m/zZ1Dhpsc 64dA23q6Eyxglgnup0zNFABFIDsN0GjW75+bfViO6HclNoLhWjcXZl3P0+yPO+M3 ZJ0GNlgc6hz67jNdJfvDNEbBVLuxR8P9ZeekiSx2T5ihqOHrgGufOpaRUhu3RHTy FzD63mSnEXCnMcwEugdnsoW2t6l7SxxPcZgVpPW6DHR+PsXLRhJVGYVd7FlWgAAq d2h9W4bbZuT0XvcZNqRTRbvznFMlhNRArvq9hkZOblHR7Ak94702EbHiaLesvd7/ uW8RpUTkmabs6HgJ/gD6Bm1LjLTantq8Vg1cuczNw== X-ME-Sender: Received: from localhost (c-73-165-108-70.hsd1.pa.comcast.net [73.165.108.70]) by mail.messagingengine.com (Postfix) with ESMTPA id DB0A7240B2; Sun, 26 Nov 2017 14:24:07 -0500 (EST) Date: Sun, 26 Nov 2017 14:24:05 -0500 From: Leo Famulari Message-ID: <20171126192405.GA1313@jasmine.lan> References: <877eudg6d7.fsf@gnu.org> <87zi79ueck.fsf@gnu.org> <87po84dfeq.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ReaqsoxgOBHFXBhH" Content-Disposition: inline In-Reply-To: <87po84dfeq.fsf@gnu.org> User-Agent: Mutt/1.9.1 (2017-09-22) X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --ReaqsoxgOBHFXBhH Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Nov 26, 2017 at 02:10:53PM -0500, Mike Gerwitz wrote: > On Sun, Nov 26, 2017 at 18:41:47 +0100, Ludovic Court=C3=A8s wrote: > > The =E2=80=98check=E2=80=99 phase fails for me (on x86_64): > [...] > > Any ideas? Could it be a non-deterministic issue? >=20 > I'm inclined to think so...I just re-ran that test in one of the build > environments I still had in /tmp and it failed with the same error...! >=20 > I feel like this is a question that might have an easy answer, but: how > do I force Guix to re-build the package? I've tried `./pre-inst-env > guix build --check' and `--rounds=3D2' and such but it keeps returning the > current derivation without doing any actual work. --check and --rounds are a bit confusing when the package in question is grafted. Basically, grafting is treated as its own derivation, so doing `./pre-inst-env guix build --check node` just re-does the grafting derivation, instead of rebuilding node. Currently every package is grafted because we used a graft to fix a bug in glibc. So, try `./pre-inst-env guix build --no-grafts --check node`. --ReaqsoxgOBHFXBhH Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlobFNUACgkQJkb6MLrK fwiepA//eZFfrS/3F89k0yaAgqjV3dsU1G/2ITOApzHKJZ9daifA/GrBgkcgo5PW UMo7rd4fWs/e4njsTZn2NyPDhNC1OH2dQynogz1i7sni4mHJY2kyWuqhjAoIbSyq 4C70632PpQbBe5pA+FmBNjursyKGZ3iAEMazpf8iycNSaH1pmUJIWPGz7rXMiFvx iSOBB+cozRzeHO61adYQ256dU6dAvXqG18YH8S6wQBNSw380DDiay/IdF9ejL9Dx 4EftMMOze5JxCR8xasG+2FAGonhUBERHxkD+FOE6080avsk9DBOCzy0PDqUyU0/V akAJPlSCl5hTLaWaBZ8AZK4fRAtKCayrnHHWW7ssuvmS62gCcrdyta2Rw8zMStn8 BqqGG2pBlffWKY1SriNGebZaModKtL+vFHRzzNH23TXFdNep0g1tJ4uuGXwvdzgL zPFrpuYjeUDnHMMEiy2LtDNfX+I+GRXsnCyJJy97nSkw5DS8VmOXEWQ6LtmbAfM8 u5bEgiA8SmZ+ESm1EObVwZjIJ6656KdLHgmbVV0DybS6VDm/CDcT5jz/hsH8RKRp L0Xj7swqLq6pHgDRUiGcx2cj7Sl9iPnHN6GviCvkKirExgPiIE9Zbwm/xW0HPPtX Mg24oPiE/KmpOWIM3Yeh7V5IKoXlOlMuYXKD0h85yzc6p3V7C/4= =2uWA -----END PGP SIGNATURE----- --ReaqsoxgOBHFXBhH-- From unknown Sat Jun 21 03:31:02 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#29449] [PATCH] gnu: node: Update to 8.9.1. Resent-From: Jelle Licht Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 26 Nov 2017 21:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29449 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: Mike Gerwitz , 29449@debbugs.gnu.org Received: via spool by 29449-submit@debbugs.gnu.org id=B29449.151173334327073 (code B ref 29449); Sun, 26 Nov 2017 21:56:01 +0000 Received: (at 29449) by debbugs.gnu.org; 26 Nov 2017 21:55:43 +0000 Received: from localhost ([127.0.0.1]:59698 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJ4tn-00072S-66 for submit@debbugs.gnu.org; Sun, 26 Nov 2017 16:55:43 -0500 Received: from mail.fsfe.org ([217.69.89.162]:36048) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJ4ti-00072A-Ae for 29449@debbugs.gnu.org; Sun, 26 Nov 2017 16:55:38 -0500 Received: from localhost (localhost [127.0.0.1]) by mail.fsfe.org (Postfix) with ESMTP id 0003E63BB5F; Sun, 26 Nov 2017 22:55:27 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mail.fsfe.org Received: from mail.fsfe.org ([127.0.0.1]) by localhost (cavendish.fsfeurope.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9SZ1sBHk4MeX; Sun, 26 Nov 2017 22:55:27 +0100 (CET) References: <877eudg6d7.fsf@gnu.org> <87zi79ueck.fsf@gnu.org> From: Jelle Licht In-reply-to: <87zi79ueck.fsf@gnu.org> Date: Sun, 26 Nov 2017 22:55:26 +0100 Message-ID: <87d144vh69.fsf@fsfe.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Ludovic Courtès writes: > Hello Mike, > > Mike Gerwitz skribis: > >> Let me know if there is a better way to accomplish removing the >> `doc-only' invocation as part of the `check' target. It invokes npm and >> attempts to download `js-yaml', so I figured we may as well just skip it >> altogether since it isn't otherwise used. > > What you did LGTM. > >> From 918303981e0dd3212f1e0c1f1f87fc8ca608cc5e Mon Sep 17 00:00:00 2001 >> From: Mike Gerwitz >> Date: Sat, 25 Nov 2017 20:34:12 -0500 >> Subject: [PATCH] gnu: node: Update to 8.9.1. >> >> * gnu/packages/node.scm (node): Update to 8.9.1. >> [arguments]: Skip 'doc-only' target in 'check', which attempts to use >> npm to retrieve 'js-yaml' package. Remove test/doctool/test-make-doc.js. >> Do not remove now-missing test case. Remove new test case that fails in >> containers due to networking. > > The ‘check’ phase fails for me (on x86_64): > > --8<---------------cut here---------------start------------->8--- > [----------] 10 tests from InspectorSocketServerTest (88 ms total) > > [----------] Global test environment tear-down > [==========] 62 tests from 7 test cases ran. (3863 ms total) > [ PASSED ] 62 tests. > /gnu/store/zlbbayv8rv6z7gnhz435gjq8pzjm06v6-python-2.7.13/bin/python tools/test.py --mode=release -J \ > async-hooks \ > default \ > addons addons-napi \ > doctool \ > known_issues > === release test-http2-server-rst-stream === > Path: parallel/test-http2-server-rst-stream > (node:12213) ExperimentalWarning: The http2 module is an experimental API. > assert.js:42 > throw new errors.AssertionError({ > ^ > > AssertionError [ERR_ASSERTION]: rstWithCancel is not match rstCode > at ClientHttp2Stream.req.on.common.mustCall (/tmp/guix-build-node-8.9.1.drv-0/node-v8.9.1/test/parallel/test-http2-server-rst-stream.js:55:14) > at ClientHttp2Stream. (/tmp/guix-build-node-8.9.1.drv-0/node-v8.9.1/test/common/index.js:533:15) > at emitOne (events.js:121:20) > at ClientHttp2Stream.emit (events.js:211:7) > at emit (internal/http2/core.js:140:8) > at _combinedTickCallback (internal/process/next_tick.js:141:11) > at process._tickCallback (internal/process/next_tick.js:180:9) > Command: out/Release/node /tmp/guix-build-node-8.9.1.drv-0/node-v8.9.1/test/parallel/test-http2-server-rst-stream.js > [10:05|% 100|+ 2010|- 1]: Done > make: *** [Makefile:218: test] Error 1 > phase `check' failed after 667.7 seconds > --8<---------------cut here---------------end--------------->8--- > > > Any ideas? Could it be a non-deterministic issue? > > Thanks, > Ludo’. I get a similar issue to Ludo: --8<---------------cut here---------------start------------->8--- Path: parallel/test-http2-server-rst-stream (node:13036) ExperimentalWarning: The http2 module is an experimental API. assert.js:42 throw new errors.AssertionError({ ^ AssertionError [ERR_ASSERTION]: rstWithProtocolError is not match rstCode at ClientHttp2Stream.req.on.common.mustCall (/tmp/guix-build-node-8.9.1.drv-0/node-v8.9.1/test/parallel/test-http2-server-rst-stream.js:55:14) at ClientHttp2Stream. (/tmp/guix-build-node-8.9.1.drv-0/node-v8.9.1/test/common/index.js:533:15) at emitOne (events.js:121:20) at ClientHttp2Stream.emit (events.js:211:7) at emit (internal/http2/core.js:140:8) at _combinedTickCallback (internal/process/next_tick.js:141:11) at process._tickCallback (internal/process/next_tick.js:180:9) Command: out/Release/node /tmp/guix-build-node-8.9.1.drv-0/node-v8.9.1/test/parallel/test-http2-server-rst-stream.js --8<---------------cut here---------------end--------------->8--- I also found a GitHub issue[0], stating that several other people have similar problems with this specific test. It also seems that commit a41cc020fd in the node git repo addresses this flaky test. We could either backport the fix until it is included in a node release proper, or disable the test for now. - Jelle [0]: https://github.com/nodejs/node/issues/16688 From unknown Sat Jun 21 03:31:02 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#29449] [PATCH] gnu: node: Update to 8.9.1. Resent-From: Mike Gerwitz Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 27 Nov 2017 05:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29449 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Leo Famulari Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , 29449@debbugs.gnu.org Received: via spool by 29449-submit@debbugs.gnu.org id=B29449.151175928917035 (code B ref 29449); Mon, 27 Nov 2017 05:09:01 +0000 Received: (at 29449) by debbugs.gnu.org; 27 Nov 2017 05:08:09 +0000 Received: from localhost ([127.0.0.1]:59921 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJBeK-0004Qg-PK for submit@debbugs.gnu.org; Mon, 27 Nov 2017 00:08:08 -0500 Received: from eggs.gnu.org ([208.118.235.92]:33171) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJBeI-0004QE-HR for 29449@debbugs.gnu.org; Mon, 27 Nov 2017 00:08:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eJBeC-0002ih-7U for 29449@debbugs.gnu.org; Mon, 27 Nov 2017 00:08:01 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:60469) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eJBe9-0002gs-Bt; Mon, 27 Nov 2017 00:07:57 -0500 Received: from localhost ([::1]:51873 helo=mikegerwitz-pc.gerwitz.local) by fencepost.gnu.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1eJBe8-0003vl-N5; Mon, 27 Nov 2017 00:07:56 -0500 From: Mike Gerwitz In-Reply-To: <20171126192405.GA1313@jasmine.lan> (Leo Famulari's message of "Sun, 26 Nov 2017 14:24:05 -0500") Date: Sun, 26 Nov 2017 23:54:26 -0500 Message-ID: <87wp2cb9tp.fsf@gnu.org> References: <877eudg6d7.fsf@gnu.org> <87zi79ueck.fsf@gnu.org> <87po84dfeq.fsf@gnu.org> <20171126192405.GA1313@jasmine.lan> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) OpenPGP: id=22175B02E626BC98D7C0C2E5F22BB8158EE30EAB MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Sun, Nov 26, 2017 at 14:24:05 -0500, Leo Famulari wrote: > --check and --rounds are a bit confusing when the package in question is > grafted. > > Basically, grafting is treated as its own derivation, so doing > `./pre-inst-env guix build --check node` just re-does the grafting > derivation, instead of rebuilding node. > > Currently every package is grafted because we used a graft to fix a bug > in glibc. > > So, try `./pre-inst-env guix build --no-grafts --check node`. Ah, that makes sense, thank you for the clarification. I did start =2D-no-grafts, but that applied to dependencies as well it seemed, so I stopped it. I'll let that run tonight (node takes a while to build on the X200) and report back / provide an updated patch tomorrow. =2D-=20 Mike Gerwitz Free Software Hacker+Activist | GNU Maintainer & Volunteer GPG: D6E9 B930 028A 6C38 F43B 2388 FEF6 3574 5E6F 6D05 https://mikegerwitz.com --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCgAGBQJaG5qCAAoJEIyRe39dxRuipFcP/j37NinqLqijOhL/Gk6UZ2ma 1tPUF1d+aA/NnDqh6eetPuNKjnDQHJbiqUlwEOqex4zN3paoZEVYBUFyQuABsY6w pXcCr49HvGhoJnp7OF0lgbGDM5iUIXwvK3pm3ZWLjzYrilv6gbVHGzdzl7IVPgAv gCYykCHF1mMs6StT/DNDgPMDcPZ8EEvYgFn/9muO2tuke+oodSfHhM/ukGShZzFD iX8YPhzRyymdG7OE+yeuL1xIGEiPm+09QxVKlP5sOQz+OLUBTsSkwIv4sXecy92V Fzq4SaXsoyiINcnA4mlOeHYxHcQ1S8h1908hK8Wa3bdHbS073s4DhgKBdsreZEWs UplB6p8xkG+FoKReGc4yzeMQgkacN+m+XnECQ/6e3fZIeD4FCOuueZKe7BzcugUJ 7GPVWqFIVQMckezvU9QzruLoz8ldNKHsQl927qPrHZTxrkNKgJdyM8506lVMxCGO B/YCe7RXwLgt8Qxljyqk8SJCfE1Lgf2UALuU03IcJzQYP1QLwjIz2DnLZ7KB3oNX sz5MECTi/oWAzjoR/s/j+ppjOh8T54k6RHGLTERipLWGp1lH1RqueLxgDGBIdbhy 9NVYPm3+jw0CfrrC4fefZ/0pyueNgB6/7kCv7pmNdfcimz4hAcl0v5OVZ3EOGXf8 31uCnqhxoB0D5GYZtmjJ =dSKI -----END PGP SIGNATURE----- --=-=-=-- From unknown Sat Jun 21 03:31:02 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#29449] [PATCH] gnu: node: Update to 8.9.1. Resent-From: Mike Gerwitz Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 27 Nov 2017 05:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29449 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Jelle Licht Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , 29449@debbugs.gnu.org Received: via spool by 29449-submit@debbugs.gnu.org id=B29449.151175928917042 (code B ref 29449); Mon, 27 Nov 2017 05:09:02 +0000 Received: (at 29449) by debbugs.gnu.org; 27 Nov 2017 05:08:09 +0000 Received: from localhost ([127.0.0.1]:59923 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJBeL-0004Qi-0o for submit@debbugs.gnu.org; Mon, 27 Nov 2017 00:08:09 -0500 Received: from eggs.gnu.org ([208.118.235.92]:33170) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJBeI-0004QD-HR for 29449@debbugs.gnu.org; Mon, 27 Nov 2017 00:08:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eJBeC-0002jA-Ik for 29449@debbugs.gnu.org; Mon, 27 Nov 2017 00:08:01 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:60471) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eJBeA-0002hT-2p; Mon, 27 Nov 2017 00:07:58 -0500 Received: from localhost ([::1]:51874 helo=mikegerwitz-pc.gerwitz.local) by fencepost.gnu.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1eJBe9-0003ww-NZ; Mon, 27 Nov 2017 00:07:57 -0500 From: Mike Gerwitz In-Reply-To: <87d144vh69.fsf@fsfe.org> (Jelle Licht's message of "Sun, 26 Nov 2017 22:55:26 +0100") Date: Sun, 26 Nov 2017 23:57:06 -0500 Message-ID: <87r2skb9p9.fsf@gnu.org> References: <877eudg6d7.fsf@gnu.org> <87zi79ueck.fsf@gnu.org> <87d144vh69.fsf@fsfe.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) OpenPGP: id=22175B02E626BC98D7C0C2E5F22BB8158EE30EAB MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Sun, Nov 26, 2017 at 22:55:26 +0100, Jelle Licht wrote: > I also found a GitHub issue[0], stating that several other people have > similar problems with this specific test. It also seems that commit > a41cc020fd in the node git repo addresses this flaky test. We could > either backport the fix until it is included in a node release proper, > or disable the test for now. > > - Jelle > > [0]: https://github.com/nodejs/node/issues/16688 Thanks for doing the research. I'll do whatever everyone thinks is best. =2D-=20 Mike Gerwitz Free Software Hacker+Activist | GNU Maintainer & Volunteer GPG: D6E9 B930 028A 6C38 F43B 2388 FEF6 3574 5E6F 6D05 https://mikegerwitz.com --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCgAGBQJaG5siAAoJEIyRe39dxRuigooQALLxcl43bpKI2XUgjnmZEJXr vpkuA/FdyAWeMDVAf0o9WQq7bQ8C2wUK174rlkRwFMd4HTq5cr40g8SG/MH7jjbC XxnFNAj2p385BpbIsGiitB148knJw4roqYDFc4GaoH+FC7Hidf4N+l8vzi+eDrDs XyN6cbHgEv/APUarKqEzWPqX59JfQNpC15t3mXKN46mxYINRVLkVSUL/zwSD7OC2 nOZz/0EeLS7lVkFxUeoXy5aLsMhuAlPxJwqi/+zzi2BFfnIAKsB3luoveyneFfSt aw69t7RVyBUVVmZ8+loXG50RYX9HBlryzNwg2SGSwOnvPauxiFYp5qD22duhdskq LV+Rzbccm4QmLyVNJy2YgikkwshChmT+wR/OtBKEgFJFN3aYXBjMlC/kcdxawozN g5FN0gU3oDbZfr9ntfWRIwNA2kQCE7uf/8fnrabPvYGMnaZBIsWw9mjOwMFU1L5M PwkokkhJ/5YviDfBfgpZeBSdieNGJoC8PVK7hjIN04r2ppwp04FylLwH+DXzLtH3 rsRnjmk9QTGSfBhVFW/umdrqGxTp4ScE/1gAvm8D6NKOKFlKbCt4LAHJLFa7Dj25 WJ0iuIhPmUFUMWxKVTUZ25W0Yv5FxMVinZ5o+65DTgIuXeKMQz9Pyw89xoiyytlZ W20347G57L6oVOmbF2tI =BgYk -----END PGP SIGNATURE----- --=-=-=-- From unknown Sat Jun 21 03:31:02 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#29449] [PATCH] gnu: node: Update to 8.9.1. Resent-From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 27 Nov 2017 08:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29449 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Mike Gerwitz Cc: Jelle Licht , 29449@debbugs.gnu.org Received: via spool by 29449-submit@debbugs.gnu.org id=B29449.15117722804978 (code B ref 29449); Mon, 27 Nov 2017 08:45:01 +0000 Received: (at 29449) by debbugs.gnu.org; 27 Nov 2017 08:44:40 +0000 Received: from localhost ([127.0.0.1]:60016 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJF1s-0001IE-A5 for submit@debbugs.gnu.org; Mon, 27 Nov 2017 03:44:40 -0500 Received: from [141.255.128.1] (port=49571 helo=hera.aquilenet.fr) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJF1q-0001I6-Uh for 29449@debbugs.gnu.org; Mon, 27 Nov 2017 03:44:39 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 58663C673; Mon, 27 Nov 2017 09:44:39 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8KO8ajRxXmq8; Mon, 27 Nov 2017 09:44:38 +0100 (CET) Received: from ribbon (unknown [193.50.110.215]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 81BDBB269; Mon, 27 Nov 2017 09:44:32 +0100 (CET) From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <877eudg6d7.fsf@gnu.org> <87zi79ueck.fsf@gnu.org> <87d144vh69.fsf@fsfe.org> <87r2skb9p9.fsf@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 7 Frimaire an 226 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 27 Nov 2017 09:44:29 +0100 In-Reply-To: <87r2skb9p9.fsf@gnu.org> (Mike Gerwitz's message of "Sun, 26 Nov 2017 23:57:06 -0500") Message-ID: <87wp2cnmaa.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 2.2 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Mike Gerwitz skribis: > On Sun, Nov 26, 2017 at 22:55:26 +0100, Jelle Licht wrote: >> I also found a GitHub issue[0], stating that several other people have >> similar problems with this specific test. It also seems that commit >> a41cc020fd in the node git repo addresses this flaky test. We could >> either backport the fix until it is included in a node release proper, >> or disable the test for now. >> >> - Jelle >> >> [0]: https://github.com/nodejs/node/issues/16688 > > Thanks for doing the research. I'll do whatever everyone thinks is > best. [...] Content analysis details: (2.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_FAIL SPF: HELO does not match SPF record (fail) [SPF failed: Please see http://www.openspf.org/Why?s=helo; id=hera.aquilenet.fr; ip=141.255.128.1; r=debbugs.gnu.org] 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.2 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Mike Gerwitz skribis: > On Sun, Nov 26, 2017 at 22:55:26 +0100, Jelle Licht wrote: >> I also found a GitHub issue[0], stating that several other people have >> similar problems with this specific test. It also seems that commit >> a41cc020fd in the node git repo addresses this flaky test. We could >> either backport the fix until it is included in a node release proper, >> or disable the test for now. >> >> - Jelle >> >> [0]: https://github.com/nodejs/node/issues/16688 > > Thanks for doing the research. I'll do whatever everyone thinks is > best. [...] Content analysis details: (2.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_FAIL SPF: HELO does not match SPF record (fail) [SPF failed: Please see http://www.openspf.org/Why?s=helo;id=hera.aquilenet.fr;ip=141.255.128.1;r=debbugs.gnu.org] 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS Mike Gerwitz skribis: > On Sun, Nov 26, 2017 at 22:55:26 +0100, Jelle Licht wrote: >> I also found a GitHub issue[0], stating that several other people have >> similar problems with this specific test. It also seems that commit >> a41cc020fd in the node git repo addresses this flaky test. We could >> either backport the fix until it is included in a node release proper, >> or disable the test for now. >> >> - Jelle >> >> [0]: https://github.com/nodejs/node/issues/16688 > > Thanks for doing the research. I'll do whatever everyone thinks is > best. Unless the fix of that test is big, I=E2=80=99d be in favor of including the patch for that test in our repo. Ludo=E2=80=99. From unknown Sat Jun 21 03:31:02 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#29449] [PATCH] gnu: node: Update to 8.9.1. Resent-From: Mike Gerwitz Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 28 Nov 2017 02:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29449 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Cc: Jelle Licht , 29449@debbugs.gnu.org Received: via spool by 29449-submit@debbugs.gnu.org id=B29449.15118362297760 (code B ref 29449); Tue, 28 Nov 2017 02:31:01 +0000 Received: (at 29449) by debbugs.gnu.org; 28 Nov 2017 02:30:29 +0000 Received: from localhost ([127.0.0.1]:33276 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJVfE-000211-Vj for submit@debbugs.gnu.org; Mon, 27 Nov 2017 21:30:29 -0500 Received: from eggs.gnu.org ([208.118.235.92]:47568) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJVfD-00020n-0b for 29449@debbugs.gnu.org; Mon, 27 Nov 2017 21:30:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eJVf5-00018e-VM for 29449@debbugs.gnu.org; Mon, 27 Nov 2017 21:30:17 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:36688) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eJVf2-00016S-7P; Mon, 27 Nov 2017 21:30:12 -0500 Received: from localhost ([::1]:56324 helo=mikegerwitz-pc.gerwitz.local) by fencepost.gnu.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1eJVf1-0000Ux-RJ; Mon, 27 Nov 2017 21:30:12 -0500 From: Mike Gerwitz In-Reply-To: <87wp2cnmaa.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Mon, 27 Nov 2017 09:44:29 +0100") Date: Mon, 27 Nov 2017 21:29:04 -0500 Message-ID: <87k1yb9lvz.fsf@gnu.org> References: <877eudg6d7.fsf@gnu.org> <87zi79ueck.fsf@gnu.org> <87d144vh69.fsf@fsfe.org> <87r2skb9p9.fsf@gnu.org> <87wp2cnmaa.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) OpenPGP: id=22175B02E626BC98D7C0C2E5F22BB8158EE30EAB MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Mon, Nov 27, 2017 at 09:44:29 +0100, Ludovic Court=C3=A8s wrote: > Mike Gerwitz skribis: >> Thanks for doing the research. I'll do whatever everyone thinks is >> best. > > Unless the fix of that test is big, I=E2=80=99d be in favor of including = the > patch for that test in our repo. I was able to reproduce the failure when rebuilding. Updated patch attached. --=-=-= Content-Type: text/x-diff; charset=utf-8 Content-Disposition: inline; filename=0001-gnu-node-Update-to-8.9.1.patch Content-Transfer-Encoding: quoted-printable From=20a07f3f92a0768661dbcb2a4b87fe08dd04149190 Mon Sep 17 00:00:00 2001 From: Mike Gerwitz Date: Sat, 25 Nov 2017 20:34:12 -0500 Subject: [PATCH] gnu: node: Update to 8.9.1. * gnu/packages/node.scm (node): Update to 8.9.1. [source]: Apply 'node-test-http2-server-rst-stream.patch'. [arguments]: Skip 'doc-only' target in 'check', which attempts to use npm to retrieve 'js-yaml' package. Remove test/doctool/test-make-doc.js. Do not remove now-missing test case. Remove new test case that fails in containers due to networking. * gnu/packages/patches/node-test-http2-server-rst-stream.patch: New file. =2D-- gnu/packages/node.scm | 23 +++- .../node-test-http2-server-rst-stream.patch | 131 +++++++++++++++++= ++++ 2 files changed, 151 insertions(+), 3 deletions(-) create mode 100644 gnu/packages/patches/node-test-http2-server-rst-stream.= patch diff --git a/gnu/packages/node.scm b/gnu/packages/node.scm index e354130ad..fade8b23d 100644 =2D-- a/gnu/packages/node.scm +++ b/gnu/packages/node.scm @@ -3,6 +3,7 @@ ;;; Copyright =C2=A9 2015 Andreas Enge ;;; Copyright =C2=A9 2015, 2016 David Thompson ;;; Copyright =C2=A9 2016 Ludovic Court=C3=A8s +;;; Copyright =C2=A9 2017 Mike Gerwitz ;;; ;;; This file is part of GNU Guix. ;;; @@ -40,14 +41,18 @@ (define-public node (package (name "node") =2D (version "8.7.0") + (version "8.9.1") (source (origin (method url-fetch) (uri (string-append "http://nodejs.org/dist/v" version "/node-v" version ".tar.gz")) (sha256 (base32 =2D "1a0ginagx3pav6v7adyp76jisia4qgbsq6pz3als4kshwlk4a667"))= )) + "1qbiz7hgwlirhwpd71c8yzcbwsyi5bjlfp6lxb6v55j6rizinj9j")) + ;; See https://github.com/nodejs/node/issues/16688 + ;; Remove this next update (>8.9.1). + (patches + (search-patches "node-test-http2-server-rst-stream.patch")= ))) (build-system gnu-build-system) (arguments ;; TODO: Purge the bundled copies from the source. @@ -76,6 +81,10 @@ (("'/usr/bin/env'") (string-append "'" (which "env") "'"))) =20 + + ;; test-make-doc needs doc-only target, which is inhibited be= low + (for-each delete-file + '("test/doctool/test-make-doc.js")) ;; FIXME: This test seems to depends on files that are not ;; available in the bundled v8. See ;; https://github.com/nodejs/node/issues/13344 @@ -88,12 +97,12 @@ "test/parallel/test-util-inspect.js" "test/parallel/test-v8-serdes.js" "test/parallel/test-dgram-membership.js" =2D "test/parallel/test-dgram-multicast-set-interfa= ce-lo.js" "test/parallel/test-dns-cancel-reverse-lookup.js" "test/parallel/test-dns-resolveany.js" "test/parallel/test-cluster-master-error.js" "test/parallel/test-cluster-master-kill.js" "test/parallel/test-npm-install.js" + "test/parallel/test-regress-GH-746.js" "test/sequential/test-child-process-emfile.js" "test/sequential/test-benchmark-child-process.js" "test/sequential/test-http-regr-gh-2928.js")) @@ -115,6 +124,14 @@ (string-append (assoc-ref inputs "python") "/bin/python") "configure" flags))))) + (add-before 'check 'skip-check-doc-only + (lambda _ + (substitute* "Makefile" + ;; requires js-yaml, which is not part of the distribution, + ;; and falls back to using npm to download it + (("\\$\\(MAKE\\) doc-only" all) + (string-append "#" all))) + #t)) (add-after 'patch-shebangs 'patch-npm-shebang (lambda* (#:key outputs #:allow-other-keys) (let* ((bindir (string-append (assoc-ref outputs "out") diff --git a/gnu/packages/patches/node-test-http2-server-rst-stream.patch b= /gnu/packages/patches/node-test-http2-server-rst-stream.patch new file mode 100644 index 000000000..c2f85010b =2D-- /dev/null +++ b/gnu/packages/patches/node-test-http2-server-rst-stream.patch @@ -0,0 +1,131 @@ +From a41cc020fd6e40b358103425edfa50e6a10fc973 Mon Sep 17 00:00:00 2001 +From: Anatoli Papirovski +Date: Thu, 2 Nov 2017 12:46:31 -0400 +Subject: [PATCH] test: fix flaky test-http2-server-rst-stream.js + +PR-URL: https://github.com/nodejs/node/pull/16690 +Fixes: https://github.com/nodejs/node/issues/16688 +Reviewed-By: James M Snell +Reviewed-By: Matteo Collina +--- + test/parallel/test-http2-server-rst-stream.js | 93 ++++++++++------------= ----- + 1 file changed, 35 insertions(+), 58 deletions(-) + +diff --git a/test/parallel/test-http2-server-rst-stream.js b/test/parallel= /test-http2-server-rst-stream.js +index b92217dc99..dd38efb42f 100644 +--- a/test/parallel/test-http2-server-rst-stream.js ++++ b/test/parallel/test-http2-server-rst-stream.js +@@ -5,11 +5,9 @@ if (!common.hasCrypto) + common.skip('missing crypto'); + const assert =3D require('assert'); + const http2 =3D require('http2'); ++const Countdown =3D require('../common/countdown'); +=20 + const { +- HTTP2_HEADER_METHOD, +- HTTP2_HEADER_PATH, +- HTTP2_METHOD_POST, + NGHTTP2_CANCEL, + NGHTTP2_NO_ERROR, + NGHTTP2_PROTOCOL_ERROR, +@@ -17,63 +15,42 @@ const { + NGHTTP2_INTERNAL_ERROR + } =3D http2.constants; +=20 +-const errCheck =3D common.expectsError({ code: 'ERR_HTTP2_STREAM_ERROR' }= , 6); ++const tests =3D [ ++ ['rstStream', NGHTTP2_NO_ERROR, false], ++ ['rstWithNoError', NGHTTP2_NO_ERROR, false], ++ ['rstWithProtocolError', NGHTTP2_PROTOCOL_ERROR, true], ++ ['rstWithCancel', NGHTTP2_CANCEL, false], ++ ['rstWithRefuse', NGHTTP2_REFUSED_STREAM, true], ++ ['rstWithInternalError', NGHTTP2_INTERNAL_ERROR, true] ++]; ++ ++const server =3D http2.createServer(); ++server.on('stream', (stream, headers) =3D> { ++ const method =3D headers['rstmethod']; ++ stream[method](); ++}); ++ ++server.listen(0, common.mustCall(() =3D> { ++ const client =3D http2.connect(`http://localhost:${server.address().por= t}`); ++ ++ const countdown =3D new Countdown(tests.length, common.mustCall(() =3D>= { ++ client.destroy(); ++ server.close(); ++ })); +=20 +-function checkRstCode(rstMethod, expectRstCode) { +- const server =3D http2.createServer(); +- server.on('stream', (stream, headers, flags) =3D> { +- stream.respond({ +- 'content-type': 'text/html', +- ':status': 200 ++ tests.forEach((test) =3D> { ++ const req =3D client.request({ ++ ':method': 'POST', ++ rstmethod: test[0] + }); +- stream.write('test'); +- if (rstMethod =3D=3D=3D 'rstStream') +- stream[rstMethod](expectRstCode); +- else +- stream[rstMethod](); +- +- if (expectRstCode !=3D=3D NGHTTP2_NO_ERROR && +- expectRstCode !=3D=3D NGHTTP2_CANCEL) { +- stream.on('error', common.mustCall(errCheck)); +- } else { +- stream.on('error', common.mustNotCall()); +- } +- }); +- +- server.listen(0, common.mustCall(() =3D> { +- const port =3D server.address().port; +- const client =3D http2.connect(`http://localhost:${port}`); +- +- const headers =3D { +- [HTTP2_HEADER_PATH]: '/', +- [HTTP2_HEADER_METHOD]: HTTP2_METHOD_POST +- }; +- const req =3D client.request(headers); +- +- req.setEncoding('utf8'); +- req.on('streamClosed', common.mustCall((actualRstCode) =3D> { +- assert.strictEqual( +- expectRstCode, actualRstCode, `${rstMethod} is not match rstCode`= ); +- server.close(); +- client.destroy(); ++ req.on('streamClosed', common.mustCall((code) =3D> { ++ assert.strictEqual(code, test[1]); ++ countdown.dec(); + })); +- req.on('data', common.mustCall()); + req.on('aborted', common.mustCall()); +- req.on('end', common.mustCall()); +- +- if (expectRstCode !=3D=3D NGHTTP2_NO_ERROR && +- expectRstCode !=3D=3D NGHTTP2_CANCEL) { +- req.on('error', common.mustCall(errCheck)); +- } else { ++ if (test[2]) ++ req.on('error', common.mustCall()); ++ else + req.on('error', common.mustNotCall()); +- } +- +- })); +-} +- +-checkRstCode('rstStream', NGHTTP2_NO_ERROR); +-checkRstCode('rstWithNoError', NGHTTP2_NO_ERROR); +-checkRstCode('rstWithProtocolError', NGHTTP2_PROTOCOL_ERROR); +-checkRstCode('rstWithCancel', NGHTTP2_CANCEL); +-checkRstCode('rstWithRefuse', NGHTTP2_REFUSED_STREAM); +-checkRstCode('rstWithInternalError', NGHTTP2_INTERNAL_ERROR); ++ }); ++})); +--=20 +2.15.0 + =2D-=20 2.15.0 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable =2D-=20 Mike Gerwitz Free Software Hacker+Activist | GNU Maintainer & Volunteer GPG: D6E9 B930 028A 6C38 F43B 2388 FEF6 3574 5E6F 6D05 https://mikegerwitz.com --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCgAGBQJaHMnwAAoJEIyRe39dxRuiAiEQAIgwT6HiAEb7rZGjU76tQb10 vvEljCAhUmjgSz/qWdnVAIzCa6mmo0kob962uadFcnbCvpxF0xhIMf4BjVmtz7p4 IQA6rx/BwM89sf48441eVW12LeDyKyrgY+wj2zzrwVgb+/m9C0hH9caY6+8/PNWP wF6PbnWCrZSbMBD7DGomqHNwK1C2DeeOyInhBHP+zgbdaXkBu8KXTdzTZ6MdEDyL 8b/sKkDUKsZVhBKCs5gdZBCX2XOK6Y1s/OL/YahaD/EVYlsvTrwJtdU1gPvAczjr 23wI58599wKbx/rjADOXH6STAL0bUsESijG3WyY9ovlA2GfEoI+r4uyNtvmTWtYk nNDhcm4iv7uOwnGoie01su86mIQBuHpUibmgxvcRAXwKPP+L6bnsoTF3mVGWyuZg K9Kv7DzbIJMCtxNi+ErRi9ry9PcDLHt80wR/7mXPxYpNnom9/nBcf4qvNrmEXTbw Z2OAR4JARcQ5+iwfNjY0Ho4VwTGFqPX3wwa36rdh+2p5d5LpBGdbUoAzR1Kv+ias CEtSBt4+idCd2ZCFMVEB4KZHQgMrNA0Q/OQX8zlaVqiZiqn+co9aQfSed/J/CVKI BiC6nnJgLTZw4qNNct/bSymSGPe4Xr7zr8q7H0/nGoLGCAEBgU4AsEQcUmvgAyEm opgtl3EyxSclfq93cWJc =6iJH -----END PGP SIGNATURE----- --==-=-=-- From unknown Sat Jun 21 03:31:02 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Mike Gerwitz Subject: bug#29449: closed (Re: [bug#29449] [PATCH] gnu: node: Update to 8.9.1.) Message-ID: References: <87y3mq3h9v.fsf@gnu.org> <877eudg6d7.fsf@gnu.org> X-Gnu-PR-Message: they-closed 29449 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 29449@debbugs.gnu.org Date: Tue, 28 Nov 2017 09:06:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1511859962-19376-1" This is a multi-part message in MIME format... ------------=_1511859962-19376-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #29449: [PATCH] gnu: node: Update to 8.9.1. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 29449@debbugs.gnu.org. --=20 29449: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D29449 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1511859962-19376-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 29449-done) by debbugs.gnu.org; 28 Nov 2017 09:05:30 +0000 Received: from localhost ([127.0.0.1]:33459 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJbpZ-00051R-Vl for submit@debbugs.gnu.org; Tue, 28 Nov 2017 04:05:30 -0500 Received: from [141.255.128.1] (port=52878 helo=hera.aquilenet.fr) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJbpS-00051D-UF for 29449-done@debbugs.gnu.org; Tue, 28 Nov 2017 04:05:23 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id AFCEBF2B7; Tue, 28 Nov 2017 10:05:23 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HT2Ghbq9gz8G; Tue, 28 Nov 2017 10:05:23 +0100 (CET) Received: from ribbon (unknown [193.50.110.215]) by hera.aquilenet.fr (Postfix) with ESMTPSA id C3CF2F0B1; Tue, 28 Nov 2017 10:05:19 +0100 (CET) From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Mike Gerwitz Subject: Re: [bug#29449] [PATCH] gnu: node: Update to 8.9.1. References: <877eudg6d7.fsf@gnu.org> <87zi79ueck.fsf@gnu.org> <87d144vh69.fsf@fsfe.org> <87r2skb9p9.fsf@gnu.org> <87wp2cnmaa.fsf@gnu.org> <87k1yb9lvz.fsf@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 8 Frimaire an 226 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 28 Nov 2017 10:05:16 +0100 In-Reply-To: <87k1yb9lvz.fsf@gnu.org> (Mike Gerwitz's message of "Mon, 27 Nov 2017 21:29:04 -0500") Message-ID: <87y3mq3h9v.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 2.2 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Mike Gerwitz skribis: > From a07f3f92a0768661dbcb2a4b87fe08dd04149190 Mon Sep 17 00:00:00 2001 > From: Mike Gerwitz > Date: Sat, 25 Nov 2017 20:34:12 -0500 > Subject: [PATCH] gnu: node: Update to 8.9.1. > > * gnu/packages/node.scm (node): Update to 8.9.1. > [source]: Apply 'node-test-http2-server-rst-stream.patch'. > [arguments]: Skip 'doc-only' target in 'check', which attempts to use > npm to retrieve 'js-yaml' package. Remove test/doctool/test-make-doc.js. > Do not remove now-missing test case. Remove new test case that fails in > containers due to networking. > * gnu/packages/patches/node-test-http2-server-rst-stream.patch: New file. [...] Content analysis details: (2.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.0 SPF_HELO_FAIL SPF: HELO does not match SPF record (fail) [SPF failed: Please see http://www.openspf.org/Why?s=helo; id=hera.aquilenet.fr; ip=141.255.128.1; r=debbugs.gnu.org] 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Debbugs-Envelope-To: 29449-done Cc: Jelle Licht , 29449-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.2 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Mike Gerwitz skribis: > From a07f3f92a0768661dbcb2a4b87fe08dd04149190 Mon Sep 17 00:00:00 2001 > From: Mike Gerwitz > Date: Sat, 25 Nov 2017 20:34:12 -0500 > Subject: [PATCH] gnu: node: Update to 8.9.1. > > * gnu/packages/node.scm (node): Update to 8.9.1. > [source]: Apply 'node-test-http2-server-rst-stream.patch'. > [arguments]: Skip 'doc-only' target in 'check', which attempts to use > npm to retrieve 'js-yaml' package. Remove test/doctool/test-make-doc.js. > Do not remove now-missing test case. Remove new test case that fails in > containers due to networking. > * gnu/packages/patches/node-test-http2-server-rst-stream.patch: New file. [...] Content analysis details: (2.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.0 SPF_HELO_FAIL SPF: HELO does not match SPF record (fail) [SPF failed: Please see http://www.openspf.org/Why?s=helo;id=hera.aquilenet.fr;ip=141.255.128.1;r=debbugs.gnu.org] 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS Mike Gerwitz skribis: > From a07f3f92a0768661dbcb2a4b87fe08dd04149190 Mon Sep 17 00:00:00 2001 > From: Mike Gerwitz > Date: Sat, 25 Nov 2017 20:34:12 -0500 > Subject: [PATCH] gnu: node: Update to 8.9.1. > > * gnu/packages/node.scm (node): Update to 8.9.1. > [source]: Apply 'node-test-http2-server-rst-stream.patch'. > [arguments]: Skip 'doc-only' target in 'check', which attempts to use > npm to retrieve 'js-yaml' package. Remove test/doctool/test-make-doc.js. > Do not remove now-missing test case. Remove new test case that fails in > containers due to networking. > * gnu/packages/patches/node-test-http2-server-rst-stream.patch: New file. Perfect. Applied, thanks! Ludo=E2=80=99. ------------=_1511859962-19376-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 26 Nov 2017 01:46:57 +0000 Received: from localhost ([127.0.0.1]:58376 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eIm21-0003Gc-Qf for submit@debbugs.gnu.org; Sat, 25 Nov 2017 20:46:57 -0500 Received: from eggs.gnu.org ([208.118.235.92]:35691) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eIm20-0003GQ-CE for submit@debbugs.gnu.org; Sat, 25 Nov 2017 20:46:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eIm1u-0002Dl-0X for submit@debbugs.gnu.org; Sat, 25 Nov 2017 20:46:47 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:36552) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eIm1t-0002De-SM for submit@debbugs.gnu.org; Sat, 25 Nov 2017 20:46:45 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54885) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eIm1s-00019a-Bb for guix-patches@gnu.org; Sat, 25 Nov 2017 20:46:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eIm1r-0002AH-5w for guix-patches@gnu.org; Sat, 25 Nov 2017 20:46:44 -0500 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:36346) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eIm1r-0002A1-0t for guix-patches@gnu.org; Sat, 25 Nov 2017 20:46:43 -0500 Received: from localhost ([::1]:55984 helo=mikegerwitz-pc.gerwitz.local) by fencepost.gnu.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1eIm1q-0005AA-Ls for guix-patches@gnu.org; Sat, 25 Nov 2017 20:46:42 -0500 From: Mike Gerwitz To: guix-patches@gnu.org Subject: [PATCH] gnu: node: Update to 8.9.1. Date: Sat, 25 Nov 2017 20:45:40 -0500 Message-ID: <877eudg6d7.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) OpenPGP: id=22175B02E626BC98D7C0C2E5F22BB8158EE30EAB MIME-Version: 1.0 Content-Type: multipart/signed; boundary="===-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) --===-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain Let me know if there is a better way to accomplish removing the `doc-only' invocation as part of the `check' target. It invokes npm and attempts to download `js-yaml', so I figured we may as well just skip it altogether since it isn't otherwise used. --=-=-= Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" --==-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-gnu-node-Update-to-8.9.1.patch Content-Transfer-Encoding: quoted-printable From=20918303981e0dd3212f1e0c1f1f87fc8ca608cc5e Mon Sep 17 00:00:00 2001 From: Mike Gerwitz Date: Sat, 25 Nov 2017 20:34:12 -0500 Subject: [PATCH] gnu: node: Update to 8.9.1. * gnu/packages/node.scm (node): Update to 8.9.1. [arguments]: Skip 'doc-only' target in 'check', which attempts to use npm to retrieve 'js-yaml' package. Remove test/doctool/test-make-doc.js. Do not remove now-missing test case. Remove new test case that fails in containers due to networking. =2D-- gnu/packages/node.scm | 18 +++++++++++++++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/gnu/packages/node.scm b/gnu/packages/node.scm index e354130ad..4e2990ca3 100644 =2D-- a/gnu/packages/node.scm +++ b/gnu/packages/node.scm @@ -40,14 +40,14 @@ (define-public node (package (name "node") =2D (version "8.7.0") + (version "8.9.1") (source (origin (method url-fetch) (uri (string-append "http://nodejs.org/dist/v" version "/node-v" version ".tar.gz")) (sha256 (base32 =2D "1a0ginagx3pav6v7adyp76jisia4qgbsq6pz3als4kshwlk4a667"))= )) + "1qbiz7hgwlirhwpd71c8yzcbwsyi5bjlfp6lxb6v55j6rizinj9j")))) (build-system gnu-build-system) (arguments ;; TODO: Purge the bundled copies from the source. @@ -76,6 +76,10 @@ (("'/usr/bin/env'") (string-append "'" (which "env") "'"))) =20 + + ;; test-make-doc needs doc-only target, which is inhibited be= low + (for-each delete-file + '("test/doctool/test-make-doc.js")) ;; FIXME: This test seems to depends on files that are not ;; available in the bundled v8. See ;; https://github.com/nodejs/node/issues/13344 @@ -88,12 +92,12 @@ "test/parallel/test-util-inspect.js" "test/parallel/test-v8-serdes.js" "test/parallel/test-dgram-membership.js" =2D "test/parallel/test-dgram-multicast-set-interfa= ce-lo.js" "test/parallel/test-dns-cancel-reverse-lookup.js" "test/parallel/test-dns-resolveany.js" "test/parallel/test-cluster-master-error.js" "test/parallel/test-cluster-master-kill.js" "test/parallel/test-npm-install.js" + "test/parallel/test-regress-GH-746.js" "test/sequential/test-child-process-emfile.js" "test/sequential/test-benchmark-child-process.js" "test/sequential/test-http-regr-gh-2928.js")) @@ -115,6 +119,14 @@ (string-append (assoc-ref inputs "python") "/bin/python") "configure" flags))))) + (add-before 'check 'skip-check-doc-only + (lambda _ + (substitute* "Makefile" + ;; requires js-yaml, which is not part of the distribution, + ;; and falls back to using npm to download it + (("\\$\\(MAKE\\) doc-only" all) + (string-append "#" all))) + #t)) (add-after 'patch-shebangs 'patch-npm-shebang (lambda* (#:key outputs #:allow-other-keys) (let* ((bindir (string-append (assoc-ref outputs "out") =2D-=20 2.15.0 --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCgAGBQJaGhzEAAoJEIyRe39dxRuicUAQAIWlpQm9UgIc0IFBC73ZzRYL FAk14GMPJZug4bUVIp4FktmthH3YKwkXMLbwugcBabRdnp3OrcQAy59GF/MBxZ1B zQ9A0y3Obn508qcr222L2dePu9nuIUqqYsEyoUl3qGQ24MgejwZ4+7EOj73ifRKR ZqS6p0en2Tb/jB8NowzcaCQi5QIwR1UM+Ej5QowsOcNLJKJarRkExM2HWimPIUeE OT7itm6c+UnE6Ua6KP70iGKiUPcrRzbHg83GRowx0PrYgSzm7r9zZ2oWh7zr6dyc 0RXVlSZq4VP63PVCq1Gx19coO5U0CkX1WW17xRoXuv9DbgqZI9zPg3Z2sXSfmJ5Q RhtwPK0qzA6R9v9EEbFrO273coAWmwGc1e7UTMCVThYr1ZZVKr8RNOjb/CdOt5QY Sr+BELutpiqDzEuHueaZ0aZ06kF/olC1hwuMKn3Xhnf48gIRXfuuKzGh/NweXbHq OrzjJzudd8eiLd98ogq+ej0zXc0N3ondRyS6aXctKxY06Fl69HLD5UFw6nmcTCXV 2WyajuC0acfQPT2tUrTdVMRnKvOg73IKaPfe5/sH0p7zXdVCqgimfYzD1UaPtm46 fQDGENIPEFuAujxUHz5gCAlV713LoYCqlx1J/DW6jgW/5/Hqud7eItV5jpSbCRGo zxv4lNqC9G4UZm7rMpJR =eOp6 -----END PGP SIGNATURE----- --==-=-=-- --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable =2D-=20 Mike Gerwitz Free Software Hacker+Activist | GNU Maintainer & Volunteer GPG: D6E9 B930 028A 6C38 F43B 2388 FEF6 3574 5E6F 6D05 https://mikegerwitz.com --=-=-=-- --===-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCgAGBQJaGhzKAAoJEIyRe39dxRui4/EQAKDgnQNrnTf9EQanHS4F+pxG yDFgd5XmZd/mb2mrIlsANLslbZc4FHB7zjlaedAO++bcKaxl93BPsz0+Mw0N9xYH nCm7pqmCgBuZIXfHGOco9dp0Z9dYD18/Ka+rhVvzr55gs0FtAK93F0AhsI1bCEcF nYOYh5sOTnFROwxPWnOLM+Tl724zOI6GcQbbbTaa+r6FCkdlS2l+D/20PggJefkk Gz8wC//yNBvkAmbdXsatPUgnZaHCxt2Vpn/DSrBwBCOxTnbYehduoUeidHio6H8K 9K/cSPC/jTbPmnfq89FvEumwG3cIw6iF6xx/VTH8q7zZCRCnE4k72x27OZMPsfpf PrdLx82u4AtTOiidFFbtUYHl+973WopOxgCytk8H7I9CoAZyX7XcdDRrQGZ3WXT0 lMn1fNQIHDeu7JUaqVa7QVT/SVm8UtoFYxxlJtGIOz5AHUWmArjapjIPYcHEJTHw gq9v3Gz0TtrruRoV3tpCyVVy1AU//drnGv9b26s260S/GzoGzx/ZLSivJvNUuVbu eC+RVACovaFBRUIH1Ypk9+fQLCJ1GmMOgB6GNxfoIsjkl0NHRqe472YWxADwjRpV YoUudkSdwTtnT4ZUcaB5t5QILLTMZaDhYlAIBqy9zk/4r8BKRENjwE4eAmGXE5Yk 6EA55YUNh134ilwKXuQQ =pd4l -----END PGP SIGNATURE----- --===-=-=-- ------------=_1511859962-19376-1-- From unknown Sat Jun 21 03:31:02 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#29449] [PATCH] gnu: node: Update to 8.9.1. Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 28 Nov 2017 18:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29449 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 29449@debbugs.gnu.org, ludo@gnu.org, mtg@gnu.org Received: via spool by 29449-submit@debbugs.gnu.org id=B29449.151189370829139 (code B ref 29449); Tue, 28 Nov 2017 18:29:01 +0000 Received: (at 29449) by debbugs.gnu.org; 28 Nov 2017 18:28:28 +0000 Received: from localhost ([127.0.0.1]:35048 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJkcN-0007Zv-Rt for submit@debbugs.gnu.org; Tue, 28 Nov 2017 13:28:28 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:35199) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJkcM-0007Zo-On for 29449@debbugs.gnu.org; Tue, 28 Nov 2017 13:28:26 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id A15E020A8B; Tue, 28 Nov 2017 13:28:26 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute4.internal (MEProxy); Tue, 28 Nov 2017 13:28:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= mesmtp; bh=iT9apUoJ9kG816UX6QCVUy2w9SMRihZPcEKjLhTV+L4=; b=XKwMy TxkZJmZuHR+GG0HOmNR2PDGBzO4qXMmHLs0KgeCTtEMxhxqRLBrcaARZRe6sQExP GlxmNFwVyd2Suxx+EMXuzv0AGyFcqSEVeU1D3KIipg9ylIwC67eWYMZkGCTm78y4 xkierTBjy8SQEETULz5RMBKg2nc20dIhuMeLpQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; bh=iT9apUoJ9kG816UX6QCVUy2w9SMRi hZPcEKjLhTV+L4=; b=MBRklogZeN/TgBfzyFj0eCwyWtFkTAqh3N5fr6BQxxMBi OZpCa/o4bdaefQP6sby4RQGsRDL23GkLU0DYlH4c4F6C1ifE5zwMyn2NU0cYAPTs qAaJgVzgcslV3YHJ+Fgv6N+Y7lDQa9t2Gvd8nzf0RDdz59BS/CIIABciEbCNw2yj H2ZZSqEzdOJbJNOLGj+yHUpqyMVCugHBcFqE5QeHZkLtfiwISXVaE430ZepY8hx0 QZ8AnKbekf/SqbFpcF9JY5CN2aM24/YiZjFMp8ApDolMmX3QGng0XaPrmLrdskjQ ilLjqRMZRx+MF7Fk+3vxgcVkBwfYXUhTestmMDcNw== X-ME-Sender: Received: from localhost (c-73-165-108-70.hsd1.pa.comcast.net [73.165.108.70]) by mail.messagingengine.com (Postfix) with ESMTPA id 584C6245A8; Tue, 28 Nov 2017 13:28:26 -0500 (EST) Date: Tue, 28 Nov 2017 13:28:25 -0500 From: Leo Famulari Message-ID: <20171128182825.GH14200@jasmine.lan> References: <877eudg6d7.fsf@gnu.org> <87zi79ueck.fsf@gnu.org> <87d144vh69.fsf@fsfe.org> <87r2skb9p9.fsf@gnu.org> <87wp2cnmaa.fsf@gnu.org> <87k1yb9lvz.fsf@gnu.org> <87y3mq3h9v.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="X1xGqyAVbSpAWs5A" Content-Disposition: inline In-Reply-To: <87y3mq3h9v.fsf@gnu.org> User-Agent: Mutt/1.9.1 (2017-09-22) X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --X1xGqyAVbSpAWs5A Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 28, 2017 at 10:05:16AM +0100, Ludovic Court=E8s wrote: > Mike Gerwitz skribis: >=20 > > From a07f3f92a0768661dbcb2a4b87fe08dd04149190 Mon Sep 17 00:00:00 2001 > > From: Mike Gerwitz > > Date: Sat, 25 Nov 2017 20:34:12 -0500 > > Subject: [PATCH] gnu: node: Update to 8.9.1. > > > > * gnu/packages/node.scm (node): Update to 8.9.1. > > [source]: Apply 'node-test-http2-server-rst-stream.patch'. > > [arguments]: Skip 'doc-only' target in 'check', which attempts to use > > npm to retrieve 'js-yaml' package. Remove test/doctool/test-make-doc.j= s. > > Do not remove now-missing test case. Remove new test case that fails in > > containers due to networking. > > * gnu/packages/patches/node-test-http2-server-rst-stream.patch: New fil= e. >=20 > Perfect. Applied, thanks! Don't we need to add 'node-test-http2-server-rst-stream.patch' to 'gnu/local.mk'? --X1xGqyAVbSpAWs5A Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlodqskACgkQJkb6MLrK fwgjhQ//Z23dC5cQnW7ovONY574+BkmfKASHk4jHJq8cWMm1EPJKBVBprv1LssPt 6ltfMm+VAf1j/aXgrVc54PJrky/QtsITedbcPvSt6ry8cnPcgR6WAB7In5miMLVj AS1fXx4kJEg58uPZquPs0QqicvbzeFhVR8Hb5HxliAoMn5Ie6NUe7AjFGiCE1qQD 5/JnrmvZZcg3HT06XZ7UoIaC1vpXtZeWAH9Qw3pFNglTB/qizlMVBNc7fp4e76xL xEL+vDl/r4nOVTset4Ua2t+6WhSrXB1bAsIFLjb7DiiCFhmsTIHc5ditE2VSO+xw XQ1HATGoMQFHa/E43gwZNOJ4XQ1fGMrNAQ1/CyYUlVSFhaNkdHoxBFngATWE7m1m MMYCF09l3CTe0XPVFLnObeNqGUGmT9M84nMIKBGtpaZG6DTqkEWJUONtZyb9GdOs k7Mra26JJeSnf18dY0PZI00XcX0kJf5yYjE8d6Z0ljmX9pE6wUVDggjLJFn8JTwX 1oioA6eYgEbjlN5VWgt7y4GEbzUmXwg/F+Vcag62FVNYSHHSwR3OcFMlXGonrGPo 5PJvWKOusvsIfyMjM6ZWzx2dwjOaSyV7kjXpAN61naDDBVnNd+em9Qf62qeed681 WQ6ZaCk3sCOaCKhL/dZzGVhHC4d3nt+iPK1Y+JnFQP7VyYq1Dtw= =ourg -----END PGP SIGNATURE----- --X1xGqyAVbSpAWs5A-- From unknown Sat Jun 21 03:31:02 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#29449] [PATCH] gnu: node: Update to 8.9.1. Resent-From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 28 Nov 2017 22:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29449 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Leo Famulari Cc: mtg@gnu.org, 29449@debbugs.gnu.org Received: via spool by 29449-submit@debbugs.gnu.org id=B29449.151190920528481 (code B ref 29449); Tue, 28 Nov 2017 22:47:02 +0000 Received: (at 29449) by debbugs.gnu.org; 28 Nov 2017 22:46:45 +0000 Received: from localhost ([127.0.0.1]:35268 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJoeL-0007PJ-35 for submit@debbugs.gnu.org; Tue, 28 Nov 2017 17:46:45 -0500 Received: from [141.255.128.1] (port=55190 helo=hera.aquilenet.fr) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJoeJ-0007PB-0A for 29449@debbugs.gnu.org; Tue, 28 Nov 2017 17:46:43 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id F10001009A; Tue, 28 Nov 2017 23:46:44 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Nocnn7V3Fmkg; Tue, 28 Nov 2017 23:46:42 +0100 (CET) Received: from ribbon (unknown [IPv6:2a01:e0a:1d:7270:af76:b9b:ca24:c465]) by hera.aquilenet.fr (Postfix) with ESMTPSA id CA4E1F4FD; Tue, 28 Nov 2017 23:46:33 +0100 (CET) From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <877eudg6d7.fsf@gnu.org> <87zi79ueck.fsf@gnu.org> <87d144vh69.fsf@fsfe.org> <87r2skb9p9.fsf@gnu.org> <87wp2cnmaa.fsf@gnu.org> <87k1yb9lvz.fsf@gnu.org> <87y3mq3h9v.fsf@gnu.org> <20171128182825.GH14200@jasmine.lan> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 8 Frimaire an 226 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 28 Nov 2017 23:46:30 +0100 In-Reply-To: <20171128182825.GH14200@jasmine.lan> (Leo Famulari's message of "Tue, 28 Nov 2017 13:28:25 -0500") Message-ID: <87374yrph5.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 2.2 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Leo Famulari skribis: > On Tue, Nov 28, 2017 at 10:05:16AM +0100, Ludovic =?UTF-8?Q?Court=C3=A8s?= wrote: >> Mike Gerwitz skribis: >> >> > From a07f3f92a0768661dbcb2a4b87fe08dd04149190 Mon Sep 17 00:00:00 2001 >> > From: Mike Gerwitz >> > Date: Sat, 25 Nov 2017 20:34:12 -0500 >> > Subject: [PATCH] gnu: node: Update to 8.9.1. >> > >> > * gnu/packages/node.scm (node): Update to 8.9.1. >> > [source]: Apply 'node-test-http2-server-rst-stream.patch'. >> > [arguments]: Skip 'doc-only' target in 'check', which attempts to use >> > npm to retrieve 'js-yaml' package. Remove test/doctool/test-make-doc.js. >> > Do not remove now-missing test case. Remove new test case that fails in >> > containers due to networking. >> > * gnu/packages/patches/node-test-http2-server-rst-stream.patch: New file. >> >> Perfect. Applied, thanks! > > Don't we need to add 'node-test-http2-server-rst-stream.patch' to > 'gnu/local.mk'? [...] Content analysis details: (2.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.0 SPF_HELO_FAIL SPF: HELO does not match SPF record (fail) [SPF failed: Please see http://www.openspf.org/Why?s=helo;id=hera.aquilenet.fr;ip=141.255.128.1;r=debbugs.gnu.org] 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.2 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Leo Famulari skribis: > On Tue, Nov 28, 2017 at 10:05:16AM +0100, Ludovic =?UTF-8?Q?Court=C3=A8s?= wrote: >> Mike Gerwitz skribis: >> >> > From a07f3f92a0768661dbcb2a4b87fe08dd04149190 Mon Sep 17 00:00:00 2001 >> > From: Mike Gerwitz >> > Date: Sat, 25 Nov 2017 20:34:12 -0500 >> > Subject: [PATCH] gnu: node: Update to 8.9.1. >> > >> > * gnu/packages/node.scm (node): Update to 8.9.1. >> > [source]: Apply 'node-test-http2-server-rst-stream.patch'. >> > [arguments]: Skip 'doc-only' target in 'check', which attempts to use >> > npm to retrieve 'js-yaml' package. Remove test/doctool/test-make-doc.js. >> > Do not remove now-missing test case. Remove new test case that fails in >> > containers due to networking. >> > * gnu/packages/patches/node-test-http2-server-rst-stream.patch: New file. >> >> Perfect. Applied, thanks! > > Don't we need to add 'node-test-http2-server-rst-stream.patch' to > 'gnu/local.mk'? [...] Content analysis details: (2.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.0 SPF_HELO_FAIL SPF: HELO does not match SPF record (fail) [SPF failed: Please see http://www.openspf.org/Why?s=helo;id=hera.aquilenet.fr;ip=141.255.128.1;r=debbugs.gnu.org] 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS Leo Famulari skribis: > On Tue, Nov 28, 2017 at 10:05:16AM +0100, Ludovic Court=C3=A8s wrote: >> Mike Gerwitz skribis: >>=20 >> > From a07f3f92a0768661dbcb2a4b87fe08dd04149190 Mon Sep 17 00:00:00 2001 >> > From: Mike Gerwitz >> > Date: Sat, 25 Nov 2017 20:34:12 -0500 >> > Subject: [PATCH] gnu: node: Update to 8.9.1. >> > >> > * gnu/packages/node.scm (node): Update to 8.9.1. >> > [source]: Apply 'node-test-http2-server-rst-stream.patch'. >> > [arguments]: Skip 'doc-only' target in 'check', which attempts to use >> > npm to retrieve 'js-yaml' package. Remove test/doctool/test-make-doc.= js. >> > Do not remove now-missing test case. Remove new test case that fails = in >> > containers due to networking. >> > * gnu/packages/patches/node-test-http2-server-rst-stream.patch: New fi= le. >>=20 >> Perfect. Applied, thanks! > > Don't we need to add 'node-test-http2-server-rst-stream.patch' to > 'gnu/local.mk'? Indeed, I=E2=80=99ve added it now. Thanks for the heads-up! Ludo=E2=80=99.