GNU bug report logs - #29434
[PATCH 0/2] gnu: python-internetarchive: Update to 1.7.4 and enable tests.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 29434 in the body.
You can then email your comments to 29434 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH 0/2] gnu: python-internetarchive: Update to 1.7.4 and enable
 tests.
Date: Sat, 25 Nov 2017 11:17:35 +0300

[0000-cover-letter.patch (text/x-patch, inline)]

From d807d092719f22addc909cb5f6a5371cef1d2d6c Mon Sep 17 00:00:00 2001
From: Oleg Pykhalov <go.wigust <at> gmail.com>
Date: Sat, 25 Nov 2017 11:13:55 +0300
Subject: [PATCH 0/2] gnu: python-internetarchive: Update to 1.7.4 and enable tests.

Hello Guix,

These patches update python-internetarchive to 1.7.4 and enable tests as
discussed in https://debbugs.gnu.org/cgi/bugreport.cgi?bug=28129

Oleg Pykhalov (2):
  gnu: python-internetarchive: Update to 1.7.4.
  gnu: python-internetarchive: Enable tests.

 gnu/packages/web.scm | 27 +++++++++++++--------------
 1 file changed, 13 insertions(+), 14 deletions(-)

-- 
2.15.0

Message #8 received at 29434 <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: 29434 <at> debbugs.gnu.org
Cc: Oleg Pykhalov <go.wigust <at> gmail.com>
Subject: [PATCH 1/2] gnu: python-internetarchive: Update to 1.7.4.
Date: Sat, 25 Nov 2017 11:21:57 +0300

* gnu/packages/web.scm (python-internetarchive): Update to 1.7.4.
---
 gnu/packages/web.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm
index a4a8778ef..9e6ad5b69 100644
--- a/gnu/packages/web.scm
+++ b/gnu/packages/web.scm
@@ -5160,7 +5160,7 @@ command-line arguments or read from stdin.")
 (define-public python-internetarchive
   (package
     (name "python-internetarchive")
-    (version "1.7.1")
+    (version "1.7.4")
     (source
      (origin
        (method url-fetch)
@@ -5169,7 +5169,7 @@ command-line arguments or read from stdin.")
        (file-name (string-append name "-" version ".tar.gz"))
        (sha256
         (base32
-         "1lj4r0y67mwjns2gcjvw0y7m5x0vqir2iv7s4q2y93492azli1qh"))))
+         "0sdbb2ag6vmybi8zmbjszi492a587giaaqxyy1p6gy03cb8mc512"))))
     (build-system python-build-system)
     (arguments
      `(#:tests? #f ; 11 tests of 105 fail to mock "requests".
-- 
2.15.0

Message #11 received at 29434 <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: 29434 <at> debbugs.gnu.org
Cc: Oleg Pykhalov <go.wigust <at> gmail.com>
Subject: [PATCH 2/2] gnu: python-internetarchive: Enable tests.
Date: Sat, 25 Nov 2017 11:21:58 +0300

* gnu/packages/web.scm (python-internetarchive): Enable tests.
---
 gnu/packages/web.scm | 23 +++++++++++------------
 1 file changed, 11 insertions(+), 12 deletions(-)

diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm
index 9e6ad5b69..988a73170 100644
--- a/gnu/packages/web.scm
+++ b/gnu/packages/web.scm
@@ -5172,21 +5172,20 @@ command-line arguments or read from stdin.")
          "0sdbb2ag6vmybi8zmbjszi492a587giaaqxyy1p6gy03cb8mc512"))))
     (build-system python-build-system)
     (arguments
-     `(#:tests? #f ; 11 tests of 105 fail to mock "requests".
-       #:phases
+     `(#:phases
        (modify-phases %standard-phases
          (delete 'check)
          (add-after 'install 'check
-           (lambda* (#:key inputs outputs target (tests? (not target)) #:allow-other-keys)
-             (if tests?
-               (begin
-                 (add-installed-pythonpath inputs outputs)
-                 (setenv "PATH" (string-append (assoc-ref outputs "out") "/bin"
-                                               ":" (getenv "PATH")))
-                 (zero? (system* "py.test")))
-               (begin
-                 (format #t "test suite not run~%")
-                 #t)))))))
+           (lambda* (#:key inputs outputs #:allow-other-keys)
+             (add-installed-pythonpath inputs outputs)
+             (setenv "PATH" (string-append (assoc-ref outputs "out") "/bin"
+                                           ":" (getenv "PATH")))
+             (zero? (system* "py.test" "-v" "-k"
+                             (string-append
+                              ;; This tests attempts to make a connection to
+                              ;; an external web service.
+                              "not test_get_item_with_kwargs"
+                              " and not test_ia"))))))))
     (propagated-inputs
      `(("python-requests" ,python-requests)
        ("python-jsonpatch" ,python-jsonpatch-0.4)
-- 
2.15.0

Message #14 received at 29434 <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: 29434 <at> debbugs.gnu.org
Subject: Re: [bug#29434] [PATCH 2/2] gnu: python-internetarchive: Enable tests.
Date: Sat, 25 Nov 2017 11:30:45 +0300

Oleg Pykhalov <go.wigust <at> gmail.com> writes:

[...]

> +             (zero? (system* "py.test" "-v" "-k"
> +                             (string-append
> +                              ;; This tests attempts to make a connection to
> +                              ;; an external web service.
> +                              "not test_get_item_with_kwargs"
> +                              " and not test_ia"))))))))

Oh, probably better: These tests attempt to make a connection to an
external web service.  :-)

>      (propagated-inputs
>       `(("python-requests" ,python-requests)
>         ("python-jsonpatch" ,python-jsonpatch-0.4)

Message #17 received at 29434 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Oleg Pykhalov <go.wigust <at> gmail.com>
Cc: 29434 <at> debbugs.gnu.org
Subject: Re: [bug#29434] [PATCH 1/2] gnu: python-internetarchive: Update to
 1.7.4.
Date: Sat, 25 Nov 2017 11:29:40 -0500

[Message part 1 (text/plain, inline)]

On Sat, Nov 25, 2017 at 11:21:57AM +0300, Oleg Pykhalov wrote:
> * gnu/packages/web.scm (python-internetarchive): Update to 1.7.4.

LGTM, thanks!

[signature.asc (application/pgp-signature, inline)]

Message #20 received at 29434 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Oleg Pykhalov <go.wigust <at> gmail.com>
Cc: 29434 <at> debbugs.gnu.org
Subject: Re: [bug#29434] [PATCH 2/2] gnu: python-internetarchive: Enable tests.
Date: Sat, 25 Nov 2017 11:30:12 -0500

[Message part 1 (text/plain, inline)]

On Sat, Nov 25, 2017 at 11:30:45AM +0300, Oleg Pykhalov wrote:
> Oleg Pykhalov <go.wigust <at> gmail.com> writes:
> 
> [...]
> 
> > +             (zero? (system* "py.test" "-v" "-k"
> > +                             (string-append
> > +                              ;; This tests attempts to make a connection to
> > +                              ;; an external web service.
> > +                              "not test_get_item_with_kwargs"
> > +                              " and not test_ia"))))))))
> 
> Oh, probably better: These tests attempt to make a connection to an
> external web service.  :-)

Yes, that's more clear :) Thanks!

[signature.asc (application/pgp-signature, inline)]

Message #23 received at 29434 <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: Leo Famulari <leo <at> famulari.name>
Cc: 29434 <at> debbugs.gnu.org
Subject: Re: [bug#29434] [PATCH 1/2] gnu: python-internetarchive: Update to
 1.7.4.
Date: Tue, 28 Nov 2017 20:26:53 +0300

[Message part 1 (text/plain, inline)]

Hello Leo,

Leo Famulari <leo <at> famulari.name> writes:

> On Sat, Nov 25, 2017 at 11:21:57AM +0300, Oleg Pykhalov wrote:
>> * gnu/packages/web.scm (python-internetarchive): Update to 1.7.4.
>
> LGTM, thanks!

OK, pushed as:

- 25fa22a99b31c91dba398935ef9457a7664d8156
- 2cdf78df2d3d5d88c7e6908754233cf37cce1e61

Thanks,
Oleg.

[signature.asc (application/pgp-signature, inline)]

Message #28 received at 29434-done <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: 29434-done <at> debbugs.gnu.org
Subject: Re: [bug#29434] [PATCH 1/2] gnu: python-internetarchive: Update to
 1.7.4.
Date: Tue, 28 Nov 2017 20:28:44 +0300

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.