From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 24 16:10:30 2017 Received: (at submit) by debbugs.gnu.org; 24 Nov 2017 21:10:30 +0000 Received: from localhost ([127.0.0.1]:56487 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eILF0-0005pp-1j for submit@debbugs.gnu.org; Fri, 24 Nov 2017 16:10:30 -0500 Received: from eggs.gnu.org ([208.118.235.92]:34276) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eILEw-0005pa-VF for submit@debbugs.gnu.org; Fri, 24 Nov 2017 16:10:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eILEq-0005ar-5t for submit@debbugs.gnu.org; Fri, 24 Nov 2017 16:10:21 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:47547) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eILEq-0005ai-0p for submit@debbugs.gnu.org; Fri, 24 Nov 2017 16:10:20 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53476) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eILEo-0005E1-Me for guix-patches@gnu.org; Fri, 24 Nov 2017 16:10:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eILEk-0005Yk-Lu for guix-patches@gnu.org; Fri, 24 Nov 2017 16:10:18 -0500 Received: from mout01.posteo.de ([185.67.36.141]:40703) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eILEj-0005XT-Rw for guix-patches@gnu.org; Fri, 24 Nov 2017 16:10:14 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 31D4020FBD for ; Fri, 24 Nov 2017 22:10:11 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1511557811; bh=Nq0vqD40JWPRuRrenAvIyqqaWKJIZwefETtKCH8YqyE=; h=From:To:Cc:Subject:Date:From; b=hOYcHXMA+1uMiN6ybbagTMFf16CwDBnzuV6Z5UzLThRa9o0SGQyMtCsGvQfMJJRr+ vaLpOq5s622+LYukae7pBqcedSAFhF7y+FFFX/m6gXm05JpvPS2BUyXYzKnzYYGeLr tDvw47sgGVnMs+iNUxblGyCqhrBZP34oAu1HP3NPeF9WNy9WJfcdTzmkICtcwSSVtc mkVEK1WDzm0MQ3JP0xA+kGLQep0KjvLPzjusJBdyvLn7gVa6W6OIlEDAqo/STQqYM6 xhgPVXAuoSpFnWS/zKYWkRx/KMNwGGnF84HfGfNRn3+VVhpgCW6Yw3urIUyRVLSP6S 7BM4rAHujcIqg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 3yk83Q1nsqz9rxD; Fri, 24 Nov 2017 22:10:09 +0100 (CET) From: Kei Kebreau To: guix-patches@gnu.org Subject: [PATCH] gnu: diffoscope: Fix error messages related to comparison tools. Date: Fri, 24 Nov 2017 16:09:58 -0500 Message-Id: <20171124210958.10089-1-kkebreau@posteo.net> X-Mailer: git-send-email 2.15.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit Cc: Kei Kebreau X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) * gnu/packages/package-management.scm (diffoscope)[arguments]: Replace readelf substitution and add stat and getfacl substitutions. [inputs]: Add acl. --- gnu/packages/package-management.scm | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/gnu/packages/package-management.scm b/gnu/packages/package-management.scm index c7a368116..15c310d6e 100644 --- a/gnu/packages/package-management.scm +++ b/gnu/packages/package-management.scm @@ -63,6 +63,7 @@ #:use-module (gnu packages ssh) #:use-module (gnu packages vim) #:use-module (gnu packages serialization) + #:use-module (gnu packages acl) #:use-module (srfi srfi-1) #:use-module (ice-9 match)) @@ -520,7 +521,6 @@ transactions from C or Python.") (build-system python-build-system) (arguments `(#:phases (modify-phases %standard-phases - (add-before 'unpack 'n (lambda _ #t)) ;; setup.py mistakenly requires python-magic from PyPi, even ;; though the Python bindings of `file` are sufficient. ;; https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=815844 @@ -535,8 +535,15 @@ transactions from C or Python.") (string-append "['" (which "xxd") "',"))) (substitute* "diffoscope/comparators/elf.py" (("@tool_required\\('readelf'\\)") "") - (("\\['readelf',") - (string-append "['" (which "readelf") "',"))) + (("get_tool_name\\('readelf'\\)") + (string-append "'" (which "readelf") "'"))) + (substitute* "diffoscope/comparators/directory.py" + (("@tool_required\\('stat'\\)") "") + (("@tool_required\\('getfacl'\\)") "") + (("\\['stat',") + (string-append "['" (which "stat") "',")) + (("\\['getfacl',") + (string-append "['" (which "getfacl") "',"))) #t)) (add-before 'check 'delete-failing-test (lambda _ @@ -547,6 +554,7 @@ transactions from C or Python.") ("python-debian" ,python-debian) ("python-libarchive-c" ,python-libarchive-c) ("python-tlsh" ,python-tlsh) + ("acl" ,acl) ;for getfacl ("colordiff" ,colordiff) ("xxd" ,xxd) -- 2.15.0 From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 24 19:17:21 2017 Received: (at 29432) by debbugs.gnu.org; 25 Nov 2017 00:17:21 +0000 Received: from localhost ([127.0.0.1]:56636 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eIO9p-0001dR-27 for submit@debbugs.gnu.org; Fri, 24 Nov 2017 19:17:21 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:33297) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eIO9n-0001dJ-PN for 29432@debbugs.gnu.org; Fri, 24 Nov 2017 19:17:20 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 0263B20AF5; Fri, 24 Nov 2017 19:17:18 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute4.internal (MEProxy); Fri, 24 Nov 2017 19:17:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= mesmtp; bh=BxvglpmMc3+z8egJhu59pnbigwSYzKyJPsJe96cv1xQ=; b=i3ZGI M12EaHMDMtG1Ehdsut8Zw8LRJNLUsqYSqrm+ctBK8RIicQuZQ2EQRdren0UpcwKV c44DChAtfCjhBrSbkKkNVldKnPLs5EEqB3+briQcSFnSAww7PIC1Gm9VLxnZOXp5 kchrE+wA9E3i7wRMzW2gL/G05mptQ5gArz3UKo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; bh=BxvglpmMc3+z8egJhu59pnbigwSYz KyJPsJe96cv1xQ=; b=SM0CUtnFSqk+yOKKb82Gsm1OEmTYE6rbvbLj0zKTtNeYE BvBufW5nCcHTkTbbia0MVpGGmKSEu9kYNVcsrqwTC7t81djf5WHG67eFNMeFi66T I5FfMX7/lvYVP4vybEvyREYerqz0z1bo+qWKwl+W8rD1yEB9KX0VAlIyu+0FJf0i 9JNALRJWq37+9E2gyI2sukGmi3BryDAKi/RcFy5nBFwtpbNxNW/VhREwNv2JeTJR Z3OoJ/7qdv1KUfOEEkF6WhMRCHnnZkjYqr8Yz/0gkzTO6hoeONJcHsHjlPNEzAqd zxApN0zJhMdiLtGOGLLYRrifLfUUaGN5fL3on5IhA== X-ME-Sender: Received: from localhost (c-73-165-108-70.hsd1.pa.comcast.net [73.165.108.70]) by mail.messagingengine.com (Postfix) with ESMTPA id B30BB7EDB4; Fri, 24 Nov 2017 19:17:17 -0500 (EST) Date: Fri, 24 Nov 2017 19:17:16 -0500 From: Leo Famulari To: Kei Kebreau Subject: Re: [bug#29432] [PATCH] gnu: diffoscope: Fix error messages related to comparison tools. Message-ID: <20171125001716.GC17061@jasmine.lan> References: <20171124210958.10089-1-kkebreau@posteo.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Clx92ZfkiYIKRjnr" Content-Disposition: inline In-Reply-To: <20171124210958.10089-1-kkebreau@posteo.net> User-Agent: Mutt/1.9.1 (2017-09-22) X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 29432 Cc: 29432@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --Clx92ZfkiYIKRjnr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Nov 24, 2017 at 04:09:58PM -0500, Kei Kebreau wrote: > * gnu/packages/package-management.scm (diffoscope)[arguments]: Replace readelf > substitution and add stat and getfacl substitutions. > [inputs]: Add acl. Can you add an example of the error messages in the commit message? Otherwise LGTM. > @@ -520,7 +521,6 @@ transactions from C or Python.") > (build-system python-build-system) > (arguments > `(#:phases (modify-phases %standard-phases > - (add-before 'unpack 'n (lambda _ #t)) > ;; setup.py mistakenly requires python-magic from PyPi, even > ;; though the Python bindings of `file` are sufficient. > ;; https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=815844 Some leftover debugging? :) --Clx92ZfkiYIKRjnr Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAloYtowACgkQJkb6MLrK fwiGchAA072iRug7ZPUs6OdM5R7C+EkoBhSlOLX7Tqj6WH9qM/NPZwSeDqQ8ZT9Y L05YYapu41AROOIPlI3znBn7HJJOpDAzhG21j/M/zLhJ/8+8X5SSKmR33F4FQFOx YxbM+pbNCRpoeRE80U51joQjaehppy5BCrciBuM0klGS96RewLyy7tsIrSsQfB1f rhRvQRq8BBQGDi2sFKTF7xMgr4I8QHdTVlX+5vntrNGrrt54boBHvDXLN9Y5vaOz OpX9uj5bI4a9UBV0dZ1xs3Fp3CVFpXmoYKuAVchE7CJyLiWGLPLzgj51G8+wCeS8 f2ZiacMcnMWmcEUe8/3e4vWPlSaF9XJ1omfrPlQkPXN4HJvVkb8iR3guXKpfUDYZ 3FDV77X+vV4K3E0ug23PKPWLZqnj5VtmDSoV9Lve92av2kwF84f+a+7zszooMu3J ujQPY/sDYoGy+4hUI3WQ33b4Yfght5ftvQJnGL3AS6ol9dbuwncz9S64qetTaTM4 Sc7Y7LMdmgwaNt/DVQQR53dZu2Kh/uBEGLWx2YfZDTsLpoOJFvHeEnru9QCQZb0H TtIjs/kQFKLIH544OJYWUwUcwmtD85PTH9isCmnkoSNp80hIAUMCu4U4un0IrVve ODfzZNx1GG3Z3/QxdkGo6ZnawmrOVjjH9ASNUu5lis1wHegK6U0= =mgTB -----END PGP SIGNATURE----- --Clx92ZfkiYIKRjnr-- From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 25 12:52:11 2017 Received: (at 29432) by debbugs.gnu.org; 25 Nov 2017 17:52:11 +0000 Received: from localhost ([127.0.0.1]:58150 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eIecc-00079s-T7 for submit@debbugs.gnu.org; Sat, 25 Nov 2017 12:52:11 -0500 Received: from mout01.posteo.de ([185.67.36.141]:58381) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eIeca-00079e-Lf for 29432@debbugs.gnu.org; Sat, 25 Nov 2017 12:52:09 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 4892620F8B for <29432@debbugs.gnu.org>; Sat, 25 Nov 2017 18:52:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1511632322; bh=k4u3HDZJ6YWPQUXIvkrHxYh0jYoZJPzBPQtHjD9WORU=; h=From:To:Cc:Subject:Date:From; b=LqMMPaLFHS5cvNSqplSj9zmvSWLiRReP49gWdOlPc0MCe/RFi+9tj9mY0e4aEfJxP 5nKmkE4xB4W9ChVu0KsuZFaCWL1x6euyiwF6p14Xi/uJsKjA/Q6yRdeIKlXYa+VlGs eUy7rynMNZ4SnFr180UUtylglmM42TEFKSkEwdrJ2Vk84yU/xpkzh4mEFkUcj5CM3w pM95T81gAaM3QpGx4Ahhfe5yrJ8nTP0LKLsGdW0gbxLhIIx5c/rlmDBy4qt1BeRfQu P2kHmaOyRujh7x8MVyKP1lr+tubiDcvP6rRj7bXSHR7mNbV+VbxRTRsK0hJNsh5HEk kOTksQK/6uiSQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 3ykgcJ75dkz9rxC; Sat, 25 Nov 2017 18:52:00 +0100 (CET) From: Kei Kebreau To: Leo Famulari Subject: Re: [bug#29432] [PATCH] gnu: diffoscope: Fix error messages related to comparison tools. In-Reply-To: <20171125001716.GC17061@jasmine.lan> (Leo Famulari's message of "Fri, 24 Nov 2017 19:17:16 -0500") References: <20171124210958.10089-1-kkebreau@posteo.net> <20171125001716.GC17061@jasmine.lan> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) Date: Sat, 25 Nov 2017 12:51:52 -0500 Message-ID: <873752jlfr.fsf@posteo.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 29432 Cc: 29432@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain Leo Famulari writes: > On Fri, Nov 24, 2017 at 04:09:58PM -0500, Kei Kebreau wrote: >> * gnu/packages/package-management.scm (diffoscope)[arguments]: Replace readelf >> substitution and add stat and getfacl substitutions. >> [inputs]: Add acl. > > Can you add an example of the error messages in the commit message? > Otherwise LGTM. > Like this? Errors fixed include the following: "FileNotFoundError: [Errno 2] No such file or directory: 'readelf'" "diffoscope.comparators.directory: Unable to find 'getfacl', some directory metadata differences might not be noticed." "diffoscope.comparators.directory: Unable to find 'stat'" >> @@ -520,7 +521,6 @@ transactions from C or Python.") >> (build-system python-build-system) >> (arguments >> `(#:phases (modify-phases %standard-phases >> - (add-before 'unpack 'n (lambda _ #t)) >> ;; setup.py mistakenly requires python-magic from PyPi, even >> ;; though the Python bindings of `file` are sufficient. >> ;; https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=815844 > > Some leftover debugging? :) You know it! ;) I figured out that this is unnecessary if one uses --keep-failed when building with multiple rounds. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEg7ZwOtzKO2lLzi2m5qXuPBlGeg0FAloZrbgACgkQ5qXuPBlG eg2GwhAAo3rU69Zbrzltemw89CXZWp80HhTsG2NwVGT1knybrPV2OjpMsZK8iZeG vfIEoTF8m9x8Qj514vMvwd5+AODTuA21K35p8Jl02EKNEN3MPzuc/AlBhJwNm5dE oc7HDz6n5csgi7o07DYPBeeX87oPiJdvo3eI/kF3WZWGgm7HBqVXy6tVkNUE6GxC MRl7qhb8In0V1XK5xXJ/geLDn2vgt8zOr0aAIm/qqs3Hlymk4jNXWIMlO1mCz8Oc ExokFWLhUyz9cJKVvO1GL3jDbsDrg6DzcLS5o2c7zRwvNHbiR7QlFaIrSrfLytQj kYAMPuCjzpb4GSautFrePvnPT+2fw3fIPf2JNFak0aCxfENZiV0lWGZfvBkVPxUX SgMQNMZHu4oOc2KL+UMiGkT7V4WmjjDwBsRbyfEouJBNbKGflPwE81T//16K2EyG cOeVSyJl7hBcVra/xH2OINp0QAaXdUPBQB2K+MhheUlnW0kpwGyPW2HI14rECQNB k90CaeoYMV1hln+rs1U1xpk3Wh5phIdPyqEjNgTVLgt6qmpTJWrciPvBo+EjJb6G 21wxK352PxxvEPcv5o9vdFyB5ISZyWsQ2HPFgKmTKMDa7KhFS5O0A08IiTg47CUD ICC1iOO4pJO+G7/7aC6cMv3zFrKdR+O5b6UaPNrHIxFiUr9qV8Y= =Pd7L -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 25 12:57:15 2017 Received: (at 29432) by debbugs.gnu.org; 25 Nov 2017 17:57:15 +0000 Received: from localhost ([127.0.0.1]:58164 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eIehX-0007IN-3X for submit@debbugs.gnu.org; Sat, 25 Nov 2017 12:57:15 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:38983) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eIehU-0007IE-LU for 29432@debbugs.gnu.org; Sat, 25 Nov 2017 12:57:13 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 3574420B56; Sat, 25 Nov 2017 12:57:12 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute4.internal (MEProxy); Sat, 25 Nov 2017 12:57:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= mesmtp; bh=WC7lCdErqquLchLH7D1A32DqFHWPnSiuwO8KsE7HAG0=; b=c1u+f LmUcslJ2VfEuCsZY1tFiwfY8s2WRMrOM8hO6JBjyKMSqQuruHCQXlPdktfClU5Q9 jF5uQehDEbMlHHnjuqzBM5agxMeaee1u1/YIpRtfGgDuQEGIQDBFQEnIXOLaMLAR rHqCtUvB3+MHP7ndmemBrd8feRd65R3VYgTVmM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; bh=WC7lCdErqquLchLH7D1A32DqFHWPn SiuwO8KsE7HAG0=; b=p/6uQJ0KzxCg0T7VchgdCcfp3IuLi7WDpzHiRGjMa92aR aRIadJj8/GPZUzBYrzjZWAjz2SAYrRuCRWty33r8QxJenDFz/lnkjAfkXj03Ojpa GgjjwSTeXhKlBRGvMhmGe6IZmS57ptr5FRWhHaiMTDbZNDWU4BdalRtqtdcegmkQ kzGjowkAruVN/58C3euafcUYlDVc3MS3JTH9NL7WZnCB0uS8s8dWmvn2HxNVqT2V ibkzBFsS/R76GHRBWW2sAJHsueuKQnSbKHnEwIZs86d6cTjQXPxlntWniLbNSl8W IZkfOt8rNaqshYGAShEvU+9uocOv+ACHAebp7rtCQ== X-ME-Sender: Received: from localhost (c-73-165-108-70.hsd1.pa.comcast.net [73.165.108.70]) by mail.messagingengine.com (Postfix) with ESMTPA id DC6E624136; Sat, 25 Nov 2017 12:57:11 -0500 (EST) Date: Sat, 25 Nov 2017 12:57:10 -0500 From: Leo Famulari To: Kei Kebreau Subject: Re: [bug#29432] [PATCH] gnu: diffoscope: Fix error messages related to comparison tools. Message-ID: <20171125175710.GA23396@jasmine.lan> References: <20171124210958.10089-1-kkebreau@posteo.net> <20171125001716.GC17061@jasmine.lan> <873752jlfr.fsf@posteo.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="7JfCtLOvnd9MIVvH" Content-Disposition: inline In-Reply-To: <873752jlfr.fsf@posteo.net> User-Agent: Mutt/1.9.1 (2017-09-22) X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 29432 Cc: 29432@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --7JfCtLOvnd9MIVvH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Nov 25, 2017 at 12:51:52PM -0500, Kei Kebreau wrote: > Leo Famulari writes: >=20 > > On Fri, Nov 24, 2017 at 04:09:58PM -0500, Kei Kebreau wrote: > >> * gnu/packages/package-management.scm (diffoscope)[arguments]: Replace= readelf > >> substitution and add stat and getfacl substitutions. > >> [inputs]: Add acl. > > > > Can you add an example of the error messages in the commit message? > > Otherwise LGTM. > > >=20 > Like this? >=20 > Errors fixed include the following: > "FileNotFoundError: [Errno 2] No such file or directory: 'readelf'" > "diffoscope.comparators.directory: Unable to find 'getfacl', some > directory metadata differences might not be noticed." > "diffoscope.comparators.directory: Unable to find 'stat'" Sure! --7JfCtLOvnd9MIVvH Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAloZrvIACgkQJkb6MLrK fwhCXw//fJbG3rTqtzT9HVppwDv9n5/ocKnFHMbvPlGXvGUcIYPpkgorVhbgDXxB UEKA+NwPlErk90mTdIfDxt2X9XyQSXUbugZPZQbymiXGrWhVVVBv89HZYbMHDSPV fUuMiXHzvuDvXcQish+WogWyCejhHYzKCpPvtqH9SiFKM1UbXl1tNV1pJkFptIor YB8GKREhMS9E/mM1RDOgXU+BZBLxaL18viHajulWjaEALchj6NMTvubV2p50G6ny BMb67zvz74VaZeL/NDhFN5ivjolmnqdBbh7t1fl6sPt0z7uXjhF8pF4LE9zev0l4 8iODasKTX0B4nWVmMSruxV35YDNpuLSTkGFOAvDfGmM/jj8bit+G39AdauD7WTCg u2y2bS9V78Yf0+0w2CqRlWut/PCOo97b3D0d1j4iMinSqvbfx48XlgMT8L1CVjSZ WZM5ptRh7GV+PF0qOUdJZJlxfewxdhB6HFXX14ALPOm0++m1o8/BaAs9IDdyVvho /o3DmGs4HLHpx1/FOJH0nxUMan6g/GbSImqBEGMY/dAG7lwljEjtxa6OAFXzM5lW 6JwN7sRKzFypVGdXT95urvr1kodeLO7jXLclKX6940R2qb7PhfLr71+2UPvuWfIq ao6joOrjA8pgsCPFIql2AsJ9E2aIdhnVKJmjN367smBjsJOakGQ= =bDfK -----END PGP SIGNATURE----- --7JfCtLOvnd9MIVvH-- From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 25 16:20:25 2017 Received: (at 29432-done) by debbugs.gnu.org; 25 Nov 2017 21:20:25 +0000 Received: from localhost ([127.0.0.1]:58275 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eIhs9-0003kb-CM for submit@debbugs.gnu.org; Sat, 25 Nov 2017 16:20:25 -0500 Received: from mout01.posteo.de ([185.67.36.141]:43254) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eIhs7-0003kL-Eg for 29432-done@debbugs.gnu.org; Sat, 25 Nov 2017 16:20:23 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id ED7FE20E48 for <29432-done@debbugs.gnu.org>; Sat, 25 Nov 2017 22:20:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1511644817; bh=nyoejyOZzrFMblDSVBPdnx9CUs0frmlA238YGhHQA0Q=; h=From:To:Cc:Subject:Date:From; b=QjUGOrqC+bNsXOH0L3/8HqazBwAk1mai1G8NJDSeeq1UPFauCVqQf9LMgeE69GS51 M0sN2axQn+rbd3zRZMHc44m+d5ILIYvSvFl2RHoDe5rzEHge9oX/YEtE2dwoYYDpiq XrLm7wt7c9TMUuJYJG0JAc3lps7DT3IrZb7vIYzneREW/juBq8XDd+wIoW0LeHCtib Q43U72WXG7tmSpWyvh75sGGFS1HWAV6cG59uas/e+1ZEsCi6EypUmnvNfTnIEzsMR7 2NtnhErVOC5krbGxevUw9B4aThSzpdGNsnK4Tunarv7FfSaIDjri6FIv4dt6E+VID2 44qXHgGG0VBHQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 3ykmDb6569z9rxC; Sat, 25 Nov 2017 22:20:15 +0100 (CET) From: Kei Kebreau To: Leo Famulari Subject: Re: [bug#29432] [PATCH] gnu: diffoscope: Fix error messages related to comparison tools. References: <20171124210958.10089-1-kkebreau@posteo.net> <20171125001716.GC17061@jasmine.lan> <873752jlfr.fsf@posteo.net> <20171125175710.GA23396@jasmine.lan> Date: Sat, 25 Nov 2017 16:20:05 -0500 In-Reply-To: <20171125175710.GA23396@jasmine.lan> (Leo Famulari's message of "Sat, 25 Nov 2017 12:57:10 -0500") Message-ID: <87y3muhx8a.fsf@posteo.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 29432-done Cc: 29432-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Leo Famulari writes: > On Sat, Nov 25, 2017 at 12:51:52PM -0500, Kei Kebreau wrote: >> Leo Famulari writes: >>=20 >> > On Fri, Nov 24, 2017 at 04:09:58PM -0500, Kei Kebreau wrote: >> >> * gnu/packages/package-management.scm (diffoscope)[arguments]: Replac= e readelf >> >> substitution and add stat and getfacl substitutions. >> >> [inputs]: Add acl. >> > >> > Can you add an example of the error messages in the commit message? >> > Otherwise LGTM. >> > >>=20 >> Like this? >>=20 >> Errors fixed include the following: >> "FileNotFoundError: [Errno 2] No such file or directory: 'readelf'" >> "diffoscope.comparators.directory: Unable to find 'getfacl', some >> directory metadata differences might not be noticed." >> "diffoscope.comparators.directory: Unable to find 'stat'" > > Sure! Pushed to master as 2af6be91d59ad5aefe01e90aa9045e26d8667098. Thank you for the review! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEg7ZwOtzKO2lLzi2m5qXuPBlGeg0FAloZ3oYACgkQ5qXuPBlG eg1N2hAAgTzbCBUlarDkXxKxUpijBZPWWK6wUWmg4tZ0kv7H8PWXL3c62fQQrrCC CUwHTcC9/iY6f3PMFuNCz+gi1eBN8nfzzCIb4XBzxN9l71LFLTGCwa7tPK4B4CYL +T1/eoiMPo5B4TA5v7grK16M17x0uid/G36YcQ/DoMSqAgyDW8+1IfUBg7wTSRq0 8pbsHHzdTMTgS6jakb82QO2ifyPx9hAqgXX5TL2S7/JAtp1SjsI4F+KHGLWhiWSP Zc4A4hCVIAs7eBbJybbni1G4xva8g95gEYhF/PQ7E00OBe/9zPBeOwYNzhRZS4Vj 1mpE5Znxq2FbyrEDJPWzuxWYtKHpe46mP7d7hpV7TGYHc8kh6v1seeTkkEdXPdVl 70nHWGyV27oqa3/AQCMnGeZa3pWcJ6zDQxDPDgryetQ5HYLJO/c/TQ+Ceu5aiy3a 8GAAeHdG0raUfI63Rq87aogzk6juFpt2Z58OgIMuFY253pW1juw3cg8R2oemowRj D9AosWIrHGSCYX5xPexxVZXwI7ZhkjIpNDlNRufpWbEOuuJ0Ix8eSXYzcPAosXb4 nDm9HbcdurBCPw59oU6elxEh7XM81dHG9RskthCSTdeKcO+4ezflHCccNSgTOeuZ w+IwHMMuWzu85OBh4M+yXBUD6XZfrF+x1WAvHOp8/ulAAb57ShE= =kgdr -----END PGP SIGNATURE----- --=-=-=-- From unknown Mon Jun 23 11:25:03 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 24 Dec 2017 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator