GNU bug report logs - #29423
27.0.50; ls-lisp does not handle -F switch properly

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: 29423 <at> debbugs.gnu.org
Subject: bug#29423: 27.0.50; ls-lisp does not handle -F switch properly
Date: Fri, 24 Nov 2017 15:37:26 +0200

> From: Michael Albinus <michael.albinus <at> gmx.de>
> Date: Fri, 24 Nov 2017 13:45:45 +0100
> 
> Goto the *scratch* buffer, and perform
> 
> M-: (ls-lisp-insert-directory "/tmp/" '(?F) nil nil nil)
> 
> Move the cursor into the string /tmp/, and perform
> 
> M-x describe-char
> 
> There is no text property 'dired-filename, as it should.
> 
> The following patch seems to cure the problem. Run the same test, you
> will see the text property 'dired-filename.
> 
> 
> [2:text/plain Hide]
> 
> diff --git a/lisp/ls-lisp.el b/lisp/ls-lisp.el
> index caddc7f760..6765cc8dc9 100644
> --- a/lisp/ls-lisp.el
> +++ b/lisp/ls-lisp.el
> @@ -841,9 +841,7 @@ ls-lisp-format
>  	    " "
>  	    (ls-lisp-format-time file-attr time-index)
>  	    " "
> -	    (if (not (memq ?F switches)) ; ls-lisp-classify already did that
> -		(propertize file-name 'dired-filename t)
> -	      file-name)
> +	    (propertize file-name 'dired-filename t)
>  	    (if (stringp file-type)	; is a symbolic link
>  		(concat " -> " file-type))
>  	    "\n"

How come ls-lisp-classify doesn't propertize the file name in this
case?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.