GNU bug report logs - #29419
[RFC PATCH] gnu: Add rename.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 29419 in the body.
You can then email your comments to 29419 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: guix-patches <at> gnu.org
Subject: [RFC PATCH] gnu: Add rename.
Date: Fri, 24 Nov 2017 02:12:51 +0100

[Message part 1 (text/plain, inline)]

Hello!

I packaged this to help rename a bunch of patches.

It installs an executable called 'rename' which conflicts with the
(limited) one in util-linux, due to the latter being part of
%base-packages.

Are there preferences to either:

* Install this one as 'perl-rename'; or
* Drop the `rename` executable from util-linux.

If there are no comments I'll go with the conservative #1.

[0001-gnu-Add-rename.patch (text/x-patch, inline)]

From 1065207246f5c5bd38ee0539e251ec6f4f65af22 Mon Sep 17 00:00:00 2001
From: Marius Bakke <mbakke <at> fastmail.com>
Date: Fri, 24 Nov 2017 01:27:18 +0100
Subject: [PATCH] gnu: Add rename.

* gnu/packages/admin.scm (rename): New public variable.
---
 gnu/packages/admin.scm | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
index cd2b9a633..f604ff4d7 100644
--- a/gnu/packages/admin.scm
+++ b/gnu/packages/admin.scm
@@ -18,6 +18,7 @@
 ;;; Copyright © 2017 Ben Sturmfels <ben <at> sturm.com.au>
 ;;; Copyright © 2017 Ethan R. Jones <doubleplusgood23 <at> gmail.com>
 ;;; Copyright © 2017 Christopher Allan Webber <cwebber <at> dustycloud.org>
+;;; Copyright © 2017 Marius Bakke <mbakke <at> fastmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -42,6 +43,7 @@
   #:use-module (guix git-download)
   #:use-module (guix build-system cmake)
   #:use-module (guix build-system gnu)
+  #:use-module (guix build-system perl)
   #:use-module (guix build-system python)
   #:use-module (guix build-system trivial)
   #:use-module (gnu packages)
@@ -755,6 +757,33 @@ console window to allow commands to be interactively run on multiple servers
 over ssh connections.")
     (license license:gpl2+)))
 
+(define-public rename
+  (package
+    (name "rename")
+    (version "0.20")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "mirror://cpan/authors/id/R/RM/RMBARKER/File-Rename-"
+                    version ".tar.gz"))
+       (sha256
+        (base32
+         "1cf6xx2hiy1xalp35fh8g73j67r0w0g66jpcbc6971x9jbm7bvjy"))))
+    (build-system perl-build-system)
+    (native-inputs
+     `(("perl-module-build" ,perl-module-build)))
+    (propagated-inputs
+     `(("perl-test-pod" ,perl-test-pod)
+       ("perl-test-pod-coverage" ,perl-test-pod-coverage)))
+    (home-page "https://metacpan.org/pod/distribution/File-Rename/rename.PL")
+    (synopsis "Rename multiple files")
+    (description "@command{rename} renames the filenames supplied according
+to the Perl regular expression specified as the first argument. If a given
+filename is not modified by the expression, it will not be renamed.  If no
+filenames are given on the command line, filenames will be read via standard
+input.")
+    (license license:perl-license)))
+
 (define-public rottlog
   (package
     (name "rottlog")
-- 
2.15.0

[Message part 3 (text/plain, inline)]

Thanks,
Marius

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 29419 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 29419 <at> debbugs.gnu.org
Subject: Re: [bug#29419] [RFC PATCH] gnu: Add rename.
Date: Fri, 24 Nov 2017 09:43:36 -0500

[Message part 1 (text/plain, inline)]

On Fri, Nov 24, 2017 at 02:12:51AM +0100, Marius Bakke wrote:
> Hello!
> 
> I packaged this to help rename a bunch of patches.
> 
> It installs an executable called 'rename' which conflicts with the
> (limited) one in util-linux, due to the latter being part of
> %base-packages.
> 
> Are there preferences to either:
> 
> * Install this one as 'perl-rename'; or
> * Drop the `rename` executable from util-linux.
> 
> If there are no comments I'll go with the conservative #1.

It looks like Debian uses this Perl rename instead of the one from
util-linux. So I'd be okay switching them. Do you have any idea if they
at all are compatible?

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 29419 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 29419 <at> debbugs.gnu.org
Subject: Re: [bug#29419] [RFC PATCH] gnu: Add rename.
Date: Fri, 24 Nov 2017 22:32:22 +0100

Hello,

Marius Bakke <mbakke <at> fastmail.com> skribis:

> It installs an executable called 'rename' which conflicts with the
> (limited) one in util-linux, due to the latter being part of
> %base-packages.

Is this conflict a hindrance in practice?

> Are there preferences to either:
>
> * Install this one as 'perl-rename'; or
> * Drop the `rename` executable from util-linux.
>
> If there are no comments I'll go with the conservative #1.

Either way is fine with me.  (At some point I’d like to avoid Perl
dependencies in %base-packages if possible, though.)

The util-linux change would be for ‘core-updates’, which maybe doesn’t
address your immediate needs.

Ludo’.

Message #14 received at 29419 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 29419 <at> debbugs.gnu.org, Marius Bakke <mbakke <at> fastmail.com>
Subject: Re: [bug#29419] [RFC PATCH] gnu: Add rename.
Date: Fri, 24 Nov 2017 19:12:09 -0500

[Message part 1 (text/plain, inline)]

On Fri, Nov 24, 2017 at 10:32:22PM +0100, Ludovic Courtès wrote:
> Either way is fine with me.  (At some point I’d like to avoid Perl
> dependencies in %base-packages if possible, though.)

util-linux also depends on Perl (not sure why).

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 29419 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 29419 <at> debbugs.gnu.org
Subject: Re: [bug#29419] [RFC PATCH] gnu: Add rename.
Date: Sun, 07 Jan 2018 14:42:21 +0100

[Message part 1 (text/plain, inline)]

Ludovic Courtès <ludo <at> gnu.org> writes:

> Hello,
>
> Marius Bakke <mbakke <at> fastmail.com> skribis:
>
>> It installs an executable called 'rename' which conflicts with the
>> (limited) one in util-linux, due to the latter being part of
>> %base-packages.
>
> Is this conflict a hindrance in practice?

Only if you have util-linux in the same profile.  And there is always
`guix environment --pure`, so not really.

>> Are there preferences to either:
>>
>> * Install this one as 'perl-rename'; or
>> * Drop the `rename` executable from util-linux.
>>
>> If there are no comments I'll go with the conservative #1.
>
> Either way is fine with me.  (At some point I’d like to avoid Perl
> dependencies in %base-packages if possible, though.)

Actually, I changed my mind and would like to keep it as-is for now.
The main problem is that the man page is not easily accessible, but that
turned out to be a different bug: <https://bugs.gnu.org/30014>.

Will push this later when I figure out a synopsis that does not upset
`guix lint` :)

[signature.asc (application/pgp-signature, inline)]

Message #22 received at 29419-done <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: 29419-done <at> debbugs.gnu.org
Subject: Re: [bug#29419] [RFC PATCH] gnu: Add rename.
Date: Mon, 08 Jan 2018 20:16:24 +0100

[Message part 1 (text/plain, inline)]

Pushed as d1ce1125b80b0dfba4b665293a6bb0c611025584.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.