GNU bug report logs - #29409
GuixSD ARM port.

Previous Next

Full log

View this message in rfc822 format

From: ludo <at> gnu.org (Ludovic Courtès)
To: Mathieu Othacehe <m.othacehe <at> gmail.com>
Cc: Danny Milosavljevic <dannym <at> scratchpost.org>, Tobias Geerinckx-Rice <me <at> tobias.gr>, 29409 <at> debbugs.gnu.org
Subject: [bug#29409] Remove hugetlb control group on ARM32.
Date: Fri, 22 Dec 2017 11:50:40 +0100

Mathieu Othacehe <m.othacehe <at> gmail.com> skribis:

> From a531af25b3cffeb70e5681ef70ced564378f2db7 Mon Sep 17 00:00:00 2001
> From: Mathieu Othacehe <m.othacehe <at> gmail.com>
> Date: Fri, 22 Dec 2017 08:42:29 +0100
> Subject: [PATCH 1/2] file-systems: Do not mount hugetlb cgroup filesystem.
>
> On ARM32 without LPAE support, hugetlb control group is not supported.
> As it is not needed by elogind, remove it for all platforms.
>
> * gnu/system/file-systems.scm (%control-groups): Remove hugetlb from control
>   groups platforms.

LGTM, but please make sure that a gnu/system/examples/desktop.tmpl or
similar still works in a VM.

> From 4a28602843a661989c687086af009481dab05eed Mon Sep 17 00:00:00 2001
> From: Mathieu Othacehe <m.othacehe <at> gmail.com>
> Date: Fri, 22 Dec 2017 08:43:24 +0100
> Subject: [PATCH 2/2] file-systems: Move %control-groups from
>  %base-file-systems to %elogind-file-systems.
>
> * gnu/system/file-systems.scm (%base-file-systems): Move %control-groups from
> here, to ...
> (%elogind-file-systems): ... here.

LGTM, but please double-check that “make check-system TESTS=basic” and
bare-bones.tmpl or install.scm (which do not use elogind) still work as
expected.

Thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.