GNU bug report logs - #29409
GuixSD ARM port.

Previous Next

Full log

Message #258 received at 29409 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Mathieu Othacehe <m.othacehe <at> gmail.com>
Cc: 29409 <at> debbugs.gnu.org
Subject: Re: [bug#29409] [PATCH v2 3/4] scripts: system: Add --expression
 option.
Date: Fri, 15 Dec 2017 15:03:11 +0100

Mathieu Othacehe <m.othacehe <at> gmail.com> skribis:

>> What happens if we run “guix system vm”?  Do we still get a proper
>> error?
>
> Nope, it's a mistake, would this be better ?
>
> @@ -1079,7 +1093,8 @@ argument list and OPTS is the option alist."
>      ;; Extract the plain arguments from OPTS.
>      (let* ((args   (reverse (filter-map (match-pair 'argument) opts)))
>             (count  (length args))
> -           (action (assoc-ref opts 'action)))
> +           (action (assoc-ref opts 'action))
> +           (expr   (assoc-ref opts 'expression)))
>        (define (fail)
>          (leave (G_ "wrong number of arguments for action '~a'~%")
>                 action))
> @@ -1093,7 +1108,8 @@ argument list and OPTS is the option alist."
>  
>        (case action
>          ((build container vm vm-image disk-image reconfigure)
> -         (unless (= count 1)
> +         (unless (or (= count 1)
> +                     (and expr (= count 0)))

It looks better, yes.  Thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.