GNU bug report logs - #29409
GuixSD ARM port.

Previous Next

Full log

Message #24 received at 29409 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Mathieu Othacehe <m.othacehe <at> gmail.com>
Cc: 29409 <at> debbugs.gnu.org
Subject: Re: [bug#29409] [PATCH] vm: Use os-defined initrd intead of
 base-initrd.
Date: Fri, 24 Nov 2017 22:36:42 +0100

Hello!

Mathieu Othacehe <m.othacehe <at> gmail.com> skribis:

> * gnu/system/vm.scm (system-disk-image, system-qemu-image,
>   virtualized-operating-system): Replace base-initrd by
>   (operating-system-initrd os).
>
> The system produced were always using base-initrd even if the user had
> defined a custom initrd based on raw-initrd in the os declaration.

[...]

>      (initrd (lambda (file-systems . rest)
> -              (apply base-initrd file-systems
> +              (apply (operating-system-initrd os)
> +                     file-systems
>                       #:volatile-root? #t
>                       #:virtio? #t
>                       rest)))

A potential issue is that we don’t know whether the user-provided initrd
procedure honors #:volatile-root? et al.  Maybe that’s not much of a
problem in practice: we can assume that it’s up to the user to do the
right thing.

I’d say go for it and we’ll adjust if/when it’s a problem.

Thoughts?

Thanks,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.