GNU bug report logs - #29398
company-minimum-prefix-length

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 29398 in the body.
You can then email your comments to 29398 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Frederik Beaujean <Frederik.Beaujean <at> lmu.de>
To: bug-auctex <at> gnu.org
Subject: company-minimum-prefix-length
Date: Wed, 22 Nov 2017 10:11:36 +0100

[Message part 1 (text/plain, inline)]

Dear auctex developers,

I'm using auctex with the company completion system. The problem is that

company-minimum-prefix-length

is ignored in tex files. This is annoying when typesetting math with the
usual single-character symbols like |i| or |n| because I have to press
C-g multiple times to turn of the completion overlay.

I had initially posted this issue on github with spacemacs and
company-auctex, it affects several people as well

https://github.com/syl20bnr/spacemacs/issues/9388

https://github.com/alexeyr/company-auctex/issues/18

The root of the problems seems this code in auctex/tex.el in v11.91

|;; By default, company completions kick in after a prefix of 3 chars has
;; been typed. Since we don't have too many completions, that's too ;;
much. (set (make-local-variable 'company-minimum-prefix-length) 1))) |

|I don't |understand the explanation given for creating this local
variable. I request that it be removed or done in such a way that it
doesn't override global user settings.

bye

Fred
||

[Message part 2 (text/html, inline)]

Message #8 received at 29398 <at> debbugs.gnu.org (full text, mbox):

From: Mosè Giordano <mose <at> gnu.org>
To: Frederik Beaujean <Frederik.Beaujean <at> lmu.de>, Tassilo Horn <tsdh <at> gnu.org>
Cc: 29398 <at> debbugs.gnu.org
Subject: Re: bug#29398: company-minimum-prefix-length
Date: Wed, 22 Nov 2017 23:31:22 +0100

Hi Fred,

2017-11-22 10:11 GMT+01:00 Frederik Beaujean <Frederik.Beaujean <at> lmu.de>:
> Dear auctex developers,
>
> I'm using auctex with the company completion system. The problem is that
>
> company-minimum-prefix-length
>
> is ignored in tex files. This is annoying when typesetting math with the
> usual single-character symbols like i or n because I have to press C-g
> multiple times to turn of the completion overlay.
>
> I had initially posted this issue on github with spacemacs and
> company-auctex, it affects several people as well
>
> https://github.com/syl20bnr/spacemacs/issues/9388
>
> https://github.com/alexeyr/company-auctex/issues/18
>
> The root of the problems seems this code in auctex/tex.el in v11.91
>
> ;; By default, company completions kick in after a prefix of 3 chars has
> ;; been typed.  Since we don't have too many completions, that's too
> ;; much.
> (set (make-local-variable 'company-minimum-prefix-length) 1)))
>
> I don't understand the explanation given for creating this local variable. I
> request that it be removed or done in such a way that it doesn't override
> global user settings.

You can override this setting with

(add-hook 'TeX-mode-hook
      '(lambda ()
         (setq company-minimum-prefix-length 3)))

However, I see that you'd like to avoid setting again the option.
Tassilo, could you please give a look at this?

Bye,
Mosè

Message #11 received at 29398 <at> debbugs.gnu.org (full text, mbox):

From: Tassilo Horn <tsdh <at> gnu.org>
To: Mosè Giordano <mose <at> gnu.org>
Cc: Frederik Beaujean <Frederik.Beaujean <at> lmu.de>, 29398 <at> debbugs.gnu.org
Subject: Re: bug#29398: company-minimum-prefix-length
Date: Thu, 23 Nov 2017 08:14:58 +0100

Mosè Giordano <mose <at> gnu.org> writes:

Hi Fred and Mosè,

>> The root of the problems seems this code in auctex/tex.el in v11.91
>>
>> ;; By default, company completions kick in after a prefix of 3 chars has
>> ;; been typed.  Since we don't have too many completions, that's too
>> ;; much.
>> (set (make-local-variable 'company-minimum-prefix-length) 1)))
>>
>> I don't understand the explanation given for creating this local
>> variable.

The explanation is that usually there are not too many TeX completions,
so if the completion popup would kick not before three characters are
typed, in many cases there would only be one single completion candidate
left over.

\alpha, \beta, \cite, and \label are typical examples.  If the standard
`company-minimum-prefix-length' of 3 was used, you would need to type
\alp, \bet, \cit, and \lab before the completion would kick in, and then
there would only be one single candidate left, so that wouldn't be very
helpful.

(Of course, if you use many packages in a document, the number of
available completions might be larger and with more overlay, so a higher
prefix length might be reasonable.)

>> I request that it be removed or done in such a way that it doesn't
>> override global user settings.
>
> You can override this setting with
>
> (add-hook 'TeX-mode-hook
>       '(lambda ()
>          (setq company-minimum-prefix-length 3)))
>
> However, I see that you'd like to avoid setting again the option.
> Tassilo, could you please give a look at this?

Well, I can simply remove it and add some docs explaining how users can
override the standard value for TeX modes for users who actually like
the current behavior (like myself).  Should I?

Bye,
Tassilo

Message #16 received at 29398-done <at> debbugs.gnu.org (full text, mbox):

From: Tassilo Horn <tsdh <at> gnu.org>
To: Mosè Giordano <mose <at> gnu.org>
Cc: Frederik Beaujean <Frederik.Beaujean <at> lmu.de>, 29398-done <at> debbugs.gnu.org
Subject: Re: bug#29398: company-minimum-prefix-length
Date: Thu, 23 Nov 2017 09:04:42 +0100

Hi all,

I've removed the code.  The argument that many users also use the
dabbrev company backend in combination with the native completion of the
mode made sense.  In that case, you might have thousands of completions
with a too short prefix length.

Bye,
Tassilo

Message #19 received at 29398-done <at> debbugs.gnu.org (full text, mbox):

From: Mosè Giordano <mose <at> gnu.org>
To: Tassilo Horn <tsdh <at> gnu.org>
Cc: Frederik Beaujean <Frederik.Beaujean <at> lmu.de>, 29398-done <at> debbugs.gnu.org
Subject: Re: bug#29398: company-minimum-prefix-length
Date: Thu, 23 Nov 2017 16:24:45 +0100

Hi Tassilo,

2017-11-23 9:04 GMT+01:00 Tassilo Horn <tsdh <at> gnu.org>:
> Hi all,
>
> I've removed the code.  The argument that many users also use the
> dabbrev company backend in combination with the native completion of the
> mode made sense.  In that case, you might have thousands of completions
> with a too short prefix length.

Great!  Thanks for taking care of this.

Bye,
Mosè

Message #22 received at 29398 <at> debbugs.gnu.org (full text, mbox):

From: Frederik Beaujean <Frederik.Beaujean <at> lmu.de>
To: 29398 <at> debbugs.gnu.org
Subject: Re: bug#29398: closed (Re: bug#29398: company-minimum-prefix-length)
Date: Thu, 23 Nov 2017 09:08:42 +0100

Thanks a lot for the quick fix. I think the behavior is much more
consistent now as it respects the user setting. I very much appreciate
your readiness to change this setting even though you liked it the way
it was before!

Best regards

Fred


Am 23.11.2017 um 09:05 schrieb GNU bug Tracking System:
> Your bug report
>
> #29398: company-minimum-prefix-length
>
> which was filed against the auctex package, has been closed.
>
> The explanation is attached below, along with your original report.
> If you require more details, please reply to 29398 <at> debbugs.gnu.org.
>

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.