From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 20 20:53:49 2017 Received: (at submit) by debbugs.gnu.org; 21 Nov 2017 01:53:49 +0000 Received: from localhost ([127.0.0.1]:49695 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eGxkz-0002zV-Fp for submit@debbugs.gnu.org; Mon, 20 Nov 2017 20:53:49 -0500 Received: from eggs.gnu.org ([208.118.235.92]:60535) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eGxkx-0002zI-Vv for submit@debbugs.gnu.org; Mon, 20 Nov 2017 20:53:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eGxkr-0000jL-K3 for submit@debbugs.gnu.org; Mon, 20 Nov 2017 20:53:42 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:38398) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eGxkr-0000jH-GD for submit@debbugs.gnu.org; Mon, 20 Nov 2017 20:53:41 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51468) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eGxkp-0004aE-1R for bug-gnu-emacs@gnu.org; Mon, 20 Nov 2017 20:53:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eGxkl-0000gr-T8 for bug-gnu-emacs@gnu.org; Mon, 20 Nov 2017 20:53:39 -0500 Received: from gateway20.websitewelcome.com ([192.185.53.25]:35699) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eGxkS-0000Zt-V0 for bug-gnu-emacs@gnu.org; Mon, 20 Nov 2017 20:53:35 -0500 Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway20.websitewelcome.com (Postfix) with ESMTP id 5E1D3400D39D9 for ; Mon, 20 Nov 2017 19:53:04 -0600 (CST) Received: from leaf.websitewelcome.com ([192.185.82.99]) by cmsmtp with SMTP id GxkGeb8cPrWstGxkGeHJXB; Mon, 20 Nov 2017 19:53:04 -0600 Received: from pool-74-96-160-131.washdc.fios.verizon.net ([74.96.160.131]:60436 helo=devons-air.fios-router.home) by leaf.websitewelcome.com with esmtpsa (TLSv1:ECDHE-RSA-AES256-SHA:256) (Exim 4.89) (envelope-from ) id 1eGxkG-003F7a-2m for bug-gnu-emacs@gnu.org; Mon, 20 Nov 2017 19:53:04 -0600 From: Devon Sean McCullough Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: 26.0.50; (setf (buffer-modified-p) t) bug Message-Id: <89ADCBCA-59B3-4B53-813B-A69D73BE7EE0@jovi.net> Date: Mon, 20 Nov 2017 20:53:02 -0500 To: bug-gnu-emacs@gnu.org Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) X-Mailer: Apple Mail (2.3124) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - leaf.websitewelcome.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - jovi.net X-BWhitelist: no X-Source-IP: 74.96.160.131 X-Source-L: No X-Exim-ID: 1eGxkG-003F7a-2m X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: pool-74-96-160-131.washdc.fios.verizon.net (devons-air.fios-router.home) [74.96.160.131]:60436 X-Source-Auth: devon2011@jovi.net X-Email-Count: 1 X-Source-Cap: am92aW5ldDtkZXZvbjtsZWFmLndlYnNpdGV3ZWxjb21lLmNvbQ== X-Local-Domain: yes X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) (setf (buffer-modified-p) t) -> (with-current-buffer nil = (set-buffer-modified-p t)) which bombs because nil is not a buffer. Here's a fix: diff -Bbdu old/cl-lib.el new/cl-lib.el --- old/cl-lib.el 2017-06-06 16:19:10.000000000 -0400 +++ new/cl-lib.el 2017-11-20 20:08:41.000000000 -0500 @@ -539,7 +539,7 @@ ;; Some more Emacs-related place types. (gv-define-simple-setter buffer-file-name set-visited-file-name t) (gv-define-setter buffer-modified-p (flag &optional buf) - `(with-current-buffer ,buf + `(with-current-buffer (or ,buf (current-buffer)) (set-buffer-modified-p ,flag))) (gv-define-simple-setter buffer-name rename-buffer t) (gv-define-setter buffer-string (store) Peace --Devon P.S. Here's a backtrace: Debugger entered--Lisp error: (wrong-type-argument stringp nil) set-buffer(nil) (save-current-buffer (set-buffer nil) (set-buffer-modified-p t)) (with-current-buffer nil (set-buffer-modified-p t)) (setf (buffer-modified-p) t) eval((setf (buffer-modified-p) t)) command-line-1(("--funcall" "toggle-debug-on-error" "--load" "cl" = "--eval" "(setf (buffer-modified-p) t)")) command-line() normal-top-level() P.P.S. We can imagine optimizers which know (or nil ...) -> (or ...), (or #) -> # and (with-current-buffer (current-buffer) ...) -> (progn ...) but this is, after all, simply a text editor. In GNU Emacs 26.0.50 (build 1, x86_64-apple-darwin13.4.0, NS = appkit-1265.21 Version 10.9.5 (Build 13F1911)) of 2017-06-07 built on builder10-9.local Windowing system distributor 'Apple', version 10.3.1404 Recent messages: Warning: arch-dependent data dir = =E2=80=99/Users/build/workspace/Emacs-Multi-Build/label/mavericks/emacs-so= urce/nextstep/Emacs.app/Contents/MacOS/libexec/=E2=80=99: No such file = or directory For information about GNU Emacs and the GNU system, type C-h C-a. Debug on Error enabled globally Entering debugger... Configured using: 'configure --with-ns '--enable-locallisppath=3D/Library/Application Support/Emacs/${version}/site-lisp:/Library/Application Support/Emacs/site-lisp' --with-modules' Configured features: NOTIFY ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS NS MODULES Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Debugger Minor modes in effect: tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t buffer-read-only: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message subr-x puny seq byte-opt bytecomp byte-compile cconv dired dired-loaddefs format-spec rfc822 mml mml-sec password-cache epa derived epg epg-config gnus-util rmail rmail-loaddefs mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils help-mode easymenu debug cl gv cl-loaddefs cl-lib cus-start cus-load time-date tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/ns-win ns-win ucs-normalize mule-util term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote kqueue cocoa ns multi-tty make-network-process emacs) Memory information: ((conses 16 213089 10429) (symbols 48 21048 2) (miscs 40 64 182) (strings 32 20087 5364) (string-bytes 1 619310) (vectors 16 35085) (vector-slots 8 697226 6051) (floats 8 54 126) (intervals 56 252 0) (buffers 976 12)) From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 20 20:57:00 2017 Received: (at control) by debbugs.gnu.org; 21 Nov 2017 01:57:00 +0000 Received: from localhost ([127.0.0.1]:49700 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eGxo4-00035c-2G for submit@debbugs.gnu.org; Mon, 20 Nov 2017 20:57:00 -0500 Received: from eggs.gnu.org ([208.118.235.92]:33322) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eGxo3-00035P-3a for control@debbugs.gnu.org; Mon, 20 Nov 2017 20:56:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eGxnx-0001zr-G7 for control@debbugs.gnu.org; Mon, 20 Nov 2017 20:56:54 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:56084) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eGxnx-0001zn-CG for control@debbugs.gnu.org; Mon, 20 Nov 2017 20:56:53 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1eGxnx-0006Mj-3Q for control@debbugs.gnu.org; Mon, 20 Nov 2017 20:56:53 -0500 Subject: control message for bug 21201 To: X-Mailer: mail (GNU Mailutils 2.99.98) Message-Id: From: Glenn Morris Date: Mon, 20 Nov 2017 20:56:53 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) merge 29371 21201 From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 17 08:16:18 2018 Received: (at control) by debbugs.gnu.org; 17 Jul 2018 12:16:18 +0000 Received: from localhost ([127.0.0.1]:44541 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ffOtu-0000Vs-Hv for submit@debbugs.gnu.org; Tue, 17 Jul 2018 08:16:18 -0400 Received: from mail-it0-f42.google.com ([209.85.214.42]:36240) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ffOts-0000Va-R1; Tue, 17 Jul 2018 08:16:17 -0400 Received: by mail-it0-f42.google.com with SMTP id j185-v6so1544641ite.1; Tue, 17 Jul 2018 05:16:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=qFKN96fCTEU8vWfrIMVm2ru3xanzHyFyFxm4W1iF/4A=; b=LX5Q0poL50VCiNSuA7NPFJb9qyNOd19P6+WGeyUdDkMQu7mqLiGdx9QpjfuPaAWqBj uV/qbTlqZzur+R3Bk0eGQ0qRliLD3Ni212B5m5+HxyKdGQkT5jGmdwUiXRFArua3FS0B 7A9mo2tKg9JZ29Y+Vq9zdbrEQ/L6zD4tfhp2NJIwn5TeNwN7hjknjHCVIQQTh6QOcjg7 oKdPdJRoDiXt/XvmVSo4E1gILOdvhB0PsFCHLE1GEQrqh0WzJzkEGB5njj3q8vrd1So7 hc4lmPpoKRWS4PxRl6dmVXssqc59byYj771RLmXvQQgnlIsCQy/fFx8BUIcFDLUC80sm 5zlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=qFKN96fCTEU8vWfrIMVm2ru3xanzHyFyFxm4W1iF/4A=; b=b/mfX6xrt830mEu1a3Lkc1ZO4eGwN/WD9ztlhN8IKrwTWDBLJxBSFz7yTkpX75JEPK +YpJAEF2Ve3sGwbRlnbTPtR4HaqAGyCtlY1LvGmpzrOMcbYU2EpkBXXb7zIfJWuOk+Zb G717TucZx4TSeDdU4L6ivhWmd2UWl/+iZqNJsPsdiOPeD1UlZmnedm3++PqTEiJ8JrI4 GgESUxYwlmJ0vGRkK5JBBqMwe6nWV8CZOPXgOtd3NT4JUrGmw3WzaxekI7l4gcXDtq0d rJBO8YCRQAPuMI24AAmSgN36Tu96+TiwcrinC1tkqwluy+Fb9q+nHWYsXe4z+bMvmBOc 2bQA== X-Gm-Message-State: AOUpUlGQ8aOWAtVTw9UA/WbpfUw0Av4lvYrkgFKQtMHZ77b4tyFMrfgF WO6Jzi+SqvLdbbEPU7mP7jz/Fw== X-Google-Smtp-Source: AAOMgpdqcZAjQ3NLJAfXAj+l94vVC+VXQxqDEc5EYGYdhoCUttfLfSauKybZVBHNZx2wO1Iqqs+Kyg== X-Received: by 2002:a24:b34f:: with SMTP id z15-v6mr1329679iti.53.1531829771059; Tue, 17 Jul 2018 05:16:11 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id 69-v6sm369378itk.3.2018.07.17.05.16.09 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 17 Jul 2018 05:16:10 -0700 (PDT) From: Noam Postavsky To: Nicolas Richard Subject: Re: bug#21201: 25.0.50; (buffer-modified-p) errors inside cl-letf References: <87lhdo41vy.fsf@members.fsf.org> <8637zwghfe.fsf@members.fsf.org> Date: Tue, 17 Jul 2018 08:16:09 -0400 In-Reply-To: <8637zwghfe.fsf@members.fsf.org> (Nicolas Richard's message of "Fri, 07 Aug 2015 00:50:45 +0200") Message-ID: <87pnzm83cm.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: control Cc: 21201@debbugs.gnu.org, Artur Malabarba X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain tags 21201 + patch quit Nicolas Richard writes: > Artur Malabarba writes: >> 2015-08-06 21:07 GMT+01:00 Nicolas Richard : >>> (gv-define-setter buffer-modified-p (flag &optional buf) >>> - `(with-current-buffer ,buf >>> - (set-buffer-modified-p ,flag))) >>> + (if buf >>> + `(with-current-buffer ,buf >>> + (set-buffer-modified-p ,flag)) >>> + `(set-buffer-modified-p ,flag))) >> >> Don't know if it's possible, but shouldn't it try to ensure that it's >> in the same buffer as before? > > I agree with you, but I don't know how to do that. This seems to work. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Allow-setf-of-buffer-modified-p-without-argument-Bug.patch Content-Description: patch >From 1481f8893ff04a83b578f403cd22c7bdd2ec65f0 Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Mon, 16 Jul 2018 22:14:32 -0400 Subject: [PATCH] Allow setf of buffer-modified-p without argument (Bug#21201) * lisp/emacs-lisp/cl-lib.el (setf buffer-modified-p): Take current buffer if optional argument BUF is not passed. --- lisp/emacs-lisp/cl-lib.el | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lisp/emacs-lisp/cl-lib.el b/lisp/emacs-lisp/cl-lib.el index 381784d1fd..ba5f9d64a1 100644 --- a/lisp/emacs-lisp/cl-lib.el +++ b/lisp/emacs-lisp/cl-lib.el @@ -521,8 +521,9 @@ cl-pairlis ;; Some more Emacs-related place types. (gv-define-simple-setter buffer-file-name set-visited-file-name t) (gv-define-setter buffer-modified-p (flag &optional buf) - `(with-current-buffer ,buf - (set-buffer-modified-p ,flag))) + (macroexp-let2 nil buffer `(or ,buf (current-buffer)) + `(with-current-buffer ,buffer + (set-buffer-modified-p ,flag)))) (gv-define-simple-setter buffer-name rename-buffer t) (gv-define-setter buffer-string (store) `(insert (prog1 ,store (erase-buffer)))) -- 2.11.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 27 20:01:36 2018 Received: (at control) by debbugs.gnu.org; 28 Aug 2018 00:01:36 +0000 Received: from localhost ([127.0.0.1]:34601 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fuRRv-00088j-RB for submit@debbugs.gnu.org; Mon, 27 Aug 2018 20:01:35 -0400 Received: from mail-it0-f43.google.com ([209.85.214.43]:40442) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fuRRu-00083s-OX; Mon, 27 Aug 2018 20:01:34 -0400 Received: by mail-it0-f43.google.com with SMTP id h23-v6so116124ita.5; Mon, 27 Aug 2018 17:01:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=WL2hAqCTLbmIxD/Hd0w5YEpeBk1ru+vrWuCu3P8hcUI=; b=ugexWqk00Dwhzukq7mNi5foucDRJBEkum0YSLnbGAeRm+/sJWjS5JzxFb3mzkI/Cmb NMXXqIadcxS4Hbm+GYDueq5HhbckBe4utuKr9U1q7QU+WapDV6EEA8ciXPy5ZnTE+dRW LBy+FMU2NTgsaILUkL9wCyl5FQWtapSimpBBFLQZdkURNrVVT65dwyVHj1ftNRPy5q9B M229BV5vzzOFGsplVFtqF1Veewh3sbu+vXyXzy0SX6+UgE36qR1HaPjgHNsP+gWyx5xU LQ5AFth+TOUeUsTZBM4j6lL7PgkT52DhWmUHqQtOpt3M8d4TLLSI8vicd8VJBWKZF6wE P/ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=WL2hAqCTLbmIxD/Hd0w5YEpeBk1ru+vrWuCu3P8hcUI=; b=PVUluO2JUH9BZGDVNqUXisX+ybuyTtcbsm3lEzc1E1GpG29VQdEgN/m7eIA1MKYvBA cKlQY6/icderXpYdjAkRsS/2zMjvmkF8zxlbX6o5wy6lEDpvMwTaqdvuMOneTZPMoNjU 9itollLWY4qfW8jnDg1NcaV6fBP7L0yN8AYmHlEDwZtP1jF5aWoFckdF/3Lkl8Cu70Aj ATN7zptIbVGWkz7PIw7Yj53W3DWUTt0TgFAxt8I7B7GPLIR1FVgImv+oYEBIVvkw3jZm 3hjMJo+QFrIZCPezPAzzgVF2OGmq3XEVNNWwmYPYhVKHkXv9wLazxHR/Oy+jQdj5SjA2 QOlQ== X-Gm-Message-State: APzg51AJ0TF4lv2nyz0gFReIgzaXGK1WtxIRbcOqFmnY6kA1ccytH+fH kfvtlw5Z2cpSmGUV/7EmcPr8bgEC X-Google-Smtp-Source: ANB0VdYKTh7ZQVD1Scwy2I/Xhlh2lvccrEOSCGdI7IjXi9CLfe8cheeZmDFOLuWpN7tm7gX6OKlmlA== X-Received: by 2002:a02:5fcc:: with SMTP id x73-v6mr12803315jad.96.1535414488966; Mon, 27 Aug 2018 17:01:28 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id e5-v6sm339170itf.0.2018.08.27.17.01.27 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 27 Aug 2018 17:01:28 -0700 (PDT) From: Noam Postavsky To: Nicolas Richard Subject: Re: bug#21201: 25.0.50; (buffer-modified-p) errors inside cl-letf References: <87lhdo41vy.fsf@members.fsf.org> <8637zwghfe.fsf@members.fsf.org> <87pnzm83cm.fsf@gmail.com> Date: Mon, 27 Aug 2018 20:01:26 -0400 In-Reply-To: <87pnzm83cm.fsf@gmail.com> (Noam Postavsky's message of "Tue, 17 Jul 2018 08:16:09 -0400") Message-ID: <87zhx7tl49.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control Cc: 21201@debbugs.gnu.org, Artur Malabarba X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 21201 fixed close 21201 27.1 quit Noam Postavsky writes: > (gv-define-setter buffer-modified-p (flag &optional buf) > - `(with-current-buffer ,buf > - (set-buffer-modified-p ,flag))) > + (macroexp-let2 nil buffer `(or ,buf (current-buffer)) > + `(with-current-buffer ,buffer > + (set-buffer-modified-p ,flag)))) Pushed to master. [1: c8b86362d4]: 2018-08-27 18:54:23 -0400 Allow setf of buffer-modified-p without argument (Bug#21201) https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=c8b86362d45a07e0aec0041cade551c3c663ea8c From unknown Sat Jun 21 12:20:02 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 25 Sep 2018 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator