GNU bug report logs - #29359
More java packages

Previous Next

Package: guix-patches;

Reported by: Julien Lepiller <julien <at> lepiller.eu>

Date: Sun, 19 Nov 2017 17:59:02 UTC

Owned by: Ricardo Wurmus <rekado <at> elephly.net>

Severity: normal

Done: Julien Lepiller <julien <at> lepiller.eu>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>
Cc: 29359 <at> debbugs.gnu.org
Subject: [bug#29359] [PATCH 13/31] gnu: Add java-joda-time.
Date: Mon, 05 Feb 2018 14:32:31 +0100

Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de> writes:

> * Finally, remove the (zero?..), as the result ignored, the result of
> the sourrunding lambda will be the final statement, the #t.

I agree with your other comments, but not with this one :)

The return value of “system*” is not a boolean.  This is why we use
“zero?”.

However, we should be using “invoke” instead of “(zero? (system* …))” as
we are slowly transitioning towards throwing exceptions upon errors in
build phases.

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net
This bug report was last modified 7 years and 101 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.