GNU bug report logs - #29359
More java packages

Previous Next

Full log

Message #106 received at 29359 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Julien Lepiller <julien <at> lepiller.eu>
Cc: 29359 <at> debbugs.gnu.org
Subject: Re: [bug#29359] [PATCH 30/31] gnu: Add java-xmlunit.
Date: Mon, 20 Nov 2017 08:35:16 +0100

Julien Lepiller <julien <at> lepiller.eu> writes:

> * gnu/packages/java.scm (java-xmlunit): New variable.
[…]
> +
> +(define java-xmlunit-test-resources
> +  (origin
> +    (method git-fetch)
> +    (uri (git-reference
> +           (url "https://github.com/xmlunit/test-resources.git")
> +           (commit "a590d2ae865c3e0455691d76ba8eefccc2215aec")))
> +    (file-name "java-xmlunit-test-resources")
> +    (sha256
> +     (base32
> +      "0r0glj37pg5l868yjz78gckr91cs8fysxxbp9p328dssssi91agr"))))

I’d prefer if this were placed inline as part of the java-xmlunit
inputs, instead of making a top-level definition.

The rest looks good to me.

-- 
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.