Subject: Re: [bug#29359] [PATCH 15/31] gnu: Add java-apache-xml-commons-resolver.

From: Björn Höfling <[email-masked]>
Date: Sun, 4 Feb 2018 19:52:47 +0100

On Sun, 19 Nov 2017 18:57:49 +0100
Julien Lepiller <[email-masked]> wrote:

> * gnu/packages/java.scm (java-apache-xml-commons-resolver): New
> variable.
> ---
>  gnu/packages/java.scm | 29 +++++++++++++++++++++++++++++
>  1 file changed, 29 insertions(+)
> 
> diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
> index f1a425418..886a71f23 100644
> --- a/gnu/packages/java.scm
> +++ b/gnu/packages/java.scm
> @@ -7963,3 +7963,32 @@ the Xerces-J XML parser and Xalan-J XSLT
> processor and specifies these APIs: @item JSR 206 Java API for XML
> Processing @end itemize")
>      (license license:asl2.0)))
> +
> +(define-public java-apache-xml-commons-resolver
> +  (package
> +    (name "java-apache-xml-commons-resolver")
> +    (version "1.2")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "mirror://apache/xerces/xml-commons/"
> +                           "xml-commons-resolver-" version
> ".tar.gz"))
> +       (sha256
> +        (base32
> "1zhy4anc3fg9f8y348bj88vmab15aavrg6nf419ifb25asyygnsm"))
> +       (modules '((guix build utils)))
> +       (snippet
> +        '(begin
> +           (for-each delete-file (find-files "." ".*\\.(jar|zip)"))
> +           #t))))
> +    (build-system ant-build-system)
> +    (arguments
> +     `(#:jar-name (string-append "xml-resolver.jar")
> +       #:tests? #f)); no tests
> +    (native-inputs
> +     `(("java-junit" ,java-junit)))
> +    (home-page "http://xerces.apache.org/xml-commons/")
> +    (synopsis "Xml-related utilities and code")
> +    (description "Xml-commons mainly focuses on providing code and
> services +to other xml.apache.org projects instead of shipping it's
> own \"standalone\" +project.")
> +    (license license:asl2.0)))

The package is good, except of:

The synopsis/descriptions is for the general xml-commons project. For
the specific resolver, I would suggest the text found here:

https://xerces.apache.org/xml-commons/components/apidocs/resolver/index.html

Synopsis:
The Apache XML Commons Resolver classes implement Catalog-based
entity and URI resolution. The Apache XML Commons Resolver classes
implement Catalog-based entity and URI resolution. 

Description:
The resolver class implements the full semantics of OASIS Technical
Resolution 9401:1997 (Amendment 2 to TR 9401) catalogs and the 06 Aug
2001 Committee Specification of OASIS XML Catalogs.

It also includes a framework of classes designed to read catalog files
in a number of formats:

    The plain-text flavor described by TR9401.
    The XCatalog XML format defined by John Cowan
    The XML Catalog format defined by the OASIS Entity Resolution
    Technical Committee. 

Björn