Subject: [bug#29359] [PATCH 13/31] gnu: Add java-joda-time.

From: Björn Höfling <[email-masked]>
Date: Sun, 4 Feb 2018 07:28:46 +0100

On Sun, 19 Nov 2017 18:57:47 +0100
Julien Lepiller <[email-masked]> wrote:

> * gnu/packages/java.scm (java-joda-time): New variable.
> ---
>  gnu/packages/java.scm | 64
> +++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed,
> 64 insertions(+)
> 
[..]
> +       (modify-phases %standard-phases
> +         (add-after 'build 'build-resources
> +           (lambda _
> +             (mkdir-p "build/classes/org/joda/time/tz/data")
> +             (mkdir-p "build/classes/org/joda/time/format")
> +             ;; This will produce an exception, but it's all right.
> +             (zero? (system* "java" "-cp"
> +                             (string-append "build/classes:" (getenv
> "CLASSPATH"))
> +                             "org.joda.time.tz.ZoneInfoCompiler"
> +                             "-src"
> "src/main/java/org/joda/time/tz/src"
> +                             "-dst"
> "build/classes/org/joda/time/tz/data"
> +                             "africa" "antarctica" "asia"
> "australasia"
> +                             "europe" "northamerica" "southamerica"
> +                             "pacificnew" "etcetera" "backward"
> "systemv"))
[..]

I'm not convinced about this.

* Why is the exception "all right?"
* If it is all right, mention the specific exception you think that is
  OK: "java.io.IOException: Resource not found:
  "org/joda/time/tz/data/ZoneInfoMap" "
* And if it throws an exception, does it actually do anything for us?
* Finally, remove the (zero?..), as the result ignored, the result of
the sourrunding lambda will be the final statement, the #t.

Björn