Subject: [bug#29359] [PATCH 06/31] gnu: Add java-hawtjni.

From: Ricardo Wurmus <[email-masked]>
Date: Sun, 17 Dec 2017 23:51:38 +0100

Julien Lepiller <[email-masked]> writes:

> * gnu/packages/java.scm (java-hawtjni): New variable.
[…]
> +    (arguments
> +     `(#:jar-name "hawtjni.jar"
> +       #:source-dir "hawtjni-generator/src/main/java:hawtjni-runtime/src/main/java"
> +       #:tests? #f; no tests
> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-before 'build 'build-native
> +           (lambda* (#:key inputs #:allow-other-keys)
> +             (with-directory-excursion "hawtjni-generator/src/main/resources/"
> +               (system* "gcc" "-c" "hawtjni.c" "-o" "hawtjni.o"
> +                        "-fPIC" "-O2"
> +                        (string-append "-I" (assoc-ref inputs "jdk") "/include/linux"))
> +               (system* "gcc" "-c" "hawtjni-callback.c" "-o" "hawtjni-callback.o"
> +                        "-fPIC" "-O2"
> +                        (string-append "-I" (assoc-ref inputs "jdk") "/include/linux"))
> +               (zero? (system* "gcc" "-o" "libhawtjni.so" "-shared"
> +                               "hawtjni.o" "hawtjni-callback.o")))))

Please do this instead:

    (let ((jdk (assoc-ref inputs "jdk")))
      (and (zero? (system* "gcc" … jdk …))
           (zero? (system* "gcc" … jdk …))
           (zero? (system* "gcc" …)))

> +    (description "HawtJNI is a code generator that produces the JNI code needed
> +to implement java native methods.  It is based on the jnigen code generator
> +that is part of the SWT Tools project.")

Please capitalize “java”.

-- 
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net