Subject: Re: [bug#29359] [PATCH 02/31] gnu: Add java-jsoup.

From: Ricardo Wurmus <[email-masked]>
Date: Sun, 17 Dec 2017 23:42:21 +0100

Hi Julien,

> * gnu/packages/java.scm (java-jsoup): New variable.

How about adding it to web.scm instead?

[…]

> +(define-public java-jsoup
> +  (package
> +    (name "java-jsoup")
> +    (version "1.10.3")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "https://github.com/jhy/jsoup/archive/jsoup-"
> +                                  version ".tar.gz"))
> +              (file-name (string-append name "-" version ".tar.gz"))

I don’t think this is necessary.

> +    (native-inputs
> +     `(("java-junit" ,java-junit)
> +       ("java-hamcrest-core" ,java-hamcrest-core)
> +       ("java-gson" ,java-gson)))

Is gson really just used at build time?

> +    (home-page "https://jsoup.org")
> +    (synopsis "HTML Parser")

s/Parser/parser/

> +    (description "Jsoup is a Java library for working with real-world HTML.  It
> +provides a very convenient API for extracting and manipulating data, using the
> +best of DOM, CSS, and jquery-like methods.")

“jQuery”.

-- 
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net