Subject: Re: [bug#29359] [PATCH 28/31] gnu: Add java-xstream.

From: Ricardo Wurmus <[email-masked]>
Date: Mon, 20 Nov 2017 08:44:50 +0100

Hi Julien,

> * gnu/packages/java.scm (java-xstream): New variable.
[…]

> +
> +(define-public java-xstream
> +  (package
> +    (name "java-xstream")
> +    (version "1.4.9")

1.4.10 has been released on May 23, 2017.  It includes a fix for
CVE-2017-7957.  Could you please update this package definition?

> +    (arguments
> +     `(#:jar-name "xstream.jar"
> +       ;; Tests are not in a java subdirectory as assumed by ant-build-system
> +       #:tests? #f

Can’t we point it at the root directory and filter the files with test-exclude?

> +    (synopsis "XML serialization library")
> +    (description "XStream is a simple library to serialize objects to XML and
> +back again.")

Maybe replace “objects” with “Java objects”.  The description is a bit
short, but I’ll take it :)

> +    (license license:x11)))

This looks like the bsd-3 license:

    https://x-stream.github.io/license.html

Okay to push with these changes.  Thanks!

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net