Subject: Re: [bug#29359] [PATCH 27/31] gnu: Add java-jdom2.

From: Ricardo Wurmus <[email-masked]>
Date: Mon, 20 Nov 2017 08:50:00 +0100

Hi Julien,

> * gnu/packages/java.scm (java-jdom2): New variable.

How about adding this to (gnu packages xml) instead?  I’d like to
prevent java.scm from becoming the next python.scm…

> +(define-public java-jdom2

Why name it “java-jdom2”?  I’d prefer just “java-jdom”.

> +    (description "Java-based solution for accessing, manipulating, and
> +outputting XML data from Java code.")

Please use a full sentence here.

> +    (license license:bsd-4)))

This seems to be correct.

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net