GNU bug report logs - #29345
27.0.50; Error message for cl-destructuring-bind could be improved

Previous Next

Full log

Message #11 received at 29345 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Philipp Stephani <p.stephani2 <at> gmail.com>
Cc: 29345 <at> debbugs.gnu.org
Subject: Re: bug#29345: 27.0.50; Error message for cl-destructuring-bind
 could be improved
Date: Thu, 25 Jul 2019 21:53:54 +0200

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Philipp Stephani <p.stephani2 <at> gmail.com> writes:
>
>> $ emacs -Q -batch -l cl-lib -eval '(cl-destructuring-bind (a b) (list 1))'
>> Wrong number of arguments: nil, 1
>>
>> It would be nice if the first error data item weren't nil, but
>> e.g. `(cl-destructuring-bind (a b))` so that the error is obvious.
>
> What about
>
> Wrong number of arguments: (a b), 1
>
> The following patch achieves that, but since it was explicitly 'cl-none
> before (which is the magic value that gives you nil in that error
> message), I'm not sure whether this has any negative effects?  Probably
> not, because there's this:
>
> (defvar cl--bind-block) ;Name of surrounding block, only use for `signal' data.
>
> Any opinions?

There weren't any, so I'm applying the patch.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.