GNU bug report logs - #29331
[PATCH 0/1] gnu: cool-retro-term: Fix qml path.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 29331 in the body.
You can then email your comments to 29331 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH 0/1] gnu: cool-retro-term: Fix qml path.
Date: Fri, 17 Nov 2017 04:13:35 +0300

[0000-cover-letter.patch (text/x-patch, inline)]

From bb537a04a3fe5682de4b21c240b5bc5d92814311 Mon Sep 17 00:00:00 2001
From: Oleg Pykhalov <go.wigust <at> gmail.com>
Date: Fri, 17 Nov 2017 04:10:49 +0300
Subject: [PATCH 0/1] gnu: cool-retro-term: Fix qml path.

Hello Guix,

This patch fixes cool-retro-term start up.

There are some issues still:

default KB_LAYOUT_DIR:  "/gnu/store/…-cool-retro-term-1.0.0-1.e48719f/lib/qt5/qml/QMLTermWidget/kb-layouts"
QObject::connect: No such slot Konsole::TerminalDisplay_QML_140::close()
loadAllColorSchemes
Both point size and pixel size set. Using pixel size.
Session::run() - program: "/gnu/store/kqb373kyrdg5wxxnmka0mmdxh35c2gbk-bash-4.4.12/bin/bash"
Session::run() - arguments: ("")
started!

Oleg Pykhalov (1):
  gnu: cool-retro-term: Fix qml path.

 gnu/packages/terminals.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.15.0

Message #8 received at 29331 <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: 29331 <at> debbugs.gnu.org
Subject: Re: [bug#29331] [PATCH 0/1] gnu: cool-retro-term: Fix qml path.
Date: Fri, 17 Nov 2017 04:15:17 +0300

[0001-gnu-cool-retro-term-Fix-qml-path.patch (text/x-patch, inline)]

From bb537a04a3fe5682de4b21c240b5bc5d92814311 Mon Sep 17 00:00:00 2001
From: Oleg Pykhalov <go.wigust <at> gmail.com>
Date: Fri, 17 Nov 2017 04:08:33 +0300
Subject: [PATCH 1/1] gnu: cool-retro-term: Fix qml path.

* gnu/packages/terminals.scm (cool-retro-term): Fix qml path.
---
 gnu/packages/terminals.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/terminals.scm b/gnu/packages/terminals.scm
index 2f74c5d5b..215511864 100644
--- a/gnu/packages/terminals.scm
+++ b/gnu/packages/terminals.scm
@@ -493,7 +493,7 @@ embedded kernel situations.")
                       (share (string-append out "/share")))
                  (substitute* '("qmltermwidget/qmltermwidget.pro")
                    (("INSTALL_DIR = \\$\\$\\[QT_INSTALL_QML\\]")
-                    (string-append "INSTALL_DIR = " out "/qml")))
+                    (string-append "INSTALL_DIR = " out "/lib/qt5/qml")))
                  (substitute* '("app/app.pro")
                    (("target.path \\+= /usr")
                     (string-append "target.path += " out))
@@ -514,7 +514,7 @@ embedded kernel situations.")
            (add-after 'install 'wrap-executable
              (lambda* (#:key inputs outputs #:allow-other-keys)
                (let* ((out (assoc-ref outputs "out"))
-                      (qml "/qml"))
+                      (qml "/lib/qt5/qml"))
                  (wrap-program (string-append out "/bin/cool-retro-term")
                    `("QML2_IMPORT_PATH" ":" prefix
                      (,(string-append out qml)
-- 
2.15.0

Message #11 received at 29331 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Oleg Pykhalov <go.wigust <at> gmail.com>
Cc: 29331 <at> debbugs.gnu.org
Subject: Re: [bug#29331] [PATCH 0/1] gnu: cool-retro-term: Fix qml path.
Date: Fri, 17 Nov 2017 11:09:14 +0100

Oleg Pykhalov <go.wigust <at> gmail.com> skribis:

> From bb537a04a3fe5682de4b21c240b5bc5d92814311 Mon Sep 17 00:00:00 2001
> From: Oleg Pykhalov <go.wigust <at> gmail.com>
> Date: Fri, 17 Nov 2017 04:08:33 +0300
> Subject: [PATCH 1/1] gnu: cool-retro-term: Fix qml path.
>
> * gnu/packages/terminals.scm (cool-retro-term): Fix qml path.

LGTM, thanks!

Ludo'.

Message #14 received at 29331 <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: 29331 <at> debbugs.gnu.org, 29331-done <at> debbugs.gnu.org
Subject: Re: [bug#29331] [PATCH 0/1] gnu: cool-retro-term: Fix qml path.
Date: Fri, 17 Nov 2017 13:32:54 +0300

Hello Ludovic,

ludo <at> gnu.org (Ludovic Courtès) writes:

>> From bb537a04a3fe5682de4b21c240b5bc5d92814311 Mon Sep 17 00:00:00 2001
>> From: Oleg Pykhalov <go.wigust <at> gmail.com>
>> Date: Fri, 17 Nov 2017 04:08:33 +0300
>> Subject: [PATCH 1/1] gnu: cool-retro-term: Fix qml path.
>>
>> * gnu/packages/terminals.scm (cool-retro-term): Fix qml path.
>
> LGTM, thanks!

OK, pushed as 669be6acfe119a6a9fef4d97a0c14d4adb67dca5

Thanks,
Oleg.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.