GNU bug report logs - #29313
Replace gnus-yes-or-no-p with yes-or-no-p?

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 29313 in the body.
You can then email your comments to 29313 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: submit <at> debbugs.gnu.org (The Gnus Bugfixing Girls + Boys)
Subject: Replace gnus-yes-or-no-p with yes-or-no-p?
Date: Wed, 15 Nov 2017 17:49:47 -0800

Gnus has the following defined:

(defun gnus-y-or-n-p (prompt)
  (prog1
      (y-or-n-p prompt)
    (message "")))
    
(defun gnus-yes-or-no-p (prompt)
  (prog1
      (yes-or-no-p prompt)
    (message "")))

I wonder if I'm missing something here: for the life of me I can't see
how the behavior is different from the built-ins. The built-ins don't
put anything in the minibuffer, why would we'd have to blank it? Is this
historical?

I'm putting this on my list of little Gnus tweaks to eventually commit,
unless someone points out why I shouldn't.


Gnus v5.13
GNU Emacs 27.0.50 (build 5, x86_64-pc-linux-gnu, GTK+ Version 3.22.25)
 of 2017-11-09

Message #8 received at 29313 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> users.sourceforge.net>
To: Eric Abrahamsen <eric <at> ericabrahamsen.net>
Cc: 29313 <at> debbugs.gnu.org
Subject: Re: bug#29313: Replace gnus-yes-or-no-p with yes-or-no-p?
Date: Wed, 15 Nov 2017 21:00:43 -0500

Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:

> Gnus has the following defined:
>
> (defun gnus-y-or-n-p (prompt)
>   (prog1
>       (y-or-n-p prompt)
>     (message "")))
>     
> (defun gnus-yes-or-no-p (prompt)
>   (prog1
>       (yes-or-no-p prompt)
>     (message "")))
>
> I wonder if I'm missing something here: for the life of me I can't see
> how the behavior is different from the built-ins. The built-ins don't
> put anything in the minibuffer, why would we'd have to blank it? Is this
> historical?

They put the prompt in the minibuffer, don't they?  (not sure why it's
important to blank that out though)

Message #11 received at 29313 <at> debbugs.gnu.org (full text, mbox):

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: Noam Postavsky <npostavs <at> users.sourceforge.net>
Cc: 29313 <at> debbugs.gnu.org
Subject: Re: bug#29313: Replace gnus-yes-or-no-p with yes-or-no-p?
Date: Wed, 15 Nov 2017 18:11:04 -0800

Noam Postavsky <npostavs <at> users.sourceforge.net> writes:

> Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:
>
>> Gnus has the following defined:
>>
>> (defun gnus-y-or-n-p (prompt)
>>   (prog1
>>       (y-or-n-p prompt)
>>     (message "")))
>>     
>> (defun gnus-yes-or-no-p (prompt)
>>   (prog1
>>       (yes-or-no-p prompt)
>>     (message "")))
>>
>> I wonder if I'm missing something here: for the life of me I can't see
>> how the behavior is different from the built-ins. The built-ins don't
>> put anything in the minibuffer, why would we'd have to blank it? Is this
>> historical?
>
> They put the prompt in the minibuffer, don't they?  (not sure why it's
> important to blank that out though)

Oh! The prompt is *left* in the minibuffer. Of course I figure that out
moments after making the bug report.

Well, at least the functions actually *do* something. Whether that's
worth doing is another question, but I'll leave it for now.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.